1. 12 Jan, 2019 3 commits
  2. 11 Jan, 2019 35 commits
    • Document C++20 library status · 66dc59e2
      	* doc/xml/manual/intro.xml: Include new section.
      	* doc/xml/manual/status_cxx2017.xml: Document more
      	implementation-defined properties of the library.
      	* doc/xml/manual/status_cxx2020.xml: Document C++2a status.
      	* doc/html/*: Regenerate.
      
      From-SVN: r267867
      Jonathan Wakely committed
    • P0357R3 reference_wrapper for incomplete types · aaeac156
      This patch implements the C++2a proposal to allow incomplete types in
      std::reference_wrapper, which was previously undefined.
      
      The change cannot be implemented for earlier standards, because prior to
      C++2a std::reference_wrapper has a weak result type, so must inspect the
      template argument to see if it defines a nested result_type member. That
      is deprecated (but still required) in C++17, and removed from C++2a.
      
      The removal of the base class from reference_wrapper is a potential ABI
      change, as it could alter the layout of a type which derives from
      reference_wrapper<T> and from an empty type with _Weak_result_type<T> as
      a base class.  Previously the repeated _Weak_result_type<T> base class
      would have prevented the empty base-class optimization, but if
      reference_wrapper<T> no longer derives from it, the empty class could be
      placed at the same address as the reference_wrapper<T> base.  In
      practice, the only types which derive from _Weak_result_type or from
      _Reference_wrapper_base_memfun or any of its base classes are non-empty
      types defined in libstdc++: std::reference_wrapper, std::function, and
      std::_Bind. As they are non-empty types, they are not eligible for EBO
      anyway.
      
      	* include/bits/refwrap.h [__cplusplus > 201703L]
      	(_Refwrap_base_arg1, _Refwrap_base_arg2, _Reference_wrapper_base)
      	(_Reference_wrapper_base_memfun): Do not define for C++2a.
      	(reference_wrapper): Do not derive from _Reference_wrapper_base_memfun
      	for C++2a.
      	(reference_wrapper::operator()): Add static assertion.
      	* testsuite/20_util/reference_wrapper/incomplete.cc: New test.
      
      From-SVN: r267866
      Jonathan Wakely committed
    • P0972R0 <chrono> zero(), min(), and max() should be noexcept · 5e9aed14
      This paper has been included in the C++20 draft, but the changes to add
      noexcept can be made unconditionally, to apply for C++11 too.
      
      	* include/std/chrono (duration_values::zero(), duration_values::min())
      	(duration_values::max()): Add noexcept.
      	(duration::zero(), duration::min(), duration::max()): Likewise.
      	(time_point::zero(), time_point::min(), time_point::max()): Likewise.
      	* testsuite/20_util/duration/requirements/noexcept.cc: New test.
      	* testsuite/20_util/time_point/requirements/noexcept.cc: New test.
      
      From-SVN: r267865
      Jonathan Wakely committed
    • re PR fortran/35031 (ELEMENTAL procedure with BIND(C)) · 89508a3f
      2019-01-11  Steven G. Kargl  <kargl@gcc.gnu.org>
      
      	PR fortran/35031
      	* decl.c (gfc_match_entry): Check for F2018:C1546.  Fix nearby
      	mis-indentation.
       
      2019-01-11  Steven G. Kargl  <kargl@gcc.gnu.org>
      
      	PR fortran/35031
      	* gfortran.dg/pr35031.f90: new test.
      
      From-SVN: r267864
      Steven G. Kargl committed
    • Fix location of __cpp_lib_erase_if macro · e334d7a7
      This macro should only be defined for C++2a, not C++17.
      
      	* include/std/version (__cpp_lib_erase_if): Move to C++20 group.
      
      From-SVN: r267863
      Jonathan Wakely committed
    • PR c++/88692, c++/87882 - -Wredundant-move false positive with *this. · 1439f355
      	* typeck.c (maybe_warn_pessimizing_move): Return if ARG isn't
      	ADDR_EXPR.
      
      	* g++.dg/cpp0x/Wredundant-move5.C: New test.
      	* g++.dg/cpp0x/Wredundant-move6.C: New test.
      
      From-SVN: r267862
      Marek Polacek committed
    • compiler: pad structs ending with zero-sized field · 378b9abe
          
          For a struct with zero-sized last field, the address of the
          field falls out of the object boundary, which confuses the
          garbage collector. Pad an extra byte in this case.
          
          Reviewed-on: https://go-review.googlesource.com/c/157557
      
      From-SVN: r267861
      Ian Lance Taylor committed
    • PR c++/88312 - pack expansion of decltype. · 3ddf08b3
      The standard doesn't really talk about an expression depending on the number
      of elements of a pack, but that's definitely an important form of template
      argument dependence.
      
      	* pt.c (instantiation_dependent_r): A template non-type parameter
      	pack is instantiation-dependent.
      
      From-SVN: r267860
      Jason Merrill committed
    • PR c++/88613 - ICE with use of const var in lambda. · f43e0585
      The issue here was that we were cp_folding a location wrapper around a
      lambda capture proxy before it had been mark_rvalue_used.  I considered
      adding mark_rvalue_use calls to build_new_op_1, but it seems appropriate to
      have them in cp_fold_maybe_rvalue when we know we're trying to produce an
      rvalue.
      
      The change to mark_use is for a related issue: when we change the operand of
      the location wrapper from VAR_DECL to INTEGER_CST, we need the TREE_CODE of
      the location wrapper to change as well, from VIEW_CONVERT_EXPR to
      NON_LVALUE_EXPR.
      
      	* expr.c (mark_use): Fix location wrapper handling.
      	* cp-gimplify.c (cp_fold_maybe_rvalue): Call mark_rvalue_use.
      
      From-SVN: r267859
      Jason Merrill committed
    • re PR middle-end/85956 (ICE in wide_int_to_tree_1, at tree.c:1549) · da972c05
      	PR middle-end/85956
      	PR lto/88733
      	* tree-inline.h (struct copy_body_data): Add adjust_array_error_bounds
      	field.
      	* tree-inline.c (remap_type_1): Formatting fix.  If TYPE_MAX_VALUE of
      	ARRAY_TYPE's TYPE_DOMAIN is newly error_mark_node, replace it with
      	a dummy "omp dummy var" variable if id->adjust_array_error_bounds.
      	* omp-low.c (new_omp_context): Set cb.adjust_array_error_bounds.
      fortran/
      	* trans-openmp.c: Include attribs.h.
      	(gfc_walk_alloc_comps, gfc_omp_clause_linear_ctor): Handle
      	VAR_DECL max bound with "omp dummy var" attribute like NULL or
      	error_mark_node - recompute number of elts independently.
      testsuite/
      	* c-c++-common/gomp/pr85956.c: New test.
      	* g++.dg/gomp/pr88733.C: New test.
      
      From-SVN: r267858
      Jakub Jelinek committed
    • PR C++/88114 Gen destructor of an abstract class · b13091dd
              PR C++/8811
              * decl2.c (maybe_emit_vtables): If needed, generate code for
              the destructor of an abstract class.
              (mark_used): Update comment for older function-name change.
      
              PR C++/88114
              * g++.dg/cpp0x/defaulted61.C: New.
              * g++.dg/cpp0x/defaulted62.C: New.
      
      From-SVN: r267855
      Tobias Burnus committed
    • re PR rtl-optimization/87305 (Segfault in end_hard_regno in… · 4321da7b
      re PR rtl-optimization/87305 (Segfault in end_hard_regno in setup_live_pseudos_and_spill_after_risky_transforms on aarch64 big-endian)
      
      2019-01-11  Vladimir Makarov  <vmakarov@redhat.com>
      
      	PR rtl-optimization/87305
      	* lra-assigns.c
      	(setup_live_pseudos_and_spill_after_risky_transforms): Add code
      	for little endian pseudos used as paradoxical subreg.
      
      From-SVN: r267854
      Vladimir Makarov committed
    • re PR tree-optimization/88693 (Wrong code since r263018) · e17fa93e
      	PR tree-optimization/88693
      	* tree-ssa-strlen.c (get_min_string_length): Don't set *full_string_p
      	for STRING_CSTs that don't contain any NUL characters in the first
      	TREE_STRING_LENGTH bytes.
      
      	* gcc.c-torture/execute/pr88693.c: New test.
      
      From-SVN: r267852
      Jakub Jelinek committed
    • re PR target/88777 (Out-of-range offsets building glibc test-tgmath2.c for hppa-linux-gnu) · 0f64d96d
      	PR 88777
      	PR 88614
      	* genattrtab.c (min_fn): Don't translate values.
      	(min_attr_value): Return INT_MAX when the value can't be calculated.
      	Return minimum among any values that can be calculated.
      	(max_attr_value): Adjust.
      
      From-SVN: r267851
      Alan Modra committed
    • * Makefile.in (PLUGIN_HEADERS): Add $(INSN_ATTR_H). · e173500e
      From-SVN: r267850
      Jakub Jelinek committed
    • Remove trailing whitespace from latest commit. · 8aa1550e
      From-SVN: r267849
      Jakub Jelinek committed
    • aarch64.c (aarch64_simd_call_p): New function. · 473574ee
      2019-01-11  Steve Ellcey  <sellcey@marvell.com>
      
      	* config/aarch64/aarch64.c (aarch64_simd_call_p): New function.
      	(aarch64_hard_regno_call_part_clobbered): Add insn argument.
      	(aarch64_return_call_with_max_clobbers): New function.
      	(TARGET_RETURN_CALL_WITH_MAX_CLOBBERS): New macro.
      	* config/avr/avr.c (avr_hard_regno_call_part_clobbered): Add insn
      	argument.
      	* config/i386/i386.c (ix86_hard_regno_call_part_clobbered): Ditto.
      	* config/mips/mips.c (mips_hard_regno_call_part_clobbered): Ditto.
      	* config/rs6000/rs6000.c (rs6000_hard_regno_call_part_clobbered): Ditto.
      	* config/s390/s390.c (s390_hard_regno_call_part_clobbered): Ditto.
      	* cselib.c (cselib_process_insn): Add argument to
      	targetm.hard_regno_call_part_clobbered call.
      	* ira-conflicts.c (ira_build_conflicts): Ditto.
      	* ira-costs.c (ira_tune_allocno_costs): Ditto.
      	* lra-constraints.c (inherit_reload_reg): Ditto.
      	* lra-int.h (struct lra_reg): Add call_insn field, remove call_p field.
      	* lra-lives.c (check_pseudos_live_through_calls): Add call_insn
      	argument.  Call targetm.return_call_with_max_clobbers.
      	Add argument to targetm.hard_regno_call_part_clobbered call.
      	(calls_have_same_clobbers_p): New function.
      	(process_bb_lives): Add call_insn and last_call_insn variables.
      	Pass call_insn to check_pseudos_live_through_calls.
      	Modify if stmt to check targetm.return_call_with_max_clobbers.
      	Update setting of flush variable.
      	(lra_create_live_ranges_1): Set call_insn to NULL instead of call_p
      	to false.
      	* lra.c (initialize_lra_reg_info_element): Set call_insn to NULL.
      	* regcprop.c (copyprop_hardreg_forward_1): Add argument to
              targetm.hard_regno_call_part_clobbered call.
      	* reginfo.c (choose_hard_reg_mode): Ditto.
      	* regrename.c (check_new_reg_p): Ditto.
      	* reload.c (find_equiv_reg): Ditto.
      	* reload1.c (emit_reload_insns): Ditto.
      	* sched-deps.c (deps_analyze_insn): Ditto.
      	* sel-sched.c (init_regs_for_mode): Ditto.
      	(mark_unavailable_hard_regs): Ditto.
      	* targhooks.c (default_dwarf_frame_reg_mode): Ditto.
      	* target.def (hard_regno_call_part_clobbered): Add insn argument.
      	(return_call_with_max_clobbers): New target function.
      	* doc/tm.texi: Regenerate.
      	* doc/tm.texi.in (TARGET_RETURN_CALL_WITH_MAX_CLOBBERS): New hook.
      	* hooks.c (hook_bool_uint_mode_false): Change to
      	hook_bool_insn_uint_mode_false.
      	* hooks.h (hook_bool_uint_mode_false): Ditto.
      
      From-SVN: r267848
      Steve Ellcey committed
    • type_traits (__cpp_lib_is_constant_evaluated): Define. · 134a6f7b
      	* include/std/type_traits (__cpp_lib_is_constant_evaluated): Define.
      	* include/std/version (__cpp_lib_is_constant_evaluated): Define.
      
      From-SVN: r267847
      Jakub Jelinek committed
    • aarch64.c (aarch64_simd_call_p): New function. · b3650d40
      2019-01-11  Steve Ellcey  <sellcey@marvell.com>
      
      	* config/aarch64/aarch64.c (aarch64_simd_call_p): New function.
      	(aarch64_remove_extra_call_preserved_regs): New function.
      	(TARGET_REMOVE_EXTRA_CALL_PRESERVED_REGS): New macro.
      	* doc/tm.texi.in (TARGET_REMOVE_EXTRA_CALL_PRESERVED_REGS): New hook.
      	* doc/tm.texi: Regenerate.
      	* final.c (get_call_reg_set_usage): Call new hook.
      	* target.def (remove_extra_call_preserved_regs): New hook.
      	* targhooks.c (default_remove_extra_call_preserved_regs): New function.
      	* targhooks.h (default_remove_extra_call_preserved_regs): New function.
      
      From-SVN: r267846
      Steve Ellcey committed
    • PR libstdc++/88802 define std::hash<nullptr_t> for C++17 · 17a73b3c
      	PR libstdc++/88802
      	* include/bits/functional_hash.h (hash<nullptr_t>): Define
      	specialization for C++17 (P0513R0, LWG 2817).
      	* testsuite/20_util/hash/nullptr.cc: New test.
      
      From-SVN: r267845
      Jonathan Wakely committed
    • Fix arm testism regression. · d58cb965
      gcc/testsuite/ChangeLog:
      
      2019-01-11  Tamar Christina  <tamar.christina@arm.com>
      
      	* gcc.target/aarch64/advsimd-intrinsics/vector-complex_f16.c: Require neon
      	and add options.
      
      From-SVN: r267843
      Tamar Christina committed
    • Better distinguish OpenACC and OpenMP sections in libgomp.texi · 4102bda6
      2019-01-11  Thomas Schwinge  <thomas@codesourcery.com>
                  James Norris  <jnorris@codesourcery.com>
      
      	* libgomp.texi: Better distinguish OpenACC and OpenMP "Runtime
      	Library Routines", and "Environment Variables".
      
      Co-Authored-By: James Norris <jnorris@codesourcery.com>
      
      From-SVN: r267841
      Thomas Schwinge committed
    • Add a testcase (PR middle-end/88758). · 5019eef8
      2019-01-11  Martin Liska  <mliska@suse.cz>
      
      	PR middle-end/88758
      	* g++.dg/lto/pr88758_0.C: New test.
      	* g++.dg/lto/pr88758_1.C: New test.
      
      From-SVN: r267840
      Martin Liska committed
    • re PR bootstrap/88714 (bootstrap comparison failure on armv7l since r265398) · b55ddd43
      	PR bootstrap/88714
      	* passes.c (finish_optimization_passes): Call print_combine_total_stats
      	inside of pass_combine_1 dump rather than pass_profile_1.
      
      From-SVN: r267839
      Jakub Jelinek committed
    • [nvptx] Don't allow vector_length 64 with num_workers 16 · 052aaace
      When using a compiler build with:
      ...
      +#define PTX_DEFAULT_VECTOR_LENGTH PTX_CTA_SIZE
      ...
      
      consider a test-case:
      ...
      int
      main (void)
      {
        #pragma acc parallel vector_length (64)
          #pragma acc loop worker
          for (unsigned int i = 0; i < 32; i++)
            #pragma acc loop vector
            for (unsigned int j = 0; j < 64; j++)
              ;
      
        return 0;
      }
      ...
      
      If num_workers is 16, either because:
      - we add a "num_workers (16)" clause on the parallel directive, or
      - we set "GOMP_OPENACC_DIM=:16:", or
      - the libgomp plugin chooses 16 num_workers
      we run into an illegal instruction at runtime, because a bar.sync instruction
      tries to use a barrier 16.  The instruction is illegal, because ptx supports
      only 16 barriers per CTA, and the valid range is 0..15.
      
      The problem is that with a warp-multiple vector length, we use a code generation
      scheme with a per-worker barrier.  And because barrier zero is reserved for
      per-cta barrier, only the remaining 15 barriers can be used as per-worker
      barrier, and consequently we can't use num_workers larger than 15.
      
      This problem occurs only for vector_length 64.  For vector_length 32, we use a
      different code generation scheme, and for vector_length >= 96, the maximum
      num_workers is not big enough not to trigger this problem.
      
      Also, this problem only occurs for num_workers 16.  As explained above,
      num_workers 15 is safe to use, and 16 is already the maximum num_workers for
      vector_length 64.
      
      This patch fixes the problem in both the compiler (handling "num_workers (16)")
      and in the libgomp nvptx plugin (with and without "GOMP_OPENACC_DIM=:16:").
      
      2019-01-11  Tom de Vries  <tdevries@suse.de>
      
      	* config/nvptx/nvptx.c (PTX_CTA_NUM_BARRIERS, PTX_PER_CTA_BARRIER)
      	(PTX_NUM_PER_CTA_BARRIER, PTX_FIRST_PER_WORKER_BARRIER)
      	(PTX_NUM_PER_WORKER_BARRIERS): Define.
      	(nvptx_apply_dim_limits): Prevent vector_length 64 and
      	num_workers 16.
      
      	* plugin/plugin-nvptx.c (nvptx_exec): Prevent vector_length 64 and
      	num_workers 16.
      
      From-SVN: r267838
      Tom de Vries committed
    • [nvptx] Move PTX_CTA_SIZE up · 69b09a58
      Move the defition of PTX_CTA_SIZE up in nvptx.c.
      
      2019-01-11  Tom de Vries  <tdevries@suse.de>
      
      	* config/nvptx/nvptx.c (PTX_CTA_SIZE): Move up.
      
      From-SVN: r267837
      Tom de Vries committed
    • [libgomp, testsuite, openacc] Remove -foffload=-w in reduction-[1-5].c · 9390f916
      Before the commit "[libgomp, testsuite, openacc] Don't use const int for
      dimensions", the "const int" construct was used to set launch dimensions in
      reductions-[1-5].c.  In the case of -xc -O0, the const int is implemented as a
      variable by the C front-end.  Consequently, the nvptx back-end generated
      warnings that vector_length was overridden to be hard-coded, rather than left to
      be set at runtime.  The test-cases silenced these warnings by switching off all
      warnings in the accelerator compiler using "-foffload=-w".
      
      Given that no warnings occur anymore, remove the "-foffload=-w" setting.
      
      2019-01-11  Tom de Vries  <tdevries@suse.de>
      
      	* testsuite/libgomp.oacc-c-c++-common/reduction-1.c: Remove
      	-foffload=-w.
      	* testsuite/libgomp.oacc-c-c++-common/reduction-2.c: Same.
      	* testsuite/libgomp.oacc-c-c++-common/reduction-3.c: Same.
      	* testsuite/libgomp.oacc-c-c++-common/reduction-4.c: Same.
      	* testsuite/libgomp.oacc-c-c++-common/reduction-5.c: Same.
      
      From-SVN: r267836
      Tom de Vries committed
    • [nvptx, testsuite, openacc, libgomp] Add insufficient-resources.c · 2c3e7ad2
      Add a test-case that tests the "insufficient resources" fatal in the nvptx
      libgomp plugin.
      
      2019-01-11  Tom de Vries  <tdevries@suse.de>
      
      	* testsuite/libgomp.oacc-c-c++-common/insufficient-resources.c: New
      	test.
      
      From-SVN: r267835
      Tom de Vries committed
    • PR libstdc++/88125 remove duplicate entry in linker script · bbed72f5
      	PR libstdc++/88125
      	* config/abi/pre/gnu.ver (GLIBCXX_3.4.6): Remove unused duplicate
      	pattern for std::basic_stringbuf::str().
      
      From-SVN: r267834
      Jonathan Wakely committed
    • x86-64: {,V}CVT{,U}SI2Sx are ambiguous without suffix · 4f853137
      For 64-bit these should not be emitted without suffix in AT&T mode (as
      being ambiguous that way); the suffixes are benign for 32-bit. For
      consistency also omit the suffix in Intel mode for {,V}CVTSI2SxQ.
      
      The omission has originally (prior to rev 260691) lead to wrong code
      being generated for the 64-bit unsigned-to-float/double conversions (as
      gas guesses an L suffix instead of the required Q one when the operand
      is in memory). In all remaining cases (being changed here) the omission
      would "just" lead to warnings with future gas versions.
      
      As a result, arrange to check for the L suffixes in 32-bit test cases.
      
      In order for related test cases to actually test what they're supposed
      to test, add (seemingly unrelated) a few empty "asm volatile()".
      Presumably there are more where constant propagation voids the intended
      effect of the tests, but these are ones helping make sure the assembler
      actually still assembles correctly the output after the changes here.
      
      From-SVN: r267833
      Jan Beulich committed
    • Fix incorrect linker script patterns · 8ce7e3f8
      The recent changes to support operator<<(nullptr_t) changed the glob
      patterns for existing operator<<(T) overloads, but did so incorrectly so
      they still matched the new symbols. That broke Solaris bootstrap. This
      patch replaces each of the existing globs by two more precise ones,
      which match the old symbols but not the new ones.
      
      	* config/abi/pre/gnu.ver (GLIBCXX_3.4): Correct recent changes to
      	basic_ostream::operator<< patterns.
      
      From-SVN: r267832
      Jonathan Wakely committed
    • re PR rtl-optimization/88296 (Infinite loop in lra_split_hard_reg_for) · 6ebf16e6
      	PR rtl-optimization/88296
      	* gcc.target/i386/pr88296.c: New test.
      
      From-SVN: r267831
      Jakub Jelinek committed
    • decl.c (start_decl): Improve error location. · a8766179
      /cp
      2019-01-11  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* decl.c (start_decl): Improve error location.
      	(grokdeclarator): Likewise, improve two locations.
      
      /testsuite
      2019-01-11  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* g++.dg/diagnostic/extern-initialized.C: New.
      	* g++.dg/ext/dllimport-initialized.C: Likewise.
      
      From-SVN: r267830
      Paolo Carlini committed
    • re PR fortran/59345 (_gfortran_internal_pack on compiler generated temps) · 7dc3df08
      2019-01-11  Thomas Koenig  <tkoenig@gcc.gnu.org>
      
      	PR fortran/59345
      	* trans-array.c (gfc_conv_parameter_array):  Temporary
      	arrays generated for expressions do not need to be repacked.
      
      2019-01-11  Thomas Koenig  <tkoenig@gcc.gnu.org>
      
      	PR fortran/59345
      	* gfortran.dg/internal_pack_16.f90: New test.
      
      From-SVN: r267829
      Thomas Koenig committed
    • Daily bump. · 0604d567
      From-SVN: r267828
      GCC Administrator committed
  3. 10 Jan, 2019 2 commits
    • re PR target/88785 (ICE in as_a, at machmode.h:353) · 84df580f
      	PR target/88785
      	* config/i386/sse.md (float<floatunssuffix>v2div2sf2): Turn into
      	define_expand.
      	(*float<floatunssuffix>v2div2sf2): New define_insn.
      	(float<floatunssuffix>v2div2sf2_mask): Turn into define_expand.
      	(*float<floatunssuffix>v2div2sf2_mask): New define_insn.
      	(*float<floatunssuffix>v2div2sf2_mask_1): Replace
      	subrtxes (const_vector:V2SF [(const_int 0) (const_int 0)]) with
      	match_operands with "const0_operand" "C".
      
      	* g++.target/i386/pr88785.C: New test.
      
      From-SVN: r267825
      Jakub Jelinek committed
    • gcc/ChangeLog: · 280d970b
      2019-01-10  Tamar Christina  <tamar.christina@arm.com>
      
      	* config/aarch64/aarch64-builtins.c
      	(aarch64_init_builtins): Move aarch64_init_fcmla_laneq_builtins...
      	(aarch64_init_simd_builtins): ...Here.
      
      From-SVN: r267824
      Tamar Christina committed