1. 30 Nov, 2018 1 commit
  2. 29 Nov, 2018 39 commits
    • Allow changing the fentry section per file and per function · 1c31f6c8
      When dynamically patching in/out instrumentation it can be useful
      to handle different classes of functions differently. Add support
      for changing the fentry section name on the command line
      or as a function attributes. This allows to mark functions differently,
      and handle them differently in dynamic patching.
      
      gcc/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* config/i386/i386.c (current_fentry_section): Add.
      	(x86_function_profiler): Handle fentry section.
      	(ix86_attribute_table): Add fentry section.
      	* config/i386/i386.opt: Add -mfentry-section.
      	* doc/extend.texi: Document fentry_section attribute.
      	* doc/invoke.texi: Document -mfentry-section.
      
      gcc/testsuite/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* gcc.target/i386/fentryname2.c: New test.
      	* gcc.target/i386/fentryname3.c: New test.
      
      From-SVN: r266654
      Andi Kleen committed
    • Support changing fentry name per function · d7bf0bd6
      It can be useful to have some classes of functions that use a different
      __fentry__ instrumentation than others.  Currently it is only
      possible to disable instrumentation on the command line or with
      no_instrument_function, but not to change the instrumentation function
      on a case by case base.
      
      Add some flexibility to allow to change the instrumentation function
      name per file with an option or per function with a new attribute.
      This also allows switching to nops for individual functions.
      
      gcc/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* config/i386/i386.c (x86_print_call_or_nop): Handle nop name.
      	(current_fentry_name): Add.
      	(x86_function_profiler): Handle fentry_name attribute.
      	(ix86_handle_fentry_name): Add.
      	(ix86_attribute_table): Add fentry_name.
      	* config/i386/i386.opt: Add -mfentry-name
      	* doc/extend.texi: Document fentry_name.
      	* doc/invoke.texi: Document minstrument-return.
      
      gcc/testsuite/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* gcc.target/i386/fentryname1.c: New test.
      
      From-SVN: r266653
      Andi Kleen committed
    • Support instrumenting returns of instrumented functions · 3b31afe1
      When instrumenting programs using __fentry__ it is often useful
      to instrument the function return too. Traditionally this
      has been done by patching the return address on the stack
      frame on entry. However this is fairly complicated (trace
      function has to emulate a stack) and also slow because
      it causes a branch misprediction on every return.
      
      Add an option to generate call or nop instrumentation for
      every return instead, including patch sections.
      
      This will increase the program size slightly, but can be a
      lot faster and simpler.
      
      This version only instruments true returns, not sibling
      calls or tail recursion. This matches the semantics of the
      original stack.
      
      gcc/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* config/i386/i386-opts.h (enum instrument_return): Add.
      	* config/i386/i386.c (output_return_instrumentation): Add.
      	(ix86_output_function_return): Call output_return_instrumentation.
      	(ix86_output_call_insn): Call output_return_instrumentation.
      	* config/i386/i386.opt: Add -minstrument-return=.
      	* doc/invoke.texi (-minstrument-return): Document.
      
      gcc/testsuite/:
      
      2018-11-29  Andi Kleen  <ak@linux.intel.com>
      
      	* gcc.target/i386/returninst1.c: New test.
      	* gcc.target/i386/returninst2.c: New test.
      	* gcc.target/i386/returninst3.c: New test.
      
      From-SVN: r266652
      Andi Kleen committed
    • re PR target/87807 (passing float/double vectors as variadic args fails on-64bit SPARC) · 856f4c6a
      	PR target/87807
      	* config/sparc/sparc-modes.def: Minor tweak.
      	* config/sparc/sparc.c: Minor reordering.
      	(sparc_pass_by_reference): Move around.
      	(traverse_record_type): Change offset from HOST_WIDE_INT to int.
      	(classify_registers): Likewise for bitpos.
      	(function_arg_slotno): Remove dead test and tweak comments.
      	<MODE_RANDOM>: Remove useless assertion and test whether the
      	parameter is named in order to pass it in FP registers.  Return
      	the regno for floating-point vector types.
      	(compute_int_layout): Change bitpos from HOST_WIDE_INT to int.
      	(compute_fp_layout): Likewise.
      	(count_registers): Likewise.
      	(assign_int_registers): Likewise.
      	(assign_fp_registers): Likewise.
      	(assign_registers): Likewise.
      	(function_arg_record_value): Change size from HOST_WIDE_INT to int
      	and use CEIL_NWORDS to compute the number of registers.
      	(function_arg_union_value): Minor tweaks.
      	(function_arg_vector_value): Add slotno and named parameters, use
      	CEIL_NWORDS to compute the number of registers.
      	(sparc_function_arg_1): Rework handling of vector types.  Change
      	size from HOST_WIDE_INT to int.
      	(sparc_arg_partial_bytes): Rework handling of 32-bit ABI and deal
      	with vector types for the 64-bt ABI.
      	(sparc_function_arg_advance): Likewise.
      	(sparc_return_in_memory): Add reference to -fpcc-struct-return.
      	(sparc_struct_value_rtx): Return NULL_RTX instead of 0.
      	(sparc_function_value_1): Rework handling of vector types.  Change
      	size from HOST_WIDE_INT to int.
      
      From-SVN: r266651
      Eric Botcazou committed
    • re PR target/88152 (optimize SSE & AVX char compares with subsequent movmskb) · 0b1c4b83
      	PR target/88152
      	* config/i386/sse.md (*<sse>_movmsk<ssemodesuffix><avxsizesuffix>_lt,
      	*<sse>_movmsk<ssemodesuffix><avxsizesuffix>_zext_lt,
      	*<sse>_movmsk<ssemodesuffix><avxsizesuffix>_shift,
      	*<sse>_movmsk<ssemodesuffix><avxsizesuffix>_zext_shift,
      	*<sse2_avx2>_pmovmskb_lt, *<sse2_avx2>_pmovmskb_zext_lt): New
      	define_insn_and_split patterns.
      
      	* g++.target/i386/pr88152.C: New test.
      
      From-SVN: r266649
      Jakub Jelinek committed
    • re PR target/54700 (Optimize away x<0 as mask argument of a blend.) · fb9e6a4b
      	PR target/54700
      	* config/i386/sse.md
      	(*<sse4_1>_blendv<ssemodesuffix><avxsizesuffix>_lt,
      	*<sse4_1>_blendv<ssefltmodesuffix><avxsizesuffix>_ltint,
      	*<sse4_1_avx2>_pblendvb_lt): Change define_insn into
      	define_insn_and_split.
      
      From-SVN: r266648
      Jakub Jelinek committed
    • pr34256.c: Adjust the number of expected moves. · f21bfc1b
      2018-11-29  Vladimir Makarov  <vmakarov@redhat.com>
      
      	* gcc.target/i386/pr34256.c: Adjust the number of expected moves.
      
      From-SVN: r266646
      Vladimir Makarov committed
    • decl.c (compute_array_index_type_loc): New, like the current… · eedb990a
      decl.c (compute_array_index_type_loc): New, like the current compute_array_index_type but takes a location_t too.
      
      /cp
      2018-11-29  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* decl.c (compute_array_index_type_loc): New, like the current
      	compute_array_index_type but takes a location_t too.
      	(compute_array_index_type): Forward to the latter.
      	(create_array_type_for_decl): Use compute_array_index_type_loc.
      
      /testsuite
      2018-11-29  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* g++.dg/cpp0x/constexpr-base6b.C: New.
      	* g++.dg/cpp0x/constexpr-47969.C: Test locations too.
      	* g++.dg/cpp0x/constexpr-48324.C: Likewise.
      	* g++.dg/cpp0x/constexpr-ex2.C: Likewise.
      	* g++.dg/cpp0x/scoped_enum2.C: Likewise.
      	* g++.dg/cpp1y/pr63996.C: Likewise.
      	* g++.dg/ext/constexpr-vla5.C: Likewise.
      	* g++.dg/ext/stmtexpr15.C: Likewise.
      	* g++.dg/ext/vla1.C: Likewise.
      	* g++.dg/other/fold1.C: Likewise.
      	* g++.dg/parse/array-size2.C: Likewise.
      	* g++.dg/parse/crash36.C: Likewise.
      	* g++.dg/ubsan/pr81530.C: Likewise.
      	* g++.dg/warn/Wvla-1.C: Likewise.
      	* g++.dg/warn/Wvla-2.C: Likewise.
      	* g++.old-deja/g++.brendan/array1.C: Likewise.
      	* g++.old-deja/g++.bugs/900402_02.C: Likewise.
      	* g++.old-deja/g++.law/init3.C: Likewise.
      	* g++.old-deja/g++.mike/p6149.C: Likewise.
      
      From-SVN: r266645
      Paolo Carlini committed
    • C++: namespaces and scopes for enum values (PR c++/88121) · 3ded6ffd
      Consider this test case:
      
      namespace json
      {
        enum { JSON_OBJECT };
      }
      
      void test ()
      {
        JSON_OBJECT;
      }
      
      which erroneously accesses an enum value in another namespace without
      qualifying the access.
      
      GCC 6 through 8 issue a suggestion that doesn't mention the namespace:
      
      <source>: In function 'void test()':
      <source>:8:3: error: 'JSON_OBJECT' was not declared in this scope
         JSON_OBJECT;
         ^~~~~~~~~~~
      <source>:8:3: note: suggested alternative:
      <source>:3:10: note:   'JSON_OBJECT'
         enum { JSON_OBJECT };
                ^~~~~~~~~~~
      
      which is suboptimal.
      
      I made the problem worse with r265610, which consolidates the single
      suggestion into the error, and emits:
      
      <source>: In function 'void test()':
      <source>:8:3: error: 'JSON_OBJECT' was not declared in this scope; did
         you mean 'JSON_OBJECT'?
          8 |   JSON_OBJECT;
            |   ^~~~~~~~~~~
            |   JSON_OBJECT
      <source>:3:10: note: 'JSON_OBJECT' declared here
          3 |   enum { JSON_OBJECT };
            |          ^~~~~~~~~~~
      
      where the message:
        'JSON_OBJECT' was not declared in this scope; did you mean 'JSON_OBJECT'?
      is nonsensical.
      
      This patch tweaks dump_scope to detect unscoped enums, and to use the
      enclosing namespace for them, so that the CONST_DECL is dumped as
      "json::JSON_OBJECT".
      
      This changes the output for the above so that it refers to the
      namespace, fixing the issue:
      
      <source>:8:3: error: 'JSON_OBJECT' was not declared in this scope; did
         you mean 'json::JSON_OBJECT'?
          9 |   JSON_OBJECT;
            |   ^~~~~~~~~~~
            |   json::JSON_OBJECT
      <source>3:10: note: 'json::JSON_OBJECT' declared here
          3 |   enum { JSON_OBJECT };
            |          ^~~~~~~~~~~
      
      The patch also fixes scope-printing for values within scoped enums.
      To exercise this, the patch extends the scanner for namespaces for
      exact matches for a name, so that we also scan inside scoped
      enums, to cover the case where someone doesn't supply the scope.
      
      Hence with the patch given e.g.:
      
      enum class vegetable { CARROT, TURNIP };
      
      we're able to offer e.g.:
      
      suggestions-scoped-enums.C:50:3: error: 'CARROT' was not declared in
        this scope; did you mean 'vegetable::CARROT'?
         50 |   CARROT;
            |   ^~~~~~
            |   vegetable::CARROT
      
      and this exercises the code path above.  The patch updates dump_scope
      for scoped enums so that we print the scope when printing the
      value ("vegetable::CARROT"), rather than just the name of the value
      ("CARROT").
      
      Finally, the patch adds spell-corrections within a scoped enum,
      giving e.g.:
      
      suggestions-scoped-enums.C:18:14: error: 'TURNUP' is not a member of
        'vegetable'; did you mean 'TURNIP'?
         18 |   vegetable::TURNUP;
            |              ^~~~~~
            |              TURNIP
      
      gcc/cp/ChangeLog:
      	PR c++/88121
      	* cp-name-hint.h (suggest_alternative_in_scoped_enum): New decl.
      	* error.c (dump_scope): Ensure that we print any scope for values
      	of unscoped enums.  Print the scope of values of scoped enums.
      	(qualified_name_lookup_error): Offer suggestions for failures
      	within scoped enums by calling suggest_alternative_in_scoped_enum.
      	* name-lookup.c (class namespace_hints): Update comment to mention
      	scoped enums.
      	(namespace_hints::namespace_hints): Call
      	maybe_add_candidate_for_scoped_enum.
      	(namespace_hints::maybe_add_candidate_for_scoped_enum): New member
      	(suggest_alternatives_for): Update comment to mention scoped
      	enums.
      	(suggest_alternative_in_scoped_enum): New function.
      
      gcc/testsuite/ChangeLog:
      	PR c++/88121
      	* g++.dg/lookup/suggestions-scoped-enums.C: New test.
      	* g++.dg/lookup/suggestions-unscoped-enums.C: New test.
      
      From-SVN: r266644
      David Malcolm committed
    • re PR target/87496 (ICE in aggregate_value_p at gcc/function.c:2046) · 171954d8
      gcc/
      	PR target/87496
      	* config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow
      	-mabi=ieeelongdouble without both -mpopcntd and -mvsx.
      
      gcc/testsuite/
      	PR target/87496
      	* gcc.target/powerpc/pr87496.c: New test.
      
      From-SVN: r266636
      Peter Bergner committed
    • i386.c (inline_memory_move_cost): Check "in" for 2 in MMX_CLASS_P case. · 9bb3d6c4
      	* config/i386/i386.c (inline_memory_move_cost):
      	Check "in" for 2 in MMX_CLASS_P case.
      	* config/i386/mmx.md (*mov<mode>_internal): Correct
      	TARGET_INTER_UNIT_MOVES_FROM_VEC and TARGET_INTER_UNIT_MOVES_TO_VEC
      	alternatives in preferred_for_speed attribute calculation.
      
      From-SVN: r266635
      Uros Bizjak committed
    • PR c/88091 - c-c++-common/Wconversion-real.c etc. FAIL · 550dfbdc
      gcc/c/ChangeLog:
      
      	PR c/88091
      	* c-typeck.c (convert_argument): Add a parameter.  Adjust indentation.
      	(convert_arguments): Add comments.  Pass additional argument to
      	the function above.
      
      From-SVN: r266634
      Martin Sebor committed
    • PR c/88172 - attribute aligned of zero silently accepted but ignored · 673670da
      PR c/88172 - attribute aligned of zero silently accepted but ignored
      PR testsuite/88208 - new test case c-c++-common/builtin-has-attribute-3.c in r266335 has multiple excess errors
      
      gcc/ChangeLog:
      
      	PR c/88172
      	PR testsuite/88208
      	* doc/extend.texi (attribute constructor): Clarify.
      
      gcc/c/ChangeLog:
      
      	PR c/88172
      	PR testsuite/88208
      	* c-decl.c (declspec_add_alignas): Adjust call to check_user_alignment.
      
      gcc/c-family/ChangeLog:
      
      	PR c/88172
      	PR testsuite/88208
      	* c-attribs.c (common_handle_aligned_attribute): Silently avoid setting
      	alignments to values less than the target requires.
      	(has_attribute): For attribute aligned consider both the attribute
      	and the alignment bits.
      	* c-common.c (c_init_attributes): Optionally issue a warning for
      	zero alignment.
      
      gcc/testsuite/ChangeLog:
      
      	PR c/88172
      	PR testsuite/88208
      	* gcc.dg/attr-aligned-2.c: New test.
      	* gcc.dg/builtin-has-attribute.c: Adjust.
      	* c-c++-common/builtin-has-attribute-2.c: Same.
      	* c-c++-common/builtin-has-attribute-3.c: Same.
      	* c-c++-common/builtin-has-attribute-4.c: Same.
      	* c-c++-common/builtin-has-attribute-5.c: New test.
      	* gcc.target/aarch64/attr-aligned.c: Same.
      	* gcc.target/i386/attr-aligned.c: Same.
      	* gcc.target/powerpc/attr-aligned.c: Same.
      	* gcc.target/sparc/attr-aligned.c: Same.
      
      From-SVN: r266633
      Martin Sebor committed
    • Fix thinko in transition to memop_ret type (PR middle-end/88246). · 2831adb5
      2018-11-29  Martin Liska  <mliska@suse.cz>
      
      	PR middle-end/88246
      	* builtins.c (expand_movstr): Fix thinko introduced
      	when switching to the new enum.
      
      From-SVN: r266631
      Martin Liska committed
    • Add a new option -flive-patching={inline-only-static|inline-clone} · 6fd6a2ff
      to support live patching in GCC.
      
      2018-11-29  qing zhao  <qing.zhao@oracle.com>
      
      gcc/ChangeLog:
      
      	* cif-code.def (EXTERN_LIVE_ONLY_STATIC): New CIF code.
      	* common.opt: Add -flive-patching flag.
      	* doc/invoke.texi: Document -flive-patching.
      	* flag-types.h (enum live_patching_level): New enum.
      	* ipa-inline.c (can_inline_edge_p): Disable external functions from
      	inlining when flag_live_patching is LIVE_PATCHING_INLINE_ONLY_STATIC.
      	* opts.c (control_options_for_live_patching): New function.
      	(finish_options): Make flag_live_patching incompatible with flag_lto.
      	Control IPA optimizations based on different levels of 
      	flag_live_patching.
      
      gcc/testsuite/ChangeLog:
      
      	* gcc.dg/live-patching-1.c: New test.
      	* gcc.dg/live-patching-2.c: New test.
      	* gcc.dg/live-patching-3.c: New test.
      	* gcc.dg/tree-ssa/writeonly-3.c: New test.
      	* gcc.target/i386/ipa-stack-alignment-2.c: New test.
      
      From-SVN: r266627
      Qing Zhao committed
    • match.pd (sinh (atanh (x))): New simplification rules. · 4aff6d17
      	* match.pd (sinh (atanh (x))): New simplification rules.
      	(cosh (atanh (x))): Likewise.
      
      	* gcc.dg/sinhatanh-1.c: New test.
      	* gcc.dg/sinhatanh-2.c: New test.
      	* gcc.dg/sinhatanh-3.c: New test.
      
      From-SVN: r266625
      Giuliano Belinassi committed
    • Only include bits/stl_algo.h for C++20. · 355c62ce
      2018-11-29  Edward Smith-Rowland  <3dw4rd@verizon.net>
      
      	Only include bits/stl_algo.h for C++20.
      	* include/std/deque: Only include bits/stl_algo.h for C++20.
      	* include/std/string: Ditto.
      	* include/std/vector: Ditto.
      
      From-SVN: r266624
      Edward Smith-Rowland committed
    • re PR target/54700 (Optimize away x<0 as mask argument of a blend.) · fe907c1f
      	PR target/54700
      	* config/i386/sse.md (ssebytemode): Add V16SI, V8SI and V4SI entries.
      	(ssefltmodesuffix, ssefltvecmode): New define_mode_attrs.
      	(*<sse4_1>_blendv<ssemodesuffix><avxsizesuffix>_lt,
      	*<sse4_1>_blendv<ssefltmodesuffix><avxsizesuffix>_ltint,
      	*<sse4_1_avx2>_pblendvb_lt): New define_insns.
      
      	* g++.target/i386/sse4_1-pr54700-1.C: New test.
      	* g++.target/i386/sse4_1-pr54700-2.C: New test.
      	* g++.target/i386/avx-pr54700-1.C: New test.
      	* g++.target/i386/avx-pr54700-2.C: New test.
      	* g++.target/i386/avx2-pr54700-1.C: New test.
      	* g++.target/i386/avx2-pr54700-2.C: New test.
      	* g++.target/i386/sse4_1-check.h: New file.
      	* g++.target/i386/avx-check.h: New file.
      	* g++.target/i386/avx2-check.h: New file.
      	* g++.target/i386/m128-check.h: New file.
      	* g++.target/i386/m256-check.h: New file.
      	* g++.target/i386/avx-os-support.h: New file.
      
      From-SVN: r266621
      Jakub Jelinek committed
    • re PR target/88152 (optimize SSE & AVX char compares with subsequent movmskb) · f06e47d7
      	PR target/88152
      	* tree.h (build_uniform_cst, uniform_integer_cst_p): Declare.
      	* tree.c (build_uniform_cst, uniform_integer_cst_p): New functions.
      	* match.pd (define_predicates): Add uniform_integer_cst_p.
      	(cmp @0 INTEGER_CST@1, cmp (convert?@2 @0) INTEGER_CST@1): Adjust
      	so that it works also for vector comparisons with uniform constants
      	with INTEGER_CST element.
      
      	* g++.dg/tree-ssa/pr88152-1.C: New test.
      	* g++.dg/tree-ssa/pr88152-2.C: New test.
      
      From-SVN: r266620
      Jakub Jelinek committed
    • re PR target/88234 (UBsan and runtime error: signed integer overflow using unsigned vector) · b076fecb
      	PR target/88234
      	* config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): For
      	vec_add and vec_sub builtins, perform PLUS_EXPR or MINUS_EXPR
      	in unsigned_type_for instead of vector integral type where overflow
      	doesn't wrap.
      
      	* gcc.dg/ubsan/pr88234.c: New test.
      
      From-SVN: r266619
      Jakub Jelinek committed
    • There can be at most one .resolver clone per function · 55da34eb
      2018-11-29  Michael Ploujnikov  <michael.ploujnikov@oracle.com>
      
      	There can be at most one .resolver clone per function
      	* config/rs6000/rs6000.c (make_resolver_func): Generate
      	resolver symbol with clone_function_name instead of
      	clone_function_name_numbered.
      
      From-SVN: r266617
      Michael Ploujnikov committed
    • Fix erasure goofs. · a62b871d
      2018-11-29  Edward Smith-Rowland  <3dw4rd@verizon.net>
      
      	Fix erasure goofs.
      	* include/experimental/deque: Make inline.
      	* include/std/deque: Include bits/stl_algo.h.
      	(erase, erase_if): Make inline.
      	* include/std/string: Include bits/stl_algo.h.
      	* include/std/unordered_set: Add erase, erase_if!
      	* include/std/vector: Include bits/stl_algo.h.
      	* testsuite/21_strings/basic_string/erasure.cc:
      	Add { dg-options "-std=gnu++2a" }.
      	* testsuite/23_containers/deque/erasure.cc: Ditto.
      	* testsuite/23_containers/forward_list/erasure.cc: Ditto.
      	* testsuite/23_containers/list/erasure.cc: Ditto.
      	* testsuite/23_containers/map/erasure.cc: Ditto.
      	* testsuite/23_containers/set/erasure.cc: Ditto.
      	* testsuite/23_containers/unordered_map/erasure.cc: Ditto.
      	* testsuite/23_containers/unordered_set/erasure.cc: Ditto.
      	* testsuite/23_containers/vector/erasure.cc: Ditto.
      
      From-SVN: r266616
      Edward Smith-Rowland committed
    • re PR tree-optimization/88243 (ice in vect_create_epilog_for_reduction, at tree-vect-loop.c:4689) · 154fb72b
      2018-11-29  Richard Biener  <rguenther@suse.de>
      
      	PR tree-optimization/88243
      	* tree-vect-patterns.c (vect_mark_pattern_stmts): Set the def
      	type of all pattern-sequence stmts to vect_internal_def.
      
      	* gcc.dg/torture/pr88243.c: New testcase.
      
      From-SVN: r266615
      Richard Biener committed
    • PR libstdc++/88119 use alignof in std::alignment_of, not __alignof__ · 8c9b3852
      Now that __alignof__ and alignof sometimes disagree it matters which one
      we use. The standard says that std::alignment_of<T>::value equals
      alignof(T), so we need to use that.
      
      Change the only uses of alignment_of to use __alignof__ to avoid a
      change in alignment.
      
      	PR libstdc++/88119
      	* include/ext/aligned_buffer.h (__aligned_membuf): Add comment.
      	(__aligned_buffer): Use __alignof__ instead of std::alignment_of.
      	* include/std/type_traits (alignment_of): Use alignof instead of
      	__alignof__.
      	* testsuite/20_util/alignment_of/value.cc: Fix test to check values
      	match alignof not __alignof__, as required by the standard.
      
      From-SVN: r266613
      Jonathan Wakely committed
    • [PATCH] [Arm] Fix fpu configurations for Cortex-R7 and Cortex-R8 · 479db227
      gcc/ChangeLog:
      2018-11-29  Andre Vieira  <andre.simoesdiasvieira@arm.com>
      
      	PR target/88224
      	* config/arm/arm-cpus.in (armv7-r): Add FP16conv configurations.
      	(cortex-r7, cortex-r8): Update default and add new configuration.
      	* doc/invoke.texi (armv7-r): Add two new vfp options.
      	(nofp.dp): Add cortex-r7 and cortex-r8 to the list of targets that
      	support this option.
      
      From-SVN: r266612
      Andre Vieira committed
    • re PR c++/87539 (internal compiler error when compiling project with Os optimization flag) · ebea4e1d
      	PR c++/87539
      	* g++.dg/cpp0x/pr87539.C: New test.
      
      From-SVN: r266611
      Jakub Jelinek committed
    • [RS6000] PR11848 rs6000_emit_move long double split · 9caa6732
      This split is disabled for power7 and up, so we don't often see its
      bad effects.  However, on a powerpc-linux compiler (which defaults
      to PPC750 judging from rs6000/sysv4.h) we see
      
      	long double ld1 (void) { return 1.0L; }
      
      compiled with -msoft-float -O2 -S resulting in
      
      	ld1:
      		li 3,0
      		li 4,0
      		mr 6,4
      		mr 5,3
      		li 4,0
      		lis 3,0x3ff0
      		blr
      
      Things go awry in init-regs, with the TFmode reg being initialized to
      zero on seeing the subreg from the split.  (And that initialization
      itself is split by rs6000_emit_move!)  Later passes apparently don't
      clean up the rubbish.
      
      Since the split was added for Darwin (as the comment says), let's get
      rid of it on other targets.
      
      	* config/rs6000/rs6000.c (rs6000_emit_move): Disable long
      	double split for targets other than Darwin.
      
      From-SVN: r266610
      Alan Modra committed
    • [RS6000] movdi_internal64 insn lengths · aa74f221
      Fixes alternatives wi<-Oj (xxlxor), wi<-wM (xxlorc) and wv<-wS
      (xxsltib+extend).
      
      	* config/rs6000/rs6000.md (movdi_internal64): Correct lengths.
      
      From-SVN: r266609
      Alan Modra committed
    • [RS6000] CONST_DOUBLE tidy · 5678e339
      Once upon a time CONST_DOUBLE was used to hold large integer constants
      that didn't fit into a CONST_INT.  Now that CONST_INT is always at
      least 64 bits, and the rs6000 backend uses CONST_WIDE_INT for larger
      integers, there is no need for old code dealing with integers in
      CONST_DOUBLE.  The rs6000 backend also doesn't create DImode subregs
      of TFmode CONST_DOUBLE, as once we did.  This patch cleans up a few
      leftovers from the past.
      
      	* config/rs6000/predicates.md (easy_fp_constant): Remove code
      	dealing with integers in const_double.  Assert on unexpected
      	modes.  Delete superfluous ABI_V4 test.
      	* config/rs6000/rs6000.c (rs6000_emit_move): Comment fixes.
      	Don't call easy_fp_constant for Pmode.
      	(rs6000_hash_constant): Remove code dealing with integers in
      	const_double.
      	(rs6000_legitimate_constant_p): Likewise.
      	(output_toc): Formatting, use CONST_DOUBLE_P.
      
      From-SVN: r266608
      Alan Modra committed
    • [RS6000] "G" and "H" constraints · 8529a062
      The patch fixes two cases where the "G" and "H" constraints were used
      incorrectly.  Their purpose is calculating insn lengths.  Thus it
      never makes sense to put "GH" together or with "F" in an insn
      alternative.
      
      movdi_internal32 used "GHF" in an alternative so I replaced that with
      "F", and added length attributes for the insn, which were missing.
      There are some formatting changes too, to make alternatives line up
      with attributes.
      
      The FMOVE128 version of mov<mode>_softfloat also had "GHF" in an
      alternative, so "GH" is dropped and "F" moved to a separate
      alternative in order to get insn lengths correct.  Well by correct I
      mean we need to choose the maximum insn length otherwise branches
      might not reach.  Note the very large length for "F".  I think it
      would be better to force soft-float long double constants to memory in
      64-bit mode, but that's a patch for another day.
      
      	* config/rs6000/constraints.md (G, H): Comment on purpose of
      	constraint.  Correct mode comments and "G" mode test.
      	* config/rs6000/rs6000.md (movdi_internal32): Remove "GH" from
      	alternative handling "F".  Add length attr.  Formatting.
      	(mov<mode>_softfloat <FMOVE128>): Delete "GH" from
      	alternative, and move "F" to separate alternative.  Correct
      	insn lengths.
      
      From-SVN: r266607
      Alan Modra committed
    • [RS6000] Bogus easy_fp_constant call · abf07e52
      easy_fp_constant accepts const_double, easy_vector_constant accepts
      const_vector.  Calling one from the other therefore will always return
      false.  I believe the zero_constant call in easy_vector_constant will
      cover the 0.0 case of easy_fp_constant.
      
      	* config/rs6000/predicates.md (easy_vector_constant): Don't call
      	easy_fp_constant.
      
      From-SVN: r266606
      Alan Modra committed
    • [RS6000] inline plt call sequences · 3f79c0ad
      Finally, the point of the previous patches in this series, support for
      inline PLT calls, keyed off -fno-plt.  This emits code using new
      relocations that tie all insns in the sequence together, so that the
      linker can edit the sequence back to a direct call should the call
      target turn out to be local.  An example of ELFv2 code to call puts is
      as follows:
      
           .reloc .,R_PPC64_PLTSEQ,puts
              std 2,24(1)
           .reloc .,R_PPC64_PLT16_HA,puts
              addis 12,2,0
           .reloc .,R_PPC64_PLT16_LO_DS,puts
              ld 12,0(12)
           .reloc .,R_PPC64_PLTSEQ,puts
              mtctr 12
           .reloc .,R_PPC64_PLTCALL,puts
              bctrl
              ld 2,24(1)
      
      "addis 12,2,puts@plt@ha" and "ld 12,puts@plt@l(12)" are also supported
      by the assembler.  gcc instead uses the explicit R_PPC64_PLT16_HA and
      R_PPC64_PLT16_LO_DS relocs because when the call is to __tls_get_addr
      an extra reloc is emitted at every place where one is shown above, to
      specify the __tls_get_addr arg.  The linker expects the extra reloc to
      come first.  .reloc enforces that ordering.
      
      The patch also changes code emitted for longcalls if the assembler
      supports the new marker relocs, so that these too can be edited.  One
      side effect of longcalls using PLT16 relocs is that they can now be
      resolved lazily by ld.so.
      
      I don't support lazy inline PLT calls for ELFv1, because ELFv1 would
      need barriers to reliably load both the function address and toc
      pointer from the PLT.  ELFv1 -fno-plt uses the longcall sequence
      instead, which isn't edited by GNU ld.
      
      	* config.in (HAVE_AS_PLTSEQ): Add.
      	* config/rs6000/predicates.md (indirect_call_operand): New.
      	* config/rs6000/rs6000-protos.h (rs6000_pltseq_template),
      	(rs6000_sibcall_sysv): Declare.
      	* config/rs6000/rs6000.c (init_cumulative_args): Set cookie
      	CALL_LONG for -fno-plt.
      	(print_operand <T, z, 0>): Handle UNSPEC_PLTSEQ.
      	(rs6000_indirect_call_template_1): Emit .reloc directives for
      	UNSPEC_PLTSEQ calls.
      	(rs6000_pltseq_template): New function.
      	(rs6000_longcall_ref): Add arg parameter.  Use PLT16 insns if
      	relocs supported by assembler.  Move SYMBOL_REF test to callers.
      	(rs6000_call_aix): Adjust rs6000_longcall_ref call.  Package
      	insns in UNSPEC_PLTSEQ, preserving original func_desc.
      	(rs6000_call_sysv): Likewise.
      	(rs6000_sibcall_sysv): New function.
      	* config/rs6000/rs6000.h (HAVE_AS_PLTSEQ): Provide default.
      	* config/rs6000/rs6000.md (UNSPEC_PLTSEQ, UNSPEC_PLT16_HA,
      	UNSPEC_PLT16_LO): New.
      	(pltseq_tocsave, pltseq_plt16_ha, pltseq_plt16_lo, pltseq_mtctr): New.
      	(call_indirect_nonlocal_sysv): Don't differentiate zero from non-zero
      	cookie in constraints.  Test explicitly for flags in length attr.
      	Handle unspec operand 1.
      	(call_value_indirect_nonlocal_sysv): Likewise.
      	(call_indirect_aix, call_value_indirect_aix): Handle unspec operand 1.
      	(call_indirect_elfv2, call_value_indirect_elfv2): Likewise.
      	(sibcall, sibcall_value): Use rs6000_sibcall_sysv.
      	(sibcall_indirect_nonlocal_sysv): New pattern.
      	(sibcall_value_indirect_nonlocal_sysv): Likewise.
      	(sibcall_nonlocal_sysv, sibcall_value_nonlocal_sysv): Remove indirect
      	call alternatives.
      	* configure.ac: Check for gas plt sequence marker support.
      	* configure: Regenerate.
      
      From-SVN: r266605
      Alan Modra committed
    • [RS6000] Use standard call patterns for __tls_get_addr calls · ece3bca2
      The current code handling __tls_get_addr calls for powerpc*-linux
      generates a call then overwrites the call insn with a special
      tls_{gd,ld}_{aix,sysv} pattern.  It's done that way to support
      !TARGET_TLS_MARKERS, where the arg setup insns need to be emitted
      immediately before the branch and link.  When TARGET_TLS_MARKERS, the
      arg setup insns are split from the actual call, but we then have a
      non-standard call pattern that needs to be carried through to output.
      
      This patch changes that scheme, to instead use the standard call
      patterns for __tls_get_addr calls, except for the now rare
      !TARGET_TLS_MARKERS case.  Doing it this way should be better for
      maintenance as the !TARGET_TLS_MARKERS code can eventually disappear.
      It also makes it possible to support longcalls (and in following
      patches, inline plt calls) for __tls_get_addr without introducing yet
      more special call patterns.
      
      __tls_get_addr calls do however need to be different to standard
      calls, because when TARGET_TLS_MARKERS the calls are decorated with an
      argument specifier, eg. "bl __tls_get_addr(thread_var@tlsgd)" that
      causes a reloc to be emitted by the assembler tying the call to its
      arg setup insns.  I chose to smuggle the arg in the currently unused
      stack size rtl.
      
      I've also introduced rs6000_call_sysv to generate rtl for sysv calls,
      as rs6000_call_aix does for aix and elfv2 calls.  This allows
      rs6000_longcall_ref to be local to rs6000.c since the calls in the
      expanders never did anything for darwin.
      
      	* config/rs6000/predicates.md (unspec_tls): New.
      	* config/rs6000/rs6000-protos.h (rs6000_call_template),
      	(rs6000_sibcall_template): Update prototype.
      	(rs6000_longcall_ref): Delete.
      	(rs6000_call_sysv): Declare.
      	* config/rs6000/rs6000.c (edit_tls_call_insn): New function.
      	(global_tlsarg): New variable.
      	(rs6000_legitimize_tls_address): Rewrite __tls_get_addr call
      	handling.
      	(print_operand): Extract UNSPEC_TLSGD address operand.
      	(rs6000_call_template, rs6000_sibcall_template): Remove arg
      	parameter, extract from second call operand instead.
      	(rs6000_longcall_ref): Make static, localize vars.
      	(rs6000_call_aix): Rename parameter to reflect new usage.  Take
      	tlsarg from global_tlsarg.  Don't create unused rtl or nop insns.
      	(rs6000_sibcall_aix): Rename parameter to reflect new usage.  Take
      	tlsarg from global_tlsarg.
      	(rs6000_call_sysv): New function.
      	* config/rs6000/rs6000.md: Adjust rs6000_call_template and
      	rs6000_sibcall_template throughout.
      	(tls_gd_aix, tls_gd_sysv, tls_gd_call_aix, tls_gd_call_sysv): Delete.
      	(tls_ld_aix, tls_ld_sysv, tls_ld_call_aix, tls_ld_call_sysv): Delete.
      	(tls_gdld_nomark): New insn.
      	(tls_gd): Swap operand order.  Simplify mode selection.
      	(tls_gd_high, tls_gd_low): Swap operand order.
      	(tls_ld): Remove const_int 0 vector element from UNSPEC_TLSLD.
      	Simplify mode selection.
      	(tls_ld_high, tls_ld_low): Similarly adjust UNSPEC_TLSLD.
      	(call, call_value): Don't assert for second call operand.
      	Use rs6000_call_sysv.
      
      From-SVN: r266604
      Alan Modra committed
    • [RS6000] Remove constraints on call rounded_stack_size_rtx arg · 7a24893b
      This call arg is unused on rs6000.
      
      	* config/rs6000/darwin.md (call_indirect_nonlocal_darwin64),
      	(call_nonlocal_darwin64, call_value_indirect_nonlocal_darwin64),
      	(call_value_nonlocal_darwin64): Remove constraints from second call
      	arg, the rounded_stack_size_rtx arg.
      	* config/rs6000/rs6000.md (tls_gd_aix, tls_gd_sysv, tls_gd_call_aix),
      	(tls_gd_call_sysv, tls_ld_aix, tls_ld_sysv, tls_ld_call_aix),
      	(tls_ld_call_sysv, call_local32, call_local64, call_value_local32),
      	(call_value_local64, call_indirect_nonlocal_sysv),
      	(call_nonlocal_sysv, call_nonlocal_sysv_secure),
      	(call_value_indirect_nonlocal_sysv, call_value_nonlocal_sysv),
      	(call_value_nonlocal_sysv_secure, call_local_aix),
      	(call_value_local_aix, call_nonlocal_aix, call_value_nonlocal_aix),
      	(call_indirect_aix, call_value_indirect_aix, call_indirect_elfv2),
      	(call_value_indirect_elfv2, sibcall_local32, sibcall_local64),
      	(sibcall_value_local32, sibcall_value_local64, sibcall_aix),
      	(sibcall_value_aix): Likewise.
      
      From-SVN: r266603
      Alan Modra committed
    • [RS6000] Replace TLSmode with P, and correct tls call mems · 493bb3d0
      There is really no need to define a TLSmode mode iterator that is
      identical (since !TARGET_64BIT == TARGET_32BIT) to the much used P
      mode iterator.  It's nonsense to think we might ever want to support
      32-bit TLS on 64-bit or vice versa!  The patch also fixes a minor
      error in the call mems.  All other direct calls use (call (mem:SI ..)).
      
      	* config/rs6000/rs6000.md (TLSmode): Delete mode iterator.  Replace
      	with P throughout except for call mems which should use SI.
      	(tls_abi_suffix, tls_sysv_suffix, tls_insn_suffix): Delete mode
      	attributes.  Replace with bits, mode and ptrload respectively.
      
      From-SVN: r266602
      Alan Modra committed
    • [RS6000] rs6000_indirect_call_template · ce83eeda
      Like the last patch for external calls, now handle most assembly code
      for indirect calls in one place.  The patch also merges some insns,
      correcting some !rs6000_speculate_indirect_jumps cases branching to
      LR, which don't require a speculation barrier.
      
      	* config/rs6000/rs6000-protos.h (rs6000_indirect_call_template),
      	(rs6000_indirect_sibcall_template): Declare.
      	* config/rs6000/rs6000.c (rs6000_indirect_call_template_1),
      	(rs6000_indirect_call_template, rs6000_indirect_sibcall_template):
      	New functions.
      	* config/rs6000/rs6000.md (call_indirect_nonlocal_sysv),
      	(call_value_indirect_nonlocal_sysv, sibcall_nonlocal_sysv),
      	(call_indirect_aix, call_value_indirect_aix): Use
      	rs6000_indirect_call_template and rs6000_indirect_sibcall_template.
      	call_indirect_elfv2, call_value_indirect_elfv2): Likewise, and
      	handle both speculation and non-speculation cases.
      	(call_indirect_aix_nospec, call_value_indirect_aix_nospec): Delete.
      	(call_indirect_elfv2_nospec, call_value_indirect_elfv2_nospec): Delete.
      
      From-SVN: r266601
      Alan Modra committed
    • [RS6000] rs6000_call_template for external call insn assembly output · 75a0b805
      This is a first step in tidying rs6000 call patterns, in preparation
      to support inline plt calls.
      
      	* config/rs6000/rs6000-protos.h (rs6000_call_template): Declare.
      	(rs6000_sibcall_template): Declare.
      	(macho_call_template): Rename from output_call.
      	* config/rs6000/rs6000.c (rs6000_call_template_1): New function.
      	(rs6000_call_template, rs6000_sibcall_template): Likewise.
      	(macho_call_template): Rename from output_call.
      	* config/rs6000/rs6000.md (tls_gd_aix, tls_gd_sysv),
      	(tls_gd_call_aix, tls_gd_call_sysv, tls_ld_aix, tls_ld_sysv),
      	(tls_ld_call_aix, tls_ld_call_sysv, call_nonlocal_sysv),
      	(call_nonlocal_sysv_secure, call_value_nonlocal_sysv),
      	(call_value_nonlocal_sysv_secure, call_nonlocal_aix),
      	(call_value_nonlocal_aix): Use rs6000_call_template and update
      	occurrences of output_call to macho_call_template.
      	(sibcall_nonlocal_sysv, sibcall_value_nonlocal_sysv, sibcall_aix),
      	(sibcall_value_aix): Use rs6000_sibcall_template.
      
      From-SVN: r266600
      Alan Modra committed
    • rs6000-string.c (expand_block_clear): Change how we determine if unaligned vsx is ok. · 645eee74
      2018-11-28  Aaron Sawdey  <acsawdey@linux.ibm.com>
      
      	* config/rs6000/rs6000-string.c (expand_block_clear): Change how
      	we determine if unaligned vsx is ok.
      
      From-SVN: r266599
      Aaron Sawdey committed
    • PR libstdc++/86910 fix filesystem::create_directories · ffe2c055
      Implement the proposed semantics from P1164R0, which reverts the changes
      of LWG 2935. This means that failure to create a directory because a
      non-directory already exists with that name will be reported as an
      error.
      
      While rewriting the function, also fix PR 87846, which is a result of
      the C++17 changes to how a trailing slash on a path affects the last
      component of a path.
      
      	PR libstdc++/86910
      	PR libstdc++/87846
      	* src/filesystem/ops.cc (experimental::create_directories): Report
      	an error when the path resolves to an existing non-directory (P1164).
      	* src/filesystem/std-ops.cc (create_directories): Likewise. Handle
      	empty filenames due to trailing slashes.
      	* testsuite/27_io/filesystem/operations/create_directories.cc: Test
      	when some component of the path exists and is not a directory. Test
      	trailing slashes.
      	* testsuite/experimental/filesystem/operations/create_directories.cc:
      	Likewise.
      
      From-SVN: r266598
      Jonathan Wakely committed