1. 03 Aug, 2015 1 commit
  2. 10 Jun, 2015 1 commit
  3. 22 May, 2015 1 commit
  4. 11 Mar, 2015 1 commit
  5. 15 Feb, 2015 1 commit
  6. 13 Feb, 2015 2 commits
  7. 29 Dec, 2014 1 commit
  8. 21 Nov, 2014 1 commit
  9. 27 Oct, 2014 1 commit
  10. 26 Sep, 2014 1 commit
  11. 02 Sep, 2014 1 commit
  12. 26 Aug, 2014 1 commit
    • pack: return the correct final offset · b3d3459f
      The callers of git_packfile_unpack() expect the obj_offset argument to
      be set to the beginning of the next object. We were mistakenly returning
      the the offset of the object's data, which causes the CRC function to
      try to use the wrong offset.
      
      Set obj_offset to curpos instead of elem->offset to point to the next
      element and bring back expected behaviour.
      Carlos Martín Nieto committed
  13. 25 Jun, 2014 1 commit
  14. 23 Jun, 2014 1 commit
    • Share packs across repository instances · b3b66c57
      Opening the same repository multiple times will currently open the same
      file multiple times, as well as map the same region of the file multiple
      times. This is not necessary, as the packfile data is immutable.
      
      Instead of opening and closing packfiles directly, introduce an
      indirection and allocate packfiles globally. This does mean locking on
      each packfile open, but we already use this lock for the global mwindow
      list so it doesn't introduce a new contention point.
      Carlos Martín Nieto committed
  15. 15 May, 2014 1 commit
  16. 13 May, 2014 3 commits
  17. 09 May, 2014 7 commits
  18. 23 Jan, 2014 1 commit
  19. 11 Dec, 2013 4 commits
    • Some callback error check style cleanups · c7b3e1b3
      I find this easier to read...
      Russell Belfer committed
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  20. 01 Nov, 2013 2 commits
  21. 04 Oct, 2013 1 commit
  22. 14 Aug, 2013 1 commit
  23. 25 Jul, 2013 1 commit
  24. 15 Jul, 2013 1 commit
  25. 31 May, 2013 2 commits
    • Mutex init can fail · 1a42dd17
      It is obviously quite a serious problem if this happens, but mutex
      initialization can fail and we should detect it.  It's a bit like
      a memory allocation failure, in that you're probably pretty screwed
      if this occurs, but at least we'll catch it.
      Russell Belfer committed
    • Zero memory for major objects before freeing · f658dc43
      By zeroing out the memory when we free larger objects (i.e. those
      that serve as collections of other data, such as repos, odb, refdb),
      I'm hoping that it will be easier for libgit2 bindings to find
      errors in their object management code.
      Russell Belfer committed
  26. 02 May, 2013 1 commit
    • Switch to index_version as "git_pack_file is ready" flag · 0ddfcb40
      We use p->index_map.data to check whether the struct has been set up
      and all the information about the index is stored there. This variable
      gets set up halfway through the setup process, however, and a thread
      can come along and use fields that haven't been written to yet.
      
      Crucially, pack_entry_find_offset() needs to read the index version
      (which is written after index_map) to know the offset and stride
      length to pass to sha1_entry_pos(). If these values are wrong,
      assertions in it will fail, as it will be reading bogus data.
      
      Make index_version the last field to be written and switch from using
      p->index_map.data to p->index_version as "git_pack_file is ready" flag
      as we can use it to know if every field has been written.
      Carlos Martín Nieto committed