1. 27 Oct, 2014 1 commit
  2. 26 Sep, 2014 1 commit
  3. 02 Sep, 2014 1 commit
  4. 26 Aug, 2014 1 commit
    • pack: return the correct final offset · b3d3459f
      The callers of git_packfile_unpack() expect the obj_offset argument to
      be set to the beginning of the next object. We were mistakenly returning
      the the offset of the object's data, which causes the CRC function to
      try to use the wrong offset.
      
      Set obj_offset to curpos instead of elem->offset to point to the next
      element and bring back expected behaviour.
      Carlos Martín Nieto committed
  5. 25 Jun, 2014 1 commit
  6. 23 Jun, 2014 1 commit
    • Share packs across repository instances · b3b66c57
      Opening the same repository multiple times will currently open the same
      file multiple times, as well as map the same region of the file multiple
      times. This is not necessary, as the packfile data is immutable.
      
      Instead of opening and closing packfiles directly, introduce an
      indirection and allocate packfiles globally. This does mean locking on
      each packfile open, but we already use this lock for the global mwindow
      list so it doesn't introduce a new contention point.
      Carlos Martín Nieto committed
  7. 15 May, 2014 1 commit
  8. 13 May, 2014 3 commits
  9. 09 May, 2014 7 commits
  10. 23 Jan, 2014 1 commit
  11. 11 Dec, 2013 4 commits
    • Some callback error check style cleanups · c7b3e1b3
      I find this easier to read...
      Russell Belfer committed
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  12. 01 Nov, 2013 2 commits
  13. 04 Oct, 2013 1 commit
  14. 14 Aug, 2013 1 commit
  15. 25 Jul, 2013 1 commit
  16. 15 Jul, 2013 1 commit
  17. 31 May, 2013 2 commits
    • Mutex init can fail · 1a42dd17
      It is obviously quite a serious problem if this happens, but mutex
      initialization can fail and we should detect it.  It's a bit like
      a memory allocation failure, in that you're probably pretty screwed
      if this occurs, but at least we'll catch it.
      Russell Belfer committed
    • Zero memory for major objects before freeing · f658dc43
      By zeroing out the memory when we free larger objects (i.e. those
      that serve as collections of other data, such as repos, odb, refdb),
      I'm hoping that it will be easier for libgit2 bindings to find
      errors in their object management code.
      Russell Belfer committed
  18. 02 May, 2013 4 commits
  19. 29 Apr, 2013 1 commit
  20. 22 Apr, 2013 4 commits
    • Consolidate packfile allocation further · 5d2d21e5
      Rename git_packfile_check to git_packfile_alloc since it is now
      being used more in that capacity.  Fix the various places that use
      it.  Consolidate some repeated code in odb_pack.c related to the
      allocation of a new pack_backend.
      Russell Belfer committed
    • Make indexer use shared packfile open code · 38eef611
      The indexer was creating a packfile object separately from the
      code in pack.c which was a problem since I put a call to
      git_mutex_init into just pack.c.  This commit updates the pack
      function for creating a new pack object (i.e. git_packfile_check())
      so that it can be used in both places and then makes indexer.c
      use the shared initialization routine.
      
      There are also a few minor formatting and warning message fixes.
      Russell Belfer committed
    • Further threading fixes · 53607868
      This builds on the earlier thread safety work to make it so that
      setting the odb, index, refdb, or config for a repository is done
      in a threadsafe manner with minimized locking time.  This is done
      by adding a lock to the repository object and using it to guard
      the assignment of the above listed pointers.  The lock is only
      held to assign the pointer value.
      
      This also contains some minor fixes to the other work with pack
      files to reduce the time that locks are being held to and fix an
      apparently memory leak.
      Russell Belfer committed
    • Add mutex around mapping and unmapping pack files · 24c70804
      When I was writing threading tests for the new cache, the main
      error I kept running into was a pack file having it's content
      unmapped underneath the running thread.  This adds a lock around
      the routines that map and unmap the pack data so that threads can
      effectively reload the data when they need it.
      
      This also required reworking the error handling paths in a couple
      places in the code which I tried to make consistent.
      Russell Belfer committed
  21. 03 Mar, 2013 1 commit
    • indexer: use a hashtable for keeping track of offsets · 0e040c03
      These offsets are needed for REF_DELTA objects, which encode which
      object they use as a base, but not where it lies in the packfile, so
      we need a list.
      
      These objects are mostly from older packfiles, before OFS_DELTA was
      widely spread. The time spent in indexing these packfiles is greatly
      reduced, though remains above what git is able to do.
      Carlos Martín Nieto committed