Skip to content

T
tic
Commit 50cfd3cd by Philip Hyunsu Cho Committed by Tianqi Chen
Options

GetChar() in base64.h should return int, not char (#2255)

parent 57a53eed
Showing with 2 additions and 2 deletions
src/common/base64.h
...@@ -58,10 +58,10 @@ class StreamBufferReader { ...@@ -58,10 +58,10 @@ class StreamBufferReader {
/*! /*!
* \return allows quick read using get char * \return allows quick read using get char
*/ */
char GetChar() { int GetChar() {
while (true) { while (true) {
if (read_ptr_ < read_len_) { if (read_ptr_ < read_len_) {
return buffer_[read_ptr_++]; return static_cast<int>(buffer_[read_ptr_++]);
} else { } else {
read_len_ = stream_->Read(&buffer_[0], buffer_.length()); read_len_ = stream_->Read(&buffer_[0], buffer_.length());
if (read_len_ == 0) return EOF; if (read_len_ == 0) return EOF;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment