GetChar() in base64.h should return int, not char (#2255)

50cfd3cd · Philip Hyunsu Cho · Tianqi Chen · 57a53eed · 50cfd3cd
Commit 50cfd3cd authored Dec 07, 2018 by Philip Hyunsu Cho Committed by Tianqi Chen Dec 07, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

src/common/base64.h
+2 -2

No files found.
--- a/src/common/base64.h
+++ b/src/common/base64.h
@@ -58,10 +58,10 @@ class StreamBufferReader {
  /*!
   * \return allows quick read using get char
   */
-  char GetChar() {
+  int GetChar() {
    while (true) {
      if (read_ptr_ < read_len_) {
-        return buffer_[read_ptr_++];
+        return static_cast<int>(buffer_[read_ptr_++]);
      } else {
        read_len_ = stream_->Read(&buffer_[0], buffer_.length());
        if (read_len_ == 0) return EOF;