Skip to content

R
riscv-gcc-1
Switch branch/tag
  1. 10 Feb, 2019 11 commits
  3. 09 Feb, 2019 11 commits
  5. 08 Feb, 2019 18 commits
    • [RS6000] Correct save_reg_p · 9b747072 
      Fixes lack of r30 save/restore on

// -m32 -fpic -ftls-model=initial-exec
__thread char* p;
char** f1 (void) { return &p; }

and

// -m32 -fpic -msecure-plt
extern int foo (int);
int f1 (int x) { return foo (x); }

These are both caused by save_reg_p returning false when the pic
offset table reg (r30 for ABI_V4) was used, due to the logic not
exactly matching that in rs6000_emit_prologue to set up r30.

I also noticed that save_reg_p isn't following the comment regarding
calls_eh_return (since svn 267049, git 0edf78b1b2a0), and the comment
needs tweaking too.  For why the revised comment is correct, grep for
saves_all_registers in lra.c, and yes, we do want to save the pic
offset table reg for eh_return.

	PR target/88343
	* config/rs6000/rs6000.c (save_reg_p): Correct calls_eh_return
	case.  Match logic in rs6000_emit_prologue emitting pic_offset_table
	setup.

From-SVN: r268708
      Alan Modra committed
    • re PR tree-optimization/88739 (Big-endian union bug) · ddf32191 
      	PR tree-optimization/88739
	* gcc.c-torture/execute/pr88739.c: New test.

From-SVN: r268706
      Jakub Jelinek committed
    • re PR middle-end/88560 (armv8_2-fp16-move-1.c and related regressions after r266385) · 82396b8c 
      2019-02-08  Vladimir Makarov  <vmakarov@redhat.com>

	PR middle-end/88560
	* lra-constraints.c (process_alt_operands): Don't increase reject
	for memory when offset memory is required.

From-SVN: r268705
      Vladimir Makarov committed
    • re PR testsuite/89258 (verify_gimple failed in gimple test pr80887 for 16-bit target) · b74ab8eb 
      2019-02-08  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

	PR testsuite/89258
	* gcc.dg/tree-ssa/pr80887.c: Require int32plus.

From-SVN: r268704
      Jozef Lawrynowicz committed
    • S/390: Implement vector copysign. · 062468db 
      This patch implements the vector copysign operation using vector select and a
signbit mask.

gcc/ChangeLog:

2019-02-08  Robin Dapp  <rdapp@linux.ibm.com>

	* config/s390/vector.md: Implement vector copysign.

gcc/testsuite/ChangeLog:

2019-02-08  Robin Dapp  <rdapp@linux.ibm.com>

	* gcc.target/s390/vector/vec-copysign-execute.c: New test.
	* gcc.target/s390/vector/vec-copysign.c: New test.

From-SVN: r268697
      Robin Dapp committed
    • expr.c: Correct indentations in expand_constructor · 94e35e0b 
      	* expr.c (expand_constructor): Correct indentations.

From-SVN: r268696
      H.J. Lu committed
    • re PR tree-optimization/89247 (ICE in expand_LOOP_VECTORIZED, at internal-fn.c:2409) · a2d0c3bf 
      2019-02-08  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/89247
	* tree-if-conv.c: Include tree-cfgcleanup.h.
	(version_loop_for_if_conversion): Record LOOP_VECTORIZED call.
	(tree_if_conversion): Pass through predicate vector.
	(pass_if_conversion::execute): Do CFG cleanup and SSA update
	inline, see if any if-converted loops we refrece in
	LOOP_VECTORIZED calls vanished and fixup.
	* tree-if-conv.h (tree_if_conversion): Adjust prototype.

	* gcc.dg/torture/pr89247.c: New testcase.

From-SVN: r268689
      Richard Biener committed
    • S/390: Introduce jdd constraint · 11719d14 
      Implementation of section anchors in S/390 back-end added in r266741
broke jump labels in S/390 Linux kernel [1].  Currently jump labels
pass global variable addresses to .quad directive in inline assembly
using "X" constraint.  In the past this used to produce regular symbol
references, however, after r266741 we sometimes get values like
(plus (reg) (const_int)), where (reg) points to a section anchor.
Strictly speaking, this is still correct, since "X" accepts anything.
Thus, now we need another way to support jump labels.

The existing "i" constraint cannot be used, since with -fPIC it must
not accept non-local symbols, however, jump labels do require that,
e.g. __tracepoint_xdp_exception from kernel proper might be referenced
from kernel modules.

The existing "ZL" constraint cannot be used for the same reason.

The existing "b" constraint cannot be used because of the way
expand_asm_stmt works.  It deduces whether the constraint allows
regs, subregs or mems, and processes asm operands differently based on
that.  "b" is supposed to accept values like (mem (symbol_ref)), and
there appears to be no way to explain to expand_asm_stmt that for "b"
mem's address must not be in a register.

This patch introduces the new machine-specific constraint named "jdd" -
"j" prefix is already used for constants, and "d" stands for "data".
It accepts anything that fits into the data section, whether or not
this might require a relocation, that is, anything that passes
CONSTANT_P check.

[1] https://lkml.org/lkml/2019/1/23/346

gcc/ChangeLog:

2019-02-08  Ilya Leoshkevich  <iii@linux.ibm.com>

	* config/s390/constraints.md (jdd): New constraint.

gcc/testsuite/ChangeLog:

2019-02-08  Ilya Leoshkevich  <iii@linux.ibm.com>

	* gcc.target/s390/jump-label.c: New test.

From-SVN: r268688
      Ilya Leoshkevich committed
    • re PR testsuite/89250 (gcc.dg/vect/vect-24.c XPASSes) · 5f5d88d8 
      2019-02-08  Richard Biener  <rguenther@suse.de>

	PR testsuite/89250
	* gcc.dg/vect/vect-24.c: Remove XFAIL on vect_condition targets.

From-SVN: r268680
      Richard Biener committed
    • trans.c (gnat_to_gnu): Minor tweak. · 14cc7b26 
      	* gcc-interface/trans.c (gnat_to_gnu) <N_Aggregate>: Minor tweak.
	* gcc-interface/utils.c (convert): Do not pad when doing an unchecked
	conversion here.  Use TREE_CONSTANT throughout the function.
	(unchecked_convert): Also pad if the source is a CONSTRUCTOR and the
	destination is a more aligned array type or a larger aggregate type,
	but not between original and packable versions of a type.

From-SVN: r268679
      Eric Botcazou committed
    • i386: Use OI/TImode in *mov[ot]i_internal_avx with AVX512VL · 694b3bb3 
      OImode and TImode moves must be done in XImode to access upper 16
vector registers without AVX512VL.  With AVX512VL, we can access
upper 16 vector registers in OImode and TImode.

	PR target/89229
	* config/i386/i386.md (*movoi_internal_avx): Set mode to XI for
	upper 16 vector registers without TARGET_AVX512VL.
	(*movti_internal): Likewise.

From-SVN: r268678
      H.J. Lu committed
    • utils.c (max_size): Be prepared for an operand with VOID_TYPE. · cc26a3bd 
      	* gcc-interface/utils.c (max_size) <tcc_unary>: Be prepared for an
	operand with VOID_TYPE.

From-SVN: r268675
      Eric Botcazou committed
    • trans.c (elaborate_all_entities): Do not elaborate the entities of a package renaming another one. · 0850f23b 
      	* gcc-interface/trans.c (elaborate_all_entities): Do not elaborate the
	entities of a package renaming another one.

From-SVN: r268674
      Eric Botcazou committed
    • trans.c (Regular_Loop_to_gnu): Replace tests on individual flag_unswitch_loops… · 3bdf0b64 
      trans.c (Regular_Loop_to_gnu): Replace tests on individual flag_unswitch_loops and flag_tree_loop_vectorize...

	* gcc-interface/trans.c (Regular_Loop_to_gnu): Replace tests on
	individual flag_unswitch_loops and flag_tree_loop_vectorize switches
	with test on global optimize switch.
	(Raise_Error_to_gnu): Likewise.

From-SVN: r268671
      Eric Botcazou committed
    • re PR rtl-optimization/89234 (ICE in get_eh_region_and_lp_from_rtx at gcc/except.c:1824) · 89cfdb7e 
      	PR rtl-optimization/89234
	* except.c (copy_reg_eh_region_note_forward): Return if note_or_insn
	is a NOTE, CODE_LABEL etc. - rtx_insn * other than INSN_P.
	(copy_reg_eh_region_note_backward): Likewise.

	* g++.dg/ubsan/pr89234.C: New test.

From-SVN: r268669
      Jakub Jelinek committed
    • [libbacktrace] Declare external backtrace fns noinline · 4af50e13 
      The backtrace functions backtrace_full, backtrace_print and backtrace_simple
walk the call stack, but make sure to skip the first entry, in order to skip
over the functions themselves, and start the backtrace at the caller of the
functions.

When compiling with -flto, the functions may be inlined, causing them to skip
over the caller instead.

Fix this by declaring the functions with __attribute__((noinline)).

2019-02-08  Tom de Vries  <tdevries@suse.de>

	* backtrace.c (backtrace_full): Declare with __attribute__((noinline)).
	* print.c (backtrace_print): Same.
	* simple.c (backtrace_simple): Same.

From-SVN: r268668
      Tom de Vries committed
    • re PR tree-optimization/89223 (internal compiler error: in int_cst_value, at tree.c:11226) · 2536d696 
      2019-02-08  Richard Biener  <rguenther@suse.de>

	PR middle-end/89223
	* tree-data-ref.c (initialize_matrix_A): Fail if constant
	doesn't fit in HWI.
	(analyze_subscript_affine_affine): Handle failure from
	initialize_matrix_A.

	* gcc.dg/torture/pr89223.c: New testcase.

From-SVN: r268666
      Richard Biener committed
    • cfganal.c (pre_and_rev_post_order_compute_fn): Use fn instead of cfun everywhere. · 1c93f6ce 
      	* cfganal.c (pre_and_rev_post_order_compute_fn): Use fn instead of
	cfun everywhere.

From-SVN: r268664
      Jakub Jelinek committed