1. 30 Nov, 2017 3 commits
  2. 29 Nov, 2017 30 commits
    • combine: Print to dump if some insn cannot be combined into i3 · 3d985316
      Eventually we should print the reason that any combination fails.
      This is a good start (these happen often).
      
      
      	* combine.c (try_combine): Print a message to dump file whenever
      	I0, I1, or I2 cannot be combined into I3.
      
      From-SVN: r255261
      Segher Boessenkool committed
    • combine: Do not throw away unneeded arms of parallels (PR83156) · 4a016178
      The fix for PR82621 makes us not split an I2 if one of the results of
      those SETs is unused, since combine does not handle that properly.  But
      this results in degradation for i386 (or more in general, for any
      target that does not have patterns for parallels with an unused result
      as a CLOBBER instead of a SET for that result).
      
      This patch instead makes us not split only if one of the results is set
      again before I3.  That fixes PR83156 and also fixes PR82621.
      
      Unfortunately it undoes the nice optimisations that the previous patch
      did on powerpc.
      
      
      	PR rtl-optimization/83156
      	PR rtl-optimization/82621
      	* combine.c (try_combine): Don't split an I2 if one of the dests is
      	set again before I3.  Allow unused dests.
      
      From-SVN: r255260
      Segher Boessenkool committed
    • rs6000: Add second variant of adde · 18b776e9
      This adds a second variant of the adde insn pattern, this one with the
      CA register as the second operand.  The existing pattern has it as the
      third operand.  It would be ideal if RTL was always canonicalised like
      that, but it isn't (and that is not trivial), and this is a simple and
      harmless patch.
      
      
      	* config/rs6000/rs6000.md (*add<mode>3_carry_in_internal2): New.
      
      From-SVN: r255259
      Segher Boessenkool committed
    • re PR rtl-optimization/80818 (LRA clobbers live hard reg clobbered during rematerialization) · 561c58b4
      2017-11-29  Vladimir Makarov  <vmakarov@redhat.com>
      
      	PR rtl-optimization/80818
      	* lra.c (collect_non_operand_hard_regs): New arg insn.  Pass it
      	recursively.  Use insn code for clobber.
      	(lra_set_insn_recog_data): Pass the new arg to
      	collect_non_operand_hard_regs.
      	(add_regs_to_insn_regno_info): Pass insn instead of uid.  Use insn
      	code for clobber.
      	(lra_update_insn_regno_info): Pass insn to
      	add_regs_to_insn_regno_info.
      
      From-SVN: r255258
      Vladimir Makarov committed
    • Riscv patterns to optimize away some redundant zero/sign extends. · 08539f3e
      	gcc/
      	* config/riscv/riscv.c (SINGLE_SHIFT_COST): New.
      	(riscv_rtx_costs): Case ZERO_EXTRACT, match new pattern, and return
      	SINGLE_SHIFT_COST.  Case LT and ZERO_EXTEND, likewise.  Case ASHIFT,
      	use SINGLE_SHIFT_COST.
      	* config/riscv/riscv.md (lshrsi3_zero_extend_1): New.
      	(lshrsi3_zero_extend_2, lshrsi3_zero_extend_3): New.
      
      	gcc/testsuite/
      	* gcc.target/riscv/riscv.exp: New.
      	* gcc.target/riscv/zero-extend-1.c: New.
      	* gcc.target/riscv/zero-extend-2.c: New.
      	* gcc.target/riscv/zero-extend-3.c: New.
      	* gcc.target/riscv/zero-extend-4.c: New.
      
      
      Co-Authored-By: Andrew Waterman <andrew@sifive.com>
      
      From-SVN: r255257
      Jim Wilson committed
    • C++: improve location of static_assert errors · 591996ba
      gcc/cp/ChangeLog:
      	* parser.c (cp_parser_unary_expression): Generate a location for
      	"noexcept".
      	(cp_parser_trait_expr): Generate and return a location_t,
      	converting the return type from tree to cp_expr.
      	(cp_parser_static_assert): Pass location of the condition to
      	finish_static_assert, rather than that of the "static_assert"
      	token, where available.
      
      gcc/testsuite/ChangeLog:
      	* g++.dg/cpp1y/static_assert3.C: New test case.
      
      libstdc++-v3/ChangeLog:
      	* testsuite/20_util/duration/literals/range.cc: Update expected
      	line of a static_assert failure.
      
      From-SVN: r255255
      David Malcolm committed
    • re PR c++/82293 (ICE in nonlambda_method_basetype at gcc/cp/lambda.c:886) · cc6fe784
      /cp
      2017-11-29  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	PR c++/82293
      	* lambda.c (nonlambda_method_basetype): Don't use LAMBDA_TYPE_P
      	on a null type.
      
      /testsuite
      2017-11-29  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	PR c++/82293
      	* g++.dg/cpp0x/lambda/lambda-ice24.C: New.
      
      From-SVN: r255254
      Paolo Carlini committed
    • PR c++/82760 - memory corruption with aligned new. · e3704417
      	* call.c (build_operator_new_call): Update *args if we add the
      	align_arg.
      
      From-SVN: r255253
      Jason Merrill committed
    • fold-vec-ld-char.c: Add lxv insn to expected output. · edaa6eb5
      [testsuite]
      
      2017-11-29  Will Schmidt  <will_schmidt@vnet.ibm.com>
      
          * gcc.target/powerpc/fold-vec-ld-char.c: Add lxv insn to expected output.
          * gcc.target/powerpc/fold-vec-ld-double.c: Add lxv insn to expected output.
          * gcc.target/powerpc/fold-vec-ld-float.c: Add lxv insn to expected output.
          * gcc.target/powerpc/fold-vec-ld-int.c: Add lxv insn to expected output.
          * gcc.target/powerpc/fold-vec-ld-longlong.c: Add lxv insn to expected output.
          * gcc.target/powerpc/fold-vec-ld-short.c: Add lxv insn to expected output.
      
      From-SVN: r255252
      Will Schmidt committed
    • fold-vec-splat-8.c: Add vspltisb to expected output. · faf08cc7
      [testsuite]
      2017-11-29  Will Schmidt  <will_schmidt@vnet.ibm.com>
      
          * gcc.target/powerpc/fold-vec-splat-8.c: Add vspltisb to expected output.
          * gcc.target/powerpc/fold-vec-splats-int.c: Add mtvsrws to expected output.
          * gcc.target/powerpc/fold-vec-splats-longlong.c: Add mtvsrdd to expected output.
      
      From-SVN: r255251
      Will Schmidt committed
    • nable VBMI2 support [7/7] · 3d2aff3d
      gcc/
      	* config/i386/avx512vbmi2intrin.h (_mm512_shldv_epi16,
      	_mm512_mask_shldv_epi16, _mm512_maskz_shldv_epi16, _mm512_shldv_epi32,
      	_mm512_mask_shldv_epi32, _mm512_maskz_shldv_epi32, _mm512_shldv_epi64,
      	_mm512_mask_shldv_epi64, _mm512_maskz_shldv_epi64): New intrinsics.
      	* config/i386/avx512vbmi2vlintrin.h (_mm256_shldv_epi16,
      	_mm256_mask_shldv_epi16, _mm256_maskz_shldv_epi16, _mm256_shldv_epi32,
      	_mm256_mask_shldv_epi32, _mm256_maskz_shldv_epi32, _mm256_shldv_epi64,
      	_mm256_mask_shldv_epi64, _mm256_maskz_shldv_epi64, _mm_shldv_epi16,
      	_mm_mask_shldv_epi16, _mm_maskz_shldv_epi16, _mm_shldv_epi32,
      	_mm_mask_shldv_epi32, _mm_maskz_shldv_epi32, _mm_shldv_epi64,
      	_mm_mask_shldv_epi64, _mm_maskz_shldv_epi64): Ditto.
      	* config/i386/i386-builtin.def (__builtin_ia32_vpshldv_v32hi,
      	__builtin_ia32_vpshldv_v32hi_mask, __builtin_ia32_vpshldv_v32hi_maskz,
      	__builtin_ia32_vpshldv_v16hi, __builtin_ia32_vpshldv_v16hi_mask,
      	__builtin_ia32_vpshldv_v16hi_maskz, __builtin_ia32_vpshldv_v8hi,
      	__builtin_ia32_vpshldv_v8hi_mask, __builtin_ia32_vpshldv_v8hi_maskz,
      	__builtin_ia32_vpshldv_v16si, __builtin_ia32_vpshldv_v16si_mask,
      	__builtin_ia32_vpshldv_v16si_maskz, __builtin_ia32_vpshldv_v8si,
      	__builtin_ia32_vpshldv_v8si_mask, __builtin_ia32_vpshldv_v8si_maskz,
      	__builtin_ia32_vpshldv_v4si, __builtin_ia32_vpshldv_v4si_mask,
      	__builtin_ia32_vpshldv_v4si_maskz, __builtin_ia32_vpshldv_v8di,
      	__builtin_ia32_vpshldv_v8di_mask, __builtin_ia32_vpshldv_v8di_maskz,
      	__builtin_ia32_vpshldv_v4di, __builtin_ia32_vpshldv_v4di_mask,
      	__builtin_ia32_vpshldv_v4di_maskz, __builtin_ia32_vpshldv_v2di,
      	__builtin_ia32_vpshldv_v2di_mask,
      	__builtin_ia32_vpshldv_v2di_maskz): New builtins.
      	* config/i386/sse.md (vpshldv_<mode>, vpshldv_<mode>_mask,
      	vpshldv_<mode>_maskz, vpshldv_<mode>_maskz_1): New patterns.
      
      gcc/testsuite/
      	* gcc.target/i386/avx512f-vpshldv-1.c: New test.
      	* gcc.target/i386/avx512f-vpshldvd-2.c: Ditto.
      	* gcc.target/i386/avx512f-vpshldvq-2.c: Ditto.
      	* gcc.target/i386/avx512f-vpshldvw-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshldv-1.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshldvd-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshldvq-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshldvw-2.c: Ditto.
      
      From-SVN: r255250
      Julia Koval committed
    • Enable VBMI2 support [6/7] · 8d4f237b
      gcc/
      	* config/i386/avx512vbmi2intrin.h (_mm512_shrdv_epi16,
      	_mm512_mask_shrdv_epi16, _mm512_maskz_shrdv_epi16, _mm512_shrdv_epi32,
      	_mm512_mask_shrdv_epi32, _mm512_maskz_shrdv_epi32, _mm512_shrdv_epi64,
      	_mm512_mask_shrdv_epi64, _mm512_maskz_shrdv_epi64): New intrinsics.
      	* config/i386/avx512vbmi2vlintrin.h (_mm256_shrdv_epi16,
      	_mm256_mask_shrdv_epi16, _mm256_maskz_shrdv_epi16, _mm256_shrdv_epi32,
      	_mm256_mask_shrdv_epi32, _mm256_maskz_shrdv_epi32, _mm256_shrdv_epi64,
      	_mm256_mask_shrdv_epi64, _mm256_maskz_shrdv_epi64, _mm_shrdv_epi16,
      	_mm_mask_shrdv_epi16, _mm_maskz_shrdv_epi16, _mm_shrdv_epi32,
      	_mm_mask_shrdv_epi32, _mm_maskz_shrdv_epi32, _mm_shrdv_epi64,
      	_mm_mask_shrdv_epi64, _mm_maskz_shrdv_epi64): Ditto.
      	* config/i386/i386-builtin-types.def (V32HI_FTYPE_V32HI_V32HI_V32HI,
      	V32HI_FTYPE_V32HI_V32HI_V32HI_INT, V16HI_FTYPE_V16HI_V16HI_V16HI_INT,
      	V8HI_FTYPE_V8HI_V8HI_V8HI_INT, V8SI_FTYPE_V8SI_V8SI_V8SI_INT,
      	V4SI_FTYPE_V4SI_V4SI_V4SI_INT, V8DI_FTYPE_V8DI_V8DI_V8DI,
      	V8DI_FTYPE_V8DI_V8DI_V8DI_INT, V4DI_FTYPE_V4DI_V4DI_V4DI_INT,
      	V16SI_FTYPE_V16SI_V16SI_V16SI, V16SI_FTYPE_V16SI_V16SI_V16SI_INT,
      	V2DI_FTYPE_V2DI_V2DI_V2DI_INT): New types.
      	* config/i386/i386.c (ix86_expand_args_builtin): Handle new types.
      	* config/i386/sse.md (vpshrdv_<mode>, vpshrdv_<mode>_mask,
      	vpshrdv_<mode>_maskz, vpshrdv_<mode>_maskz_1): New pattern.
      
      gcc/testsuite/
      	* gcc.target/i386/avx512f-vpshrdv-1.c: New test.
      	* gcc.target/i386/avx512f-vpshrdvd-2.c: Ditto.
      	* gcc.target/i386/avx512f-vpshrdvq-2.c: Ditto.
      	* gcc.target/i386/avx512f-vpshrdvw-2.c: Ditto.
      	* gcc.target/i386/avx512f-vpshrdw-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshrdv-1.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshrdvd-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshrdvq-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshrdvw-2.c: Ditto.
      	* gcc.target/i386/avx512vl-vpshrdw-2.c: Ditto.
      
      From-SVN: r255249
      Julia Koval committed
    • Add myself as GCC maintainer · 1d0a8ae9
      From-SVN: r255248
      Qing Zhao committed
    • re PR tree-optimization/83195 (pr82929.c scan for "Merging successful" fail) · 8746a215
      	PR tree-optimization/83195
      	* gcc.dg/pr82929.c: Don't check for "Merging successful" on arm.
      	* gcc.dg/pr82929-2.c: New test.
      
      From-SVN: r255247
      Jakub Jelinek committed
    • [SPARC] Recognize the load when accessing the GOT · 9d52da2f
      Needed for the UT699 errata workaround to function correctly when
      compiling with -fPIC.
      
      2017-11-29  Daniel Cederman  <cederman@gaisler.com>
      
      gcc/
      	* config/sparc/sparc.c (sparc_do_work_around_errata): Treat the
              movsi_pic_gotdata_op instruction as a load for the UT699 errata
              workaround.
      
      From-SVN: r255239
      Daniel Cederman committed
    • [SPARC] Prevent -mfix-ut699 from generating b2bst errata sequences · 6f9bc5a7
      The sequence
        st
        fdivd / fsqrtd
        std
      was generated in some cases with -mfix-ut699 when there was
      a st before the div/sqrt. This sequence could trigger the b2bst errata.
      
      Now the following safe sequence is generated instead:
        st
        nop
        fdivd / fsqrtd
        std
      
      2017-11-29  Martin Aberg  <maberg@gaisler.com>
      
      gcc/
      	* config/sparc/sparc.md (divdf3_fix): Add NOP and adjust length
              to prevent b2bst errata sequence.
              (sqrtdf2_fix): Likewise.
      
      From-SVN: r255238
      Martin Aberg committed
    • [SPARC] Errata workaround for GRLIB-TN-0013 · 97c30075
      This patch provides a workaround for the errata described in GRLIB-TN-0013.
      
      If the workaround is enabled it will:
      
      * Prevent div and sqrt instructions in the delay slot.
      
      * Insert NOPs to prevent the sequence (div/sqrt) -> (two or three floating
        point operations or loads) -> (div/sqrt).
      
      * Not insert NOPs if any of the floating point operations have a dependency
        on the destination register of the first (div/sqrt).
      
      * Not insert NOPs if one of the floating point operations is a (div/sqrt).
      
      * Insert NOPs to prevent (div/sqrt) followed by a branch.
      
      It is applicable to GR712RC, UT700, and UT699.
      
      2017-11-29  Daniel Cederman  <cederman@gaisler.com>
      
      gcc/
      	* config/sparc/sparc.c (fpop_reg_depend_p): New function.
      	(div_sqrt_insn_p): New function.
      	(sparc_do_work_around_errata): Insert NOP instructions to
      	prevent sequences that could trigger the TN-0013 errata for
      	certain LEON3 processors.
      	(pass_work_around_errata::gate): Also test sparc_fix_lost_divsqrt.
      	(sparc_option_override): Set sparc_fix_lost_divsqrt appropriately.
      	* config/sparc/sparc.md (fix_lost_divsqrt): New attribute.
      	(in_branch_delay): Prevent div and sqrt in delay slot if
      	fix_lost_divsqrt.
      	* config/sparc/sparc.opt (sparc_fix_lost_divsqrt): New variable.
      
      From-SVN: r255237
      Daniel Cederman committed
    • [SPARC] Errata workaround for GRLIB-TN-0010 · 47c72733
      This patch provides a workaround for the errata described in GRLIB-TN-0010.
      
      If the workaround is enabled it will:
      
       * Insert a NOP between load instruction and atomic
         instruction (swap, ldstub, casa).
      
       * Insert a NOP at branch target if load in delay slot
         and atomic instruction at branch target.
      
      It is applicable to UT700.
      
      2017-11-29  Daniel Cederman  <cederman@gaisler.com>
      
      gcc/
      	* config/sparc/sparc.c (atomic_insn_p): New function.
      	(sparc_do_work_around_errata): Insert NOP instructions to
      	prevent sequences that could trigger the TN-0010 errata for
      	UT700.
      	* config/sparc/sync.md (atomic_compare_and_swap_leon3_1): Make
      	instruction referable in atomic_insns_p.
      
      From-SVN: r255236
      Daniel Cederman committed
    • [SPARC] Errata workaround for GRLIB-TN-0011 · aed17373
      This patch provides a workaround for the errata described in GRLIB-TN-0011.
      
      If the workaround is enabled it will:
      
       * Insert .align 16 before atomic instructions (swap, ldstub, casa).
      
      It is applicable to GR712RC.
      
      2017-11-29  Daniel Cederman  <cederman@gaisler.com>
      
      gcc/
      	* config/sparc/sync.md (swapsi): 16-byte align if sparc_fix_gr712rc.
      	(atomic_compare_and_swap_leon3_1): Likewise.
      	(ldstub): Likewise.
      
      From-SVN: r255235
      Daniel Cederman committed
    • [SPARC] Errata workaround for GRLIB-TN-0012 · dcacda0c
      This patch provides a workaround for the errata described in GRLIB-TN-0012.
      
      If the workaround is enabled it will:
      
       * Prevent any floating-point operation from being placed in the
         delay slot of an annulled integer branch.
      
       * Place a NOP at the branch target of an integer branch if it is
         a floating-point operation or a floating-point branch.
      
      It is applicable to GR712RC.
      
      2017-11-29  Daniel Cederman  <cederman@gaisler.com>
      
      gcc/
      	* config/sparc/sparc.c (fpop_insn_p): New function.
      	(sparc_do_work_around_errata): Insert NOP instructions to
      	prevent sequences that could trigger the TN-0012 errata for
      	GR712RC.
      	(pass_work_around_errata::gate): Also test sparc_fix_gr712rc.
      	* config/sparc/sparc.md (fix_gr712rc): New attribute.
      	(in_branch_annul_delay): Prevent floating-point instructions
      	in delay slot of annulled integer branch.
      
      From-SVN: r255234
      Daniel Cederman committed
    • re PR tree-optimization/83202 (Try joining operations on consecutive array… · f7300fff
      re PR tree-optimization/83202 (Try joining operations on consecutive array elements during tree vectorization)
      
      2017-11-29  Richard Biener  <rguenther@suse.de>
      
      	PR tree-optimization/83202
      	* tree-vect-slp.c (scalar_stmts_set_t): New typedef.
      	(bst_fail): Use it.
      	(vect_analyze_slp_cost_1): Add visited set, do not account SLP
      	nodes vectorized to the same stmts multiple times.
      	(vect_analyze_slp_cost): Allocate a visited set and pass it down.
      	(vect_analyze_slp_instance): Adjust.
      	(scalar_stmts_to_slp_tree_map_t): New typedef.
      	(vect_schedule_slp_instance): Add a map recording the SLP node
      	representing the vectorized stmts for a set of scalar stmts.
      	Avoid code-generating redundancies.
      	(vect_schedule_slp): Allocate map and pass it down.
      
      	* gcc.dg/vect/costmodel/x86_64/costmodel-pr83202.c: New testcase.
      
      From-SVN: r255233
      Richard Biener committed
    • Fix PR number 83817->83187 · d5ed6a87
      From-SVN: r255232
      Nathan Sidwell committed
    • [PATCH] complex type canonicalization · b7f592fc
      
      https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02453.html
      	PR c++/83817
      	* tree.c (build_complex_type): Fix canonicalization.  Only fill in
      	type if it is new.
      
      	PR c++/83187
      	* g++.dg/opt/pr83187.C: New.
      
      From-SVN: r255231
      Nathan Sidwell committed
    • [AArch64] Fix ICE due to store_pair_lanes · e69a816d
      The recently added store_pair_lanes causes ICEs in output_operand.
      This is due to aarch64_classify_address treating it like a 128-bit STR
      rather than a STP.  The valid immediate offsets don't fully overlap,
      causing it to return false.  Eg. offset 264 is a valid 8-byte STP offset
      but not a valid 16-byte STR offset since it isn't a multiple of 16.
      
      The original instruction isn't passed in the printing code, so the context
      is unclear.  The solution is to add a new operand formatting specifier
      which is used for LDP/STP instructions like this.  This, like the Uml
      constraint that applies to store_pair_lanes, uses PARALLEL when calling
      aarch64_classify_address so that it knows it is an STP.
      Also add the 'z' specifier for future use by load/store pair instructions.
      
          gcc/
      	* config/aarch64/aarch64.c (aarch64_print_operand): Add new
      	cases for printing LDP/STP memory addresses.
      	(aarch64_print_address_internal): Renamed from
      	aarch64_print_operand_address, added parameter, add Pmode check.
      	(aarch64_print_ldpstp_address): New function for LDP/STP addresses.
      	(aarch64_print_operand_address): Indirect to
      	aarch64_print_address_internal.
      	* config/aarch64/aarch64-simd.md (store_pair_lanes): Use new
      	'y' operand output specifier.
      
      From-SVN: r255230
      Wilco Dijkstra committed
    • re PR middle-end/83185 (ICE with -fsanitize=address in build_simple_mem_ref_loc, at tree.c:4696) · 65d5e454
      	PR middle-end/83185
      	* tree.c (build_simple_mem_ref_loc): Handle
      	get_addr_base_and_unit_offset returning a MEM_REF.
      
      	* gcc.dg/asan/pr83185.c: New test.
      
      From-SVN: r255229
      Jakub Jelinek committed
    • re PR middle-end/80929 (Division with constant no more optimized to mult highpart) · cedd8ca5
      	PR middle-end/80929
      	* rtlanal.c (seq_cost): For non-single_set insns try to use insn_cost.
      
      From-SVN: r255228
      Jakub Jelinek committed
    • fix merge conflict in libgfortran/ChangeLog · 88011878
      From-SVN: r255227
      Janne Blomqvist committed
    • re PR target/80819 (Useless store to the stack in _mm_set_epi64x with SSE4 -mno-avx) · 4c42d640
      	PR target/80819
      	* config/i386/sse.md (vec_concatv2di): Remove * from (=Yr,0,*rm)
      	alternative.
      
      	* gcc.target/i386/pr80819-1.c: New test.
      	* gcc.target/i386/pr80819-2.c: New test.
      
      From-SVN: r255226
      Jakub Jelinek committed
    • re PR libfortran/83168 (FAIL: gfortran.dg/fmt_f0_2.f90 with a sanitized libgfortran) · b7c44c8f
      2017-11-28  Jerry DeLisle  <jvdelisle@gcc.gnu.org>
      
      	PR libgfortran/83168
      	* io/write.c (select_string): Bump size by one to avoid
      	overrun.
      
      From-SVN: r255225
      Jerry DeLisle committed
    • Daily bump. · db147565
      From-SVN: r255224
      GCC Administrator committed
  3. 28 Nov, 2017 7 commits
    • Fix some incorrectly formatted ChangeLog entries. · 5ded3aec
      From-SVN: r255220
      Jim Wilson committed
    • Handle very long lines when printing fix-it hints · 64ea27f0
      When fixing PR c/82050 I noticed a bug in how we print fix-it hints
      for very long lines: we weren't taking into account the x-offset for
      the line when printing the fix-it hint.
      
      This could lead to output where instead of printing:
      
      foo.c:14:3944: error: etc
        = foo.field
              ^~~~~
              replacement
      
      where the lines have been offset to start printing at about column 3900,
      the "replacement" line was erroneously *not* offset, and was thus
      prefixed by thousands of spaces, leading to large whitespace gaps in
      the output, and the replacement failing to line up with the source to be
      replaced.
      
      Fixed thusly.
      
      gcc/ChangeLog:
      	* diagnostic-show-locus.c (layout::print_trailing_fixits): Handle
      	m_x_offset.
      	(layout::move_to_column): Likewise.
      
      gcc/testsuite/ChangeLog:
      	* gcc.dg/plugin/diagnostic-test-show-locus-bw.c
      	(test_very_wide_line): Update expected output to include a
      	fix-it hint.
      	* gcc.dg/plugin/diagnostic-test-show-locus-color.c
      	(test_very_wide_line): Likewise.
      	* gcc.dg/plugin/diagnostic_plugin_test_show_locus.c
      	(test_show_locus): Add a fix-it hint to "test_very_wide_line".
      
      From-SVN: r255219
      David Malcolm committed
    • re PR sanitizer/81275 (-fsanitize=thread produce incorrect -Wreturn-type warning) · 1a2e9708
      	PR sanitizer/81275
      	* cp-tree.h (SWITCH_STMT_ALL_CASES_P): Define.
      	(SWITCH_STMT_NO_BREAK_P): Define.
      	(note_break_stmt, note_iteration_stmt_body_start,
      	note_iteration_stmt_body_end): Declare.
      	* decl.c (struct cp_switch): Add has_default_p, break_stmt_seen_p
      	and in_loop_body_p fields. 
      	(push_switch): Clear them.
      	(pop_switch): Set SWITCH_STMT_CANNOT_FALLTHRU_P if has_default_p
      	and !break_stmt_seen_p.  Assert in_loop_body_p is false.
      	(note_break_stmt, note_iteration_stmt_body_start,
      	note_iteration_stmt_body_end): New functions.
      	(finish_case_label): Set has_default_p when both low and high
      	are NULL_TREE.
      	* parser.c (cp_parser_iteration_statement): Use
      	note_iteration_stmt_body_start and note_iteration_stmt_body_end
      	around parsing iteration body.
      	* pt.c (tsubst_expr): Likewise.
      	* cp-objcp-common.c (cxx_block_may_fallthru): Return false for
      	SWITCH_STMT which contains no BREAK_STMTs, contains a default:
      	CASE_LABEL_EXPR and where SWITCH_STMT_BODY isn't empty and
      	can't fallthru.
      	* semantics.c (finish_break_stmt): Call note_break_stmt.
      	* cp-gimplify.c (genericize_switch_stmt): Copy SWITCH_STMT_ALL_CASES_P
      	bit to SWITCH_ALL_CASES_P.  Assert that if SWITCH_STMT_NO_BREAK_P then
      	the break label is not TREE_USED.
      
      	* g++.dg/warn/pr81275-1.C: New test.
      	* g++.dg/warn/pr81275-2.C: New test.
      	* g++.dg/warn/pr81275-3.C: New test.
      	* c-c++-common/tsan/pr81275.c: Skip for C++ and -O2.
      
      From-SVN: r255218
      Jakub Jelinek committed
    • re PR sanitizer/81275 (-fsanitize=thread produce incorrect -Wreturn-type warning) · 058f0b9e
      	PR sanitizer/81275
      	* tree.c (block_may_fallthru): Return false if SWITCH_ALL_CASES_P
      	is set on SWITCH_EXPR and !block_may_fallthru (SWITCH_BODY ()).
      c/
      	* c-typeck.c (c_finish_case): Set SWITCH_ALL_CASES_P if
      	c_switch_covers_all_cases_p returns true.
      c-family/
      	* c-common.c (c_switch_covers_all_cases_p_1,
      	c_switch_covers_all_cases_p): New functions.
      	* c-common.h (c_switch_covers_all_cases_p): Declare.
      testsuite/
      	* c-c++-common/tsan/pr81275.c: New test.
      
      From-SVN: r255217
      Jakub Jelinek committed
    • PR 53796 Improve INQUIRE(RECL=...) handling · 67c24a8b
      The current F2018 draft (N2137) specifies behavior of the RECL=
      specifier in the INQUIRE statement, where it previously was left as
      undefined. Namely:
      
      - If the unit is not connected, RECL= should be given the value -1.
      - If the unit is connected with stream access, RECL= should be given
        the value -2.
      
      Further, as PR 53796 describes, the handling of RECL= is poor in other
      ways as well. When the recl is set to the maximum possible
      (GFC_INTEGER_8_HUGE / LLONG_MAX), which it does by default except for
      preconnected units, and when INQUIRE(RECL=) is used with a 4 byte
      integer, the value is truncated and the 4 byte value is thus
      -1. Fixing this to generate an error is a lot of work, as currently
      the truncation is done by the frontend, the library sees only an 8
      byte value with no indication that the frontend is going to copy it to
      a 4 byte one. Instead, this patch does a bit twiddling trick such that
      the truncated 4 byte value is GFC_INTEGER_4_HUGE while still being
      0.99999999 * GFC_INTEGER_8_HUGE which is large enough for all
      practical purposes.
      
      Finally, the patch removes GFORTRAN_DEFAULT_RECL which was used only
      for preconnected units, and instead uses the same approach as describe
      above.
      
      Regtested on x86_64-pc-linux-gnu, Ok for trunk.
      
      gcc/fortran/ChangeLog:
      
      2017-11-28  Janne Blomqvist  <jb@gcc.gnu.org>
      
      	PR fortran/53796
      	* gfortran.texi: Remove mentions of GFORTRAN_DEFAULT_RECL.
      
      libgfortran/ChangeLog:
      
      2017-11-28  Janne Blomqvist  <jb@gcc.gnu.org>
      
      	PR fortran/53796
      	* io/inquire.c (inquire_via_unit): Set recl to -1 for unconnected
      	units.
      	* io/io.h (default_recl): New variable.
      	* io/open.c (new_unit): Set recl to default_recl for sequential,
      	-2 for stream access.
      	* io/transfer.c (read_block_form): Test against default_recl
      	instead of DEFAULT_RECL.
      	(write_block): Likewise.
      	* io/unit.c (init_units): Calculate max_offset, default_recl.
      	* libgfortran.h (DEFAULT_RECL): Remove.
      	* runtime/environ.c: Remove GFORTRAN_DEFAULT_RECL.
      
      gcc/testsuite/ChangeLog:
      
      2017-11-28  Janne Blomqvist  <jb@gcc.gnu.org>
      
      	PR fortran/53796
      	* gfortran.dg/inquire_recl_f2018.f90: New test.
      
      From-SVN: r255215
      Janne Blomqvist committed
    • Reject fix-it hints for various awkward boundary cases (PR c/82050) · 6df8934f
      PR c/82050 reports a failed assertion deep within diagnostic_show_locus's
      code for printing fix-it hints.
      
      The root cause is a fix-it hint suggesting a textual replacement,
      where the affected column numbers straddle the LINE_MAP_MAX_COLUMN_NUMBER
      boundary, so that the start of the range has a column number, but the
      end of the range doesn't.
      
      The fix is to verify that the column numbers are sane when adding fix-it
      hints to a rich_location, rejecting fix-it hints where they are not.
      
      libcpp/ChangeLog:
      	PR c/82050
      	* include/line-map.h (LINE_MAP_MAX_COLUMN_NUMBER): Move here.
      	* line-map.c (LINE_MAP_MAX_COLUMN_NUMBER): ...from here.
      	(rich_location::maybe_add_fixit): Reject fix-it hints in which
      	the start column exceeds the next column.
      
      From-SVN: r255214
      David Malcolm committed
    • [PR 82808] Use proper result types for arithmetic jump functions · e5cf5e11
      2017-11-28  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>
      	    Martin Jambor  <mjambor@suse.cz>
      
      	PR ipa/82808
      	* tree.h (expr_type_first_operand_type_p): Declare
      	* tree.c (expr_type_first_operand_type_p): New function.
      	* ipa-prop.h (ipa_get_type): Allow i to be out of bounds.
      	(ipa_value_from_jfunc): Adjust declaration.
      	* ipa-cp.c (ipa_get_jf_pass_through_result): New parameter RES_TYPE.
      	Use it as result type for arithmetics, unless it is NULL in which case
      	be more conservative.
      	(ipa_value_from_jfunc): New parameter PARM_TYPE, pass it to
      	ipa_get_jf_pass_through_result.
      	(propagate_vals_across_pass_through): Likewise.
      	(propagate_scalar_across_jump_function): New parameter PARM_TYPE, pass
      	is to propagate_vals_across_pass_through.
      	(propagate_constants_across_call): Pass PARM_TYPE to
      	propagate_scalar_across_jump_function.
      	(find_more_scalar_values_for_callers_subset): Pass parameter type to
      	ipa_value_from_jfunc.
      	(cgraph_edge_brings_all_scalars_for_node): Likewise.
      	* ipa-fnsummary.c (evaluate_properties_for_edge): Renamed parms_info
      	to caller_parms_info, pass parameter type to ipa_value_from_jfunc.
      	* ipa-prop.c (try_make_edge_direct_simple_call): New parameter
      	target_type, pass it to ipa_value_from_jfunc.
      	(update_indirect_edges_after_inlining): Pass parameter type to
      	try_make_edge_direct_simple_call.
      
      testsuite/
      	* gcc.dg/ipa/pr82808.c: New test.
      
      
      Co-Authored-By: Martin Jambor <mjambor@suse.cz>
      
      From-SVN: r255212
      Prathamesh Kulkarni committed