1. 24 Nov, 2019 1 commit
    • test: add an azure repos test · 0005c77a
      We currently talk to Azure Repos for executing an online test
      (online::clone::path_whitespace).  Add a simpler test to talk to Azure
      Repos to make it obvious that strange test failures are not likely the
      whitespace in the path, but actually a function of talking to Azure
      Repos itself.
      Edward Thomson committed
  2. 13 Aug, 2019 1 commit
  3. 12 Aug, 2019 1 commit
  4. 25 Jul, 2019 1 commit
  5. 24 Jul, 2019 1 commit
  6. 20 Jul, 2019 1 commit
  7. 24 Jun, 2019 1 commit
  8. 10 Jun, 2019 2 commits
    • winhttp: support default credentials for proxies · 3d11b6c5
      We did not properly support default credentials for proxies, only for
      destination servers.  Refactor the credential handling to support sending
      either username/password _or_ default credentials to either the proxy or
      the destination server.
      
      This actually shares the authentication logic between proxy servers and
      destination servers.  Due to copy/pasta drift over time, they had
      diverged.  Now they share a common logic which is: first, use
      credentials specified in the URL (if there were any), treating empty
      username and password (ie, "http://:@foo.com/") as default credentials,
      for compatibility with git.  Next, call the credential callbacks.
      Finally, fallback to WinHTTP compatibility layers using built-in
      authentication like we always have.
      
      Allowing default credentials for proxies requires moving the security
      level downgrade into the credential setting routines themselves.
      We will update our security level to "high" by default which means that
      we will never send default credentials without prompting.  (A lower
      setting, like the WinHTTP default of "medium" would allow WinHTTP to
      handle credentials for us, despite what a user may have requested with
      their structures.)  Now we start with "high" and downgrade to "low" only
      after a user has explicitly requested default credentials.
      Edward Thomson committed
    • network: don't add arbitrary url rules · 757411a0
      There's no reason a git repository couldn't be at the root of a server,
      and URLs should have an implicit path of '/' when one is not specified.
      Edward Thomson committed
  9. 05 Jun, 2019 1 commit
    • online tests: use gitlab for auth failures · e66a4eb3
      GitHub recently changed their behavior from returning 401s for private
      or nonexistent repositories on a clone to returning 404s.  For our tests
      that require an auth failure (and 401), move to GitLab to request a
      missing repository.  This lets us continue to test our auth failure
      case, at least until they decide to mimic that decision.
      Edward Thomson committed
  10. 21 May, 2019 1 commit
  11. 22 Feb, 2019 1 commit
  12. 22 Jan, 2019 1 commit
  13. 17 Jan, 2019 1 commit
  14. 14 Jan, 2019 1 commit
  15. 28 Nov, 2018 5 commits
  16. 22 Sep, 2018 1 commit
  17. 20 Jul, 2018 2 commits
  18. 10 Jun, 2018 1 commit
  19. 20 Mar, 2018 1 commit
  20. 19 Mar, 2018 1 commit
    • online::clone: skip creds fallback test · 03c58778
      At present, we have three online tests against bitbucket: one which
      specifies the credentials in the payload, one which specifies the
      correct credentials in the URL and a final one that specifies the
      incorrect credentials in the URL.  Bitbucket has begun responding to the
      latter test with a 403, which causes us to fail.
      
      Break these three tests into separate tests so that we can skip the
      latter until this is resolved on Bitbucket's end or until we can change
      the test to a different provider.
      Edward Thomson committed
  21. 28 Feb, 2018 1 commit
  22. 18 Jan, 2018 1 commit
  23. 03 Jan, 2018 2 commits
    • tests: online::clone: inline creds-test with nonexistent URL · 54a1bf05
      Right now, we test our credential callback code twice, once via SSH on
      localhost and once via a non-existent GitHub repository. While the first
      URL makes sense to be configurable, it does not make sense to hard-code
      the non-existing repository, which requires us to call tests multiple
      times. Instead, we can just inline the URL into another set of tests.
      Patrick Steinhardt committed
    • tests: online::clone: construct credential-URL from environment · fea60920
      We support two types of passing credentials to the proxy, either via the
      URL or explicitly by specifying user and password. We test these types
      by modifying the proxy URL and executing the tests twice, which is
      in fact unnecessary and requires us to maintain the list of environment
      variables and test executions across multiple CI infrastructures.
      
      To fix the situation, we can just always pass the host, port, user and
      password to the tests. The tests can then assemble the complete URL
      either with or without included credentials, allowing us to test both
      cases in-process.
      Patrick Steinhardt committed
  24. 21 Jun, 2017 1 commit
  25. 05 May, 2017 3 commits
  26. 25 Apr, 2017 1 commit
  27. 09 Jan, 2017 2 commits
  28. 06 Jan, 2017 1 commit
  29. 27 Oct, 2016 1 commit
  30. 04 Aug, 2016 1 commit
    • refspec: do not set empty rhs for fetch refspecs · 1eee631d
      According to git-fetch(1), "[t]he colon can be omitted when <dst>
      is empty." So according to git, the refspec "refs/heads/master"
      is the same as the refspec "refs/heads/master:" when fetching
      changes. When trying to fetch from a remote with a trailing
      colon with libgit2, though, the fetch actually fails while it
      works when the trailing colon is left out. So obviously, libgit2
      does _not_ treat these two refspec formats the same for fetches.
      
      The problem results from parsing refspecs, where the resulting
      refspec has its destination set to an empty string in the case of
      a trailing colon and to a `NULL` pointer in the case of no
      trailing colon. When passing this to our DWIM machinery, the
      empty string gets translated to "refs/heads/", which is simply
      wrong.
      
      Fix the problem by having the parsing machinery treat both cases
      the same for fetch refspecs.
      Patrick Steinhardt committed