- 31 Oct, 2016 1 commit
-
-
When running a Coverity build, we have to provide an authentication token in order to proof that we are actually allowed to run analysis in the name of a certain project. As this token should be secret, it is only set on the main repository, so when we were requested to run the Coverity script on another repository we do error out. But in fact we do also error out if the Coverity analysis should _not_ be run if there is no authentication token provided. Fix the issue by only checking for the authentication token after determining if analysis is indeed requested.
Patrick Steinhardt committed
-
- 28 Oct, 2016 2 commits
-
-
We used to only execute Coverity analysis on the 'development' branch before commit 998f0016 (Refine build limitation, 2014-01-15), which refined Coverity build limitations. While we do not really use the 'development' branch anymore, it does still make sense to only analyze a single branch, as otherwise Coverity might get confused. Re-establish the restriction such that we only analyze libgit2's 'master' branch. Also fix the message announcing why we do not actually analyze a certain build.
Patrick Steinhardt committed -
Patrick Steinhardt committed
-
- 10 Oct, 2016 1 commit
-
-
Patrick Steinhardt committed
-
- 05 Oct, 2016 2 commits
-
-
The Mac machines have updated their SSH version and so the ssh-keygen format has changed. Ask it for MD5, which is the one that is output as hex.
Carlos Martín Nieto committed -
This lets us see the details of what we're doing instead of just seeing the output of unknown commands in the build output.
Carlos Martín Nieto committed
-
- 24 Jul, 2016 1 commit
-
-
Edward Thomson committed
-
- 23 Jul, 2016 1 commit
-
-
Edward Thomson committed
-
- 07 Jun, 2016 2 commits
-
-
The `git_buf` structure seems to be too complicated to correctly grasp for Coverity. As such, add simpler models trying to guide Coverity and remove false positives related to these functions.
Patrick Steinhardt committed -
The static analysis engine coverity allows for user models overriding how it treats functions when analyzing code. Like this, one can greatly reduce the rate of false positives and thus make it easier to spot actual errors. Add a user model that overrides function models for `git_buf_len` and `git_vector_insert`, which together amount for a majority of false positives.
Patrick Steinhardt committed
-
- 19 Apr, 2016 2 commits
-
-
It takes a bit for the propxy to get ready to accept connections, so start it before the build so we can be reasonably sure that it's going to be ready in time.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
- 14 Mar, 2016 1 commit
-
-
The tests have never run successfully and we do have successful builds of mingw-w64, so remove these CI builds which do not add value.
Carlos Martín Nieto committed
-
- 11 Mar, 2016 1 commit
-
-
Curl by default does not report errors by setting the error code. As the upload can fail through several conditions (e.g. the rate limit, leading to unauthorized access) we should indicate this information in Travis CI. To improve upon the behavior, use `--write-out=%{http_code}` to write out the HTTP code in addition to the received body and return an error if the code does not equal 201.
Patrick Steinhardt committed
-
- 03 Mar, 2016 2 commits
-
-
Carlos Martín Nieto committed
-
We were missing this test on Windows, which meant we didn't notice that we never fixed the single authentication attempt it tries, nor its wrong return code. Enable this for the unix platforms as well over HTTP. We previously were doing it locally but disabled it on OS X due to issues with its sshd not accepting password authentication.
Carlos Martín Nieto committed
-
- 23 Feb, 2016 2 commits
-
-
We commonly have to check if a git_buf has been allocated correctly or if we ran out of memory. Introduce a new macro similar to `GITERR_CHECK_ALLOC` which checks if we ran OOM and if so returns an error. Provide a `#nodef` for Coverity to mark the error case as an abort path.
Patrick Steinhardt committed -
Coverity does not comprehend the connection between a vector's size and the contents pointer, that is that the vector's pointer is non-NULL when its size is positive. As the vector code should be reasonably well tested and users are expected to not manually modify a vector's contents it seems save to assume that the macros will never dereference a NULL pointer. Fix Coverity warnings by overriding the foreach macros with macros that explicitly aborting when (v)->contents is NULL.
Patrick Steinhardt committed
-
- 18 Feb, 2016 2 commits
-
-
When checking if a string is prefixed by a drive letter (e.g. "C:") we verify this by inspecting the first and second character of the string. Coverity thinks this is a defect as we do not check the string's length first, but in fact we only check the second character if the first character is part of the alphabet, that is it cannot be '\0'. Fix this by overriding the macro and explicitly checking the string's length.
Patrick Steinhardt committed -
Add nodefs for macros that abort the current flow due to errors. This includes macros that trigger on integer overflows and for the version check macro. This aids Coverity as we point out that these paths will cause a fatal error.
Patrick Steinhardt committed
-
- 10 Feb, 2016 2 commits
-
-
When posting our instrumented build results to Coverity we have to include sensitive information, in particular our authorization token. Currently we use an unencrypted channel to post this information, leading to the token being transferred in plain. Fix this by using a secured connection instead.
Patrick Steinhardt committed -
Coverity currently lists a lot of errors with regard to GITERR_CHECK_ALLOC causing resource leaks. We know this macro is only invoked when we want to abort because we are out of memory. Coverity allows for overriding the default model where we know that certain functions guarantee a desired behavior. The user_nodefs.h is used to override the behavior of macros. Re-define GITERR_CHECK_ALLOC inside of it to specify its abort nature.
Patrick Steinhardt committed
-
- 06 Jul, 2015 2 commits
-
-
Homebrew will error out because it's already installed.
Carlos Martín Nieto committed -
We need to make sure we are asking for the current version of packages, or we might get 404s from the download service.
Carlos Martín Nieto committed
-
- 27 Jun, 2015 1 commit
-
-
We're installing dependencies via the APT addon now.
Arthur Schreiber committed
-
- 26 Jun, 2015 1 commit
-
-
Arthur Schreiber committed
-
- 12 Jun, 2015 1 commit
-
-
These tests were not being taken into consideration for the failure of the test. They've been failing for a while now, but we hadn't noticed as Travis was reporting the builds successful.
Carlos Martín Nieto committed
-
- 17 Mar, 2015 1 commit
-
-
Tony Kelman committed
-
- 16 Mar, 2015 1 commit
-
-
Philip Kelley committed
-
- 10 Mar, 2015 1 commit
-
-
This reverts commit ba6c53b9.
Edward Thomson committed
-
- 05 Mar, 2015 1 commit
-
-
cache mingw-w64 downloads quiet curl and 7zip run appveyor steps in cmd for mingw
Tony Kelman committed
-
- 04 Mar, 2015 2 commits
-
-
Tony Kelman committed
-
use MSYS makefiles generator add bash script for running mingw on appveyor add --login and fix run paths use msys style path to appveyor-mingw.sh add mingw path to /etc/fstab
Tony Kelman committed
-
- 20 Nov, 2014 1 commit
-
-
Ungureanu Marius committed
-
- 19 Nov, 2014 1 commit
-
-
The sshd on OSX has stopped responding to the setting which this test assumes is there, so let's disable it until we can figure out what's happening.
Carlos Martín Nieto committed
-
- 16 Sep, 2014 2 commits
-
-
Carlos Martín Nieto committed
-
Test that the certificate check callback gets the right fingerprint from the host we're connecting to.
Carlos Martín Nieto committed
-
- 29 Aug, 2014 1 commit
-
-
This was added to avoid the remote's default branch to be considered to the be notes one which the first network test leaves behind.
Carlos Martín Nieto committed
-
- 07 Jul, 2014 1 commit
-
-
git allows you to set which paths to use for the git server programs when connecting over ssh; and we want to provide something similar. We do this by providing a factory function which can be set as the remote's transport callback which will set the given paths upon creation.
Carlos Martín Nieto committed
-
- 26 Jun, 2014 1 commit
-
-
Our ssh tests assume that the server supports password authentication in a few places. This is convenient as we're not testing authentication methods, but what happens around them. Tell sshd on OSX to accept this form of authentication.
Carlos Martín Nieto committed
-