- 26 Oct, 2018 40 commits
-
-
We use `git__strtol64` and `git__strtol32` to parse the trailing commit or author date and timezone of signatures. As signatures are usually part of a commit or tag object and thus essentially untrusted data, the buffer may be misformatted and may not be `NUL` terminated. This may lead to an out-of-bounds read. Fix the issue by using `git__strntol64` and `git__strntol32` instead. (cherry picked from commit 3db9aa6f)
Patrick Steinhardt committed -
We use `git__strtol64` to parse file modes of the index entries, which does not limit the parsed buffer length. As the index can be essentially treated as "untrusted" in that the data stems from the file system, it may be misformatted and may not contain terminating `NUL` bytes. This may lead to out-of-bounds reads when trying to parse index entries with such malformatted modes. Fix the issue by using `git__strntol64` instead. (cherry picked from commit 600ceadd)
Patrick Steinhardt committed -
When quick-parsing a commit, we use `git__strtol64` to parse the commit's time. The buffer that's passed to `commit_quick_parse` is the raw data of an ODB object, though, whose data may not be properly formatted and also does not have to be `NUL` terminated. This may lead to out-of-bound reads. Use `git__strntol64` to avoid this problem. (cherry picked from commit 1a3fa1f5)
Patrick Steinhardt committed -
Before resetting the url and username, ensure that we free them in case they were set by environment variables. (cherry picked from commit e84914fd)
Edward Thomson committed -
Don't just free the spec vector, also free the specs themselves. (cherry picked from commit d285de73)
Edward Thomson committed -
Don't just free the push status structure, actually free the strings that were strdup'd into the struct as well. (cherry picked from commit dad99881)
Edward Thomson committed -
Free the url field when resetting the stream to avoid leaking it. (cherry picked from commit ca2eb460)
Edward Thomson committed -
(cherry picked from commit 820fb712)
Patrick Steinhardt committed -
PowerShell can _read_ top-level variables in functions, but cannot _update_ top-level variables in functions unless they're explicitly prefixed with `$global`. (cherry picked from commit 0e26717a)
Edward Thomson committed -
Don't stop on test failures; run all the tests, even when a test fails. (cherry picked from commit 429c7f11)
Edward Thomson committed -
Similar to the way we parse the ctest output on POSIX systems, do the same on Windows. This allows us to append the `-r` flag to clar after we've identified the command to run. (cherry picked from commit 7c9769d9)
Edward Thomson committed -
Introduce SKIP_*_TEST variables for Windows builds to match POSIX builds. (cherry picked from commit a8301b0c)
Edward Thomson committed -
Add the clar flags to produce JUnit-style XML output before invocation. (cherry picked from commit fff33a1b)
Edward Thomson committed -
This reverts commit a2d73f56. Using clar to propagate the XML settings was a mistake. (cherry picked from commit 943181c2)
Patrick Steinhardt committed -
Our CI test system invokes ctest with the name of the given tests it wishes to invoke. ctest (with the `-R` flag) treats this name as a regular expression. Provide anchors in the regular expression to avoid matching additional tests in this search. (cherry picked from commit 7e353b7a)
Edward Thomson committed -
Visual Studio Team Services is now a family of applications named "Azure DevOps". Update the README to refer to it thusly. (cherry picked from commit e2613039)
Edward Thomson committed -
VSTS is now a family of components; "Azure Pipelines" is the build and release pipeline application. (cherry picked from commit 464305b7)
Edward Thomson committed -
(cherry picked from commit d7d0139e)
Patrick Steinhardt committed -
Instead of trying to have a clever iterator pattern that increments the error number, just iterate over errors in the report errors or report all functions as it's easier to reason about in this fashion. (cherry picked from commit d17e67d0)
Edward Thomson committed -
Windows lacks %F and %T formats for strftime. Expand them to the year/month/day and hour/minute/second formats, respectively. (cherry picked from commit e595eeb5)
Edward Thomson committed -
Our build YAML is becoming unweildly and full of copy-pasta. Simplify with templates. (cherry picked from commit 6b2d8f09)
Patrick Steinhardt committed -
Explicitly run from the build directory, not the source. (I was mistaken about the default working directory for VSTS agents.) (cherry picked from commit 306875bc)
Edward Thomson committed -
CMake treats backslashes as escape characters; use forward slashes for the XML output path. (cherry picked from commit f3f2c45e)
Edward Thomson committed -
(cherry picked from commit bfcbde50)
Patrick Steinhardt committed -
(cherry picked from commit a84863fc)
Patrick Steinhardt committed -
Remove the global summary filename and file pointer; pass them in to the summary functions as needed. Error check the results of buffered I/O calls. (cherry picked from commit b67a93ff)
Edward Thomson committed -
Introduce a CLAR_XML option, to run the `ctest` commands with the new `-r` flag to clar. Permitted values are `OFF`, `ON` and a directory to write the XML test results to. (cherry picked from commit a2d73f56)
Patrick Steinhardt committed -
Accept an (optional) value for the summary filename. Continues to default to summary.xml. (cherry picked from commit baa5c20d)
Edward Thomson committed -
(cherry picked from commit dbebcb04)
Edward Thomson committed -
(cherry picked from commit 59f1e477)
Etienne Samson committed -
(cherry picked from commit 3a9b9631)
Etienne Samson committed -
This makes it possible to keep track of every test status (even successful ones), and their errors, if any. (cherry picked from commit bf9fc126)
Etienne Samson committed -
Previously, supplying `-s` to explicitly enable some test(s) would run the tests immediately from the argument parser. This forces us to set up the entire clar environment (for example: sandboxing) before argument parsing takes place. Refactor the behavior of `-s` to add the explicitly chosen tests to a list that is executed later. This untangles the argument parsing from the setup lifecycle, allowing us to use the arguments to perform the setup. (cherry picked from commit 90753a96)
Edward Thomson committed -
(cherry picked from commit 76cfeb20)
Edward Thomson committed -
(cherry picked from commit 6fc946e8)
Edward Thomson committed -
(cherry picked from commit 7238a1e8)
Patrick Steinhardt committed -
(cherry picked from commit 40c3a974)
David Staheli committed -
Otherwise you get something like Emitted 525 C/C++ compilation units (100%) successfully 525 C/C++ compilation units (100%) are ready for analysis The cov-build utility completed successfully. Build successfully submitted. Received error code 200 from Coverity travis_time:end:14cf6373:start=1534254309066933889,finish=1534254728190974302,duration=419124040413 The command "if [ -n "$COVERITY" ]; then ../ci/coverity.sh; fi" exited with 1. travis_time:start:01ed61d4 $ if [ -z "$COVERITY" ]; then ../ci/build.sh && ../ci/test.sh; fi travis_time:end:01ed61d4:start=1534254728197560961,finish=1534254728202711214,duration=5150253 The command "if [ -z "$COVERITY" ]; then ../ci/build.sh && ../ci/test.sh; fi" exited with 0. Done. Your build exited with 1. (cherry picked from commit 351ca661)
Etienne Samson committed -
(cherry picked from commit 658b8e8a)
Edward Thomson committed -
(cherry picked from commit 3ce31df3)
Edward Thomson committed
-