1. 04 Apr, 2017 5 commits
    • fileops: do not overwrite correct error message on mmap · 9daba9f4
      When executing `git_futils_mmap_ro_file`, we first try to guess whether
      the file is mmapable at all. Part of this check is whether the file is
      too large to be mmaped, which can be true on systems with 32 bit
      `size_t` types.
      
      The check is performed by first getting the file size wtih
      `git_futils_filesize` and then checking whether the returned size can be
      represented as `size_t`, returning an error if so. While this test also
      catches the case where the function returned an error (as `-1` is not
      representable by `size_t`), we will set the misleading error message
      "file too large to mmap". But in fact, a negative return value from
      `git_futils_filesize` will be caused by the inability to fstat the file.
      
      Fix the error message by handling negative return values separately and
      not overwriting the error message in that case.
      Patrick Steinhardt committed
    • blame_git: check return value of `git__calloc` · 756138e4
      We do not check the return value of `git__calloc`, which may return
      `NULL` in out-of-memory situations. Fix the error by using
      `GITERR_CHECK_ALLOC`.
      Patrick Steinhardt committed
    • path: short-circuit `git_path_apply_relative` on error · a76d7502
      Short-circuit the call to `git_path_resolve_relative` in case
      `git_buf_joinpath` returns an error. While this does not fix any
      immediate errors, the resulting code is easier to read and handles
      potential new error conditions raised by `git_buf_joinpath`.
      Patrick Steinhardt committed
    • path: handle error returned by `git_buf_joinpath` · cffd616a
      In the `_check_dir_contents` function, we first allocate memory for
      joining the directory and subdirectory together and afterwards use
      `git_buf_joinpath`. While this function in fact should not fail as
      memory is already allocated, err on the safe side and check for returned
      errors.
      Patrick Steinhardt committed
    • config_file: handle errors other than OOM while parsing section headers · 4467aeac
      The current code in `parse_section_header_ext` is only prepared to
      properly handle out-of-memory conditions for the `git_buf` structure.
      While very unlikely and probably caused by a programming error, it is
      also possible to run into error conditions other than out-of-memory
      previous to reaching the actual parsing loop. In these cases, we will
      run into undefined behavior as the `rpos` variable is only initialized
      after these triggerable errors, but we use it in the cleanup-routine.
      
      Fix the issue by unifying the function's cleanup code with an
      `end_error` section, which will not use the `rpos` variable.
      Patrick Steinhardt committed
  2. 28 Mar, 2017 1 commit
  3. 24 Mar, 2017 3 commits
  4. 23 Mar, 2017 6 commits
  5. 22 Mar, 2017 6 commits
  6. 21 Mar, 2017 7 commits
  7. 20 Mar, 2017 11 commits
  8. 17 Mar, 2017 1 commit
    • submodule: resolve URLs relative to main worktree · b0c9bc92
      It is possible to specify submodule URLs relative to the repository
      location. E.g. having a submodule with URL "../submodule" will look for
      the submodule at "repo/../submodule".
      
      With the introduction of worktrees, though, we cannot simply resolve the
      URL relative to the repository location itself. If the repository for
      which a URL is to be resolved is a working tree, we have to resolve the
      URL relative to the parent's repository path. Otherwise, the URL would
      change depending on where the working tree is located.
      
      Fix this by special-casing when we have a working tree while getting the
      URL base.
      Patrick Steinhardt committed