1. 14 Jul, 2022 1 commit
  2. 20 Jun, 2022 3 commits
  3. 15 Jun, 2022 3 commits
  4. 10 Apr, 2022 2 commits
  5. 23 Feb, 2022 1 commit
  6. 12 Feb, 2022 2 commits
  7. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  8. 27 Nov, 2020 1 commit
  9. 11 Oct, 2020 1 commit
    • global: separate global state from thread-local state · 4853d94c
      Our "global initialization" has accumulated some debris over the years.
      It was previously responsible for both running the various global
      initializers (that set up various subsystems) _and_ setting up the
      "global state", which is actually the thread-local state for things
      like error reporting.
      
      Separate the thread local state out into "threadstate".  Use the normal
      subsystem initialization functions that we already have to set it up.
      This makes both the global initialization system and the threadstate
      system simpler to reason about.
      Edward Thomson committed
  10. 09 Jun, 2020 1 commit
    • tree-wide: do not compile deprecated functions with hard deprecation · c6184f0c
      When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor
      definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h"
      header to be empty. As a result, no function declarations are made
      available to callers, but the implementations are still available to
      link against. This has the problem that function declarations also
      aren't visible to the implementations, meaning that the symbol's
      visibility will not be set up correctly. As a result, the resulting
      library may not expose those deprecated symbols at all on some platforms
      and thus cause linking errors.
      
      Fix the issue by conditionally compiling deprecated functions, only.
      While it becomes impossible to link against such a library in case one
      uses deprecated functions, distributors of libgit2 aren't expected to
      pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually
      define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real"
      hard deprecation still makes sense in the context of CI to test we don't
      use deprecated symbols ourselves and in case a dependant uses libgit2 in
      a vendored way and knows it won't ever use any of the deprecated symbols
      anyway.
      Patrick Steinhardt committed
  11. 24 Jan, 2020 1 commit
  12. 15 Jun, 2019 1 commit
  13. 22 Jan, 2019 1 commit
  14. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  15. 29 Dec, 2016 1 commit
  16. 13 Feb, 2015 2 commits
  17. 27 Oct, 2014 1 commit
  18. 18 Aug, 2014 1 commit
  19. 07 Mar, 2014 1 commit
  20. 20 Feb, 2014 1 commit
  21. 13 Jan, 2014 1 commit
  22. 19 Sep, 2013 1 commit
  23. 31 Aug, 2013 1 commit
  24. 22 May, 2013 1 commit
  25. 17 May, 2013 1 commit
  26. 29 Apr, 2013 4 commits
  27. 25 Mar, 2013 1 commit
  28. 21 Mar, 2013 2 commits
  29. 08 Jan, 2013 1 commit