Commit 13640d1b by Vicent Marti

oid: Do not parse OIDs longer than 40

parent 1f107478
......@@ -25,7 +25,7 @@ int git_oid_fromstrn(git_oid *out, const char *str, size_t length)
int v;
if (length > GIT_OID_HEXSZ)
length = GIT_OID_HEXSZ;
return oid_error_invalid("too long");
for (p = 0; p < length - 1; p += 2) {
v = (git__fromhex(str[p + 0]) << 4)
......
......@@ -11,7 +11,7 @@ void test_core_oid__initialize(void)
{
cl_git_pass(git_oid_fromstr(&id, str_oid));
cl_git_pass(git_oid_fromstrp(&idp, str_oid_p));
cl_git_pass(git_oid_fromstrp(&idm, str_oid_m));
cl_git_fail(git_oid_fromstrp(&idm, str_oid_m));
}
void test_core_oid__streq(void)
......@@ -27,6 +27,4 @@ void test_core_oid__streq(void)
cl_assert(git_oid_streq(&idp, "deadbeef") == -1);
cl_assert(git_oid_streq(&idp, "I'm not an oid.... :)") == -1);
cl_assert(git_oid_cmp(&id, &idm) == 0);
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment