1. 11 Sep, 2017 1 commit
  2. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  3. 29 Dec, 2016 1 commit
  4. 20 Dec, 2016 1 commit
  5. 19 Apr, 2016 1 commit
  6. 20 Mar, 2016 1 commit
  7. 08 Sep, 2015 1 commit
  8. 14 May, 2015 1 commit
  9. 13 May, 2015 3 commits
    • Remove the callbacks struct from the remote · 8f0104ec
      Having the setting be different from calling its actions was not a great
      idea and made for the sake of the wrong convenience.
      
      Instead of that, accept either fetch options, push options or the
      callbacks when dealing with the remote. The fetch options are currently
      only the callbacks, but more options will be moved from setters and
      getters on the remote to the options.
      
      This does mean passing the same struct along the different functions but
      the typical use-case will only call git_remote_fetch() or
      git_remote_push() and so won't notice much difference.
      Carlos Martín Nieto committed
    • push: remove own copy of callbacks · 05259114
      The push object knows which remote it's associated with, and therefore
      does not need to keep its own copy of the callbacks stored in the
      remote.
      
      Remove the copy and simply access the callbacks struct within the
      remote.
      Carlos Martín Nieto committed
  10. 18 Apr, 2015 1 commit
    • push: report the update plan to the caller · efc2fec5
      It can be useful for the caller to know which update commands will be
      sent to the server before the packfile is pushed up. git does this via
      the pre-push hook.
      
      We don't have hooks, but as it adds introspection into what is
      happening, we can add a callback which performs the same function.
      Carlos Martín Nieto committed
  11. 11 Mar, 2015 1 commit
  12. 03 Mar, 2015 2 commits
  13. 10 Dec, 2014 1 commit
  14. 17 Nov, 2014 1 commit
  15. 09 Nov, 2014 1 commit
    • push: use the common refspec parser · aad638f3
      There is one well-known and well-tested parser which we should use,
      instead of implementing parsing a second time.
      
      The common parser is also augmented to copy the LHS into the RHS if the
      latter is empty.
      
      The expressions test had to change a bit, as we now catch a bad RHS of a
      refspec locally.
      Carlos Martín Nieto committed
  16. 02 May, 2014 1 commit
  17. 21 Apr, 2014 2 commits
  18. 03 Apr, 2014 1 commit
  19. 06 Mar, 2014 1 commit
  20. 05 Feb, 2014 1 commit
  21. 27 Jan, 2014 1 commit
  22. 15 Jan, 2014 1 commit
  23. 12 Dec, 2013 1 commit
    • Cleanups, renames, and leak fixes · 9cfce273
      This renames git_vector_free_all to the better git_vector_free_deep
      and also contains a couple of memory leak fixes based on valgrind
      checks.  The fixes are specifically: failure to free global dir
      path variables when not compiled with threading on and failure to
      free filters from the filter registry that had not be initialized
      fully.
      Russell Belfer committed
  24. 11 Dec, 2013 5 commits
    • Some callback error check style cleanups · c7b3e1b3
      I find this easier to read...
      Russell Belfer committed
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Add git_vector_free_all · fcd324c6
      There are a lot of places that we call git__free on each item in
      a vector and then call git_vector_free on the vector itself.  This
      just wraps that up into one convenient helper function.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  25. 13 Nov, 2013 1 commit
  26. 12 Nov, 2013 1 commit
  27. 11 Nov, 2013 1 commit
    • remote: make _ls return the list directly · 359dce72
      The callback-based method of listing remote references dates back to the
      beginning of the network code's lifetime, when we didn't know any
      better.
      
      We need to keep the list around for update_tips() after disconnect() so
      let's make use of this to simply give the user a pointer to the array so
      they can write straightforward code instead of having to go through a
      callback.
      Carlos Martín Nieto committed
  28. 02 Oct, 2013 1 commit
    • Support cancellation in push operation · 5b188225
      This commit adds cancellation for the push operation. This work consists of:
      
      1) Support cancellation during push operation
          - During object counting phase
          - During network transfer phase
              - Propagate GIT_EUSER error code out to caller
      2) Improve cancellation support during fetch
          - Handle cancellation request during network transfer phase
          - Clear error string when cancelled during indexing
      3) Fix error handling in git_smart__download_pack
      
      Cancellation during push is still only handled in the pack building and
      network transfer stages of push (and not during packbuilding).
      Jameson Miller committed
  29. 30 Sep, 2013 1 commit
    • Initial Implementation of progress reports during push · b176eded
      This adds the basics of progress reporting during push. While progress
      for all aspects of a push operation are not reported with this change,
      it lays the foundation to add these later. Push progress reporting
      can be improved in the future - and consumers of the API should
      just get more accurate information at that point.
      
      The main areas where this is lacking are:
      
      1) packbuilding progress: does not report progress during deltafication,
         as this involves coordinating progress from multiple threads.
      
      2) network progress: reports progress as objects and bytes are going
         to be written to the subtransport (instead of as client gets
         confirmation that they have been received by the server) and leaves
         out some of the bytes that are transfered as part of the push protocol.
         Basically, this reports the pack bytes that are written to the
         subtransport. It does not report the bytes sent on the wire that
         are received by the server. This should be a good estimate of
         progress (and an improvement over no progress).
      Jameson Miller committed
  30. 15 Aug, 2013 1 commit
    • push: handle tag chains correctly · 5ce6c1e9
      When dealing with a chain of tags, we need to enqueue each of them
      individually, which means we can't use `git_tag_peel` as that jumps
      over the intermediate tags.
      
      Do the peeling manually so we can look at each object and take the
      appropriate action.
      Carlos Martín Nieto committed
  31. 11 May, 2013 1 commit
  32. 01 May, 2013 1 commit