1. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  2. 11 May, 2021 1 commit
  3. 28 Apr, 2021 1 commit
  4. 22 Oct, 2019 1 commit
  5. 28 Aug, 2019 1 commit
  6. 27 Aug, 2019 1 commit
  7. 21 Aug, 2019 1 commit
  8. 21 Feb, 2019 1 commit
    • tests: apply: verify that we correctly truncate the source buffer · 966b9440
      Previously, we would fail to correctly truncate the source buffer
      if the source has more than one line and ends with a non-newline
      character. In the following call, we thus truncate the source
      string in the middle of the second line. Without the bug fixed,
      we would successfully apply the patch to the source and return
      success. With the overflow being fixed, we should return an
      error now.
      Patrick Steinhardt committed
  9. 01 Dec, 2018 1 commit
  10. 28 Nov, 2018 1 commit
    • tests: move apply_helpers functions into own compilation unit · 14a9a4f3
      Currently, the "apply_helper" functions used for testing the apply logic are all
      statically defined in the "apply_helpers.h" header file. This may lead to
      warnings from the compiler in case where this header file is included, but not
      all functions it brings along are used in the compilation unit where it has been
      included into.
      
      Fix these potential warnings by moving the implementation into its own
      compilation unit "apply_helpers.c".
      Patrick Steinhardt committed
  11. 13 Nov, 2018 3 commits
    • tests: address two null argument instances · f127ce35
      Handle two null argument cases that occur in the unit tests.
      One is in library code, the other is in test code.
      
      Detected by running unit tests with undefined behavior sanitizer:
      ```bash
       # build
      mkdir build && cd build
      cmake -DBUILD_CLAR=ON -DCMAKE_C_FLAGS="-fsanitize=address \
      -fsanitize=undefined -fstack-usage -static-libasan" ..
      cmake --build .
      
       # run with asan
      ASAN_OPTIONS="allocator_may_return_null=1" ./libgit2_clar
      ...
      ............../libgit2/src/apply.c:316:3: runtime error: null pointer \
      passed as argument 1, which is declared to never be null
      ...................../libgit2/tests/apply/fromfile.c:46:3: runtime \
      error: null pointer passed as argument 1, which is declared to never be null
      ```
      Noah Pendleton committed
    • tests: apply: fix reference to deprecated `git_buf_free` · afc64bcd
      Since commit 56ffdfc6 (buffer: deprecate `git_buf_free` in favor of
      `git_buf_dispose`, 2018-02-08), the function `git_buf_free` is
      deprecated and shall not be used anymore. As part of the new apply
      framework that has been cooking for quite some time some new references
      have been introduced to that deprecated function. Replace them with
      calls to `git_buf_dispose`.
      Patrick Steinhardt committed
    • tests: apply: fix missing `cl_git_pass` wrappers · fe215153
      Some function calls in the new "apply" test suite were missing the
      checks whether they succeeded as expected. Fix this by adding the
      missing `cl_git_pass` wrappers.
      Patrick Steinhardt committed
  12. 05 Nov, 2018 27 commits