1. 09 Nov, 2021 1 commit
  2. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  3. 27 Nov, 2020 1 commit
  4. 22 Jan, 2019 1 commit
  5. 10 Jun, 2018 1 commit
  6. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  7. 29 Dec, 2016 1 commit
  8. 23 Jul, 2016 2 commits
  9. 06 Jul, 2016 1 commit
  10. 28 Dec, 2015 1 commit
  11. 22 Dec, 2015 1 commit
  12. 23 Apr, 2015 2 commits
  13. 18 Mar, 2015 1 commit
  14. 24 Oct, 2014 1 commit
  15. 31 Aug, 2014 3 commits
  16. 26 Aug, 2014 1 commit
  17. 14 Aug, 2014 1 commit
    • Custom transport: minor cleanups · c180c065
       * Move the transport registration mechanisms into a new header under
         'sys/' because this is advanced stuff.
       * Remove the 'priority' argument from the registration as it adds
         unnecessary complexity.  (Since transports cannot decline to operate,
         only the highest priority transport is ever executed.)  Users who
         require per-priority transports can implement that in their custom
         transport themselves.
       * Simplify registration further by taking a scheme (eg "http") instead
         of a prefix (eg "http://").
      Edward Thomson committed
  18. 27 Jun, 2014 1 commit
  19. 02 May, 2014 1 commit
  20. 06 Mar, 2014 1 commit
  21. 05 Dec, 2013 1 commit
  22. 01 Oct, 2013 1 commit
  23. 09 Jul, 2013 1 commit
  24. 07 May, 2013 1 commit
  25. 05 May, 2013 1 commit
  26. 03 May, 2013 2 commits
  27. 08 Jan, 2013 1 commit
  28. 13 Dec, 2012 2 commits
  29. 28 Nov, 2012 1 commit
  30. 01 Nov, 2012 1 commit
  31. 19 May, 2012 1 commit
  32. 17 May, 2012 1 commit
  33. 03 May, 2012 1 commit
  34. 11 Apr, 2012 1 commit