error-handling: remote, transport

include/git2/errors.h

@@ -131,7 +131,8 @@ typedef enum {
 	GITERR_REGEX,
 	GITERR_ODB,
 	GITERR_INDEX,
-	GITERR_OBJECT
+	GITERR_OBJECT,
+	GITERR_NET,
 } git_error_class;
 
 /**

src/transport.c

@@ -46,7 +46,8 @@ static git_transport_cb transport_find_fn(const char *url)
 int git_transport_dummy(git_transport **transport)
 {
 	GIT_UNUSED(transport);
-	return git__throw(GIT_ENOTIMPLEMENTED, "This protocol isn't implemented. Sorry");
+	giterr_set(GITERR_NET, "This transport isn't implemented. Sorry");
+	return -1;
 }
 
 int git_transport_new(git_transport **out, const char *url)
@@ -66,11 +67,10 @@ int git_transport_new(git_transport **out, const char *url)
 
 	error = fn(&transport);
 	if (error < GIT_SUCCESS)
-		return git__rethrow(error, "Failed to create new transport");
+		return error;
 
 	transport->url = git__strdup(url);
-	if (transport->url == NULL)
-		return GIT_ENOMEM;
+	GITERR_CHECK_ALLOC(transport->url);
 
 	*out = transport;