1. 07 Apr, 2017 1 commit
    • filter: only close filter if it's been initialized correctly · cf07db2f
      In the function `git_filter_list_stream_data`, we initialize, write and
      subesquently close the stream which should receive content processed by
      the filter. While we skip writing to the stream if its initialization
      failed, we still try to close it unconditionally -- even if the
      initialization failed, where the stream might not be set at all, leading
      us to segfault.
      
      Semantics in this code is not really clear. The function handling the
      same logic for files instead of data seems to do the right thing here in
      only closing the stream when initialization succeeded. When stepping
      back a bit, this is only reasonable: if a stream cannot be initialized,
      the caller would not expect it to be closed again. So actually, both
      callers of `stream_list_init` fail to do so. The data streaming function
      will always close the stream and the file streaming function will not
      close the stream if writing to it has failed.
      
      The fix is thus two-fold:
      
      - callers of `stream_list_init` now close the stream iff it has been
        initialized
      - `stream_list_init` now closes the lastly initialized stream if
        the current stream in the chain failed to initialize
      
      Add a test which segfaulted previous to these changes.
      Patrick Steinhardt committed
  2. 10 Jul, 2015 2 commits
  3. 02 Jul, 2015 2 commits
  4. 01 Jul, 2015 1 commit
  5. 29 Jun, 2015 1 commit
  6. 22 Jun, 2015 1 commit
  7. 10 Jun, 2015 1 commit
  8. 26 May, 2015 1 commit
  9. 24 Mar, 2015 1 commit
  10. 06 Mar, 2015 1 commit
  11. 19 Feb, 2015 2 commits
  12. 18 Feb, 2015 2 commits
  13. 17 Feb, 2015 1 commit
  14. 20 Jan, 2015 1 commit
  15. 30 May, 2014 1 commit
  16. 19 May, 2014 1 commit
  17. 06 May, 2014 1 commit
    • Add filter options and ALLOW_UNSAFE · 5269008c
      Diff and status do not want core.safecrlf to actually raise an
      error regardless of the setting, so this extends the filter API
      with an additional options flags parameter and adds a flag so that
      filters can be applied with GIT_FILTER_OPT_ALLOW_UNSAFE, indicating
      that unsafe filter application should be downgraded from a failure
      to a warning.
      Russell Belfer committed
  18. 08 Apr, 2014 1 commit
  19. 12 Feb, 2014 1 commit
  20. 25 Jan, 2014 1 commit
  21. 08 Jan, 2014 1 commit
  22. 14 Nov, 2013 1 commit