1. 30 May, 2018 1 commit
  2. 29 May, 2018 1 commit
  3. 30 Dec, 2017 1 commit
  4. 29 Dec, 2017 1 commit
  5. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  6. 08 Jun, 2017 2 commits
  7. 17 Mar, 2017 1 commit
    • refdb: create references in commondir · 097f0105
      References for a repository are usually created inside of its gitdir.
      When using worktrees, though, these references are not to be created
      inside the worktree gitdir, but instead inside the gitdir of its parent
      repository, which is the commondir. Like this, branches will still be
      available after the worktree itself has been deleted.
      
      The filesystem refdb currently still creates new references inside of
      the gitdir. Fix this and have it create references in commondir.
      Patrick Steinhardt committed
  8. 06 Mar, 2017 1 commit
  9. 02 Mar, 2017 1 commit
  10. 28 Feb, 2017 3 commits
  11. 17 Feb, 2017 1 commit
  12. 15 Feb, 2017 1 commit
    • refdb: catch additional per-worktree refs · 6da6b425
      The upstream git.git project currently identifies all references inside
      of `refs/bisect/` as well as `HEAD` as per-worktree references. This is
      already incorrect and is currently being fixed by an in-flight topic
      [1]. The new behavior will be to match all pseudo-references outside of
      the `refs/` hierarchy as well as `refs/bisect/`.
      
      Our current behavior is to mark a selection of pseudo-references as
      per-worktree, only. This matches more pseudo-references than current
      git, but forgets about `refs/bisect/`. Adjust behavior to match the
      in-flight topic, that is classify the following references as
      per-worktree:
      
      - everything outside of `refs/`
      - everything inside of `refs/bisect/`
      
      [1]: <20170213152011.12050-1-pclouds@gmail.com>
      Patrick Steinhardt committed
  13. 13 Feb, 2017 4 commits
    • repository: rename `path_repository` and `path_gitlink` · 84f56cb0
      The `path_repository` variable is actually confusing to think
      about, as it is not always clear what the repository actually is.
      It may either be the path to the folder containing worktree and
      .git directory, the path to .git itself, a worktree or something
      entirely different. Actually, the intent of the variable is to
      hold the path to the gitdir, which is either the .git directory
      or the bare repository.
      
      Rename the variable to `gitdir` to avoid confusion. While at it,
      also rename `path_gitlink` to `gitlink` to improve consistency.
      Patrick Steinhardt committed
    • refdb: introduce commondir awareness · e0a6c28e
      The refdb_fs_backend is not aware of the git commondir, which
      stores common objects like the o bject database and packed/loose
      refereensces when worktrees are used.
      
      Make refdb_fs_backend aware of the common directory by
      introducing a new commonpath variable that points to the actual
      common path of the database and using it instead of the gitdir
      for the mentioned objects.
      Patrick Steinhardt committed
    • refdb: rename refdb_fs_backend's .path to .gitpath · 71dd0861
      The variable '.path' of the refdb_fs_backend struct becomes
      confusing regarding the introduction of the git commondir. It
      does not immediatly become obvious what it should point to.
      
      Fix this problem by renaming the variable to `gitpath`,
      clarifying that it acutally points to the `.git` directory of the
      repository, in contrast to the commonpath directory, which points
      to the directory containing shared objects like references and
      the object store.
      Patrick Steinhardt committed
  14. 29 Dec, 2016 1 commit
  15. 16 Dec, 2016 1 commit
  16. 14 Nov, 2016 8 commits
  17. 11 Mar, 2016 1 commit
  18. 23 Feb, 2016 1 commit
    • refdb_fs: remove unnecessary check for NULL · 793e0855
      The fail-label of `reflog_parse` explicitly checks the entry
      poitner for NULL before freeing it. When we jump to the label the
      variable has to be set to a non-NULL and valid pointer though: if
      the allocation fails we immediately return with an error code and
      if the loop was not entered we return with a success code,
      withouth executing the label's code.
      
      Remove the useless NULL-check to silence Coverity.
      Patrick Steinhardt committed
  19. 17 Feb, 2016 1 commit
    • index: allow read of index w/ illegal entries · 318b825e
      Allow `git_index_read` to handle reading existing indexes with
      illegal entries.  Allow the low-level `git_index_add` to add
      properly formed `git_index_entry`s even if they contain paths
      that would be illegal for the current filesystem (eg, `AUX`).
      Continue to disallow `git_index_add_bypath` from adding entries
      that are illegal universally illegal (eg, `.git`, `foo/../bar`).
      Edward Thomson committed
  20. 12 Nov, 2015 2 commits
  21. 29 Oct, 2015 1 commit
  22. 28 Oct, 2015 1 commit
  23. 17 Sep, 2015 1 commit
    • git_futils_mkdir_*: make a relative-to-base mkdir · ac2fba0e
      Untangle git_futils_mkdir from git_futils_mkdir_ext - the latter
      assumes that we own everything beneath the base, as if it were
      being called with a base of the repository or working directory,
      and is tailored towards checkout and ensuring that there is no
      bogosity beneath the base that must be cleaned up.
      
      This is (at best) slow and (at worst) unsafe in the larger context
      of a filesystem where we do not own things and cannot do things like
      unlink symlinks that are in our way.
      Edward Thomson committed
  24. 28 Aug, 2015 1 commit
  25. 12 Jul, 2015 1 commit
  26. 08 Mar, 2015 1 commit