1. 16 Apr, 2019 2 commits
    • examples: honor allowed credential types when prompting user · 635ec366
      Credential callback are being passed a bitset that indicates
      which credential types are allowed in the current context. In our
      examples code, we completely ignore that field and always return
      username/password credentials, which doesn't necessarily make
      sense e.g. when only SSH keys are allowed.
      
      Refactor the code and only return username/password credentials
      in the case where `USERPASS_PLAINTEXT` credentials are allowed.
      Otherwise, return a positive error code to indicate that no
      credentials could be acquired.
      Patrick Steinhardt committed
    • examples: move MSVC compatibility macros into common header · b106620d
      We currently have two locations in our examples where we define
      the same compatibility wrappers for MSVC. Move them into
      "common.h" to avoid duplication and make them available to other
      examples.
      Patrick Steinhardt committed
  2. 07 Apr, 2019 4 commits
  3. 05 Apr, 2019 1 commit
    • ignore: treat paths with trailing "/" as directories · 9d117e20
      The function `git_ignore_path_is_ignored` is there to test the
      ignore status of paths that need not necessarily exist inside of
      a repository. This has the implication that for a given path, we
      cannot always decide whether it references a directory or a file,
      and we need to distinguish those cases because ignore rules may
      treat those differently. E.g. given the following gitignore file:
      
          *
          !/**/
      
      we'd only want to unignore directories, while keeping files
      ignored. But still, calling `git_ignore_path_is_ignored("dir/")`
      will say that this directory is ignored because it treats "dir/"
      as a file path.
      
      As said, the `is_ignored` function cannot always decide whether
      the given path is a file or directory, and thus it may produce
      wrong results in some cases. While this is unfixable in the
      general case, we can do better when we are being passed a path
      name with a trailing path separator (e.g. "dir/") and always
      treat them as directories.
      Patrick Steinhardt committed
  4. 04 Apr, 2019 6 commits
  5. 29 Mar, 2019 11 commits
  6. 25 Mar, 2019 2 commits
  7. 23 Mar, 2019 1 commit
  8. 20 Mar, 2019 2 commits
  9. 15 Mar, 2019 1 commit
  10. 14 Mar, 2019 2 commits
  11. 06 Mar, 2019 1 commit
  12. 05 Mar, 2019 1 commit
  13. 02 Mar, 2019 2 commits
  14. 28 Feb, 2019 2 commits
  15. 27 Feb, 2019 2 commits