1. 04 Oct, 2020 2 commits
  2. 18 Sep, 2020 6 commits
  3. 17 Sep, 2020 1 commit
  4. 16 Sep, 2020 1 commit
  5. 15 Sep, 2020 2 commits
  6. 14 Sep, 2020 2 commits
  7. 10 Sep, 2020 2 commits
  8. 09 Sep, 2020 1 commit
  9. 08 Sep, 2020 2 commits
  10. 01 Sep, 2020 1 commit
  11. 31 Aug, 2020 3 commits
  12. 28 Aug, 2020 1 commit
  13. 27 Aug, 2020 1 commit
  14. 24 Aug, 2020 4 commits
  15. 21 Aug, 2020 2 commits
  16. 18 Aug, 2020 1 commit
  17. 05 Aug, 2020 4 commits
    • zstream: handle Z_BUF_ERROR appropriately in get_output_chunk · 9bb61bad
      Our processing loop in git_zstream_get_output_chunk does not handle
      `Z_BUF_ERROR` appropriately at the end of a compressed window.
      
      From the zlib manual, inflate will return:
      
      > Z_BUF_ERROR if no progress was possible or if there was not enough
      > room in the output buffer when Z_FINISH is used. Note that Z_BUF_ERROR
      > is not fatal, and inflate() can be called again with more input and
      > more output space to continue decompressing.
      
      In our loop, we were waiting until we got the expected size, then
      ensuring that we were at `Z_STREAM_END`.  We are not guaranteed to be,
      since zlib may be in the `Z_BUF_ERROR` state where it has consumed a
      full window's worth of data, but it doesn't know that it's really at the
      end of the stream.  There _could_ be more compressed data, but it
      doesn't _know_ that there's not until we make a subsequent call.
      
      We can change the loop to look for the end of stream instead of our
      expected size.  This allows us to call inflate one last time when we are
      at the end of a window (and in the `Z_BUF_ERROR` state), allowing it to
      recognize the end of the stream, and move from the `Z_BUF_ERROR` state
      to the `Z_STREAM_END` state.
      
      If we do this, we need another exit condition: when `bytes == 0`, then
      no progress could be made and we should stop trying to inflate.  This
      will be an error case, caught by the size and/or end-of-stream test.
      Edward Thomson committed
  18. 03 Aug, 2020 4 commits