gitno_connect() can return an error or socket, which is fine on most
platforms where sockets are file descriptors (signed int), but on Windows,
SOCKET is an unsigned type, which is problematic when we are trying to
test if the socket was actually a negative error code.

This fix seperates the error code and socket in gitno_connect(), and fixes
the error handling in do_connect() functions to compensate. It appears
that git_connect() and the git-transport do_connect() functions had bugs
in the non-windows cases too (leaking sockets, and not properly reporting
connection error, respectively) so I went ahead and fixed those too.

MINGW32 does not define _mktemp_s, so we can just use _mktemp instead. See
the non-compressed/non-base64-encoded version of the patch here:
http://gist.github.com/2605249

The code used to assume that there had to be data after the newline in
a tree cache extension entry. This isn't true for a childless
invalidated entry if it's the last one, as there won't be any children
nor a hash to take up space.

Adapt the off-by-one comparison to also work in this case. Fixes #633.

Win32 fixes

This fixes a possible compilation issue (when GIT_WIN32 was not set) which was introduced in revision 69a4bc19.

Signed-off-by: Sven Strickroth <email@cs-ware.de>

There is no need to check for _WIN32 and _WIN64. x64 compiler also set _WIN32 (compare http://sourceforge.net/apps/mediawiki/predef/index.php?title=Operating_Systems#Windows).

Signed-off-by: Sven Strickroth <email@cs-ware.de>

WIN32 is not always defined, use GIT_WIN32 instead

GetFileAttributes does not work for utf-8 encoded paths

Signed-off-by: Sven Strickroth <email@cs-ware.de>

Signed-off-by: Sven Strickroth <email@cs-ware.de>

Looking through the open windows to check whether we can re-use an
open window should take into account whether both `offset` and `offset
+ extra` are contained within the same window. Failure to do so can
lead to invalid memory accesses. This closes #614.

While we're in the area remove an outdated assert.

tests-clar: cleanup

Signed-off-by: schu <schu-github@schulog.org>

Signed-off-by: schu <schu-github@schulog.org>

Signed-off-by: schu <schu-github@schulog.org>

Ported t04_commit.c to Clar.

Port all tests to clar

Travis-CI integration

Removed the BUILD_CLAR CMake flag, and updated the readme.

* t00 / 6e86fb3 (mentioned in #406)
* t01 / fc60c4a (mentioned in #406)
* t03 / bcbabe61
* t04 / PR #606
* t05 / d96f2c3
* t06 / 6c106eec
* t07 / 2ef582b4
* t08 / b482c420
* t09 / 9a39a364
* t10 / 00a48934
* t12 / 7c3a4a7f
* t13 / 1cb9b31e
* t17 / cdaa6ff (mentioned in #406)
* t18 / efabc08

It'd be nice to be rid of all the #define's, but converting to const
char*'s would be even messier, and less declarative.