- 14 Sep, 2021 2 commits
-
-
Fix config parsing for multiline with multiple quoted comment chars
Edward Thomson committed -
notes: use a buffer internally
Edward Thomson committed
-
- 10 Sep, 2021 1 commit
-
-
Code cleanup to use `git_buf`s instead of simple c strings.
Edward Thomson committed
-
- 09 Sep, 2021 2 commits
-
-
The strip_comments function uses the count of quotes to know if a comment char (';' or '#') is the start of a comment or part of the multiline as a string. Unfortunately converting the count of quotes from previous lines to a boolean meant that it would only work as expected in some cases (0 quotes or an odd number of quotes).
Basile Henry committed -
This tests parsing a multiline string containing multiple quoted comment chars. See #6019
Basile Henry committed
-
- 05 Sep, 2021 3 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
This change makes `git_remote_name_is_valid` be part of the public interface of the library. This is needed for other language bindings to be able to find this symbol (like in git2go, when linking against libgit2 dynamically).
lhchavez committed
-
- 03 Sep, 2021 2 commits
-
-
#6028: Check if `threadstate->error_t.message` is not `git_buf__initbuf` before freeing.
Edward Thomson committed -
This follows the same principle as `buffer.c` where the same check is done before freeing the buffer. It fixes the crash described in #6028.
Miguel Arroz committed
-
- 02 Sep, 2021 10 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Update proxy configuration
Edward Thomson committed -
Update the proxy detection for a remote. 1. Honor `http.<url>.proxy` syntax for a remote's direct URL and parent URLs. 2. Honor an empty configuration URL to override a proxy configuration. Add tests to ensure that configuration specificity is honored.
Edward Thomson committed -
Edward Thomson committed
-
Provide a utility method on a url to determine if it matches any pattern in a comma-separated list, similar to what one would find in `NO_PROXY` environment variables.
Edward Thomson committed -
Provide a method to determine if a given URL matches a host:port pattern like the ones found in `NO_PROXY` environment variables.
Edward Thomson committed -
Edward Thomson committed
-
Introduce a utility function that compares a NUL terminated string to a possibly not-NUL terminated string with length. This is similar to `strncmp` but with an added check to ensure that the lengths match (not just the `size` portion of the two strings).
Edward Thomson committed -
Item 2 of 3 from #4164 Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Mathieu Parent committed
-
- 31 Aug, 2021 5 commits
-
-
Fix a possible null pointer dereference
Edward Thomson committed -
This change fixes a possible null pointer dereference if anything inside `git_commit_graph_writer_add_index_file` fails before the packfile being valid. https://scan6.coverity.com/reports.htm#v52218/p10377/fileInstanceId=122935896&defectInstanceId=32525576&mergedDefectId=1461634
lhchavez committed -
Edward Thomson committed
-
Edward Thomson committed
-
Fix worktree iteration when repository has no common directory
Edward Thomson committed
-
- 30 Aug, 2021 15 commits
-
-
Set Host Header to match CONNECT authority target
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Prior to this change, for CONNECT requests, the Host header was set to the host and port of the target http proxy. However, per the rfc7230 for HTTP/1.1 this is incorrect as the Host header should match the target of the CONNECT request, as detailed in section 5.3.3 & 5.4. 5.3.3. authority-form The authority-form of request-target is only used for CONNECT requests (Section 4.3.6 of [RFC7231]). authority-form = authority When making a CONNECT request to establish a tunnel through one or more proxies, a client MUST send only the target URI's authority component (excluding any userinfo and its "@" delimiter) as the request-target. For example, CONNECT www.example.com:80 HTTP/1.1 5.4. Host <snip> A client MUST send a Host header field in all HTTP/1.1 request messages. If the target URI includes an authority component, then a client MUST send a field-value for Host that is identical to that authority component, excluding any userinfo subcomponent and its "@" delimiter (Section 2.7.1). If the authority component is missing or undefined for the target URI, then a client MUST send a Host header field with an empty field-value. This issue was noticed when proxying requests through HAProxy 2.2 which rejects these invalid http requests.
Jesse Hathaway committed -
Fixes from code analysis
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
buf: deprecate public git_buf writing functions
Edward Thomson committed -
filter: filter drivers stop taking git_buf as user input
Edward Thomson committed -
Introduce `create_commit_cb`, deprecate `signing_cb`
Edward Thomson committed
-