1. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  2. 17 Feb, 2017 2 commits
  3. 29 Dec, 2016 1 commit
  4. 04 Aug, 2016 1 commit
  5. 09 Mar, 2016 1 commit
  6. 15 Feb, 2015 1 commit
  7. 27 Oct, 2014 1 commit
  8. 25 Jun, 2014 2 commits
  9. 23 Jun, 2014 1 commit
    • Share packs across repository instances · b3b66c57
      Opening the same repository multiple times will currently open the same
      file multiple times, as well as map the same region of the file multiple
      times. This is not necessary, as the packfile data is immutable.
      
      Instead of opening and closing packfiles directly, introduce an
      indirection and allocate packfiles globally. This does mean locking on
      each packfile open, but we already use this lock for the global mwindow
      list so it doesn't introduce a new contention point.
      Carlos Martín Nieto committed
  10. 22 Apr, 2013 1 commit
    • Further threading fixes · 53607868
      This builds on the earlier thread safety work to make it so that
      setting the odb, index, refdb, or config for a repository is done
      in a threadsafe manner with minimized locking time.  This is done
      by adding a lock to the repository object and using it to guard
      the assignment of the above listed pointers.  The lock is only
      held to assign the pointer value.
      
      This also contains some minor fixes to the other work with pack
      files to reduce the time that locks are being held to and fix an
      apparently memory leak.
      Russell Belfer committed
  11. 17 Mar, 2013 1 commit
  12. 23 Jan, 2013 1 commit
  13. 08 Jan, 2013 1 commit
  14. 06 Jan, 2013 1 commit
    • git_mwindow_file_deregister() shouldn't return errors · f9b55bcb
      As a function that appears to only be called on error paths, I don't
      think it makes sense for it to return an error, or clobber the global
      giterr. Note that no existing callsites actually check the return
      code.
      
      In my own application, there are errors where the real error ends
      up being hidden, as git_mwindow_file_deregister() clobbers the
      global giterr. I'm not sure this error is even relevant?
      Scott J. Goldman committed
  15. 09 Dec, 2012 1 commit
  16. 20 Aug, 2012 1 commit
    • Make the memory-window conrol structures global · 8cef828d
      Up to now, the idea was that the user would do all the operations for
      one repository in the same thread. Thus we could have the
      memory-mapped window information thread-local and avoid any locking.
      
      This is not practical in a few environments, such as Apple's GCD which
      allocates threads arbitrarily or the .NET CLR, where the OS-level
      thread can change at any moment.
      
      Make the control structure global and protect it with a mutex so we
      don't depend on the thread currently executing the code.
      Carlos Martín Nieto committed
  17. 28 Jun, 2012 1 commit
  18. 12 Jun, 2012 1 commit
  19. 23 May, 2012 1 commit
  20. 02 May, 2012 1 commit
  21. 13 Apr, 2012 1 commit
  22. 04 Apr, 2012 1 commit
  23. 16 Mar, 2012 1 commit
  24. 15 Mar, 2012 1 commit
    • Continue error conversion · deafee7b
      This converts blob.c, fileops.c, and all of the win32 files.
      Also, various minor cleanups throughout the code.  Plus, in
      testing the win32 build, I cleaned up a bunch (although not
      all) of the warnings with the 64-bit build.
      Russell Belfer committed
  25. 13 Mar, 2012 1 commit
    • Migrate ODB files to new error handling · e1de726c
      This migrates odb.c, odb_loose.c, odb_pack.c and pack.c to
      the new style of error handling.  Also got the unix and win32
      versions of map.c.  There are some minor changes to other
      files but no others were completely converted.
      
      This also contains an update to filebuf so that a zeroed out
      filebuf will not think that the fd (== 0) is actually open
      (and inadvertently call close() on fd 0 if cleaned up).
      
      Lastly, this was built and tested on win32 and contains a
      bunch of fixes for the win32 build which was pretty broken.
      Russell Belfer committed
  26. 13 Feb, 2012 1 commit
  27. 16 Nov, 2011 1 commit
  28. 29 Oct, 2011 1 commit
  29. 15 Oct, 2011 1 commit
    • mwindow: close LRU window properly · 5fa1bed0
      Remove a wrong call to git_mwindow_close which caused a segfault if it
      ever did run. In that same piece of code, if the LRU was from the
      first wiindow in the list in a different file, we didn't update that
      list, so the first element had been freed.
      
      Fix these two issues.
      
      Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
      Carlos Martín Nieto committed
  30. 19 Sep, 2011 1 commit
    • Tabify everything · 87d9869f
      There were quite a few places were spaces were being used instead of
      tabs. Try to catch them all. This should hopefully not break anything.
      Except for `git blame`. Oh well.
      Vicent Marti committed
  31. 18 Sep, 2011 1 commit
    • Cleanup legal data · bb742ede
      1. The license header is technically not valid if it doesn't have a
      copyright signature.
      
      2. The COPYING file has been updated with the different licenses used in
      the project.
      
      3. The full GPLv2 header in each file annoys me.
      Vicent Marti committed
  32. 08 Sep, 2011 1 commit
  33. 30 Aug, 2011 1 commit
  34. 09 Aug, 2011 1 commit
  35. 08 Aug, 2011 1 commit
  36. 02 Aug, 2011 2 commits