Commit fbb5f707 by 雾雨魔理沙 Committed by Tianqi Chen

[Relay] fix small typekey issue (#1992)

It might cause TupleTypeNode to be printed incorrectly.
it doesnt show in http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1989/1/pipeline/141, but if you run it on local machine you will see what get compared being NodeBase and TupleType.

Also as a side thought can we write a giant macro that make sure everything get did right (all field get visited, typekey match, declare_node_type_info match, etc?) I can do some macro metaprogramming, so I can take up the work.
parent 9fc9d66e
...@@ -251,7 +251,7 @@ class TupleTypeNode : public TypeNode { ...@@ -251,7 +251,7 @@ class TupleTypeNode : public TypeNode {
TVM_DLL static TupleType make(tvm::Array<Type> fields); TVM_DLL static TupleType make(tvm::Array<Type> fields);
static constexpr const char* _type_key = "relay.TypeTuple"; static constexpr const char* _type_key = "relay.TupleType";
TVM_DECLARE_NODE_TYPE_INFO(TupleTypeNode, TypeNode); TVM_DECLARE_NODE_TYPE_INFO(TupleTypeNode, TypeNode);
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment