Skip to content

T
tic
Commit 280c4c3d by Tianqi Chen Committed by GitHub
Options

Update code_review.rst

parent 10a2d2ea
Showing with 4 additions and 4 deletions
docs/contribute/code_review.rst
...@@ -46,8 +46,8 @@ Respect each other ...@@ -46,8 +46,8 @@ Respect each other
------------------ ------------------
The code reviewers and contributors are paying the most precious currencies in the world -- time. We are volunteers in the community to spend the time to build good code, help each other, learn and have fun hacking. The code reviewers and contributors are paying the most precious currencies in the world -- time. We are volunteers in the community to spend the time to build good code, help each other, learn and have fun hacking.
Approve Code Reviews Approve Changes
-------------------- ---------------
The contributor and code owner can request code reviews from multiple reviewers. The contributor and code owner can request code reviews from multiple reviewers.
Code owner can decide if the code can be merged in case by case if some of the reviewers did not respond in time(e.g. a week) Code owner can decide if the code can be merged in case by case if some of the reviewers did not respond in time(e.g. a week) and existing reviews are sufficient.
and existing reviews are sufficient. Remember to approve your code reviews when your comments are addressed. Remember to approve changes when your comments are addressed in a code review.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment