Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
Y
yaml-cpp
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
lvzhengyang
yaml-cpp
Commits
6d5cfab5
Unverified
Commit
6d5cfab5
authored
Jul 06, 2020
by
Chen
Committed by
GitHub
Jul 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix bug from issue298:Emitter stylings settings overridden by node settings. (#915)
parent
026a53fb
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
39 additions
and
0 deletions
+39
-0
include/yaml-cpp/emitter.h
+1
-0
src/emitfromevents.cpp
+4
-0
src/emitter.cpp
+4
-0
src/emitterstate.cpp
+4
-0
src/emitterstate.h
+1
-0
test/integration/emitter_test.cpp
+25
-0
No files found.
include/yaml-cpp/emitter.h
View file @
6d5cfab5
...
...
@@ -59,6 +59,7 @@ class YAML_CPP_API Emitter {
bool
SetPostCommentIndent
(
std
::
size_t
n
);
bool
SetFloatPrecision
(
std
::
size_t
n
);
bool
SetDoublePrecision
(
std
::
size_t
n
);
void
RestoreGlobalModifiedSettings
();
// local setters
Emitter
&
SetLocalValue
(
EMITTER_MANIP
value
);
...
...
src/emitfromevents.cpp
View file @
6d5cfab5
...
...
@@ -59,6 +59,8 @@ void EmitFromEvents::OnSequenceStart(const Mark&, const std::string& tag,
default
:
break
;
}
// Restore the global settings to eliminate the override from node style
m_emitter
.
RestoreGlobalModifiedSettings
();
m_emitter
<<
BeginSeq
;
m_stateStack
.
push
(
State
::
WaitingForSequenceEntry
);
}
...
...
@@ -83,6 +85,8 @@ void EmitFromEvents::OnMapStart(const Mark&, const std::string& tag,
default
:
break
;
}
// Restore the global settings to eliminate the override from node style
m_emitter
.
RestoreGlobalModifiedSettings
();
m_emitter
<<
BeginMap
;
m_stateStack
.
push
(
State
::
WaitingForKey
);
}
...
...
src/emitter.cpp
View file @
6d5cfab5
...
...
@@ -90,6 +90,10 @@ bool Emitter::SetDoublePrecision(std::size_t n) {
return
m_pState
->
SetDoublePrecision
(
n
,
FmtScope
::
Global
);
}
void
Emitter
::
RestoreGlobalModifiedSettings
()
{
m_pState
->
RestoreGlobalModifiedSettings
();
}
// SetLocalValue
// . Either start/end a group, or set a modifier locally
Emitter
&
Emitter
::
SetLocalValue
(
EMITTER_MANIP
value
)
{
...
...
src/emitterstate.cpp
View file @
6d5cfab5
...
...
@@ -222,6 +222,10 @@ std::size_t EmitterState::LastIndent() const {
void
EmitterState
::
ClearModifiedSettings
()
{
m_modifiedSettings
.
clear
();
}
void
EmitterState
::
RestoreGlobalModifiedSettings
()
{
m_globalModifiedSettings
.
restore
();
}
bool
EmitterState
::
SetOutputCharset
(
EMITTER_MANIP
value
,
FmtScope
::
value
scope
)
{
switch
(
value
)
{
...
...
src/emitterstate.h
View file @
6d5cfab5
...
...
@@ -72,6 +72,7 @@ class EmitterState {
bool
HasBegunContent
()
const
{
return
m_hasAnchor
||
m_hasTag
;
}
void
ClearModifiedSettings
();
void
RestoreGlobalModifiedSettings
();
// formatters
void
SetLocalValue
(
EMITTER_MANIP
value
);
...
...
test/integration/emitter_test.cpp
View file @
6d5cfab5
...
...
@@ -732,6 +732,31 @@ TEST_F(EmitterTest, GlobalLongKeyOnMap) {
: *value)"
);
}
TEST_F
(
EmitterTest
,
GlobalSettingStyleOnSeqNode
)
{
Node
n
(
Load
(
R"(foo:
- 1
- 2
- 3
bar: aa)"
));
out
.
SetSeqFormat
(
YAML
::
Flow
);
out
<<
n
;
ExpectEmit
(
R"(foo: [1, 2, 3]
bar: aa)"
);
}
TEST_F
(
EmitterTest
,
GlobalSettingStyleOnMapNode
)
{
Node
n
(
Load
(
R"(-
foo: a
bar: b
- 2
- 3)"
));
out
.
SetMapFormat
(
YAML
::
Flow
);
out
<<
n
;
ExpectEmit
(
R"(- {foo: a, bar: b}
- 2
- 3)"
);
}
TEST_F
(
EmitterTest
,
ComplexGlobalSettings
)
{
out
<<
BeginSeq
;
out
<<
Block
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment