Several VEC member functions that accept an element 'T' used to have
two overloads: one taking 'T', the second taking 'T *'.
This used to be needed because of the interface dichotomy between
vectors of objects and vectors of pointers. In the past, vectors of
pointers would use pass-by-value semantics, but vectors of objects
would use pass-by-reference semantics. This is no longer necessary,
but the distinction had remained.
The main side-effect of this change is some code reduction in code
that manipulates vectors of objects. For instance,
- struct iterator_use *iuse;
-
- iuse = VEC_safe_push (iterator_use, heap, iterator_uses, NULL);
- iuse->iterator = iterator;
- iuse->ptr = ptr;
+ struct iterator_use iuse = {iterator, ptr};
+ VEC_safe_push (iterator_use, heap, iterator_uses, iuse);
Compile time performance was not affected.
Tested on x86_64 and ppc64.
Also built all-gcc on all targets using VEC routines: arm, bfin, c6x,
epiphany, ia64, mips, sh, spu, and vms.
2012-09-10 Diego Novillo <dnovillo@google.com>
* vec.h (vec_t::quick_push): Remove overload that accepts 'T *'.
Update all users.
(vec_t::safe_push): Likewise.
(vec_t::quick_insert): Likewise.
(vec_t::lower_bound): Likewise.
(vec_t::safe_insert): Likewise.
(vec_t::replace): Change second argument to 'T &'.
From-SVN: r191165
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| ChangeLog | Loading commit data... | |
| ChangeLog.ptr | Loading commit data... | |
| ChangeLog.tree-ssa | Loading commit data... | |
| Make-lang.in | Loading commit data... | |
| boehm.c | Loading commit data... | |
| builtins.c | Loading commit data... | |
| class.c | Loading commit data... | |
| config-lang.in | Loading commit data... | |
| constants.c | Loading commit data... | |
| decl.c | Loading commit data... | |
| except.c | Loading commit data... | |
| expr.c | Loading commit data... | |
| gcj.texi | Loading commit data... | |
| java-except.h | Loading commit data... | |
| java-gimplify.c | Loading commit data... | |
| java-opcodes.h | Loading commit data... | |
| java-tree.def | Loading commit data... | |
| java-tree.h | Loading commit data... | |
| javaop.def | Loading commit data... | |
| javaop.h | Loading commit data... | |
| jcf-depend.c | Loading commit data... | |
| jcf-dump.c | Loading commit data... | |
| jcf-io.c | Loading commit data... | |
| jcf-parse.c | Loading commit data... | |
| jcf-path.c | Loading commit data... | |
| jcf-reader.c | Loading commit data... | |
| jcf.h | Loading commit data... | |
| jvgenmain.c | Loading commit data... | |
| jvspec.c | Loading commit data... | |
| lang-specs.h | Loading commit data... | |
| lang.c | Loading commit data... | |
| lang.opt | Loading commit data... | |
| mangle.c | Loading commit data... | |
| mangle_name.c | Loading commit data... | |
| parse.h | Loading commit data... | |
| resource.c | Loading commit data... | |
| typeck.c | Loading commit data... | |
| verify-glue.c | Loading commit data... | |
| verify-impl.c | Loading commit data... | |
| verify.h | Loading commit data... | |
| win32-host.c | Loading commit data... | |
| zextract.c | Loading commit data... | |
| zipfile.h | Loading commit data... |