When deciding whether to perform the memset optimization in ranges::fill_n, we were crucially neglecting to check that the output pointer's value type is a byte type. This patch adds such a check to the problematic condition in ranges::fill_n. At the same time, this patch relaxes the overly conservative __is_byte<_Tp>::__value check that requires the fill type be a byte type. It's overly conservative because it means we won't enable the memset optimization in the following example char c[100]; ranges::fill(c, 37); because the fill type is deduced to be int here. Rather than requiring that the fill type be a byte type, it seems safe to just require the fill type be an integral type, which is what this patch does. libstdc++-v3/ChangeLog: PR libstdc++/94017 * include/bits/ranges_algobase.h (__fill_n_fn::operator()): Refine condition for when to use memset, making sure to additionally check that the output pointer's value type is a non-volatile byte type. Instead of requiring that the fill type is a byte type, just require that it's an integral type. * testsuite/20_util/specialized_algorithms/uninitialized_fill/94017.cc: New test. * testsuite/20_util/specialized_algorithms/uninitialized_fill_n/94017.cc: New test. * testsuite/25_algorithms/fill/94013.cc: Uncomment part that was blocked by PR 94017. * testsuite/25_algorithms/fill/94017.cc: New test. * testsuite/25_algorithms/fill_n/94017.cc: New test.
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| algorithmfwd.h | Loading commit data... | |
| alloc_traits.h | Loading commit data... | |
| allocated_ptr.h | Loading commit data... | |
| allocator.h | Loading commit data... | |
| atomic_base.h | Loading commit data... | |
| atomic_futex.h | Loading commit data... | |
| basic_ios.h | Loading commit data... | |
| basic_ios.tcc | Loading commit data... | |
| basic_string.h | Loading commit data... | |
| basic_string.tcc | Loading commit data... | |
| boost_concept_check.h | Loading commit data... | |
| c++0x_warning.h | Loading commit data... | |
| c++config | Loading commit data... | |
| char_traits.h | Loading commit data... | |
| charconv.h | Loading commit data... | |
| codecvt.h | Loading commit data... | |
| concept_check.h | Loading commit data... | |
| cpp_type_traits.h | Loading commit data... | |
| deque.tcc | Loading commit data... | |
| enable_special_members.h | Loading commit data... | |
| erase_if.h | Loading commit data... | |
| forward_list.h | Loading commit data... | |
| forward_list.tcc | Loading commit data... | |
| fs_dir.h | Loading commit data... | |
| fs_fwd.h | Loading commit data... | |
| fs_ops.h | Loading commit data... | |
| fs_path.h | Loading commit data... | |
| fstream.tcc | Loading commit data... | |
| functexcept.h | Loading commit data... | |
| functional_hash.h | Loading commit data... | |
| gslice.h | Loading commit data... | |
| gslice_array.h | Loading commit data... | |
| hashtable.h | Loading commit data... | |
| hashtable_policy.h | Loading commit data... | |
| indirect_array.h | Loading commit data... | |
| int_limits.h | Loading commit data... | |
| invoke.h | Loading commit data... | |
| ios_base.h | Loading commit data... | |
| istream.tcc | Loading commit data... | |
| iterator_concepts.h | Loading commit data... | |
| list.tcc | Loading commit data... | |
| locale_classes.h | Loading commit data... | |
| locale_classes.tcc | Loading commit data... | |
| locale_conv.h | Loading commit data... | |
| locale_facets.h | Loading commit data... | |
| locale_facets.tcc | Loading commit data... | |
| locale_facets_nonio.h | Loading commit data... | |
| locale_facets_nonio.tcc | Loading commit data... | |
| localefwd.h | Loading commit data... | |
| mask_array.h | Loading commit data... | |
| memoryfwd.h | Loading commit data... | |
| move.h | Loading commit data... | |
| node_handle.h | Loading commit data... | |
| ostream.tcc | Loading commit data... | |
| ostream_insert.h | Loading commit data... | |
| parse_numbers.h | Loading commit data... | |
| postypes.h | Loading commit data... | |
| predefined_ops.h | Loading commit data... | |
| ptr_traits.h | Loading commit data... | |
| quoted_string.h | Loading commit data... | |
| random.h | Loading commit data... | |
| random.tcc | Loading commit data... | |
| range_access.h | Loading commit data... | |
| range_cmp.h | Loading commit data... | |
| ranges_algo.h | Loading commit data... | |
| ranges_algobase.h | Loading commit data... | |
| ranges_uninitialized.h | Loading commit data... | |
| refwrap.h | Loading commit data... | |
| regex.h | Loading commit data... | |
| regex.tcc | Loading commit data... | |
| regex_automaton.h | Loading commit data... | |
| regex_automaton.tcc | Loading commit data... | |
| regex_compiler.h | Loading commit data... | |
| regex_compiler.tcc | Loading commit data... | |
| regex_constants.h | Loading commit data... | |
| regex_error.h | Loading commit data... | |
| regex_executor.h | Loading commit data... | |
| regex_executor.tcc | Loading commit data... | |
| regex_scanner.h | Loading commit data... | |
| regex_scanner.tcc | Loading commit data... | |
| shared_ptr.h | Loading commit data... | |
| shared_ptr_atomic.h | Loading commit data... | |
| shared_ptr_base.h | Loading commit data... | |
| slice_array.h | Loading commit data... | |
| specfun.h | Loading commit data... | |
| sstream.tcc | Loading commit data... | |
| std_abs.h | Loading commit data... | |
| std_function.h | Loading commit data... | |
| std_mutex.h | Loading commit data... | |
| stl_algo.h | Loading commit data... | |
| stl_algobase.h | Loading commit data... | |
| stl_bvector.h | Loading commit data... | |
| stl_construct.h | Loading commit data... | |
| stl_deque.h | Loading commit data... | |
| stl_function.h | Loading commit data... | |
| stl_heap.h | Loading commit data... | |
| stl_iterator.h | Loading commit data... | |
| stl_iterator_base_funcs.h | Loading commit data... | |
| stl_iterator_base_types.h | Loading commit data... | |
| stl_list.h | Loading commit data... | |
| stl_map.h | Loading commit data... | |
| stl_multimap.h | Loading commit data... | |
| stl_multiset.h | Loading commit data... | |
| stl_numeric.h | Loading commit data... | |
| stl_pair.h | Loading commit data... | |
| stl_queue.h | Loading commit data... | |
| stl_raw_storage_iter.h | Loading commit data... | |
| stl_relops.h | Loading commit data... | |
| stl_set.h | Loading commit data... | |
| stl_stack.h | Loading commit data... | |
| stl_tempbuf.h | Loading commit data... | |
| stl_tree.h | Loading commit data... | |
| stl_uninitialized.h | Loading commit data... | |
| stl_vector.h | Loading commit data... | |
| stream_iterator.h | Loading commit data... | |
| streambuf.tcc | Loading commit data... | |
| streambuf_iterator.h | Loading commit data... | |
| string_view.tcc | Loading commit data... | |
| stringfwd.h | Loading commit data... | |
| uniform_int_dist.h | Loading commit data... | |
| unique_lock.h | Loading commit data... | |
| unique_ptr.h | Loading commit data... | |
| unordered_map.h | Loading commit data... | |
| unordered_set.h | Loading commit data... | |
| uses_allocator.h | Loading commit data... | |
| valarray_after.h | Loading commit data... | |
| valarray_array.h | Loading commit data... | |
| valarray_array.tcc | Loading commit data... | |
| valarray_before.h | Loading commit data... | |
| vector.tcc | Loading commit data... |