normal_mv_distribution maintains the variance-covariance matrix param in Cholesky-decomposed form. Existing param_type constructors, when taking a full or lower-triangle varcov matrix, perform Cholesky decomposition to convert it to the internal representation. This internal representation is visible both in the varcov() result, and in the streamed-out representation of a normal_mv_distribution object. The problem is that when that representation is streamed back in, the read-back decomposed varcov matrix is used as a lower-triangle non-decomposed varcov matrix, and it undergoes Cholesky decomposition again. So, each cycle of stream-out/stream-in changes the varcov matrix to its "square root", instead of restoring the original params. This patch includes Corentin's changes that introduce verification in testsuite/ext/random/normal_mv_distribution/operators/serialize.cc and other similar tests that the object read back in compares equal to the written-out object: the modified tests pass only if (u == v). This patch also fixes the error exposed by his change, introducing an alternate private constructor for param_type, used only by operator>>. for libstdc++-v3/ChangeLog * include/ext/random (normal_mv_distribution::param_type::param_type): New private ctor taking a decomposed varcov matrix, for use by... (operator>>): ... this, befriended. * include/ext/random.tcc (operator>>): Use it. (normal_mv_distribution::param_type::_M_init_lower): Adjust member function name in exception message. for libstdc++-v3/ChangeLog from Corentin Gay <gay@adacore.com> * testsuite/ext/random/beta_distribution/operators/serialize.cc, testsuite/ext/random/hypergeometric_distribution/operators/serialize.cc, testsuite/ext/random/normal_mv_distribution/operators/serialize.cc, testsuite/ext/random/triangular_distribution/operators/serialize.cc, testsuite/ext/random/von_mises_distribution/operators/serialize.cc: Add call to `VERIFY`. From-SVN: r274233
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
bitmap_allocator | Loading commit data... | |
char8_t | Loading commit data... | |
codecvt | Loading commit data... | |
concurrence_lock_error | Loading commit data... | |
concurrence_unlock_error | Loading commit data... | |
debug_allocator | Loading commit data... | |
enc_filebuf | Loading commit data... | |
ext_pointer | Loading commit data... | |
forced_error | Loading commit data... | |
iota | Loading commit data... | |
is_heap | Loading commit data... | |
is_sorted | Loading commit data... | |
malloc_allocator | Loading commit data... | |
mt_allocator | Loading commit data... | |
new_allocator | Loading commit data... | |
numeric_traits | Loading commit data... | |
pb_ds | Loading commit data... | |
pool_allocator | Loading commit data... | |
random | Loading commit data... | |
rope | Loading commit data... | |
shared_ptr | Loading commit data... | |
slist | Loading commit data... | |
special_functions | Loading commit data... | |
stdio_filebuf | Loading commit data... | |
stdio_sync_filebuf | Loading commit data... | |
throw_allocator | Loading commit data... | |
throw_value | Loading commit data... | |
type_traits | Loading commit data... | |
vstring | Loading commit data... | |
concept_checks.cc | Loading commit data... | |
headers.cc | Loading commit data... | |
median.cc | Loading commit data... | |
pod_char_traits.cc | Loading commit data... |