currently, aarch64 LEGITIMIZE_ADDRESS_P hook will reject all "reg + offset" address given "offset" is beyond supported range. while this may be too strict. we should honor the "strict_p" parameter in the hook. before reload, we accept all offset if it's a frame access, because the offset may change during later register elimination. the early reject of "reg + offset" may cause extra registers created, and if that register live range is across function invoking then callee saved reg needed, thus introduce extra reg save/restore also. give a simple example as: int test15 (void) { unsigned char a[480]; initialize_array (a, 480); if (a[0] == 0x10) return 1; return 0; } .S before the patch (-O2 -fPIC) === test15: sub sp, sp, #480 mov w1, 480 stp x29, x30, [sp, -32]! add x29, sp, 0 str x19, [sp, 16] add x19, x29, 32 mov x0, x19 bl initialize_array ldrb w0, [x19] ldr x19, [sp, 16] ldp x29, x30, [sp], 32 cmp w0, 16 cset w0, eq add sp, sp, 480 ret .S after the patch === test15: stp x29, x30, [sp, -496]! mov w1, 480 add x29, sp, 0 add x0, x29, 16 bl initialize_array ldrb w0, [x29, 16] ldp x29, x30, [sp], 496 cmp w0, 16 cset w0, eq ret gcc/ * config/aarch64/aarch64.c (aarch64_classify_address): Accept all offset for frame access when strict_p is false. gcc/testsuite * gcc.target/aarch64/legitimize_stack_var_before_reload_1.c: New testcase. From-SVN: r213488
Name |
Last commit
|
Last update |
---|---|---|
INSTALL | Loading commit data... | |
boehm-gc | Loading commit data... | |
config | Loading commit data... | |
contrib | Loading commit data... | |
fixincludes | Loading commit data... | |
gcc | Loading commit data... | |
gnattools | Loading commit data... | |
include | Loading commit data... | |
intl | Loading commit data... | |
libada | Loading commit data... | |
libatomic | Loading commit data... | |
libbacktrace | Loading commit data... | |
libcilkrts | Loading commit data... | |
libcpp | Loading commit data... | |
libdecnumber | Loading commit data... | |
libffi | Loading commit data... | |
libgcc | Loading commit data... | |
libgfortran | Loading commit data... | |
libgo | Loading commit data... | |
libgomp | Loading commit data... | |
libiberty | Loading commit data... | |
libitm | Loading commit data... | |
libjava | Loading commit data... | |
libobjc | Loading commit data... | |
libquadmath | Loading commit data... | |
libsanitizer | Loading commit data... | |
libssp | Loading commit data... | |
libstdc++-v3 | Loading commit data... | |
libvtv | Loading commit data... | |
lto-plugin | Loading commit data... | |
maintainer-scripts | Loading commit data... | |
zlib | Loading commit data... | |
.dir-locals.el | Loading commit data... | |
.gitignore | Loading commit data... | |
ABOUT-NLS | Loading commit data... | |
COPYING | Loading commit data... | |
COPYING.LIB | Loading commit data... | |
COPYING.RUNTIME | Loading commit data... | |
COPYING3 | Loading commit data... | |
COPYING3.LIB | Loading commit data... | |
ChangeLog | Loading commit data... | |
ChangeLog.tree-ssa | Loading commit data... | |
MAINTAINERS | Loading commit data... | |
Makefile.def | Loading commit data... | |
Makefile.in | Loading commit data... | |
Makefile.tpl | Loading commit data... | |
README | Loading commit data... | |
compile | Loading commit data... | |
config-ml.in | Loading commit data... | |
config.guess | Loading commit data... | |
config.rpath | Loading commit data... | |
config.sub | Loading commit data... | |
configure | Loading commit data... | |
configure.ac | Loading commit data... | |
depcomp | Loading commit data... | |
install-sh | Loading commit data... | |
libtool-ldflags | Loading commit data... | |
libtool.m4 | Loading commit data... | |
ltgcc.m4 | Loading commit data... | |
ltmain.sh | Loading commit data... | |
ltoptions.m4 | Loading commit data... | |
ltsugar.m4 | Loading commit data... | |
ltversion.m4 | Loading commit data... | |
lt~obsolete.m4 | Loading commit data... | |
missing | Loading commit data... | |
mkdep | Loading commit data... | |
mkinstalldirs | Loading commit data... | |
move-if-change | Loading commit data... | |
symlink-tree | Loading commit data... | |
ylwrap | Loading commit data... |