1. 03 Apr, 2020 8 commits
    • Improve svn-rev to search for pattern at line beginning. · fa4aab7f
      	* gcc-git-customization.sh: Search for the pattern
      	at line beginning only.
      Martin Liska committed
    • amdgcn: Support unordered floating-point comparison operators · 1dff18a1
      2020-04-03  Kwok Cheung Yeung  <kcy@codesourcery.com>
      
      	gcc/
      	* config/gcn/gcn.c (print_operand): Handle unordered comparison
      	operators.
      	* config/gcn/predicates.md (gcn_fp_compare_operator): Add unordered
      	comparison operators.
      Kwok Cheung Yeung committed
    • libstdc++: Fix std::to_address for debug iterators (PR 93960) · 24fe8c8e
      It should be valid to use std::to_address on a past-the-end iterator,
      but the debug mode iterators do a check for dereferenceable in their
      operator->(). That check is generally useful, so rather than remove it
      this changes std::__to_address to identify a debug mode iterator and
      use base().operator->() to skip the check.
      
      	PR libstdc++/93960
      	* include/bits/ptr_traits.h (__to_address): Add special case for debug
      	iterators, to avoid dereferenceable check.
      	* testsuite/20_util/to_address/1_neg.cc: Adjust dg-error line number.
      	* testsuite/20_util/to_address/debug.cc: New test.
      Jonathan Wakely committed
    • Revert "[nvptx, libgomp] Update pr85381-{2,4}.c test-cases" [PR89713, PR94392] · 2b1e849b
      In response to PR94392 commit 75efe9cb
      "c/94392 - only enable -ffinite-loops for C++", this reverts PR89713
      commit 00908992, as apparently now again
      "empty oacc loops are" no longer "removed before expand".
      
      	libgomp/
      	PR tree-optimization/89713
      	PR c/94392
      	* testsuite/libgomp.oacc-c-c++-common/pr85381-2.c: Again expect
      	'bar.sync'.
      	* testsuite/libgomp.oacc-c-c++-common/pr85381-4.c: Likewise.
      Thomas Schwinge committed
    • Fix PR94443 with gsi_insert_seq_before [PR94443] · 4441eced
      This patch is to fix the stupid mistake by using
      gsi_insert_seq_before instead of gsi_insert_before.
      
      BTW, the regression testing on one x86_64 machine from CFarm is
      unable to reveal it (I guess due to native arch sandybridge?), so I
      specified additional option -march=znver2 and verified the coverage.
      
      Bootstrapped/regtested on powerpc64le-linux-gnu (P9) and
      x86_64-pc-linux-gnu, also verified the fail cases in related PRs.
      
      2020-04-03  Kewen Lin  <linkw@gcc.gnu.org>
      
      gcc/
          PR tree-optimization/94443
          * tree-vect-loop.c (vectorizable_live_operation): Use
          gsi_insert_seq_before to replace gsi_insert_before.
      
      gcc/testsuite/
          PR tree-optimization/94443
          * gcc.dg/vect/pr94443.c: New test.
      Kewen Lin committed
    • ICF: compare type attributes for gimple_call_fntypes. · 55a73802
      	PR ipa/94445
      	* ipa-icf-gimple.c (func_checker::compare_gimple_call):
      	  Compare type attributes for gimple_call_fntypes.
      Martin Liska committed
    • S/390 zTPF: Handle skip trace addresses when unwinding · b749b5ec
      Check for and handle new skip trace addresses when unwinding on zTPF.
      
      libgcc/ChangeLog:
      
      2020-04-03  Jim Johnston  <jjohnst@us.ibm.com>
      
      	* config/s390/tpf-unwind.h (MIN_PATRANGE, MAX_PATRANGE)
      	(TPFRA_OFFSET): Macros removed.
      	(CP_CNF, cinfc_fast, CINFC_CMRESET, CINTFC_CMCENBKST)
      	(CINTFC_CMCENBKED, ICST_CRET, ICST_SRET, LOWCORE_PAGE3_ADDR)
      	(PG3_SKIPPING_OFFSET): New macros.
      	(__isPATrange): Use cinfc_fast for the check.
      	(__isSkipResetAddr): New function.
      	(s390_fallback_frame_state): Check for skip trace addresses. Use
      	either ICST_CRET or ICST_SRET to calculate return address
      	location.
      	(__tpf_eh_return): Handle skip trace addresses.
      Jim Johnston committed
    • Daily bump. · 535ce76a
      GCC Administrator committed
  2. 02 Apr, 2020 22 commits
    • Fix some comment typos in alias.c. · 63f56527
      2020-04-02  Sandra Loosemore  <sandra@codesourcery.com>
      
      	* alias.c (get_alias_set): Fix comment typos.
      Sandra Loosemore committed
    • Fix check_effective_target_sigsetjmp for glibc targets. · a950bb6e
      2020-04-02  Sandra Loosemore  <sandra@codesourcery.com>
      
      	gcc/testsuite/
      	* lib/target-supports.exp (check_effective_target_sigsetjmp): Test
      	for __sigsetjmp as well as sigsetjmp.
      Sandra Loosemore committed
    • Fix fortran/85982 ICE in resolve_component. · 0cd74f35
      2020-04-01  Fritz Reese  <foreese@gcc.gnu.org>
      
      	PR fortran/85982
      	* fortran/decl.c (match_attr_spec): Lump COMP_STRUCTURE/COMP_MAP into
      	attribute checking used by TYPE.
      
      2020-04-01  Fritz Reese  <foreese@gcc.gnu.org>
      
      	PR fortran/85982
      	* gfortran.dg/dec_structure_28.f90: New test.
      Fritz Reese committed
    • [Fortran] Resolve formal args before checking DTIO · 3ab216a4
              * gfortran.h (gfc_resolve_formal_arglist): Add prototype.
              * interface.c (check_dtio_interface1): Call it.
              * resolve.c (gfc_resolve_formal_arglist): Renamed from
              resolve_formal_arglist, removed static.
              (find_arglists, resolve_types): Update calls.
      
              * gfortran.dg/dtio_35.f90: New.
      Tobias Burnus committed
    • Prevent IPA-SRA from creating calls to local comdats (PR 92676) · b90061c6
      since r278669 (fix for PR ipa/91956), IPA-SRA makes sure that the clone
      it creates is put into the same same_comdat as the original cgraph_node,
      so that it can call private comdats (such as the ipa-split bits of a
      comdat that is private).
      
      However, that means that if there is non-comdat caller of a public
      comdat that is modified by IPA-SRA, it now finds itself calling a
      private comdat, which call graph verifier does not like (and for a
      reason, in theory it can disappear and since it is private it would not
      be available from other CUs).
      
      The patch fixes this by performing the fix for PR 91956 only when the
      node in question actually calls a local comdat and when it does, also
      making sure that no callers come from a different same_comdat (disabling
      IPA-SRA if both conditions are true), so that it plays by the rules in
      both modes, does not violate the private comdat calling rule and at the
      same time does not disable the transformation unnecessarily.
      
      The patch also fixes up the calls_comdat_local of callers of the
      modified node, despite that not triggering any known issues.
      
      2020-04-02  Martin Jambor  <mjambor@suse.cz>
      
      	PR ipa/92676
      	* ipa-sra.c (struct caller_issues): New fields candidate and
      	call_from_outside_comdat.
      	(check_for_caller_issues): Check for calls from outsied of
      	candidate's same_comdat_group.
      	(check_all_callers_for_issues): Set up issues.candidate, check result
      	of the new check.
      	(mark_callers_calls_comdat_local): New function.
      	(process_isra_node_results): Set calls_comdat_local of callers if
      	appropriate.
      Martin Jambor committed
    • c/94392 - only enable -ffinite-loops for C++ · 75efe9cb
      This does away with enabling -ffinite-loops at -O2+ for all languages
      and instead enables it selectively for C++ only.
      
      It also makes -ffinite-loops loop-private at CFG construction time
      fixing correctness issues with inlining.
      
      2020-04-02  Richard Biener  <rguenther@suse.de>
      
      	PR c/94392
      	* c-opts.c (c_common_post_options): Enable -ffinite-loops
      	for -O2 and C++11 or newer.
      
      	* common.opt (ffinite-loops): Initialize to zero.
      	* opts.c (default_options_table): Remove OPT_ffinite_loops
      	entry.
      	* cfgloop.h (loop::finite_p): New member.
      	* cfgloopmanip.c (copy_loop_info): Copy finite_p.
      	* ipa-icf-gimple.c (func_checker::compare_loops): Compare
      	finite_p.
      	* lto-streamer-in.c (input_cfg): Stream finite_p.
      	* lto-streamer-out.c (output_cfg): Likewise.
      	* tree-cfg.c (replace_loop_annotate): Initialize finite_p
      	from flag_finite_loops at CFG build time.
      	* tree-ssa-loop-niter.c (finite_loop_p): Check the loops
      	finite_p flag instead of flag_finite_loops.
      	* doc/invoke.texi (ffinite-loops): Adjust documentation of
      	default setting.
      
      	* gcc.dg/torture/pr94392.c: New testcase.
      Richard Biener committed
    • debug/94450 - remove DW_TAG_imported_unit generated in LTRANS units · 54af9576
      This removes the DW_TAG_imported_unit we generate for each referenced
      early debug unit in LTRANS units.  They are more harmful than they
      do good and the semantics can be read in a way making it even wrong.
      
      2020-04-02  Richard Biener  <rguenther@suse.de>
      
      	PR debug/94450
      	* dwarf2out.c (dwarf2out_early_finish): Remove code emitting
      	DW_TAG_imported_unit.
      Richard Biener committed
    • doc: RISC-V: Update binutils requirement to 2.30 · 879bc686
      Complement commit bfe78b08 ("RISC-V: Using fmv.x.w/fmv.w.x rather
      than fmv.x.s/fmv.s.x") and document a binutils 2.30 requirement in the
      installation manual, matching the addition of fmv.x.w/fmv.w.x mnemonics
      to GAS.
      
      	gcc/
      	* doc/install.texi (Specific) <riscv32-*-elf, riscv32-*-linux>
      	<riscv64-*-elf, riscv64-*-linux>: Update binutils requirement to
      	2.30.
      Maciej W. Rozycki committed
    • Fix PR94401 by considering reverse overrun · 81ce375d
      The commit r10-7415 brings scalar type consideration
      to eliminate epilogue peeling for gaps, but it exposed
      one problem that the current handling doesn't consider
      the memory access type VMAT_CONTIGUOUS_REVERSE, for
      which the overrun happens on low address side.  This
      patch is to make the code take care of it by updating
      the offset and construction element order accordingly.
      
      Bootstrapped/regtested on powerpc64le-linux-gnu P8
      and aarch64-linux-gnu.
      
      2020-04-02  Kewen Lin  <linkw@gcc.gnu.org>
      
      gcc/ChangeLog
      
          PR tree-optimization/94401
          * tree-vect-loop.c (vectorizable_load): Handle VMAT_CONTIGUOUS_REVERSE
          access type when loading halves of vector to avoid peeling for gaps.
      Kewen Lin committed
    • Fix up -Wliteral-suffix warning on mti-linux.h · 68cbee9b
      I've noticed while trying to reproduce PR92989 the following warning:
      In file included from ./tm.h:42,
                       from ../../gcc/backend.h:28,
                       from ../../gcc/lra-assigns.c:80:
      ../../gcc/config/mips/mti-linux.h:31:5: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
           "/%{mmicromips:micro}mips%{mel|EL:el}-"MIPS_SYSVERSION_SPEC  \
           ^
      This fixes it, string concatenation works just fine even with whitespace
      in between.
      
      2020-04-02  Jakub Jelinek  <jakub@redhat.com>
      
      	* config/mips/mti-linux.h (SYSROOT_SUFFIX_SPEC): Add a space in
      	between a string literal and MIPS_SYSVERSION_SPEC macro.
      Jakub Jelinek committed
    • sra/doc: Document param sra-max-propagations · d4ed2cd1
      I forgot to document the new param in invoke.texi, does the text below
      look OK?
      
      Tested with make info and make pdf.
      
      Thanks,
      
      Martin
      
      2020-04-02  Martin Jambor  <mjambor@suse.cz>
      
      	* doc/invoke.texi (Optimize Options): Document sra-max-propagations.
      Martin Jambor committed
    • params: Decrease -param=max-find-base-term-values= default [PR92264] · 86c92411
      For the PR in question, my proposal would be to also lower
      -param=max-find-base-term-values=
      default from 2000 to 200 after this, at least in the above 4
      bootstraps/regtests there is nothing that would ever result in
      find_base_term returning non-NULL with more than 200 VALUEs being processed.
      
      2020-04-02  Jakub Jelinek  <jakub@redhat.com>
      
      	PR rtl-optimization/92264
      	* params.opt (-param=max-find-base-term-values=): Decrease default
      	from 2000 to 200.
      Jakub Jelinek committed
    • cselib: Reuse VALUEs on sp adjustments [PR92264] · 2c0fa3ec
      As discussed in the PR, if !ACCUMULATE_OUTGOING_ARGS on large functions we
      can have hundreds of thousands of stack pointer adjustments and cselib
      creates a new VALUE after each sp adjustment, which form extremely deep
      VALUE chains, which is very harmful e.g. for find_base_term.
      E.g. if we have
      sp -= 4
      sp -= 4
      sp += 4
      sp += 4
      sp -= 4
      sp += 4
      that means 7 VALUEs, one for the sp at beginning (val1), than val2 = val1 -
      4, then val3 = val2 - 4, then val4 = val3 + 4, then val5 = val4 + 4, then
      val6 = val5 - 4, then val7 = val6 + 4.
      This patch tweaks cselib, so that it is smarter about sp adjustments.
      When cselib_lookup (stack_pointer_rtx, Pmode, 1, VOIDmode) and we know
      nothing about sp yet (this happens at the start of the function, for
      non-var-tracking also after cselib_reset_table and for var-tracking after
      processing fp_setter insn where we forget about former sp values because
      that is now hfp related while everything after it is sp related), we
      look it up normally, but in addition to what we have been doing before
      we mark the VALUE as SP_DERIVED_VALUE_P.  Further lookups of sp + offset
      are then special cased, so that it is canonicalized to that
      SP_DERIVED_VALUE_P VALUE + CONST_INT (if possible).  So, for the above,
      we get val1 with SP_DERIVED_VALUE_P set, then val2 = val1 - 4, val3 = val1 -
      8 (note, no longer val2 - 4!), then we get val2 again, val1 again, val2
      again, val1 again.
      In the find_base_term visited_vals.length () > 100 find_base_term
      statistics during combined x86_64-linux and i686-linux bootstrap+regtest
      cycle, without the patch I see:
      			find_base_term > 100
      			returning NULL	returning non-NULL
      32-bit compilations	4229178		407
      64-bit compilations	217523		0
      with largest visited_vals.length () when returning non-NULL being 206.
      With the patch the same numbers are:
      32-bit compilations	1249588		135
      64-bit compilations	3510		0
      with largest visited_vals.length () when returning non-NULL being 173.
      This shows significant reduction of the deep VALUE chains.
      On powerpc64{,le}-linux, these stats didn't change at all, we have
      			1008		0
      for all of -m32, -m64 and little-endian -m64, just the
      gcc.dg/pr85180.c and gcc.dg/pr87985.c testcases which are unrelated to sp.
      
      My earlier version of the patch, which contained just the rtl.h and cselib.c
      changes, regressed some tests:
      gcc.dg/guality/{pr36728-{1,3},pr68860-{1,2}}.c
      gcc.target/i386/{pr88416,sse-{13,23,24,25,26}}.c
      The problem with the former tests was worse debug info, where with -m32
      where arg7 was passed in a stack slot we though a push later on might have
      invalidated it, when it couldn't.  This is something I've solved with the
      var-tracking.c (vt_initialize) changes.  In those problematic functions, we
      create a cfa_base VALUE (argp) and want to record that at the start of
      the function the argp VALUE is sp + off and also record that current sp
      VALUE is argp's VALUE - off.  The second permanent equivalence didn't make
      it after the patch though, because cselib_add_permanent_equiv will
      cselib_lookup the value of the expression it wants to add as the equivalence
      and if it is the same VALUE as we are calling it on, it doesn't do anything;
      and due to the cselib changes for sp based accesses that is exactly what
      happened.  By reversing the order of the cselib_add_permanent_equiv calls we
      get both equivalences though and thus are able to canonicalize the sp based
      accesses in var-tracking to the cfa_base value + offset.
      The i386 FAILs were all ICEs, where we had pushf instruction pushing flags
      and then pop pseudo reading that value again.  With the cselib changes,
      cselib during RTL DSE is able to see through the sp adjustment and wanted
      to replace_read what was done pushf, by moving the flags register into a
      pseudo and replace the memory read in the pop with that pseudo.  That is
      wrong for two reasons: one is that the backend doesn't have an instruction
      to move the flags hard register into some other register, but replace_read
      has been validating just the mem -> pseudo replacement and not the insns
      emitted by copy_to_mode_reg.  And the second issue is that it is obviously
      wrong to replace a stack pop which contains stack post-increment by a copy
      of pseudo into destination.  dse.c has some code to handle RTX_AUTOINC, but
      only uses it when actually removing stores and only when there is REG_INC
      note (stack RTX_AUTOINC does not have those), in check_for_inc_dec* where
      it emits the reg adjustment(s) before the insn that is going to be deleted.
      replace_read doesn't remove the insn, so if it e.g. contained REG_INC note,
      it would be kept there and we might have the RTX_AUTOINC not just in *loc,
      but other spots.
      So, the dse.c changes try to validate the added insns and punt on all
      RTX_AUTOINC in *loc.  Furthermore, it seems that with the cselib.c changes
      on the gfortran.dg/pr87360.f90 and gcc.target/i386/pr88416.c testcases
      check_for_inc_dec{,_1} happily throws stack pointer autoinc on the floor,
      which is also wrong.  While we could perhaps do the for_each_inc_dec
      call regardless of whether we have REG_INC note or not, we aren't prepared
      to handle e.g. REG_ARGS_SIZE distribution and thus could end up with wrong
      unwind info or ICEs during dwarf2cfi.c.  So the patch also punts on those,
      after all, if we'd in theory managed to try to optimize such pushes before,
      we'd create wrong-code.
      
      On x86_64-linux and i686-linux, the patch has some minor debug info coverage
      differences, but it doesn't appear very significant to me.
      https://github.com/pmachata/dwlocstat tool gives (where before is vanilla
      trunk + the rtl.h patch but not {cselib,var-tracking,dse}.c
      --enable-checking=yes,rtl,extra bootstrapped, then {cselib,var-tracking,dse}.c
      hunks applied and make cc1plus, while after is trunk with the whole patch
      applied).
      
      64-bit cc1plus
      before
      cov%	samples	cumul
      0..10	1232756/48%	1232756/48%
      11..20	31089/1%	1263845/49%
      21..30	39172/1%	1303017/51%
      31..40	38853/1%	1341870/52%
      41..50	47473/1%	1389343/54%
      51..60	45171/1%	1434514/56%
      61..70	69393/2%	1503907/59%
      71..80	61988/2%	1565895/61%
      81..90	104528/4%	1670423/65%
      91..100	875402/34%	2545825/100%
      after
      cov%	samples	cumul
      0..10	1233238/48%	1233238/48%
      11..20	31086/1%	1264324/49%
      21..30	39157/1%	1303481/51%
      31..40	38819/1%	1342300/52%
      41..50	47447/1%	1389747/54%
      51..60	45151/1%	1434898/56%
      61..70	69379/2%	1504277/59%
      71..80	61946/2%	1566223/61%
      81..90	104508/4%	1670731/65%
      91..100	875094/34%	2545825/100%
      
      32-bit cc1plus
      before
      cov%	samples	cumul
      0..10	1231221/48%	1231221/48%
      11..20	30992/1%	1262213/49%
      21..30	36422/1%	1298635/51%
      31..40	35793/1%	1334428/52%
      41..50	47102/1%	1381530/54%
      51..60	41201/1%	1422731/56%
      61..70	65467/2%	1488198/58%
      71..80	59560/2%	1547758/61%
      81..90	104076/4%	1651834/65%
      91..100	881879/34%	2533713/100%
      after
      cov%	samples	cumul
      0..10	1230469/48%	1230469/48%
      11..20	30390/1%	1260859/49%
      21..30	36362/1%	1297221/51%
      31..40	36042/1%	1333263/52%
      41..50	47619/1%	1380882/54%
      51..60	41674/1%	1422556/56%
      61..70	65849/2%	1488405/58%
      71..80	59857/2%	1548262/61%
      81..90	104178/4%	1652440/65%
      91..100	881273/34%	2533713/100%
      
      2020-04-02  Jakub Jelinek  <jakub@redhat.com>
      
      	PR rtl-optimization/92264
      	* rtl.h (struct rtx_def): Mention that call bit is used as
      	SP_DERIVED_VALUE_P in cselib.c.
      	* cselib.c (SP_DERIVED_VALUE_P): Define.
      	(PRESERVED_VALUE_P, SP_BASED_VALUE_P): Move definitions earlier.
      	(cselib_hasher::equal): Handle equality between SP_DERIVED_VALUE_P
      	val_rtx and sp based expression where offsets cancel each other.
      	(preserve_constants_and_equivs): Formatting fix.
      	(cselib_reset_table): Add reverse op loc to SP_DERIVED_VALUE_P
      	locs list for cfa_base_preserved_val if needed.  Formatting fix.
      	(autoinc_split): If the to be returned value is a REG, MEM or
      	VALUE which has SP_DERIVED_VALUE_P + CONST_INT as one of its
      	locs, return the SP_DERIVED_VALUE_P VALUE and adjust *off.
      	(rtx_equal_for_cselib_1): Call autoinc_split even if both
      	expressions are PLUS in Pmode with CONST_INT second operands.
      	Handle SP_DERIVED_VALUE_P cases.
      	(cselib_hash_plus_const_int): New function.
      	(cselib_hash_rtx): Use it for PLUS in Pmode with CONST_INT
      	second operand, as well as for PRE_DEC etc. that ought to be
      	hashed the same way.
      	(cselib_subst_to_values): Substitute PLUS with Pmode and
      	CONST_INT operand if the first operand is a VALUE which has
      	SP_DERIVED_VALUE_P + CONST_INT as one of its locs for the
      	SP_DERIVED_VALUE_P + adjusted offset.
      	(cselib_lookup_1): When creating a new VALUE for stack_pointer_rtx,
      	set SP_DERIVED_VALUE_P on it.  Set PRESERVED_VALUE_P when adding
      	SP_DERIVED_VALUE_P PRESERVED_VALUE_P subseted VALUE location.
      	* var-tracking.c (vt_initialize): Call cselib_add_permanent_equiv
      	on the sp value before calling cselib_add_permanent_equiv on the
      	cfa_base value.
      	* dse.c (check_for_inc_dec_1, check_for_inc_dec): Punt on RTX_AUTOINC
      	in the insn without REG_INC note.
      	(replace_read): Punt on RTX_AUTOINC in the *loc being replaced.
      	Punt on invalid insns added by copy_to_mode_reg.  Formatting fixes.
      Jakub Jelinek committed
    • aarch64: Fix ICE due to aarch64_gen_compare_reg_maybe_ze [PR94435] · df562b12
      The following testcase ICEs, because aarch64_gen_compare_reg_maybe_ze emits
      invalid RTL.
      For y_mode [QH]Imode it expects y to be of that mode (or CONST_INT that fits
      into that mode) and x being SImode; for non-CONST_INT y it zero extends y
      into SImode and compares that against x, for CONST_INT y it zero extends y
      into SImode.  The problem is that when the zero extended constant isn't
      usable directly, it forces it into a REG, but with y_mode mode, and then
      compares against y.  That is wrong, because it should force it into a SImode
      REG and compare that way.
      
      2020-04-02  Jakub Jelinek  <jakub@redhat.com>
      
      	PR target/94435
      	* config/aarch64/aarch64.c (aarch64_gen_compare_reg_maybe_ze): For
      	y_mode E_[QH]Imode and y being a CONST_INT, change y_mode to SImode.
      
      	* gcc.target/aarch64/pr94435.c: New test.
      Jakub Jelinek committed
    • aarch64: Fix ICE due to aarch64_gen_compare_reg_maybe_ze [PR94435] · 66e32751
      The following testcase ICEs, because aarch64_gen_compare_reg_maybe_ze emits
      invalid RTL.
      For y_mode [QH]Imode it expects y to be of that mode (or CONST_INT that fits
      into that mode) and x being SImode; for non-CONST_INT y it zero extends y
      into SImode and compares that against x, for CONST_INT y it zero extends y
      into SImode.  The problem is that when the zero extended constant isn't
      usable directly, it forces it into a REG, but with y_mode mode, and then
      compares against y.  That is wrong, because it should force it into a SImode
      REG and compare that way.
      
      2020-04-02  Jakub Jelinek  <jakub@redhat.com>
      
      	PR target/94435
      	* config/aarch64/aarch64.c (aarch64_gen_compare_reg_maybe_ze): For
      	y_mode E_[QH]Imode and y being a CONST_INT, change y_mode to SImode.
      
      	* gcc.target/aarch64/pr94435.c: New test.
      Jakub Jelinek committed
    • [ARM]: Fix for MVE ACLE intrinsics with writeback (PR94317). · ff825b81
      Following MVE ACLE intrinsics have an issue with writeback to the base address.
      
      vldrdq_gather_base_wb_s64, vldrdq_gather_base_wb_u64, vldrdq_gather_base_wb_z_s64, vldrdq_gather_base_wb_z_u64, vldrwq_gather_base_wb_s32, vldrwq_gather_base_wb_u32, vldrwq_gather_base_wb_z_s32, vldrwq_gather_base_wb_z_u32, vldrwq_gather_base_wb_f32, vldrwq_gather_base_wb_z_f32.
      
      This patch fixes the bug reported in PR94317 by adding separate builtin calls to update the result and writeback to base address for the above intrinsics.
      
      2020-04-02  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
      
      	PR target/94317
      	* config/arm/arm-builtins.c (LDRGBWBXU_QUALIFIERS): Define.
      	(LDRGBWBXU_Z_QUALIFIERS): Likewise.
      	* config/arm/arm_mve.h (__arm_vldrdq_gather_base_wb_s64): Modify
      	intrinsic defintion by adding a new builtin call to writeback into base
      	address.
      	(__arm_vldrdq_gather_base_wb_u64): Likewise.
      	(__arm_vldrdq_gather_base_wb_z_s64): Likewise.
      	(__arm_vldrdq_gather_base_wb_z_u64): Likewise.
      	(__arm_vldrwq_gather_base_wb_s32): Likewise.
      	(__arm_vldrwq_gather_base_wb_u32): Likewise.
      	(__arm_vldrwq_gather_base_wb_z_s32): Likewise.
      	(__arm_vldrwq_gather_base_wb_z_u32): Likewise.
      	(__arm_vldrwq_gather_base_wb_f32): Likewise.
      	(__arm_vldrwq_gather_base_wb_z_f32): Likewise.
      	* config/arm/arm_mve_builtins.def (vldrwq_gather_base_wb_z_u): Modify
      	builtin's qualifier.
      	(vldrdq_gather_base_wb_z_u): Likewise.
      	(vldrwq_gather_base_wb_u): Likewise.
      	(vldrdq_gather_base_wb_u): Likewise.
      	(vldrwq_gather_base_wb_z_s): Likewise.
      	(vldrwq_gather_base_wb_z_f): Likewise.
      	(vldrdq_gather_base_wb_z_s): Likewise.
      	(vldrwq_gather_base_wb_s): Likewise.
      	(vldrwq_gather_base_wb_f): Likewise.
      	(vldrdq_gather_base_wb_s): Likewise.
      	(vldrwq_gather_base_nowb_z_u): Define builtin.
      	(vldrdq_gather_base_nowb_z_u): Likewise.
      	(vldrwq_gather_base_nowb_u): Likewise.
      	(vldrdq_gather_base_nowb_u): Likewise.
      	(vldrwq_gather_base_nowb_z_s): Likewise.
      	(vldrwq_gather_base_nowb_z_f): Likewise.
      	(vldrdq_gather_base_nowb_z_s): Likewise.
      	(vldrwq_gather_base_nowb_s): Likewise.
      	(vldrwq_gather_base_nowb_f): Likewise.
      	(vldrdq_gather_base_nowb_s): Likewise.
      	* config/arm/mve.md (mve_vldrwq_gather_base_nowb_<supf>v4si): Define RTL
      	pattern.
      	(mve_vldrwq_gather_base_wb_<supf>v4si): Modify RTL pattern.
      	(mve_vldrwq_gather_base_nowb_z_<supf>v4si): Define RTL pattern.
      	(mve_vldrwq_gather_base_wb_z_<supf>v4si): Modify RTL pattern.
      	(mve_vldrwq_gather_base_wb_fv4sf): Modify RTL pattern.
      	(mve_vldrwq_gather_base_nowb_fv4sf): Define RTL pattern.
      	(mve_vldrwq_gather_base_wb_z_fv4sf): Modify RTL pattern.
      	(mve_vldrwq_gather_base_nowb_z_fv4sf): Define RTL pattern.
      	(mve_vldrdq_gather_base_nowb_<supf>v4di): Define RTL pattern.
      	(mve_vldrdq_gather_base_wb_<supf>v4di):  Modify RTL pattern.
      	(mve_vldrdq_gather_base_nowb_z_<supf>v4di): Define RTL pattern.
      	(mve_vldrdq_gather_base_wb_z_<supf>v4di):  Modify RTL pattern.
      
      gcc/testsuite/ChangeLog:
      
      2020-04-02  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
      
      	PR target/94317
      	* gcc.target/arm/mve/intrinsics/vldrdq_gather_base_wb_s64.c: Modify.
      	* gcc.target/arm/mve/intrinsics/vldrdq_gather_base_wb_u64.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrdq_gather_base_wb_z_s64.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrdq_gather_base_wb_z_u64.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_f32.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_s32.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_u32.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_f32.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_s32.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_wb_z_u32.c: Likewise.
      Srinath Parvathaneni committed
    • libstdc++-v3/test: Better skip for "use_service.cc" · c1effaa2
      2020-04-01  Andrea Corallo  <andrea.corallo@arm.com>
      
      	* testsuite/experimental/net/execution_context/use_service.cc:
      	Require pthread and gthreads.
      Andrea Corallo committed
    • [Fortran] Fix error cleanup of select rank (PR93522) · 224efaf7
      	PR fortran/93522
      	* match.c (gfc_match_select_rank): Fix error cleanup.
      
      	PR fortran/93522
      	* gfortran.dg/select_rank_4.f90: New.
      Tobias Burnus committed
    • S/390: Remove superfluous commutative constraint modifiers · b7a98f48
      For operands with an identical set of alternatives there is no point
      in marking them commutative.  This patch removes the superfluous
      constraint modifiers in vector.md and vx-builtins.md since it might
      slow down reload without buying us anything.
      
      There were even two patterns where the constraint modifier was plain
      wrong: "sub<VF_HW>3" and "ior_not<VT>3". Fortunately it never had any effect.
      
      gcc/ChangeLog:
      
      2020-04-02  Andreas Krebbel  <krebbel@linux.ibm.com>
      
      	* config/s390/vector.md ("<ti*>add<mode>3", "mul<mode>3")
      	("and<mode>3", "notand<mode>3", "ior<mode>3", "ior_not<mode>3")
      	("xor<mode>3", "notxor<mode>3", "smin<mode>3", "smax<mode>3")
      	("umin<mode>3", "umax<mode>3", "vec_widen_smult_even_<mode>")
      	("vec_widen_umult_even_<mode>", "vec_widen_smult_odd_<mode>")
      	("vec_widen_umult_odd_<mode>", "add<mode>3", "sub<mode>3")
      	("mul<mode>3", "fma<mode>4", "fms<mode>4", "neg_fma<mode>4")
      	("neg_fms<mode>4", "*smax<mode>3_vxe", "*smaxv2df3_vx")
      	("*smin<mode>3_vxe", "*sminv2df3_vx"): Remove % constraint
      	modifier.
      	("vec_widen_umult_lo_<mode>", "vec_widen_umult_hi_<mode>")
      	("vec_widen_smult_lo_<mode>", "vec_widen_smult_hi_<mode>"):
      	Remove constraints from expander.
      	* config/s390/vx-builtins.md ("vacc<bhfgq>_<mode>", "vacq")
      	("vacccq", "vec_avg<mode>", "vec_avgu<mode>", "vec_vmal<mode>")
      	("vec_vmah<mode>", "vec_vmalh<mode>", "vec_vmae<mode>")
      	("vec_vmale<mode>", "vec_vmao<mode>", "vec_vmalo<mode>")
      	("vec_smulh<mode>", "vec_umulh<mode>", "vec_nor<mode>3")
      	("vfmin<mode>", "vfmax<mode>"): Remove % constraint modifier.
      Andreas Krebbel committed
    • fortran : ICE in gfc_resolve_findloc PR93498 · 2c54eab5
      ICE occurs when findloc is used with character arguments of different
      kinds.  If the character kinds are different reject the code.
      
      Original patch provided by Steven G. Kargl  <kargl@gcc.gnu.org>.
      
      gcc/fortran/ChangeLog:
      
      	PR fortran/93498
      	* check.c (gfc_check_findloc):  If the kinds of the arguments
      	differ goto label "incompat".
      
      gcc/testsuite/ChangeLog:
      
      	PR fortran/93498
      	* gfortran.dg/pr93498_1.f90:  New test.
      	* gfortran.dg/pr93498_2.f90:  New test.
      Mark Eggleston committed
    • fortran: ICE equivalence with an element of an array PR94030 · bf1f6d88
      Deferred size arrays can not be used in equivalance statements.
      
      gcc/fortran/ChangeLog:
      
      	PR fortran/94030
      	* resolve.c (resolve_equivalence): Correct formatting
      	around the label "identical_types".  Instead of using
      	gfc_resolve_array_spec use is_non_constants_shape_array
      	to determine whether the array can be used in a in an
      	equivalence statement.
      
      gcc/testsuite/ChangeLog:
      
      	PR fortran/94030
      	* gfortran.dg/pr94030_1.f90
      	* gfortran.dg/pr94030_2.f90
      Mark Eggleston committed
    • Daily bump. · 25839b6a
      GCC Administrator committed
  3. 01 Apr, 2020 10 commits
    • d: Fix new tests gdc.dg/pr93038.d and gdc.dg/pr93038b.d in r10-7320 fail · 918b89b7
      The scan-file match is likely too strict to always succeed, so instead
      have split it up into a set of smaller matches.
      
      gcc/testsuite/ChangeLog:
      
      	PR d/94315
      	* gdc.dg/pr93038.d: Split dg-final into multiple tests.
      	* gdc.dg/pr93038b.d: Likewise.
      Iain Buclaw committed
    • d: Fix gdc.dg/pr92216.d FAILs on 32-bit targets · fb25041e
      The symbol being scanned for only matched on 64-bit targets.
      
      gcc/testsuite/ChangeLog:
      
      	PR d/94321
      	* gdc.dg/pr92216.d: Update to work on targets with 16 or 32-bit
      	pointers.
      Iain Buclaw committed
    • libstdc++: Move "free books" list from fsf.org to gnu.org · 6c557ba5
      	* doc/xml/manual/appendix_free.xml: Move "free books" list from
      	fsf.org to gnu.org.
      	* doc/html/manual/appendix_free.html: Regenerate.
      Gerald Pfeifer committed
    • analyzer: handle compound assignments [PR94378] · a96f1c38
      PR analyzer/94378 reports a false -Wanalyzer-malloc-leak
      when returning a struct containing a malloc-ed pointer.
      
      The issue is that the assignment code was not handling
      compound copies, only copying top-level values from region to region,
      and not copying child values.
      
      This patch introduces a region_model::copy_region function, using
      it for assignments and when analyzing function return values.
      It recursively copies nested values within structs, unions, and
      arrays, fixing the bug.
      
      gcc/analyzer/ChangeLog:
      	PR analyzer/94378
      	* checker-path.cc: Include "bitmap.h".
      	* constraint-manager.cc: Likewise.
      	* diagnostic-manager.cc: Likewise.
      	* engine.cc: Likewise.
      	(exploded_node::detect_leaks): Pass null region_id to pop_frame.
      	* program-point.cc: Include "bitmap.h".
      	* program-state.cc: Likewise.
      	* region-model.cc (id_set<region_id>::id_set): Convert to...
      	(region_id_set::region_id_set): ...this.
      	(svalue_id_set::svalue_id_set): New ctor.
      	(region_model::copy_region): New function.
      	(region_model::copy_struct_region): New function.
      	(region_model::copy_union_region): New function.
      	(region_model::copy_array_region): New function.
      	(stack_region::pop_frame): Drop return value.  Add
      	"result_dst_rid" param; if it is non-null, use copy_region to copy
      	the result to it.  Rather than capture and pass a single "known
      	used" return value to be used by purge_unused_values, instead
      	gather and pass a set of known used return values.
      	(root_region::pop_frame): Drop return value.  Add "result_dst_rid"
      	param.
      	(region_model::on_assignment): Use copy_region.
      	(region_model::on_return): Likewise for the result.
      	(region_model::on_longjmp): Pass null for pop_frame's
      	result_dst_rid.
      	(region_model::update_for_return_superedge): Pass the region for the
      	return value of the call, if any, to pop_frame, rather than setting
      	the lvalue for the lhs of the result.
      	(region_model::pop_frame): Drop return value.  Add
      	"result_dst_rid" param.
      	(region_model::purge_unused_svalues): Convert third param from an
      	svalue_id * to an svalue_id_set *, updating the initial populating
      	of the "used" bitmap accordingly.  Don't remap it when done.
      	(struct selftest::coord_test): New selftest fixture, extracted from...
      	(selftest::test_dump_2): ...here.
      	(selftest::test_compound_assignment): New selftest.
      	(selftest::test_stack_frames): Pass null to new param of pop_frame.
      	(selftest::analyzer_region_model_cc_tests): Call the new selftest.
      	* region-model.h (class id_set): Delete template.
      	(class region_id_set): Reimplement, using old id_set implementation.
      	(class svalue_id_set): Likewise.  Convert from auto_sbitmap to
      	auto_bitmap.
      	(region::get_active_view): New accessor.
      	(stack_region::pop_frame): Drop return value.  Add
      	"result_dst_rid" param.
      	(root_region::pop_frame): Likewise.
      	(region_model::pop_frame): Likewise.
      	(region_model::copy_region): New decl.
      	(region_model::purge_unused_svalues): Convert third param from an
      	svalue_id * to an svalue_id_set *.
      	(region_model::copy_struct_region): New decl.
      	(region_model::copy_union_region): New decl.
      	(region_model::copy_array_region): New decl.
      
      gcc/testsuite/ChangeLog:
      	PR analyzer/94378
      	* gcc.dg/analyzer/compound-assignment-1.c: New test.
      	* gcc.dg/analyzer/compound-assignment-2.c: New test.
      	* gcc.dg/analyzer/compound-assignment-3.c: New test.
      David Malcolm committed
    • subreg: Fix PR94123, SVN r273240 causes gcc.target/powerpc/pr87507.c to fail · 7546463b
      Segher's patch that added -fsplit-wide-types-early and enabled by default
      for rs6000, caused pr87507.c to FAIL because when running lower-subreg
      earlier, we don't see any pseudo-to-pseudo copies of our wide type,
      which are created by combine, therefore, we skip decomposing our TImode
      accesses.  The fix here is just to always run the third pass of lower-subreg
      instead of disabling it if we ran the second pass.
      
      2020-04-01  Peter Bergner  <bergner@linux.ibm.com>
      
      	PR rtl-optimization/94123
      	* lower-subreg.c (pass_lower_subreg3::gate): Remove test for
      	flag_split_wide_types_early.
      Peter Bergner committed
    • doc: Fix typo · b60bd122
      2020-04-01  Joerg Sonnenberger  <joerg@bec.de>
      
      	* doc/extend.texi (Common Function Attributes): Fix typo.
      Joerg Sonnenberger committed
    • doc: Fix a typo in the documentation of the copy attribute · dd5da571
      2020-04-01  Zackery Spytz  <zspytz@gmail.com>
      
      gcc/
      	* doc/extend.texi: Fix a typo in the documentation of the
      	copy function attribute.
      Zackery Spytz committed
    • rs6000: Make code questionably using r2 not ICE (PR94420) · 032f2366
      The example code in the PR uses r2 (the TOC register) directly.  In the
      RTL generated for that, r2 is copied to some pseudo, and then cprop
      propagates that into a "*tocref<mode>" insn, because nothing is
      preventing it from doing that.
      
      So, put the same condition in the insn condition for this as we will
      later encounter in the constraint anyway, fixing this.
      
      2020-04-01  Segher Boessenkool  <segher@kernel.crashing.org>
      
      	PR target/94420
      	* config/rs6000/rs6000.md (*tocref<mode> for P): Add insn condition
      	on operands[1].
      Segher Boessenkool committed
    • Add testcase for already fixed PR [PR94436] · e899d4b7
      2020-04-01  Jakub Jelinek  <jakub@redhat.com>
      
      	PR middle-end/94436
      	* gcc.dg/pr94436.c: New test.
      Jakub Jelinek committed