1. 01 Oct, 2019 35 commits
    • Support prefixes in diagnostic_show_locus · e9c9a142
      Previously, diagnostic_show_locus saved and restored the pretty_printer's
      prefix, clearing it for the duration of the call.
      
      I have a patch kit in development that can benefit from applying a prefix
      to the output of d_s_l, so this patch adds support to d_s_l for printing
      such prefixes.
      
      It moves the save and restore of the pp's prefix from d_s_l to all of its
      callers, and updates diagnostic-show-locus.c to properly handle prefixes.
      
      gcc/c-family/ChangeLog:
      	* c-opts.c (c_diagnostic_finalizer): Temporarily clear prefix when
      	calling diagnostic_show_locus, rather than destroying it afterwards.
      
      gcc/ChangeLog:
      	* diagnostic-show-locus.c (layout::print_gap_in_line_numbering):
      	Call pp_emit_prefix.
      	(layout::print_source_line): Likewise.
      	(layout::start_annotation_line): Likewise.
      	(diagnostic_show_locus): Remove call to temporarily clear the
      	prefix.
      	(selftest::test_one_liner_fixit_remove): Add test coverage for the
      	interaction of pp_set_prefix with rulers and fix-it hints.
      	* diagnostic.c (default_diagnostic_finalizer): Temporarily clear
      	prefix when calling diagnostic_show_locus, rather than destroying
      	it afterwards.
      	(print_parseable_fixits): Temporarily clear prefix.
      	* pretty-print.c (pp_format): Save and restore line_length, rather
      	than assuming it is zero.
      	(pp_output_formatted_text): Remove assertion that line_length is
      	zero.
      
      gcc/fortran/ChangeLog:
      	* error.c (gfc_diagnostic_starter): Clear the prefix before
      	calling diagnostic_show_locus.
      
      gcc/testsuite/ChangeLog:
      	* gcc.dg/plugin/diagnostic_group_plugin.c (test_begin_group_cb):
      	Clear the prefix before emitting the "END GROUP" line.
      	* gcc.dg/plugin/diagnostic_plugin_test_show_locus.c
      	(custom_diagnostic_finalizer): Temporarily clear prefix when
      	calling diagnostic_show_locus, rather than destroying it
      	afterwards.
      
      From-SVN: r276433
      David Malcolm committed
    • Make some new algorithms work in parallel mode · a16bc2f3
      	* include/experimental/algorithm (experimental::sample): Qualify call
      	to __sample correctly.
      	* include/parallel/algo.h (sample, for_each_n): Add using-declarations
      	for algorithms that don't have parallel implementations.
      
      From-SVN: r276432
      Jonathan Wakely committed
    • Make some parallel mode algorithms usable in constexpr contexts · e12097ed
      This makes the __parallel::equal and __parallel:lexicographical_compare
      algorithms usable in constant expressions, by dispatching to the
      sequential algorithm when calling during constant evaluation.
      
      	* include/parallel/algobase.h (equal, lexicographical_compare): Add
      	_GLIBCXX20_CONSTEXPR and dispatch to sequential algorithm when being
      	constant evaluated.
      	* include/parallel/algorithmfwd.h (equal, lexicographical_compare):
      	Add _GLIBCXX20_CONSTEXPR.
      
      From-SVN: r276431
      Jonathan Wakely committed
    • Disable tests that aren't valid in parallel mode · 61e619b4
      Tests that depend on debug mode can't be tested in parallel mode.
      
      	* testsuite/17_intro/using_namespace_std_tr1_neg.cc: Skip test for
      	parallel mode.
      	* testsuite/20_util/hash/84998.cc: Likewise.
      	* testsuite/23_containers/deque/types/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/forward_list/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/list/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/map/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/multimap/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/multiset/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/set/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/23_containers/unordered_map/pmr_typedefs_debug.cc:
      	Likewise.
      	* testsuite/23_containers/unordered_multimap/pmr_typedefs_debug.cc:
      	Likewise.
      	* testsuite/23_containers/unordered_multiset/pmr_typedefs_debug.cc:
      	Likewise.
      	* testsuite/23_containers/unordered_set/pmr_typedefs_debug.cc:
      	Likewise.
      	* testsuite/23_containers/vector/cons/destructible_debug_neg.cc:
      	Likewise.
      	* testsuite/23_containers/vector/types/pmr_typedefs_debug.cc: Likewise.
      	* testsuite/25_algorithms/binary_search/partitioned.cc: Likewise.
      	* testsuite/25_algorithms/copy/86658.cc: Likewise.
      	* testsuite/25_algorithms/equal_range/partitioned.cc: Likewise.
      	* testsuite/25_algorithms/lexicographical_compare/71545.cc: Likewise.
      	* testsuite/25_algorithms/lower_bound/partitioned.cc: Likewise.
      	* testsuite/25_algorithms/upper_bound/partitioned.cc: Likewise.
      
      From-SVN: r276430
      Jonathan Wakely committed
    • Fix non-reserved names in Parallel Mode headers · 57766351
      	* include/parallel/algo.h: Replace non-reserved names.
      	* include/parallel/multiway_merge.h: Likewise.
      	* include/parallel/multiway_mergesort.h: Likewise.
      	* include/parallel/numericfwd.h: Likewise.
      	* testsuite/17_intro/names.cc: Add RAI to test macros.
      
      From-SVN: r276429
      Jonathan Wakely committed
    • Regenerate `liboffloadmic/plugin/configure' for r275564 ("[ARM/FDPIC v6 02/24] [ARM] FDPIC... · 43a0ea77
      Regenerate `liboffloadmic/plugin/configure' for r275564 ("[ARM/FDPIC v6
      02/24] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure
      scripts") too.
      
      	liboffloadmic/
      	* plugin/configure: Regenerate.
      
      From-SVN: r276428
      Maciej W. Rozycki committed
    • tree-ssa-alias.c (nonoverlapping_component_refs_since_match_p): Rename to ... · ede31f6f
      
      	* tree-ssa-alias.c (nonoverlapping_component_refs_since_match_p):
      	Rename to ...
      	(nonoverlapping_refs_since_match_p): ... this; handle also
      	ARRAY_REFs.
      	(alias_stats): Update stats.
      	(dump_alias_stats): Likewise.
      	(cheap_array_ref_low_bound): New function.
      	(aliasing_matching_component_refs_p): Add partial_overlap
      	argument;
      	pass it to nonoverlapping_refs_since_match_p.
      	(aliasing_component_refs_walk): Update call of
      	aliasing_matching_component_refs_p
      	(nonoverlapping_array_refs_p): New function.
      	(decl_refs_may_alias_p, indirect_ref_may_alias_decl_p,
      	indirect_refs_may_alias_p): Update calls of
      	nonoverlapping_refs_since_match_p.
      
      	* gcc.dg/tree-ssa/alias-access-path-10.c: New testcase.
      	* gcc.dg/tree-ssa/alias-access-path-11.c: New testcase.
      
      From-SVN: r276427
      Jan Hubicka committed
    • re PR target/85401 (segfault building code for VAX) · 11f2ce1f
      	PR target/85401
      	* ira-color.c (allocno_copy_cost_saving): Call
      	ira_init_register_move_cost_if_necessary.
      
      From-SVN: r276426
      Maya Rashish committed
    • libada: Respect `--enable-version-specific-runtime-libs' · 13681906
      Respect the `--enable-version-specific-runtime-libs' configuration
      option in libada/, so that shared gnatlib libraries will be installed
      in non-version-specific $(toolexeclibdir) if requested.  In a
      cross-compilation environment this helps setting up a consistent
      sysroot, which can then be shared between the host and the target
      system.
      
      This lets one have `libgnarl-10.so' and `libgnat-10.so' installed in say
      /usr/lib and /usr/$(target_alias)/lib for a native and a cross-build
      respectively, rather than in /usr/lib/gcc/$(target_alias)/10.0.0/adalib.
      
      Update the settings of $(toolexecdir) and $(toolexeclibdir), unused till
      now, to keep the current arrangement in the version-specific case and
      make the new option to be enabled by default, unlike with the other
      target libraries, so as to keep existing people's build infrastructure
      unaffected.
      
      Of course if someone does use `--disable-version-specific-runtime-libs'
      already, then the installation location of shared gnatlib libraries will
      change, but presumably this is what they do want anyway as the current
      situation where the option is ignored in libada/ only is an anomaly
      really rather than one that is expected or desired.
      
      	gcc/ada/
      	* gcc-interface/Makefile.in (ADA_RTL_DSO_DIR): New variable.
      	(install-gnatlib): Use it in place of ADA_RTL_OBJ_DIR for shared
      	library installation.
      
      	libada/
      	* Makefile.in (toolexecdir, toolexeclibdir): New variables.
      	(LIBADA_FLAGS_TO_PASS): Add `toolexeclibdir'.
      	* configure.ac: Add `--enable-version-specific-runtime-libs'.
      	Update version-specific `toolexecdir' and `toolexeclibdir' from
      	ADA_RTL_OBJ_DIR from gcc/ada/gcc-interface/Makefile.in.
      	* configure: Regenerate.
      
      From-SVN: r276424
      Maciej W. Rozycki committed
    • libada: Remove racy duplicate gnatlib installation · 8951374d
      For some reason, presumably historical, the `install-gnatlib' target for
      the default multilib is invoked twice, once via the `ada.install-common'
      target in `gcc/ada/gcc-interface/Make-lang.in' invoked from gcc/ and
      again via the `install-libada' target in libada/.
      
      Apart from doing the same twice this is actually harmful in sufficiently
      parallelized `make' invocation, as the removal of old files performed
      within the `install-gnatlib' recipe in the former case actually races
      with the installation of new files done in the latter case, causing the
      recipe to fail and abort, however non-fatally, having not completed the
      installation of all the built files needed for the newly-built compiler
      to work correctly.
      
      This can be observed with a native `x86_64-linux-gnu' bootstrap:
      
      make[4]: Entering directory '.../gcc/ada'
      rm -rf .../lib/gcc/x86_64-linux-gnu/10.0.0/adalib
      rm: cannot remove '.../lib/gcc/x86_64-linux-gnu/10.0.0/adalib': Directory not empty
      make[4]: *** [gcc-interface/Makefile:512: install-gnatlib] Error 1
      make[4]: Leaving directory '.../gcc/ada'
      make[3]: *** [.../gcc/ada/gcc-interface/Make-lang.in:853: install-gnatlib] Error 2
      make[2]: [.../gcc/ada/gcc-interface/Make-lang.in:829: ada.install-common] Error 2 (ignored)
      
      which then causes missing files to be reported when an attempt is made
      to use the newly-installed non-functional compiler to build a
      `riscv-linux-gnu' cross-compiler:
      
      (cd ada/bldtools/sinfo; gnatmake -q xsinfo ; ./xsinfo sinfo.h )
      error: "ada.ali" not found, "ada.ads" must be compiled
      error: "s-memory.ali" not found, "s-memory.adb" must be compiled
      gnatmake: *** bind failed.
      /bin/sh: ./xsinfo: No such file or directory
      make[2]: *** [.../gcc/ada/Make-generated.in:45: ada/sinfo.h] Error 127
      make[2]: Leaving directory '.../gcc'
      make[1]: *** [Makefile:4369: all-gcc] Error 2
      make[1]: Leaving directory '...'
      make: *** [Makefile:965: all] Error 2
      
      Depending on timing `.../lib/gcc/x86_64-linux-gnu/10.0.0/adainclude' may
      cause an installation failure instead and the resulting compiler may be
      non-functional in a different way.
      
      Only invoke `install-gnatlib' from within gcc/ then if a legacy build
      process is being used with libada disabled and gnatlib built manually
      with `make -C gcc gnatlib'.
      
      	gcc/
      	* Makefile.in (gnat_install_lib): New variable.
      	* configure.ac: Substitute it.
      	* configure: Regenerate.
      
      	gcc/ada/
      	* gcc-interface/Make-lang.in (ada.install-common): Split into...
      	(gnat-install-tools, gnat-install-lib): ... these.
      
      From-SVN: r276422
      Maciej W. Rozycki committed
    • re PR c++/91222 (507.cactuBSSN_r build fails in warn_types_mismatch at… · 56f1a16c
      re PR c++/91222 (507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571)
      
      	PR lto/91222
      	* ipa-devirt.c (warn_types_mismatch): Do not ICE when anonymous type
      	is matched with non-C++ type
      	* g++.dg/lto/odr-6_0.C: New testcase.
      	* g++.dg/lto/odr-6_1.c: New testcase.
      
      From-SVN: r276420
      Jan Hubicka committed
    • ssa-thread-12.c: Fix warning introduced by my previous change. · a9346b55
      
      	* gcc.dg/tree-ssa/ssa-thread-12.c: Fix warning introduced by my
      	previous change.
      
      From-SVN: r276418
      Jan Hubicka committed
    • tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce after local CSE. · f30b3d28
      2019-10-01  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>
      
      	* tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce
      	after local CSE.
      
      From-SVN: r276417
      Prathamesh Kulkarni committed
    • invoke.texi (early-inlining-insns-O2): Document. · 0b92cf30
      
      	* doc/invoke.texi (early-inlining-insns-O2): Document.
      	(early-inlining-insns): Update.
      	* params.def (early-inlining-insns-O2): New bound.
      	(early-inlining-insns): Update docs.
      	* ipa-inline.c (want_early_inline_function_p): Use new bound.
      
      	* g++.dg/tree-ssa/pr61034.C: Set early-inlining-insns-O2=14.
      	* g++.dg/tree-ssa/pr8781.C: Likewise.
      	* g++.dg/warn/Wstringop-truncation-1.C: Likewise.
      	* gcc.dg/ipa/pr63416.c: likewise.
      	* gcc.dg/vect/pr66142.c: Likewise.
      	* gcc.dg/tree-ssa/ssa-thread-12.c: Mark compure_idf inline.
      
      From-SVN: r276416
      Jan Hubicka committed
    • re PR c++/91925 (-fpack-struct causes a decltype with template to ICE) · 7552c36a
      	PR c++/91925
      	* c-warn.c (check_alignment_of_packed_member): Ignore FIELD_DECLs
      	with NULL DECL_FIELD_OFFSET.
      
      	* g++.dg/conversion/packed2.C: New test.
      
      From-SVN: r276415
      Jakub Jelinek committed
    • re PR c++/88562 (Incorrect pointer incrementing on SH4) · 04bf300e
      gcc/
      2019-10-01  Oleg Endo  <olegendo@gcc.gnu.org>
      
      	PR target/88562
      	* config/sh/sh.c (sh_extending_set_of_reg::use_as_extended_reg): Use
      	sh_check_add_incdec_notes to preserve REG_INC notes when replacing
      	a memory access insn.
      
      From-SVN: r276411
      Oleg Endo committed
    • rs6000-p8swap.c (rtx_is_swappable_p): Don't swap vpmsumd. · 2a2592a1
      [gcc]
      
      2019-10-01  Bill Schmidt  <wschmidt@linux.ibm.com>
      
      	* config/rs6000/rs6000-p8swap.c (rtx_is_swappable_p): Don't swap
      	vpmsumd.
      
      [gcc/testsuite]
      
      2019-10-01  Bill Schmidt  <wschmdit@linux.ibm.com>
      
      	* gcc.target/powerpc/pr91275.c: New.
      
      From-SVN: r276410
      William Schmidt committed
    • S/390: Remove code duplication in vec_* comparison expanders · a1bfb5b1
      s390.md uses a lot of near-identical expanders that perform dispatching
      to other expanders based on operand types. Since the following patch
      would require even more of these, avoid copy-pasting the code by
      generating these expanders using an iterator.
      
      gcc/ChangeLog:
      
      2019-10-01  Ilya Leoshkevich  <iii@linux.ibm.com>
      
      	PR target/77918
      	* config/s390/s390.c (s390_expand_vec_compare): Use
      	gen_vec_cmpordered and gen_vec_cmpunordered.
      	* config/s390/vector.md (vec_cmpuneq, vec_cmpltgt, vec_ordered,
      	vec_unordered): Delete.
      	(vec_ordered<mode>): Rename to vec_cmpordered<mode>.
      	(vec_unordered<mode>): Rename to vec_cmpunordered<mode>.
      	(VEC_CMP_EXPAND): New iterator for the generic dispatcher.
      	(vec_cmp<code>): Generic dispatcher.
      
      From-SVN: r276409
      Ilya Leoshkevich committed
    • S/390: Implement vcond expander for V1TI,V1TF · b4363c5a
      Currently gcc does not emit wf{c,k}* instructions when comparing long
      double values.  Middle-end actually adds them in the first place, but
      then veclower pass replaces them with floating point register pair
      operations, because the corresponding expander is missing.
      
      gcc/ChangeLog:
      
      2019-10-01  Ilya Leoshkevich  <iii@linux.ibm.com>
      
      	PR target/77918
      	* config/s390/vector.md (V_HW): Add V1TI in order to make
      	vcond$a$b generate vcondv1tiv1tf.
      
      From-SVN: r276408
      Ilya Leoshkevich committed
    • Fix reload after function-abi patches (PR91948) · 3366b378
      The code was passing a pseudo rather than its allocated hard reg
      to ira_need_caller_save_p.  Running under valgrind to reproduce
      the failure also showed that ALLOCNO_CROSSED_CALLS_ABIS wasn't
      being explicitly initialised.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	PR rtl-optimization/91948
      	* ira-build.c (ira_create_allocno): Initialize
      	ALLOCNO_CROSSED_CALLS_ABIS.
      	* ira-color.c (allocno_reload_assign): Pass hard_regno rather
      	than regno to ira_need_caller_save_p.
      
      From-SVN: r276407
      Richard Sandiford committed
    • recompute opt flags after opt level change · 6bc89193
      flag_omit_frame_pointer is set in machine-independent code depending
      on the optimization level.  It is then overridden in x86
      target-specific code depending on a macro defined by
      --enable-frame-pointer.
      
      Uses of attribute optimize go through machine-independent overriding
      of flag_omit_frame_pointer, but the x86-specific overriding code did
      NOT cover this flag, so, even if the attribute does not change the
      optimization level, flag_omit_frame_pointer may end up with a
      different value, and prevent inlining because of incompatible flags,
      as detected by the gcc.dg/ipa/iinline-attr.c test on an
      --enable-frame-pointer x86 toolchain.
      
      
      for  gcc/ChangeLog
      
      	* config/i386/i386-options.c
      	(ix86_recompute_optlev_based_flags): New, moved out of...
      	(ix86_option_override_internal): ... this.  Call it.
      	(ix86_override_options_after_change): Call it here too.
      
      From-SVN: r276405
      Alexandre Oliva committed
    • Store float for pow result test · 676e38c2
      Optimizing gcc.dg/torture/pr41094.c, the compiler computes the
      constant value and short-circuits the whole thing.  At -O0, however,
      on 32-bit x86, the call to pow() remains, and the program compares the
      returned value in a stack register, with excess precision, with the
      exact return value expected from pow().  If libm's pow() returns a
      slightly off result, the compare fails.  If the value in the register
      is stored in a separate variable, so it gets rounded to double
      precision, and then compared, the compare passes.
      
      It's not clear that the test was meant to detect libm's reliance on
      rounding off the excess precision, but I guess it wasn't, so I propose
      this slight change that enables it to pass regardless of the slight
      inaccuracy of the C library in use.
      
      
      for  gcc/testsuite/ChangeLog
      
      	* gcc.dg/torture/pr41094.c: Introduce intermediate variable.
      
      From-SVN: r276404
      Alexandre Oliva committed
    • DWARF array bounds missing from C++ array definitions · 31632e2c
      A variable redeclaration or definition that provides additional type
      information for it, e.g. outermost array bounds, is not reflected in
      the debug information for the variable.  With this patch, the debug
      info of the variable specialization gets a type attribute with the
      adjusted type.
      
      This patch affects mostly only array bounds.  However, when the
      symbolic type used in a declaration and in a definition are different,
      although they refer to the same type, debug information will end up
      (correctly?) naming different symbolic types in the specification and
      the definition.  Also, when a readonly declaration of an array loses
      the readonly flag at the definition because of the initializer, the
      definition may end up referencing a type while the specification
      refers to a const-qualified version of that type.  If the type of the
      variable is already const-qualified, e.g. an array of a const type,
      the difference is meaningless.
      
      
      for  gcc/ChangeLog
      
      	PR debug/91507
      	* dwarf2out.c (override_type_for_decl_p): New.
      	(gen_variable_die): Use it.
      
      for  gcc/testsuite/ChangeLog
      
      	PR debug/91507
      	* gcc.dg/debug/dwarf2/array-0.c: New.
      	* gcc.dg/debug/dwarf2/array-1.c: New.
      	* gcc.dg/debug/dwarf2/array-2.c: New.
      	* gcc.dg/debug/dwarf2/array-3.c: New.
      	* g++.dg/debug/dwarf2/array-0.C: New.
      	* g++.dg/debug/dwarf2/array-1.C: New.
      	* g++.dg/debug/dwarf2/array-2.C: New.  Based on libstdc++-v3's
      	src/c++98/pool_allocator.cc:__pool_alloc_base::_S_heap_size.
      	* g++.dg/debug/dwarf2/array-3.C: New.  Based on
      	gcc's config/i386/i386-features.c:xlogue_layout::s_instances.
      	* g++.dg/debug/dwarf2/array-4.C: New.
      
      From-SVN: r276403
      Alexandre Oliva committed
    • tree-vect-loop.c (vectorizable_reduction): Move variables to where they are used. · c7ea76ea
      2019-10-01  Richard Biener  <rguenther@suse.de>
      
      	* tree-vect-loop.c (vectorizable_reduction): Move variables
      	to where they are used.
      
      From-SVN: r276402
      Richard Biener committed
    • regrename: Use PC instead of CC0 to hide operands · 58e721d2
      The regrename pass temporarily changes some operand RTL to CC0 so that
      note_stores and scan_rtx don't see those operands.  CC0 is deprecated
      and we want to remove it, so we need to use something else here.
      PC fits the bill fine.
      
      
      	* regrename.c (hide_operands): Use pc_rtx instead of cc0_rtx.
      	(build_def_use): Use PC instead of CC0 in a comment.
      
      From-SVN: r276401
      Segher Boessenkool committed
    • Add myself to MAINTAINERS file · 4d07a2ec
      2019-10-01  Frederik Harwath <frederik@codesourcery.com>
      
      	 * MAINTAINERS: Add myself to Write After Approval
      
      From-SVN: r276396
      Frederik Harwath committed
    • [C] Avoid aka types that just add tags · 55879815
      diag-aka-1.c tests that:
      
        struct T { int i; } T;
        void *a;
        T *t = a;
      
      produces:
      
        request for implicit conversion from 'void *' to 'T *' {aka 'struct T *'} ...
      
      But printing an aka for the tag seems a bit redundant when the tag name
      is the same as the typedef name.  It's probably not going to be telling
      the user anything they don't already know, and can be distracting if "T"
      rather than "struct T" is the preferred choice for an exported interface.
      This is even more true if the tag is anonymous; e.g.:
      
        struct { int i; } T;
        void *a;
        T *t = a;
      
      gives:
      
        request for implicit conversion from 'void *' to 'T *' {aka 'struct <anonymous> *'}
      
      Rather than just drop the test above, the patch instead tests for:
      
        struct T { int i; } *T;
      
      where seeing the tag definitely helps.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/c/
      	* c-objc-common.c (useful_aka_type_p): New function.
      	(print_type): Use it to decide whether an aka type is worth printing.
      
      gcc/testsuite/
      	* gcc.dg/diag-aka-1.c (T): Turn into a pointer typedef.
      	(foo): Update accordingly.
      	* gcc.dg/diag-aka-4.c: New test.
      
      From-SVN: r276395
      Richard Sandiford committed
    • [C] Improve diagnostics for vector types · 8209db25
      Given the following invalid arm_neon.h-based code:
      
        float x;
        int8x8_t y = x;
      
      the error message we emit is pretty good:
      
        incompatible types when initializing type 'int8x8_t' using type 'float'
      
      But convert the types to pointers:
      
        int8x8_t *ptr = &x;
      
      and the message becomes:
      
        initialization of '__vector(8) signed char *' from incompatible pointer type 'float *'
      
      Although it's reasonably obvious what '__vector(8) signed char *' means,
      it isn't valid C or C++ syntax and is quite far from what the user wrote,
      so using 'int8x8_t *' would be better.
      
      This patch therefore prints the type name of vectors that have one.
      It's still OK to print the __vector syntax as an "aka", although I have
      a follow-on patch to tweak this slightly for types defined in system
      header files.  The follow-on patch also addresses the ??? in
      gcc.target/aarch64/diag_aka_1.c.
      
      The C++ test already passed, but it seemed worth including for
      consistency.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/c-family/
      	* c-pretty-print.c (pp_c_specifier_qualifier_list): If a vector type
      	has a type name, use it in preference to the __vector syntax.
      
      gcc/testsuite/
      	* gcc.dg/diag-aka-3.c: New test.
      	* gcc.target/aarch64/diag_aka_1.c: New test.
      	* g++.dg/diagnostic/aka4.C: New test.
      
      From-SVN: r276394
      Richard Sandiford committed
    • Remove clobber_high · 17d184e5
      The AArch64 SVE tlsdesc patterns were the main motivating reason
      for clobber_high.  It's no longer needed now that the patterns use
      calls instead.
      
      At the time, one of the possible future uses for clobber_high was for
      asm statements.  However, the current code wouldn't handle that case
      without modification, so I think we might as well remove it for now.
      We can always reapply it in future if it turns out to be useful again.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	* rtl.def (CLOBBER_HIGH): Delete.
      	* doc/rtl.texi (clobber_high): Remove documentation.
      	* rtl.h (SET_DEST): Remove CLOBBER_HIGH from the list of codes.
      	(reg_is_clobbered_by_clobber_high): Delete.
      	(gen_hard_reg_clobber_high): Likewise.
      	* alias.c (record_set): Remove CLOBBER_HIGH handling.
      	* cfgexpand.c (expand_gimple_stmt): Likewise.
      	* combine-stack-adj.c (single_set_for_csa): Likewise.
      	* combine.c (find_single_use_1, set_nonzero_bits_and_sign_copies)
      	(can_combine_p, is_parallel_of_n_reg_sets, try_combine)
      	(record_dead_and_set_regs_1, reg_dead_at_p_1): Likewise.
      	* cse.c (invalidate_reg): Remove clobber_high parameter.
      	(invalidate): Update call accordingly.
      	(canonicalize_insn): Remove CLOBBER_HIGH handling.
      	(invalidate_from_clobbers, invalidate_from_sets_and_clobbers)
      	(count_reg_usage, insn_live_p): Likewise.
      	* cselib.h (cselib_invalidate_rtx): Remove sett argument.
      	* cselib.c (cselib_invalidate_regno, cselib_invalidate_rtx): Likewise.
      	(cselib_invalidate_rtx_note_stores): Update call accordingly.
      	(cselib_expand_value_rtx_1): Remove CLOBBER_HIGH handling.
      	(cselib_invalidate_regno, cselib_process_insn): Likewise.
      	* dce.c (deletable_insn_p, mark_nonreg_stores_1): Likewise.
      	(mark_nonreg_stores_2): Likewise.
      	* df-scan.c (df_find_hard_reg_defs, df_uses_record): Likewise.
      	(df_get_call_refs): Likewise.
      	* dwarf2out.c (mem_loc_descriptor): Likewise.
      	* emit-rtl.c (verify_rtx_sharing): Likewise.
      	(copy_insn_1, copy_rtx_if_shared_1): Likewise.
      	(hard_reg_clobbers_high, gen_hard_reg_clobber_high): Delete.
      	* genconfig.c (walk_insn_part): Remove CLOBBER_HIGH handling.
      	* genemit.c (gen_exp, gen_insn): Likewise.
      	* genrecog.c (validate_pattern, remove_clobbers): Likewise.
      	* haifa-sched.c (haifa_classify_rtx): Likewise.
      	* ira-build.c (create_insn_allocnos): Likewise.
      	* ira-costs.c (scan_one_insn): Likewise.
      	* ira.c (equiv_init_movable_p, memref_referenced_p): Likewise.
      	(rtx_moveable_p, interesting_dest_for_shprep): Likewise.
      	* jump.c (mark_jump_label_1): Likewise.
      	* lra-int.h (lra_insn_reg::clobber_high): Delete.
      	* lra-eliminations.c (lra_eliminate_regs_1): Remove CLOBBER_HIGH
      	handling.
      	(mark_not_eliminable): Likewise.
      	* lra-lives.c (process_bb_lives): Likewise.
      	* lra.c (new_insn_reg): Remove clobber_high parameter.
      	(collect_non_operand_hard_regs): Likewise.  Update call to new
      	insn_reg.  Remove CLOBBER_HIGH handling.
      	(lra_set_insn_recog_data): Remove CLOBBER_HIGH handling.  Update call
      	to collect_non_operand_hard_regs.
      	(add_regs_to_insn_regno_info): Remove CLOBBER_HIGH handling.
      	Update call to new_insn_reg.
      	(lra_update_insn_regno_info): Remove CLOBBER_HIGH handling.
      	* postreload.c (reload_cse_simplify, reload_combine_note_use)
      	(move2add_note_store): Likewise.
      	* print-rtl.c (print_pattern): Likewise.
      	* recog.c (store_data_bypass_p_1, store_data_bypass_p): Likewise.
      	(if_test_bypass_p): Likewise.
      	* regcprop.c (kill_clobbered_value, kill_set_value): Likewise.
      	* reginfo.c (reg_scan_mark_refs): Likewise.
      	* reload1.c (maybe_fix_stack_asms, eliminate_regs_1): Likewise.
      	(elimination_effects, mark_not_eliminable, scan_paradoxical_subregs)
      	(forget_old_reloads_1): Likewise.
      	* reorg.c (find_end_label, try_merge_delay_insns, redundant_insn)
      	(own_thread_p, fill_simple_delay_slots, fill_slots_from_thread)
      	(dbr_schedule): Likewise.
      	* resource.c (update_live_status, mark_referenced_resources)
      	(mark_set_resources): Likewise.
      	* rtl.c (copy_rtx): Likewise.
      	* rtlanal.c (reg_referenced_p, set_of_1, single_set_2, noop_move_p)
      	(note_pattern_stores): Likewise.
      	(reg_is_clobbered_by_clobber_high): Delete.
      	* sched-deps.c (sched_analyze_reg, sched_analyze_insn): Remove
      	CLOBBER_HIGH handling.
      
      From-SVN: r276393
      Richard Sandiford committed
    • [AArch64] Use calls for SVE TLSDESC · bb6ce448
      One (unintended) side effect of the patches to support multiple
      ABIs is that we can now represent tlsdesc calls as normal calls
      on SVE targets.  This is likely to be handled more efficiently than
      clobber_high, and for example fixes the long-standing failure in
      gcc.target/aarch64/sve/tls_preserve_1.c.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	PR target/91452
      	* config/aarch64/aarch64.h (ARM_PCS_TLSDESC): New arm_pcs.
      	* config/aarch64/aarch64-protos.h (aarch64_tlsdesc_abi_id): Declare.
      	* config/aarch64/aarch64.c (aarch64_hard_regno_call_part_clobbered):
      	Handle ARM_PCS_TLSDESC.
      	(aarch64_tlsdesc_abi_id): New function.
      	* config/aarch64/aarch64.md (tlsdesc_small_sve_<mode>): Use a call
      	rtx instead of a list of clobbers and clobber_highs.
      	(tlsdesc_small_<mode>): Update accordingly.
      
      From-SVN: r276392
      Richard Sandiford committed
    • [AArch64] Make call insns record the callee's arm_pcs · 08cc4d92
      At the moment we rely on SYMBOL_REF_DECL to get the ABI of the callee
      of a call insn, falling back to the default ABI if the decl isn't
      available.  I think it'd be cleaner to attach the ABI directly to the
      call instruction instead, which would also have the very minor benefit
      of handling indirect calls more efficiently.
      
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	* config/aarch64/aarch64-protos.h (aarch64_expand_call): Take an
      	extra callee_abi argument.
      	* config/aarch64/aarch64.c (aarch64_expand_call): Likewise.
      	Insert a CALLEE_ABI unspec into the call pattern as the second
      	element in the PARALLEL.
      	(aarch64_simd_call_p): Delete.
      	(aarch64_insn_callee_abi): Get the arm_pcs of the callee from
      	the new CALLEE_ABI element of the PARALLEL.
      	(aarch64_init_cumulative_args): Get the arm_pcs of the callee
      	from the function type, if given.
      	(aarch64_function_arg_advance): Handle ARM_PCS_SIMD.
      	(aarch64_function_arg): Likewise.  Return the arm_pcs of the callee
      	when passed the function_arg_info end marker.
      	(aarch64_output_mi_thunk): Pass the arm_pcs of the callee as the
      	final argument of gen_sibcall.
      	* config/aarch64/aarch64.md (UNSPEC_CALLEE_ABI): New unspec.
      	(call): Make operand 2 a const_int_operand and pass it to expand_call.
      	Wrap it in an UNSPEC_CALLEE_ABI unspec for the dummy define_expand
      	pattern.
      	(call_value): Likewise operand 3.
      	(sibcall): Likewise operand 2.  Place the unspec before rather than
      	after the return.
      	(sibcall_value): Likewise operand 3.
      	(*call_insn, *call_value_insn): Include an UNSPEC_CALLEE_ABI.
      	(tlsgd_small_<mode>, *tlsgd_small_<mode>): Likewise.
      	(*sibcall_insn, *sibcall_value_insn): Likewise.  Remove empty
      	constraint strings.
      	(untyped_call): Pass const0_rtx as the callee ABI to gen_call.
      
      gcc/testsuite/
      	* gcc.target/aarch64/torture/simd-abi-10.c: New test.
      	* gcc.target/aarch64/torture/simd-abi-11.c: Likewise.
      
      From-SVN: r276391
      Richard Sandiford committed
    • configure.ac: Remove GCC_HEADER_STDINT(gstdint.h). · 810f316d
      	* configure.ac: Remove GCC_HEADER_STDINT(gstdint.h).
      	* libgomp.h: Include <stdint.h> instead of "gstdint.h".
      	* oacc-parallel.c: Don't include "libgomp_g.h".
      	* plugin/plugin-hsa.c: Include <stdint.h> instead of "gstdint.h".
      	* plugin/plugin-nvptx.c: Don't include "gstdint.h".
      	* aclocal.m4: Regenerated.
      	* config.h.in: Regenerated.
      	* configure: Regenerated.
      	* Makefile.in: Regenerated.
      
      From-SVN: r276389
      Jakub Jelinek committed
    • Update remaining calls to choose_hard_reg_mode · ba8fa8da
      2019-10-01  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	* regs.h (HARD_REGNO_CALLER_SAVE_MODE): Update call to
      	choose_hard_reg_mode.
      	* config/sparc/sparc.h (HARD_REGNO_CALLER_SAVE_MODE): Likewise.
      
      From-SVN: r276388
      Richard Sandiford committed
    • doc/md.texi: Fix some typos · bd2d1b3d
      It says "size N/2" in a few places where "size S/2" is meant.
      
      
      	* doc/md.texi (vec_pack_trunc_@var{m}): Fix typo.
      	(vec_pack_sfix_trunc_@var{m}, vec_pack_ufix_trunc_@var{m}): Ditto.
      	(vec_packs_float_@var{m}, vec_packu_float_@var{m}): Ditto.
      
      From-SVN: r276387
      Segher Boessenkool committed
    • Daily bump. · c6db6fee
      From-SVN: r276386
      GCC Administrator committed
  2. 30 Sep, 2019 5 commits