- 04 Jan, 2013 17 commits
-
-
* config/v850/lib1funcs.S: Only provide CALLT support functions if the CALLT instruction is supported. From-SVN: r194898
Nick Clifton committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * sinfo.ads: Clean up order of N_xxx subtypes 2013-01-04 Vincent Celier <celier@adacore.com> * prj-conf.adb (Check_Target): Allow --autoconf= with no target. From-SVN: r194897
Arnaud Charlet committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * warnsw.adb: Minor fixes to -gnatw.d handling. 2013-01-04 Robert Dewar <dewar@adacore.com> * einfo.adb, atree.adb: Enlarge entities to make 63 more flags, 6 more fields. 2013-01-04 Joel Brobecker <brobecker@adacore.com brobecker> * gnat_ugn.texi: Fix typo. 2013-01-04 Robert Dewar <dewar@adacore.com> * gnat_rm.texi: Document alignment choice for subtypes. 2013-01-04 Robert Dewar <dewar@adacore.com> * validsw.ads: Minor fix to comment. 2013-01-04 Doug Rupp <rupp@adacore.com> * Makefile.rtl (GNATRTL_NONTASKING_OBJS, GNATRTL_ALTIVEC_OBJS): Factor g-al* objects. * gcc-interface/Makefile.in (ADA_EXCLUDE_SRCS): Add g-al* sources. (GNATRTL_ALTIVEC_OBJS): Override to null for VMS. Rename leon vxworks toolchain as leon-wrs-vxworks. * gcc-interface/Make-lang.in: Update dependencies 2013-01-04 Pascal Obry <obry@adacore.com> * prj.ads (For_Each_Source): Add Locally_Removed parameter. (Source_Iterator): Add Locally_Removed field. * prj.adb (For_Each_Source): Ignore Locally_Removed files if needed. (Next): Likewise. 2013-01-04 Robert Dewar <dewar@adacore.com> * exp_attr.adb: Minor reformatting. 2013-01-04 Robert Dewar <dewar@adacore.com> * checks.adb (Insert_Valid_Check): Fix handling of renamed packed array element. * exp_ch4.adb (Expand_Concatenate): Fix some missing parent fields in generated code. * exp_util.adb (Side_Effect_Free): Improve detection of cases needing renaming. 2013-01-04 Robert Dewar <dewar@adacore.com> * sinfo.ads: Clean up order of N_xxx subtypes 2013-01-04 Vincent Celier <celier@adacore.com> * prj-conf.adb (Check_Target): Allow --autoconf= with no target. From-SVN: r194896
Arnaud Charlet committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * types.ads, prj-conf.adb, par-tchk.adb: Minor reformatting. 2013-01-04 Robert Dewar <dewar@adacore.com> * par-ch6.adb (P_Subprogram): Better handling of missing IS after expression function. * par-util.adb (No_Constraint): Improve handling to avoid bad warnings. 2013-01-04 Robert Dewar <dewar@adacore.com> * exp_util.ads, exp_util.adb (Insert_Actions): In expression with actions case, new actions are appended to the sequence rather than prepended. 2013-01-04 Robert Dewar <dewar@adacore.com> * gnat_ugn.texi: Document -gnatw.d/w.D (does no apply in VMS mode). * usage.adb: Add lines for -gnatw.d/w.D switches. * warnsw.adb: Minor fixes (some missing cases of setting Warning_Doc_Switch). Reject -gnatw.d and -gnatw.D in VMS mode. From-SVN: r194895
Robert Dewar committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * exp_util.adb (Remove_Side_Effects): Make sure scope suppress is restored on exit. 2013-01-04 Robert Dewar <dewar@adacore.com> * usage.adb: Document -gnateF (check overflow for predefined Float). 2013-01-04 Robert Dewar <dewar@adacore.com> * sem_res.adb (Resolve_Type_Conversion): Remove incorrect prevention of call to Apply_Type_Conversion_Checks, which resulted in missing check flags in formal mode. 2013-01-04 Vincent Celier <celier@adacore.com> * makeutl.ads (Db_Switch_Args): New table used by gprbuild. * prj-conf.adb (Check_Builder_Switches): Check for switches --config= (Get_Db_Switches): New procedure to get the --db switches so that they are used when invoking gprconfig in auto-configuration. (Do_Autoconf): When invoking gprconfig, use the --db switches, if any. From-SVN: r194894
Arnaud Charlet committed -
2013-01-04 Pascal Obry <obry@adacore.com> * prj-nmsc.adb: Minor reformatting. 2013-01-04 Vincent Celier <celier@adacore.com> * makeutl.ads (Root_Environment): New variable, moved rom gprbuild (Load_Standard_Base): New Boolean variable, moved from gprbuild. * prj-conf.adb (Check_Builder_Switches): New procedure to check for switch --RTS in package Builder. If a runtime specified by --RTS is a relative path name, but not a base name, then find the path on the Project Search Path. (Do_Autoconf): Call Check_Builder_Switches. (Locate_Runtime): New procedure, moved from gprbuild, to get the absolute paths of runtimes when they are not specified as a base name. * prj-conf.ads (Locate_Runtime): New procedure, moved from gprbuild. From-SVN: r194893
Arnaud Charlet committed -
sem_ch3.adb (Build_Private_Derived_Type): Set Has_Private_Ancestor on type derived from an untagged private type whose... 2013-01-04 Ed Schonberg <schonberg@adacore.com> * sem_ch3.adb (Build_Private_Derived_Type): Set Has_Private_Ancestor on type derived from an untagged private type whose full view has discriminants * sem_aggr.adb (Resolve_Record_Aggregate): Reject non-extension aggregate for untagged record type with private ancestor. From-SVN: r194892
Ed Schonberg committed -
2013-01-04 Thomas Quinot <quinot@adacore.com> * sem_elab.adb, sem_ch3.adb: Minor reformatting. From-SVN: r194891
Thomas Quinot committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * table.adb: Minor reformatting. 2013-01-04 Ed Schonberg <schonberg@adacore.com> * sem_ch10.adb (Check_Redundant_Withs): A with_clause that does not come from source does not generate a warning for redundant with_clauses. 2013-01-04 Hristian Kirtchev <kirtchev@adacore.com> * aspects.adb, aspects.ads: Add Aspect_Global to all relevant tables. * par-prag.adb: Add pragma Global to the list of pragmas that do not need special processing by the parser. * sem_ch13.adb (Analyze_Aspect_Specifications): Convert aspect Global into a pragma without any form of legality checks. The work is done by Analyze_Pragma. The aspect and pragma are both marked as needing delayed processing. Insert the corresponding pragma of aspect Abstract_State in the visible declarations of the related package. (Check_Aspect_At_Freeze_Point): Aspect Global does not need processing even though it is marked as delayed. Alphabetize the list on aspect names. * sem_prag.adb: Add a value for pragma Global in table Sig_Flags. (Analyze_Pragma): Add ??? comment about the grammar of pragma Abstract_State. Move the error location from the pragma to the state to improve the quality of error placement. Add legality checks for pragma Global. * snames.ads-tmpl Add the following specially recognized names 2013-01-04 Eric Botcazou <ebotcazou@adacore.com> * sem_ch3.adb: Fix minor typo. 2013-01-04 Ed Schonberg <schonberg@adacore.com> * par-ch13.adb (Aspect_Specifications_Present): In Strict mode, accept an aspect name followed by a comma, indicating a defaulted boolean aspect. From-SVN: r194890
Arnaud Charlet committed -
* gnat_ugn.texi: Document procedure to codesign GDB on Darwin. Update doc on gnattest --separates switch. 2013-01-04 Thomas Quinot <quinot@adacore.com> * s-chepoo.ads: Minor reformatting. 2013-01-04 Arnaud Charlet <charlet@adacore.com> * usage.adb: Remove mention of -gnatN in usage. From-SVN: r194889
Arnaud Charlet committed -
2013-01-04 Robert Dewar <dewar@adacore.com> * exp_prag.adb, gnatcmd.adb, exp_util.adb, table.adb, sem_prag.adb, freeze.adb, sem_ch4.adb, sem_warn.adb, opt.ads, exp_aggr.adb, prj-conf.adb, sem_ch13.adb: Minor reformatting. From-SVN: r194888
Robert Dewar committed -
2013-01-04 Thomas Quinot <quinot@adacore.com> * sinfo.ads: Minor documentation update. 2013-01-04 Thomas Quinot <quinot@adacore.com> * sem_ch3.adb, einfo.adb (Analyze_Object_Declaration): Do not set Ekind before resolving initialization expression. 2013-01-04 Hristian Kirtchev <kirtchev@adacore.com> * checks.adb (Generate_Index_Checks): Delay the generation of the check for an indexed component where the prefix mentions Loop_Entry until the attribute has been properly expanded. * exp_ch5.adb (Expand_Loop_Entry_Attributes): Perform minor decoration of the constant that captures the value of Loop_Entry's prefix at the entry point into a loop. Generate index checks for an attribute reference that has been transformed into an indexed component. 2013-01-04 Thomas Quinot <quinot@adacore.com> * exp_prag.adb, exp_util.adb, exp_util.ads, freeze.adb, exp_aggr.adb, sem_ch13.adb (Exp_Aggr.Collect_Initialization_Statements): Nothing to do if Obj is already frozen. (Exp_Util.Find_Init_Call): Rename to... (Exp_Util.Remove_Init_Call): New subprogram, renamed from Find_Init_Call. Remove the initialization call from the enclosing list if found, and if it is from an Initialization_Statements attribute, reset it. (Exp_Util.Append_Freeze_Action): Minor code reorganization. (Exp_Util.Append_Freeze_Actions): Ensure a freeze node has been allocated (as is already done in Append_Freeze_Action). (Freeze.Freeze_Entity): For an object with captured Initialization_Statements and non-delayed freezeing, unwrap the initialization statements and insert and them directly in the enclosing list. (Sem_Ch13.Check_Address_Clause): For an object with Initialization_Statements and an address clause, unwrap the initialization statements when moving them to the freeze actions. From-SVN: r194887
Arnaud Charlet committed -
2014-01-04 Tobias Burnus <burnus@net-b.de> PR fortran/55763 * decl.c (gfc_match_null): Parse and reject MOLD. 2014-01-04 Tobias Burnus <burnus@net-b.de> PR fortran/55763 * gfortran.dg/null_7.f90: New. From-SVN: r194886
Tobias Burnus committed -
2013-01-03 Tobias Burnus <burnus@net-b.de> PR fortran/55854 PR fortran/55763 * class.c (gfc_class_null_initializer): Fix finding the vtab. (gfc_find_intrinsic_vtab): Use BT_VOID for some components. 2013-01-03 Tobias Burnus <burnus@net-b.de> PR fortran/55854 PR fortran/55763 * gfortran.dg/unlimited_polymorphic_3.f03: Remove invalid code. * gfortran.dg/unlimited_polymorphic_7.f90: New. * gfortran.dg/unlimited_polymorphic_8.f90: New. From-SVN: r194885
Tobias Burnus committed -
From-SVN: r194881
John David Anglin committed -
PR target/53789 * config/pa/pa.md (movsi): Revert previous change. * pa.c (pa_legitimate_constant_p): Reject all TLS symbol references. From-SVN: r194879
John David Anglin committed -
From-SVN: r194878
GCC Administrator committed
-
- 03 Jan, 2013 23 commits
-
-
* config/i386/i386.c (ix86_expand_move): Always assign to op1 after eliminating TLS symbols. From-SVN: r194873
Richard Henderson committed -
PR c++/55419 PR c++/55753 * pt.c (tsubst_copy_and_build) [TARGET_EXPR]: Don't touch TREE_CONSTANT. From-SVN: r194870
Jason Merrill committed -
PR c++/55842 * semantics.c (trait_expr_value): Call maybe_instantiate_noexcept. From-SVN: r194869
Jason Merrill committed -
2013-01-03 Marc Glisse <marc.glisse@inria.fr> PR bootstrap/50167 gcc/ * graphite-interchange.c (pdr_stride_in_loop): Use gmp_fprintf. * graphite-poly.c (debug_gmp_value): Likewise. PR bootstrap/50177 libcpp/ * line-map.c (get_combined_adhoc_loc): Cast from extern "C" type. (new_linemap): Likewise. (linemap_enter_macro): Likewise. From-SVN: r194868
Marc Glisse committed -
gcc/testsuite/ * gcc.dg/torture/tls/tls-reload-1.c (main): Make testing more thorough. From-SVN: r194867
Richard Sandiford committed -
PR c++/55856 * g++.dg/init/array34.C: Check gimple dump, not assembler. From-SVN: r194866
Jason Merrill committed -
PR c++/55856 * semantics.c (build_data_member_initialization): Handle DECL_EXPR. From-SVN: r194865
Jason Merrill committed -
* ChangeLog: Fix. * testsuite/ChangeLog: Ditto. From-SVN: r194863
Uros Bizjak committed -
PR target/55712 * config/i386/i386-c.c (ix86_target_macros_internal): Depending on selected code model, define __code_mode_small__, __code_model_medium__, __code_model_large__, __code_model_32__ or __code_model_kernel__. * config/i386/cpuid.h (__cpuid, __cpuid_count) [__i386__]: Prefix xchg temporary register with %k. Declare temporary register as early clobbered. [__x86_64__]: For medium and large code models, preserve %rbx register. From-SVN: r194862
Uros Bizjak committed -
From-SVN: r194861
H.J. Lu committed -
PR c++/53650 * call.c (type_has_extended_temps): New. * cp-tree.h: Declare it. * decl.c (check_initializer): Use build_aggr_init for arrays if it is false. * init.c (build_vec_init): Avoid mixed signed/unsigned arithmetic. From-SVN: r194860
Jason Merrill committed -
2013-01-03 Richard Biener <rguenther@suse.de> * tree-data-ref.c (dump_conflict_function): Use less vertical spacing. (dump_subscript): Adjust. (finalize_ddr_dependent): Do not dump redundant info. (analyze_siv_subscript): Adjust. (subscript_dependence_tester): Likewise. (compute_affine_dependence): Likewise. From-SVN: r194858
Richard Biener committed -
re PR fortran/55855 ([OOP] incorrect warning with procedure pointer component on pointer-valued base object) 2013-01-03 Janus Weil <janus@gcc.gnu.org> PR fortran/55855 * expr.c (gfc_check_assign): Use 'gfc_expr_attr' to evaluate attributes of rvalue. Correct hyphenation in error message. 2013-01-03 Janus Weil <janus@gcc.gnu.org> PR fortran/55855 * gfortran.dg/assignment_1.f90: Modified. * gfortran.dg/assignment_4.f90: New. From-SVN: r194857
Janus Weil committed -
2013-01-03 Richard Biener <rguenther@suse.de> Revert 2013-01-03 Richard Biener <rguenther@suse.de> PR tree-optimization/55857 * tree-vect-stmts.c (vectorizable_load): Do not setup re-alignment for invariant loads. 2013-01-02 Richard Biener <rguenther@suse.de> * tree-vect-stmts.c (vectorizable_load): When vectorizing an invariant load do not generate a vector load from the scalar location. From-SVN: r194856
Richard Biener committed -
From-SVN: r194855
David Edelsohn committed -
2013-01-03 Richard Biener <rguenther@suse.de> * tree-vect-loop.c (vect_analyze_loop_form): Clarify reason for not vectorizing. * tree-vect-data-refs.c (vect_create_addr_base_for_vector_ref): Do not build INDIRECT_REFs, call get_name once only. (vect_create_data_ref_ptr): Likewise. Dump base object kind based on DR_BASE_OBJECT, not DR_BASE_ADDRESS. From-SVN: r194853
Richard Biener committed -
2013-01-03 Pascal Obry <obry@adacore.com> * prj-attr.adb, projects.texi, snames.ads-tmpl: Add package remote and corresponding attibutes. 2013-01-03 Thomas Quinot <quinot@adacore.com> * exp_aggr.adb: Minor comment improvement. From-SVN: r194852
Arnaud Charlet committed -
2013-01-03 Hristian Kirtchev <kirtchev@adacore.com> * aspects.adb, aspects.ads: Add Aspect_Abstract_State to all the relevant tables. * einfo.ads, einfo.adb: Add Integrity_Level and Refined_State to the description of fields (Abstract_States): New routine. (Integrity_Level): New routine. (Has_Property): New routine. (Is_Input_State): New routine. (Is_Null_State): New routine. (Is_Output_State): New routine. (Is_Volatile_State): New routine. (Refined_State): New routine. (Set_Abstract_States): New routine. (Set_Integrity_Level): New routine. (Set_Refined_State): New routine. (Write_Field8_Name): Add proper output for E_Abstract_State. (Write_Field9_Name): Add proper output for E_Abstract_State. (Write_Field25_Name): Add proper output for E_Package. * lib-xref.ads: Add new letter for an abstract state. * par-prag.adb: Add pragma Abstract_State to the list of pragma that do not need special processing by the parser. * sem_ch13.adb (Analyze_Aspect_Specifications): Convert aspect Abstract_State into a pragma without any form of legality checks. The work is done by Analyze_Pragma. (Check_Aspect_At_Freeze_Point): Aspect Abstract_State does not require delayed analysis. * sem_prag.adb: Add a value for pragma Abstract_State in table Sig_Flags. (Analyze_Pragma): Add legality checks for pragma Abstract_State. Analysis of individual states introduces a state abstraction entity into the visibility chain. * snames.ads-tmpl: Add new names for abstract state and integrity. Add new pragma id for abstract state. 2013-01-03 Bob Duff <duff@adacore.com> * table.adb (Reallocate): Calculate new Length in Long_Integer to avoid overflow. 2013-01-03 Thomas Quinot <quinot@adacore.com> * sem_ch3.adb, sinfo.ads, freeze.adb, sem_ch4.adb, exp_aggr.adb (Sem_Ch3.Analyze_Object_Declaration): Set Ekind early so that it is set properly when expanding the initialization expression. (Freeze.Check_Address_Clause): Transfer initialization expression to an assignment in the freeze actions, so that the object is initialized only after being elaborated by GIGI. (Sinfo (comments), Sem_Ch4.Analyze_Expression_With_Actions): Allow a Null_Statement as the expression in an Expression_With_Actions. (Exp_Aggr.Collect_Initialization_Statements): New subprogram shared by expansion of record and array aggregates, used to capture statements for an aggregate used to initalize an object into an Expression_With_Actions (which acts as a container for a list of actions). (Exp_Aggr.Convert_Aggr_In_Obj_Decl): Use the above to capture initialization statements, instead of the previously existing loop which left freeze nodes out of the capturing construct (causing out of order elaboration crashes in GIGI). (Exp_Aggr.Expand_Array_Aggregate): Use the above to capture initialization statements (this was previously not done for arrays). Also do not unconditionally prevent in place expansion for an object with address clause. From-SVN: r194851
Arnaud Charlet committed -
2013-01-03 Richard Biener <rguenther@suse.de> PR tree-optimization/55857 * tree-vect-stmts.c (vectorizable_load): Do not setup re-alignment for invariant loads. * gcc.dg/vect/pr55857-1.c: New testcase. * gcc.dg/vect/pr55857-2.c: Likewise. From-SVN: r194850
Richard Biener committed -
2013-01-03 Thomas Quinot <quinot@adacore.com> * gnat_rm.texi, freeze.adb (Check_Component_Storage_Order): Check that a record extension has the same scalar storage order as the parent type. 2013-01-03 Thomas Quinot <quinot@adacore.com> * exp_ch4.adb: Add comment. 2013-01-03 Vincent Celier <celier@adacore.com> * prj.adb: Minor spelling error correction in comment. 2013-01-03 Vincent Celier <celier@adacore.com> * gnatcmd.adb (GNATCmd): If a single main has been specified as an absolute path, use its simple file name to find specific switches, instead of the absolute path. 2013-01-03 Javier Miranda <miranda@adacore.com> * sem_warn.adb (Warn_On_Overlapping_Actuals): For overlapping parameters that are record types or array types generate warnings only compiling under -gnatw.i * opt.ads (Extensions_Allowed): Restore previous documentation. 2013-01-03 Vincent Celier <celier@adacore.com> * prj-conf.adb (Do_Autoconf): If Target is specified in the main project, but not on the command line, use the Target in the project to invoke gprconfig in auto-configuration. * makeutl.ads (Default_Config_Name): New constant String. 2013-01-03 Arnaud Charlet <charlet@adacore.com> * usage.adb: Minor: fix typo in usage. 2013-01-03 Thomas Quinot <quinot@adacore.com> * sem_ch13.adb (Analyze_Record_Representation_Clause): Reject an illegal component clause for an inherited component in a record extension. From-SVN: r194849
Arnaud Charlet committed -
2013-01-03 Emmanuel Briot <briot@adacore.com> * xref_lib.adb (Parse_Identifier_Info): Fix handling of arrays, which have information in the ALI file for both the index and the component types. 2013-01-03 Emmanuel Briot <briot@adacore.com> * projects.texi: Fix error in documenting the project path computed for an aggregate project. 2013-01-03 Javier Miranda <miranda@adacore.com> * sem_warn.adb (Warn_On_Overlapping_Actuals): Adding documentation plus restricting the functionality of this routine to cover the cases described in the Ada 2012 reference manual. The previous extended support is now available under -gnatX. * s-tassta.adb (Finalize_Global_Tasks): Addition of a dummy variable to call Timed_Sleep. Required to avoid warning on overlapping out-mode actuals. * opt.ads (Extensions_Allowed): Update documentation. 2013-01-03 Tristan Gingold <gingold@adacore.com> * s-arit64.ads: Use Multiply_With_Ovflo_Check as __gnat_mulv64. * arit64.c: Removed * gcc-interface/Makefile.in: Remove reference to arit64.c. 2013-01-03 Thomas Quinot <quinot@adacore.com> * checks.adb, checks.ads (Apply_Address_Clause_Check): The check must be generated at the start of the freeze actions for the entity, not before (or after) the freeze node. 2013-01-03 Thomas Quinot <quinot@adacore.com> * exp_aggr.adb (Exp_Aggr.Convert_Aggregate_In_Obj_Decl): Reorganize code to capture initialization statements in a block, so that freeze nodes are excluded from the captured block. From-SVN: r194848
Arnaud Charlet committed -
2013-01-03 Thomas Quinot <quinot@adacore.com> * exp_ch11.adb: Minor reformatting. 2013-01-03 Thomas Quinot <quinot@adacore.com> * exp_util.adb, einfo.adb, einfo.ads, freeze.adb, exp_aggr.adb, sem_ch13.adb (Einfo.Initialization_Statements, Einfo.Set_Initialization_Statements): New entity attribute for objects. (Exp_Util.Find_Init_Call): Handle case of an object initialized by an aggregate converted to a block of assignment statements. (Freeze.Check_Address_Clause): Do not clear Has_Delayed_Freeze even for objects that require a constant address, because the address expression might involve entities that have yet to be elaborated at the point of the object declaration. (Exp_Aggr.Convert_Aggregate_In_Obj_Decl): For a type that does not require a transient scope, capture the assignment statements in a block so that they can be moved down after elaboration of an address clause if needed. (Sem_Ch13.Check_Constant_Address_Clause.Check_Expr_Constants, case N_Unchecked_Conversion): Do not replace operand subtype with its base type as this violates a GIGI invariant if the operand is an identifier (in which case the etype of the identifier is expected to be equal to that of the denoted entity). 2013-01-03 Javier Miranda <miranda@adacore.com> * sem_util.ads, sem_util.adb (Denotes_Same_Object): Extend the functionality of this routine to cover cases described in the Ada 2012 reference manual. 2013-01-03 Ed Schonberg <schonberg@adacore.com> * sem_elab.adb (Set_Elaboration_Constraint): Handle properly a 'Access attribute reference when the subprogram is called Initialize. 2013-01-03 Arnaud Charlet <charlet@adacore.com> * s-tpobop.adb (PO_Do_Or_Queue): Refine assertion, since a select statement may be called from a controlled (e.g. Initialize) operation and have abort always deferred. From-SVN: r194847
Arnaud Charlet committed -
2013-01-03 Robert Dewar <dewar@adacore.com> * sem_ch8.adb, einfo.ads, einfo.adb: Minor code reorganization. 2013-01-03 Javier Miranda <miranda@adacore.com> * exp_ch3.adb (Make_Controlling_Function_Wrappers): Exclude internal entities associated with interfaces and add minimum decoration to the defining entity of the generated wrapper to allow overriding interface primitives. * sem_disp.ads (Override_Dispatching_Operation): Addition of a new formal (Is_Wrapper). * sem_disp.adb (Override_Dispatching_Operation): When overriding interface primitives the new formal helps identifying that the new operation is not fully decorated. From-SVN: r194846
Arnaud Charlet committed
-