1. 30 Jul, 2008 33 commits
    • sem_ch8.adb: Minor reformatting · a7a0d4dd
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* sem_ch8.adb: Minor reformatting
      
      From-SVN: r138330
      Robert Dewar committed
    • exp_util.ads (Find_Prim_Op): Document that Program_Error is raised if no… · 7813a510
      exp_util.ads (Find_Prim_Op): Document that Program_Error is raised if no primitive operation is found.
      
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* exp_util.ads (Find_Prim_Op): Document that Program_Error is raised
      	if no primitive operation is found.
      
      	* exp_util.adb: (Find_Prim_Op): Add comments for previous change
      
      From-SVN: r138329
      Robert Dewar committed
    • exp_ch9.adb: Minor reformatting · 1adfc03b
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* exp_ch9.adb: Minor reformatting
      
      From-SVN: r138328
      Robert Dewar committed
    • arm.c (arm_compute_static_chain_stack_bytes): New function. · 35596784
      	* config/arm/arm.c (arm_compute_static_chain_stack_bytes): New
      	function.
      	(arm_compute_initial_elimination_offset): Use it.
      	(arm_compute_save_reg_mask): Include static chain save slot when
      	calculating alignment.
      	(arm_get_frame_offsets): Ditto.
      	(thumb1_compute_save_reg_mask): Ensure we have a low register saved
      	that we can use to decrement the stack when the stack decrement
      	could be too big for an immediate value in a single insn.
      	(thumb1_expand_prologue): Avoid using r12 for stack decrement.
      
      From-SVN: r138327
      Andrew Jenner committed
    • Resync. · 5cc6fa41
      From-SVN: r138325
      Arnaud Charlet committed
    • einfo.adb: Flag245 is now used. · d44202ba
      2008-07-30  Hristian Kirtchev  <kirtchev@adacore.com>
      
      	* einfo.adb: Flag245 is now used.
      	(Is_Primitive_Wrapper, Set_Is_Primitive_Wrapper): Relax the assertion
      	check to include functions.
      	(Is_Private_Primitive, Set_Is_Private_Primitive): New subprograms.
      	(Wrapped_Entity, Set_Wrapped_Entity): Relax the assertion check to
      	include functions.
      	(Write_Entity_Flags): Move flag Is_Primitive, add Is_Private_Primitive
      	to the list of displayed flags.
      
      	* einfo.ads: Update comment on the usage of Is_Primitive_Wrapper and
      	Wrapped_Entity. These two flags are now present in functions.
      	New flag Is_Private_Primitive.
      	(Is_Private_Primitive, Set_Is_Private_Primitive): New subprograms.
      
      	* exp_ch9.adb:
      	(Build_Wrapper_Bodies): New subprogram.
      	(Build_Wrapper_Body): The spec and body have been moved to in
      	Build_Wrapper_ Bodies. Code cleanup.
      	(Build_Wrapper_Spec): Moved to the spec of Exp_Ch9. Code cleanup.
      	Wrappers are now generated for primitives declared between the private
      	and full view of a concurrent type that implements an interface.
      	(Build_Wrapper_Specs): New subprogram.
      	(Expand_N_Protected_Body): Code reformatting. Replace the wrapper body
      	creation mechanism with a call to Build_Wrapper_Bodies.
      	(Expand_N_Protected_Type_Declaration): Code reformatting. Replace the
      	wrapper spec creation mechanism with a call to Build_Wrapper_Specs.
      	(Expand_N_Task_Body): Replace the wrapper body creation
      	mechanism with a call to Build_Wrapper_Bodies.
      	(Expand_N_Task_Type_Declaration): Replace the wrapper spec
      	creation mechanism with a call to Build_Wrapper_Specs.
      	(Is_Private_Primitive_Subprogram): New subprogram.
      	(Overriding_Possible): Code cleanup.
      	(Replicate_Entry_Formals): Renamed to Replicate_Formals, code cleanup.
      
      	* exp_ch9.ads (Build_Wrapper_Spec): Moved from the body of Exp_Ch9.
      
      	* sem_ch3.adb: Add with and use clause for Exp_Ch9.
      	(Process_Full_View): Build wrapper specs for all primitives
      	that belong to a private view completed by a concurrent type
      	implementing an interface.
      	
      	* sem_ch6.adb (Analyze_Subprogram_Body): When the current subprogram
      	is a primitive of a
      	concurrent type with a private view that implements an interface, try to
      	find the proper spec.
      	(Analyze_Subprogram_Declaration): Mark a subprogram as a private
      	primitive if the type of its first parameter is a non-generic tagged
      	private type.
      	(Analyze_Subprogram_Specification): Code reformatting.
      	(Disambiguate_Spec): New routine.
      	(Find_Corresponding_Spec): Add a flag to controll the output of errors.
      	(Is_Private_Concurrent_Primitive): New routine.
      
      	* sem_ch6.ads:
      	(Find_Corresponding_Spec): Add a formal to control the output of errors.
      
      From-SVN: r138324
      Hristian Kirtchev committed
    • uintp.adb (UI_GCD): Fix potential overflow · dc829590
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* uintp.adb (UI_GCD): Fix potential overflow
      
      From-SVN: r138323
      Robert Dewar committed
    • sem_ch8.adb (Analyze_Subprogram_Renaming): When renaming an attribute as a actual in an instance... · 6a4d72a6
      2008-07-30  Ed Schonberg  <schonberg@adacore.com>
      
      	* sem_ch8.adb (Analyze_Subprogram_Renaming): When renaming an attribute
      	as a actual in an instance, check for a missing attribute to prevent
      	program_error on an illegal program.
      	
      	* exp_util.adb (Find_Prim_Op): Rather than Assert (False), raise program
      	error if primitive is not found, so that exception can be handled
      	elsewhere on illegal programs.
      
      From-SVN: r138322
      Ed Schonberg committed
    • rtsfind.adb (Check_RPC): Check version consistency even when not generating RCI stubs. · 706d7459
      2008-07-30  Thomas Quinot  <quinot@adacore.com>
      
      	* rtsfind.adb (Check_RPC): Check version consistency even when not
      	generating RCI stubs. Provide more detailed error message in case of
      	mismatch.
      
      From-SVN: r138321
      Thomas Quinot committed
    • gnatlink.adb: Minor reformatting · cc72409e
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* gnatlink.adb: Minor reformatting
      
      From-SVN: r138320
      Robert Dewar committed
    • re PR tree-optimization/36967 (segfault in is_gimple_real_type with… · 5f8ecf45
      re PR tree-optimization/36967 (segfault in is_gimple_real_type with -fpredictive-commoning -ffast-math)
      
      2008-07-30  Richard Guenther  <rguenther@suse.de>
      
      	PR tree-optimization/36967
      	* tree-predcom.c (remove_stmt): Use gimple_assign_ssa_name_copy_p.
      	Release defs of statements we remove.
      
      	* gfortran.dg/pr36967.f: New testcase.
      
      From-SVN: r138318
      Richard Guenther committed
    • arm.c (arm_expand_prologue): Use 0-length rtvec instead of NULL_RTVEC. · 44bfa35b
              * config/arm/arm.c (arm_expand_prologue): Use 0-length rtvec
              instead of NULL_RTVEC.
      
      From-SVN: r138317
      Nathan Froyd committed
    • re PR target/35866 (Vector load/store from a packed struct does not work (without -mstrict-align)) · 54ce9cc2
      	PR target/35866
      
      	* config/rs6000/rs6000.h (SLOW_UNALIGNED_ACCESS): Add clause for
      	vector modes.
      
      From-SVN: r138316
      Nathan Froyd committed
    • sync with src · efd41714
      From-SVN: r138314
      Paolo Bonzini committed
    • config: sync with src · a8416675
      2008-07-25  Keith Seitz  <keiths@redhat.com>
      
      	* acinclude.m4: Remove libide, libgui, and all the other Tcl
      	functions.
      	* tcl.m4: New file.
      
      From-SVN: r138313
      Keith Seitz committed
    • final.c (call_from_call_insn): New. · f410e1b3
      2008-07-30  Rafael Avila de Espindola  <espindola@google.com>
      
             * final.c (call_from_call_insn): New.
             (final_scan_insn): Call assemble_external on FUNCTION_DECLs.
      
      2008-07-30  Rafael Avila de Espindola  <espindola@google.com>
      
      	* gcc.dg/visibility-14.c: New test.
      	* gcc.dg/visibility-15.c: New test.
      	* gcc.dg/visibility-16.c: New test.
      	* gcc.dg/visibility-17.c: New test.
      	* gcc.dg/visibility-18.c: New test.
      	* gcc.dg/visibility-19.c: New test.
      
      From-SVN: r138310
      Rafael Avila de Espindola committed
    • re PR c++/36767 (Segmentation fault with -fprofile-arcs -O2) · e44c800e
      2008-07-30  Dodji Seketeli  <dseketel@redhat.com>
      
      	PR c++/36767
      	* decl2.c (fix_temporary_vars_context_r): New function.
      	 (one_static_initialization_or_destruction): Make sure temporary
      	 variables part of the initialiser have their DECL_CONTEXT()
      	 properly set.
      
      From-SVN: r138308
      Dodji Seketeli committed
    • gigi.h (build_vms_descriptor64): New function prototype. · 6ca2b0a0
      2008-07-30  Doug Rupp  <rupp@adacore.com>
      
      	* gigi.h (build_vms_descriptor64): New function prototype.
      	(fill_vms_descriptor): Modified function prototype.
      
      	* utils.c (build_vms_descriptor64): New function.
      
      	* utils2.c (fill_vms_descriptor): Fix handling on 32bit systems.
      
      	* trans.c (call_to_gnu): Call fill_vms_descriptor with new third
      	argument.
      
      	* decl.c (gnat_to_gnu_tree): For By_Descriptor mech, build both a
      	64bit and 32bit descriptor and save the 64bit version as an alternate
      	TREE_TYPE in the parameter.
      	(make_type_from_size) <RECORD_TYPE>: Use the appropriate mode for the
      	thin pointer.
      
      	* ada-tree.h (DECL_PARM_ALT, SET_DECL_PARM_ALT): New macros.
      
      From-SVN: r138307
      Doug Rupp committed
    • Resync · 002b2ad6
      From-SVN: r138306
      Arnaud Charlet committed
    • 2008-07-30 Jose Ruiz <ruiz@adacore.com> · f921a1cd
      	* adaint.c
      	(__gnat_file_exists): Do not use __gnat_stat for RTX.
      	(__main for RTX in RTSS mode): Create this dummy procedure symbol to
      	avoid the use of this symbol from libgcc.a in RTX kernel mode.
      
      	* cio.c
      	(put_int, put_int_stderr, put_char, put_char_stderr): For RTX we call
      	the function RtPrintf for console output.
      	
      	* argv.c Do not use the environ variable for RTX.
      	
      	* gnatlink.adb (gnatlink): The part that handles the --RTS option has
      	been moved before the call to Osint.Add_Default_Search_Dirs in order
      	to take into account the flags in system.ads (RTX_RTSS_Kernel_Module)
      	from the appropriate run time.
      	
      	* targparm.ads
      	(RTX_RTSS_Kernel_Module_On_Target): Add this flag that is set to True if
      	target is a RTSS module for RTX.
      	
      	* targparm.adb (Targparm_Tags, RTX_Str, Targparm_Str): Add tag RTX for
      	RTX_RTSS_Kernel_Module
      	(Get_Target_Parameters): Add processing of RTX_RTSS_Kernel_Module flag.
      
      	* gcc-interface/Makefile.in (LIBGNAT_TARGET_PAIRS for RTX): Use gcc
      	exception handling mechanism for Windows and RTX in Win32 mode, but
      	not for RTX in kernel mode (RTSS).
      	(LIBGNAT_SRCS): Remove ada.h
      
      From-SVN: r138305
      Jose Ruiz committed
    • osint.ads: Minor reformatting · 88462e81
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* osint.ads: Minor reformatting
      
      From-SVN: r138304
      Robert Dewar committed
    • mlib-utl.adb: Minor reformatting · fe42997b
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* mlib-utl.adb: Minor reformatting
      
      From-SVN: r138303
      Robert Dewar committed
    • make.adb: Minor reformatting · 015fbc5c
      2008-07-30  Robert Dewar  <dewar@adacore.com>
      
      	* make.adb: Minor reformatting
      
      From-SVN: r138302
      Robert Dewar committed
    • configure.ac: Add makefile fragments for hpux. · 00afcaa0
      2008-07-30  Paolo Bonzini  <bonzini@gnu.org>
      
      	* configure.ac: Add makefile fragments for hpux.
      	* Makefile.def (flags_to_pass): Add ADA_CFLAGS.
      	* Makefile.tpl (HOST_EXPORTS): Pass ADA_CFLAGS.
      	* configure: Regenerate.
      	* Makefile.in: Regenerate.
      
      config:
      2008-07-30  Paolo Bonzini  <bonzini@gnu.org>
      
      	* mh-pa: New, from gcc/config/pa/x-ada.
      	* mh-pa-hpux10: New, from gcc/config/pa/x-ada-hpux10.
      
      gcc:
      2008-07-30  Paolo Bonzini  <bonzini@gnu.org>
      
      	* configure.ac: Substitute ADA_CFLAGS.
      	* configure: Regenerate.
      	* config.host: Remove mention of pa/x-ada and pa/x-ada-hpux10 files.
      	* Makefile.in: Remove mention of X_* variables.
      	* config/pa/x-ada-hpux10: Remove.
      	* config/pa/x-ada: Remove.
      
      	* doc/fragments.texi: Update.
      
      gcc/ada:
      2008-07-30  Paolo Bonzini  <bonzini@gnu.org>
      
      	* gcc-interface/Make-lang.in (ALL_ADAFLAGS): Remove X_ADAFLAGS and
      	T_ADAFLAGS, replace ALL_ADA_CFLAGS with ADA_CFLAGS.
      	(ALL_ADA_CFLAGS): Remove, replace throughout with ADA_CFLAGS.
      	* gcc-interface/Makefile.in (XCFLAGS, X_CFLAGS, X_CPPFLAGS, T_CPPFLAGS,
      	X_ADA_CFLAGS, T_ADA_CFLAGS, X_ADAFLAGS, T_ADAFLAGS, ADA_CFLAGS,
      	ALL_ADA_CFLAGS): Remove.
      	(ALL_ADAFLAGS, MOST_ADAFLAGS): Remove X_ADAFLAGS and T_ADAFLAGS,
              replace ALL_ADA_CFLAGS with ADA_CFLAGS.
      	(GCC_CFLAGS): Remove X_CFLAGS.
      	(LOOSE_CFLAGS): Remove X_CFLAGS and XCFLAGS.
      	(ALL_CPPFLAGS): Remove X_CPPFLAGS and T_CPPFLAGS.
      	(ADA_CFLAGS): Substitute.
      	
      gnattools:
      2008-07-30  Paolo Bonzini  <bonzini@gnu.org>
      
      	* configure.ac (x_ada_cflags): Remove.
      	(ADA_CFLAGS): Substitute.
      	* configure: Regenerate.
      	* Makefile.in (ADA_CFLAGS): Substitute.
      	(T_ADA_CFLAGS, X_ADA_CFLAGS, ALL_ADA_CFLAGS): Remove.
      	(TOOLS_FLAGS_TO_PASS_1, TOOLS_FLAGS_TO_PASS_1re,
      	TOOLS_FLAGS_TO_PASS_NATIVE, TOOLS_FLAGS_TO_PASS_CROSS):
      	Pass ADA_CFLAGS.
      
      From-SVN: r138301
      Paolo Bonzini committed
    • move wrong gcc/ChangeLog entry to gnattools/ChangeLog · cd913357
      From-SVN: r138300
      Paolo Bonzini committed
    • Fix date on entry headline. · f90354fd
      From-SVN: r138298
      Olivier Hainque committed
    • irix-crti.asm: .hide __gcc_init and __gcc_fini. · c67a9338
              * config/mips/irix-crti.asm: .hide __gcc_init and __gcc_fini.
              * config/mips/iris6.h (IRIX_SUBTARGET_LINK_SPEC, irix ld): Hide
              __dso_handle explicitly here.
      
      From-SVN: r138297
      Olivier Hainque committed
    • re PR c/34389 (-Wconversion produces wrong warning) · 6715192c
      2008-07-30  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
      
      	PR 34389
      	* c-typeck.c (build_binary_op): Encapsulate code into...
      	* c-common.c (shorten_binary_op): ...this new function.
      	(conversion_warning): Use the new function. Handle non-negative
      	constant in bitwise-and.
      	* c-common.h (shorten_binary_op): Declare.
      cp/
      	* typeck.c (build_binary_op): Encapsulate code into
      	shorten_binary_op.
      testsuite/
      	* gcc.dg/Wconversion-pr34389.c: New.
      	* g++.dg/warn/Wconversion-pr34389.C: New.
      
      From-SVN: r138296
      Manuel López-Ibáñez committed
    • scan.c (make_sstring_space): Add explicit conversions of allocator's return value. · 473e1062
      	* scan.c (make_sstring_space): Add explicit conversions of
      	allocator's return value.
      	* fix-header.c (recognized_function): Likewise.
      
      From-SVN: r138295
      Olivier Hainque committed
    • re PR ada/5911 (Support for multilib in Ada) · a7dafa20
      gcc/ChangeLog
      2008-07-29  Laurent Guerby <laurent@guerby.net>
      
              PR ada/5911
              * gnattools/Makefile.in: Replace stamp-gnatlib by
              stamp-gnatlib-rts.
      
      gcc/ada/ChangeLog
      2008-07-29  Laurent Guerby <laurent@guerby.net>
      
              PR ada/5911
              * gcc-interface/Makefile.in (MULTISUBDIR, RTSDIR): New variables.
              Pass MULTISUBDIR to recursive make. Use $(RTSDIR) instead of rts.
              Replace stamp-gnatlib* by stamp-gnatlib*-rts.
              * gcc-interface/Make-lang.in: Replace stamp-gnatlib2
              by stamp-gnatlib2-rts.
      
      From-SVN: r138294
      Laurent GUERBY committed
    • re PR ada/15479 (Ada manual problems) · 70b1e376
      gcc/ada/
      	PR documentation/15479
      	* gnat-style.texi: Remove AdaCore copyright statement and GPL
      	statement for GNAT.  Add @copying stanza, use it.  Update to
      	GFDL 1.2.  Do not list GFDL as Invariant Section, do not list
      	title as Front-Cover Text.
      	* gnat_rm.texi: Likewise.
      	* gnat_ugn.texi: Likewise.
      
      gcc/
      	* doc/cpp.texi: Update to GFDL 1.2.
      	* doc/gcc.texi: Do not list GPL as Invariant Section.
      	* doc/gccint.texi: Likewise.  Update copyright years.
      	* doc/install.texi: Update copyright years.
      
      gcc/fortran/
      	* gfc-internals.texi: Update to GFDL 1.2.  Do not list GPL as
      	Invariant Section.
      	* gfortran.texi: Likewise.
      	* intrinsic.texi: Do not list GPL as Invariant Section.
      	* invoke.texi: Likewise.  Update copyright years.
      
      gcc/java/
      	* gcj.texi: Update copyright years.  Do not list GPL as
      	Invariant Section.
      
      libgomp/
      	* libgomp.texi: Update to GFDL 1.2.  Update copyright years.
      	Do not list GPL as Invariant Section.
      
      From-SVN: r138293
      Ralf Wildenhues committed
    • re PR target/36955 (TLS LIBCALL change breaks libstdc++ built with older binutils) · d161cb2d
      	PR target/36955
      	* config/rs6000/rs6000.c (rs6000_legitimize_tls_address): Add
      	a use of pic_offset_table_rtx for -msecure-plt __tls_get_addr calls.
      
      From-SVN: r138291
      Alan Modra committed
    • Daily bump. · 559d6599
      From-SVN: r138289
      GCC Administrator committed
  2. 29 Jul, 2008 7 commits
    • * gcc.dg/pr32370.c: Force 64 bits on IA64. · ce49641d
      From-SVN: r138277
      Steve Ellcey committed
    • trans-expr.c (conv_parent_component_references): New function to build missing parent references. · 7d1f1e61
      2008-07-29  Paul Thomas  <pault@gcc.gnu.org>
      
      fortran/	
      	* trans-expr.c (conv_parent_component_references): New function
      	to build missing parent references.
      	(gfc_conv_variable): Call it
      	* symbol.c (gfc_add_component): Check that component name in a
      	derived type extension does not appear in parent.
      	(gfc_find_component): For a derived type extension, check if
      	the component appears in the parent derived type by calling
      	self. Separate errors for private components and private types.
      	* decl.c (match_data_constant): Add extra arg to call to
      	gfc_match_structure_constructor.
      	(check_extended_derived_type): New function to check that a
      	parent derived type exists and that it is OK for exension.
      	(gfc_get_type_attr_spec): Add extra argument 'name' and return
      	it if extends is specified.
      	(gfc_match_derived_decl): Match derived type extension and
      	build a first component of the parent derived type if OK. Add
      	the f2k namespace if not present.
      	* gfortran.h : Add the extension attribute.
      	* module.c : Handle attribute 'extension'.
      	* match.h : Modify prototypes for gfc_get_type_attr_spec and
      	gfc_match_structure_constructor.
      	* primary.c (build_actual_constructor): New function extracted
      	from gfc_match_structure_constructor and modified to call self
      	iteratively to build derived type extensions, when f2k named
      	components are used.
      	(gfc_match_structure_constructor): Do not throw error for too
      	many components if a parent type is being handled. Use
      	gfc_find_component to generate errors for non-existent or
      	private components.  Iteratively call self for derived type
      	extensions so that parent constructor is built.  If extension
      	and components left over, throw error.
      	(gfc_match_rvalue): Add extra arg to call to
      	gfc_match_structure_constructor.
      	* trans-array.c (gfc_conv_resolve_dependencies): If lhs and rhs
      	are the same symbol, aliassing does not matter.
      testsuite/
      	* gfortran.dg/extends_1.f03: New test.
      	* gfortran.dg/extends_2.f03: New test.
      	* gfortran.dg/extends_3.f03: New test.
      	* gfortran.dg/extends_4.f03: New test.
      	* gfortran.dg/extends_5.f03: New test.
      	* gfortran.dg/extends_6.f03: New test.
      	* gfortran.dg/private_type_6.f90: Modify error message.
      	* gfortran.dg/structure_constructor_7.f03: Modify error message.
      	* gfortran.dg/structure_constructor_8.f03: Modify error message.
      
      From-SVN: r138275
      Paul Thomas committed
    • Moved to gcc-interface directory. · e54cf157
      From-SVN: r138274
      Arnaud Charlet committed
    • set.h: Minor formatting fixes. · b798df05
      2008-07-29  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* include/debug/set.h: Minor formatting fixes.
      	* include/debug/multiset.h: Likewise.
      	* include/debug/safe_association.h: Likewise.
      	* include/debug/vector: Likewise.
      	* include/debug/map.h: Likewise.
      	* include/debug/string: Likewise.
      	* include/debug/multimap.h: Likewise.
      	* include/bits/stl_list.h: Likewise.
      	* include/bits/stl_map.h: Likewise.
      	* include/bits/stl_set.h: Likewise.
      	* include/bits/stl_multimap.h: Likewise.
      	* include/bits/stl_vector.h: Likewise.
      	* include/bits/stl_multiset.h: Likewise.
      	* include/bits/stl_bvector.h: Likewise.
      
      From-SVN: r138263
      Paolo Carlini committed
    • trans.c (process_inlined_subprograms): Remove tree_really_inline check. · 13669c36
      	* trans.c (process_inlined_subprograms): Remove tree_really_inline
      	check.
      
      From-SVN: r138261
      Arnaud Charlet committed
    • Moved to gcc-interface. · 68c989b0
      From-SVN: r138260
      Arnaud Charlet committed
    • c-decl.c (merge_decls): Do not handle DECL_INLINE. · 54dfd46b
      
      	* c-decl.c (merge_decls): Do not handle DECL_INLINE.
      	(grokdeclarator): Likewise.
      	* langhooks.c (lhd_warn_unused_global_decl): Use
      	DECL_DECLARED_INLINE_P.
      	* print-tree.c (print_node): Remove DECL_INLINE check.
      
      From-SVN: r138258
      Jan Hubicka committed