1. 14 Nov, 2019 16 commits
    • Use func_checker::hash_operand for hashing of GIMPLE operands. · a37f58f5
      2019-11-14  Martin Liska  <mliska@suse.cz>
      
      	* ipa-icf-gimple.h (func_checker::func_checker): Add
      	default constructor.
      	* ipa-icf.c (sem_function::init): Make operand_equal_p
      	and hash_operand public.
      	(sem_item::add_expr): Remove.
      	(sem_item::add_type): Remove.
      	(sem_function::hash_stmt): Use m_checker for hashing
      	of GIMPLE statements.
      	(sem_function::parse): Init with checker.
      	(sem_variable::parse): Pass NULL as checker.
      	(sem_item_optimizer::parse_funcs_and_vars):
      	Pass checker to ::parse function.
      	(sem_item_optimizer::parse_nonsingleton_classes): Likewise.
      	(sem_variable::parse): New function.
      	(sem_variable::get_hash): Only return computed hash value.
      	(sem_variable::init): Initialize hash of a variable.
      	* ipa-icf.h: Remove add_expr, add_type and add func_checker
      	to couple of functions as a new argument.
      
      From-SVN: r278207
      Martin Liska committed
    • Update dump message in IPA ICF. · 5d0152bf
      2019-11-14  Martin Liska  <mliska@suse.cz>
      
      	* ipa-icf-gimple.c (func_checker::compare_gimple_call): Update
      	bail out reason.
      	(func_checker::compare_gimple_assign): Likewise.
      
      From-SVN: r278206
      Martin Liska committed
    • i386-options.c (ix86_omp_device_kind_arch_isa): Don't change sse4.2 to sse4_2 and sse4.1 to sse4.1. · aa16689e
      	* config/i386/i386-options.c (ix86_omp_device_kind_arch_isa): Don't
      	change sse4.2 to sse4_2 and sse4.1 to sse4.1.
      	* config/i386/t-omp-device (omp-device-properties-i386): Likewise.
      
      	* c-c++-common/gomp/declare-variant-11.c: Add "sse4.2" and "sse4.1"
      	test.
      
      From-SVN: r278205
      Jakub Jelinek committed
    • c-parser.c (c_parser_omp_context_selector): Don't require score argument to fit… · bedb7f04
      c-parser.c (c_parser_omp_context_selector): Don't require score argument to fit into shwi, just to be INTEGER_CST.
      
      	* c-parser.c (c_parser_omp_context_selector): Don't require score
      	argument to fit into shwi, just to be INTEGER_CST.  Diagnose
      	negative score.
      
      	* parser.c (cp_parser_omp_context_selector): Don't require score
      	argument to fit into shwi, just to be INTEGER_CST.  Diagnose
      	negative score.
      	* pt.c (tsubst_attribute): Likewise.
      
      	* c-c++-common/gomp/declare-variant-2.c: Add test for non-integral
      	score and for negative score.
      	* c-c++-common/gomp/declare-variant-3.c: Add test for zero score.
      	* g++.dg/gomp/declare-variant-8.C: Add test for negative and zero
      	scores.
      
      From-SVN: r278204
      Jakub Jelinek committed
    • c-omp.c (c_omp_check_context_selector): Add nvidia to the list of valid vendors. · d0ec7c93
      	* c-omp.c (c_omp_check_context_selector): Add nvidia to the list of
      	valid vendors.
      
      	* c-c++-common/gomp/declare-variant-3.c: Add testcase for vendor nvidia.
      
      From-SVN: r278203
      Jakub Jelinek committed
    • omp-general.c (omp_context_name_list_prop): New function. · b2417b59
      	* omp-general.c (omp_context_name_list_prop): New function.
      	(omp_context_selector_matches): Use it.  Return 0 if it returns
      	NULL.
      	(omp_context_selector_props_compare): Allow equivalency of an
      	identifier and a string literal containing no embedded zeros.
      c-family/
      	* c-omp.c (c_omp_check_context_selector): Handle name lists
      	containing string literals.  Don't diagnose atomic_default_mem_order
      	with multiple props.
      c/
      	* c-parser.c (c_parser_omp_context_selector): Rename
      	CTX_PROPERTY_IDLIST to CTX_PROPERTY_NAME_LIST, add CTX_PROPERTY_ID.
      	Use CTX_PROPERTY_ID for atomic_default_mem_order, only allow a single
      	identifier in that.  For CTX_PROPERTY_NAME_LIST, allow identifiers
      	and string literals.
      cp/
      	* parser.c (cp_parser_omp_context_selector): Rename
      	CTX_PROPERTY_IDLIST to CTX_PROPERTY_NAME_LIST, add CTX_PROPERTY_ID.
      	Use CTX_PROPERTY_ID for atomic_default_mem_order, only allow a single
      	identifier in that.  For CTX_PROPERTY_NAME_LIST, allow identifiers
      	and string literals.
      	* pt.c (tsubst_attribute): Fix up STRING_CST handling if allow_string.
      testsuite/
      	* c-c++-common/gomp/declare-variant-2.c: Adjust expected diagnostics,
      	add a test for atomic_default_mem_order with a string literal.
      	* c-c++-common/gomp/declare-variant-3.c: Use string literal props
      	in a few random places, add a few string literal prop related tests.
      	* c-c++-common/gomp/declare-variant-8.c: Likewise.
      	* c-c++-common/gomp/declare-variant-9.c: Use string literal props
      	in a few random places.
      	* c-c++-common/gomp/declare-variant-10.c: Likewise.
      	* c-c++-common/gomp/declare-variant-11.c: Likewise.
      	* c-c++-common/gomp/declare-variant-12.c: Likewise.
      	* g++.dg/gomp/declare-variant-7.C: Likewise.
      
      From-SVN: r278202
      Jakub Jelinek committed
    • Remove higher precision range tests because they are unused. · f1471317
      This removes the dependency on m_max_pairs from the selftests, which has
      the ultimate effect of allowing us to put the tests in the selftest
      namespace as was the original plan.
      
      From-SVN: r278200
      Aldy Hernandez committed
    • update_version_svn (IGNORE_BRANCHES): Add 7. · 456ccd32
      2019-11-14  Richard Biener  <rguenther@suse.de>
      
      	* update_version_svn (IGNORE_BRANCHES): Add 7.
      
      From-SVN: r278199
      Richard Biener committed
    • Make normalize_addresses and normalize_symbolics work on THIS, instead · 6ee86466
      of returning by value.
      
      From-SVN: r278196
      Aldy Hernandez committed
    • [testsuite] Fix PR92464 by adjust test case loop bound · 9773f69c
        The recent vectorization cost adjustment on load leads
        the profitable min iteration count to change from 19 to 12.
        The case happens to hit the threshold.  This patch is to
        adjust the loop bound from 16 to 14.
      
        gcc/testsuite/ChangeLog
      
        2019-11-14  Kewen Lin  <linkw@gcc.gnu.org>
      
          PR target/92464
          * gcc.dg/vect/costmodel/ppc/costmodel-vect-76b.c: Adjust
          loop bound due to load cost adjustment.
      
      From-SVN: r278195
      Kewen Lin committed
    • Support C2x [[]] attributes for C. · 4e03c3a7
      This patch adds support for the C2x [[]] attribute syntax to the C
      front end.  Support is only added for C at this point, not for
      Objective-C; I intend to add the unbounded lookahead required to
      support it for Objective-C in a followup patch, but maybe not in
      development stage 1.
      
      The syntax is supported in all relevant places where the standard says
      it is supported, but support is not added for the individual
      attributes specified in C2x (all of which are optional to support).  I
      expect to add support for some of them in followup patches; all except
      nodiscard can be mapped directly to the semantics of an existing GNU
      attribute (subject to extra checks for invalid usages such as the same
      attribute being used more than once inside a single [[]]), and the
      fallthrough attribute already works after this patch because of
      existing special-case code handling it (but without some of the checks
      for invalid usage being present).
      
      Note that the four functions c_token_starts_declspecs,
      c_token_starts_declaration, c_parser_next_token_starts_declspecs and
      c_parser_next_tokens_start_declaration do *not* accept "[[".  This is
      analogous with the handling of __extension__: both cases have the
      property that they can start either a declaration or some other
      statements and so need an unbounded number of tokens to be parsed in
      the caller before it can find out what kind of syntactic construct
      follows.  Note also that, while I updated all places calling those
      functions for standard C syntax to handle attributes if applicable, I
      did not do anything regarding calls to such functions for OpenMP or
      OpenACC constructs.  Thus, if there are such constructs using such
      functions where "[[" *should* be accepted as a possible start to a
      declaration, the code for parsing those constructs should be updated
      accordingly.
      
      Although all cases of the syntax are handled, and attributes applied
      to the constructs the standard says they should be (with less laxity
      than there is for GNU attributes to allow an attribute applied to one
      construct to be moved automatically to another one), there is a major
      limitation in the existing language-independent code in attribs.c
      preventing most cases of type attributes from working.  The following
      code has been present with minor changes since the first support for
      [[]] attributes for C++ was added:
      
            if (TYPE_P (*node)
                && cxx11_attr_p
                && !(flags & ATTR_FLAG_TYPE_IN_PLACE))
              {
                /* This is a c++11 attribute that appertains to a
                   type-specifier, outside of the definition of, a class
                   type.  Ignore it.  */
                auto_diagnostic_group d;
                if (warning (OPT_Wattributes, "attribute ignored"))
                  inform (input_location,
                          "an attribute that appertains to a type-specifier "
                          "is ignored");
                continue;
              }
      
      I see no justification for this in general for either C or C++ and so
      propose to remove or restrict it in a followup bug-fix patch.  Both C
      and C++ are clear about attributes in certain places (at the end of
      declaration specifiers, or after function or array declarators)
      appertaining to a specific type (and explicitly say, in the case of
      attributes at the end of declaration specifiers, that they only apply
      for that particular use of that type, not for subsequent uses of the
      same type without the attributes).  Thus it seems clear to me that,
      for example,
      
      int [[gnu::mode(DI)]] x;
      
      ought to be accepted as an analogue in [[]] syntax for
      
      int __attribute__((mode(DI))) x;
      
      (or strictly as an analogue for a version of that with extra
      parentheses to make the GNU attribute bind properly to the type rather
      than being automatically moved from the declaration to the type).
      There are certain cases where an attribute *does* only make sense for
      the definition of a type (e.g. "packed" on structure types), but those
      should already be handled in the individual attribute handlers (such
      as handle_packed_attribute, which already has code to deal with that
      issue).  So my inclination is that the above-quoted check in attribs.c
      should simply be removed, but failing that it should be restricted to
      structure and union types (and such a change would be a bug-fix).
      That would then allow various cases of [[]] attributes on types to
      work properly.
      
      Bootstrapped with no regressions on x86_64-pc-linux-gnu.
      
      gcc/c:
      	* c-tree.h (enum c_typespec_kind): Add ctsk_tagref_attrs and
      	ctsk_tagfirstref_attrs.
      	(struct c_declspecs): Update description of attrs.  Add
      	postfix_attrs and non_std_attrs_seen_p.  Increase size of
      	typespec_kind bit-field.
      	(c_warn_unused_attributes): New declaration.
      	(parser_xref_tag): Update prototype.
      	* c-decl.c (c_warn_unused_attributes): New function.
      	(shadow_tag_warned): Handle ctsk_tagfirstref_attrs and
      	ctsk_tagref_attrs.  Handle attribute declarations.
      	(check_compound_literal_type): Handle ctsk_tagfirstref_attrs.
      	(grokdeclarator): Handle standard attributes.
      	(parser_xref_tag): Add arguments have_std_attrs and attrs.  Apply
      	attributes to incomplete type reference.
      	(xref_tag): Update call to parser_xref_tag.
      	(declspecs_add_addrspace, declspecs_add_type)
      	(declspecs_add_scspec, declspecs_add_attrs): Set
      	non_std_attrs_seen_p.
      	(finish_declspecs): Apply postfix standard attributes to type.
      	* c-parser.c (c_token_starts_declspecs)
      	(c_token_starts_declaration, c_parser_next_token_starts_declspecs)
      	(c_parser_next_tokens_start_declaration): Update comments.
      	(c_parser_consume_token, c_parser_consume_pragma): Handle moving
      	parser->tokens[2] to parser->tokens[1].
      	(c_parser_nth_token_starts_std_attributes)
      	(c_parser_std_attribute_specifier_sequence): New functions.
      	(c_parser_declaration_or_fndef): Add arguments have_attrs and
      	attrs.  All callers changed.  Handle standard attributes.
      	(c_parser_parms_declarator, c_parser_parms_list_declarator)
      	(c_parser_parameter_declaration): Add argument have_gnu_attrs.
      	All callers changed.
      	(c_parser_declspecs): Add arguments start_std_attr_ok and
      	end_std_attr_ok.  All callers changed.  Handle standard
      	attributes.
      	(c_parser_enum_specifier, c_parser_struct_or_union_specifier)
      	(c_parser_direct_declarator, c_parser_direct_declarator_inner)
      	(c_parser_compound_statement_nostart, c_parser_all_labels)
      	(c_parser_label, c_parser_statement, c_parser_for_statement):
      	Handle standard attributes.
      	* c-parser.h (c_parser_declspecs): Update prototype.
      	* gimple-parser.c (c_parser_gimple_declaration): Update call to
      	c_parser_declspecs.
      
      gcc/testsuite:
      	* gcc.dg/c2x-attr-fallthrough-1.c, gcc.dg/c2x-attr-syntax-1.c,
      	gcc.dg/c2x-attr-syntax-2.c, gcc.dg/c2x-attr-syntax-3.c,
      	gcc.dg/gnu2x-attr-syntax-1.c, gcc.dg/gnu2x-attr-syntax-2.c,
      	gcc.dg/gnu2x-attrs-1.c: New tests.
      
      From-SVN: r278194
      Joseph Myers committed
    • Support extended aggregate jump function in ipa-cp · eb270950
      2019-11-14  Feng Xue  <fxue@os.amperecomputing.com>
      
      	PR ipa/91682
      	* ipa-prop.h (jump_func_type): New value IPA_JF_LOAD_AGG.
      	(ipa_load_agg_data, ipa_agg_value, ipa_agg_value_set): New structs.
      	(ipa_agg_jf_item): Add new field jftype and type, redefine field value.
      	(ipa_agg_jump_function): Remove member function equal_to.
      	(ipa_agg_jump_function_p): Remove typedef.
      	(ipa_copy_agg_values, ipa_release_agg_values): New functions.
      	* ipa-prop.c (ipa_print_node_jump_functions_for_edge): Dump
      	information for aggregate jump function.
      	(get_ssa_def_if_simple_copy): Add new parameter rhs_stmt to
      	record last definition statement.
      	(load_from_unmodified_param_or_agg): New function.
      	(ipa_known_agg_contents_list): Add new field type and value, remove
      	field constant.
      	(build_agg_jump_func_from_list): Rename parameter const_count to
      	value_count, build aggregate jump function from ipa_load_agg_data.
      	(analyze_agg_content_value): New function.
      	(extract_mem_content): Analyze memory store assignment to prepare
      	information for aggregate jump function generation.
      	(determine_known_aggregate_parts): Add new parameter fbi, remove
      	parameter aa_walk_budeget_p.
      	(update_jump_functions_after_inlining): Update aggregate jump function.
      	(ipa_find_agg_cst_for_param): Change type of parameter agg.
      	(try_make_edge_direct_simple_call): Add new parameter new_root.
      	(try_make_edge_direct_virtual_call): Add new parameter new_root and
      	new_root_info.
      	(update_indirect_edges_after_inlining): Pass new argument to
      	try_make_edge_direct_simple_call and try_make_edge_direct_virtual_call.
      	(ipa_write_jump_function): Write aggregate jump function to file.
      	(ipa_read_jump_function): Read aggregate jump function from file.
      	(ipa_agg_value::equal_to): Migrate from ipa_agg_jf_item::equal_to.
      	* ipa-cp.c (ipa_get_jf_arith_result): New function.
      	(ipa_agg_value_from_node): Likewise.
      	(ipa_agg_value_set_from_jfunc): Likewise.
      	(propagate_vals_across_arith_jfunc): Likewise.
      	(propagate_aggregate_lattice): Likewise.
      	(ipa_get_jf_pass_through_result): Call ipa_get_jf_arith_result.
      	(propagate_vals_across_pass_through): Call
      	propagate_vals_across_arith_jfunc.
      	(get_clone_agg_value): Move forward.
      	(propagate_aggs_across_jump_function): Handle value propagation for
      	aggregate jump function.
      	(agg_jmp_p_vec_for_t_vec): Remove.
      	(context_independent_aggregate_values): Replace vec<ipa_agg_jf_item>
      	with vec<ipa_agg_value>.
      	(copy_plats_to_inter, intersect_with_plats): Likewise.
      	(agg_replacements_to_vector, intersect_with_agg_replacements): Likewise.
      	(intersect_aggregate_with_edge): Likewise.
      	(find_aggregate_values_for_callers_subset): Likewise.
      	(cgraph_edge_brings_all_agg_vals_for_node): Likewise.
      	(estimate_local_effects): Replace vec<ipa_agg_jump_function> and
      	vec<ipa_agg_jump_function_p> with vec<ipa_agg_value_set>.
      	(gather_context_independent_values): Likewise.
      	(perform_estimation_of_a_value, decide_whether_version_node): Likewise.
      	* ipa-fnsummary.c (evaluate_conditions_for_known_args): Replace
      	vec<ipa_agg_jump_function_p> with vec<ipa_agg_value_set>.
      	(evaluate_properties_for_edge): Likewise.
      	(estimate_edge_devirt_benefit): Likewise.
      	(estimate_edge_size_and_time):  Likewise.
      	(estimate_calls_size_and_time): Likewise.
      	(ipa_call_context::ipa_call_context): Likewise.
      	(estimate_ipcp_clone_size_and_time):  Likewise.
      	* ipa-fnsummary.h (ipa_call_context): Replace
      	vec<ipa_agg_jump_function_p> with vec<ipa_agg_value_set>.
      	* ipa-inline-analysis.c (do_estimate_edge_time): Replace
      	vec<ipa_agg_jump_function_p> with vec<ipa_agg_value_set>.
      	(do_estimate_edge_size): Likewise.
      	(do_estimate_edge_hints): Likewise.
      
      2019-11-14  Feng Xue  <fxue@os.amperecomputing.com>
      
              PR ipa/91682
              * gcc.dg/ipa/ipcp-agg-10.c: Change dg-scan string.
              * gcc.dg/ipa/ipcp-agg-11.c: New test.
      
      From-SVN: r278193
      Feng Xue committed
    • re PR ipa/92421 (ICE in inline_small_functions, at ipa-inline.c:2001 since r277759) · 3e7cf2e6
      	PR ipa/92421
      	* g++.dg/torture/pr92421.C: Add -Wno-return-type to
      	dg-additional-options.  Avoid -Wwrite-string warnings, most of
      	-Wreturn-type warnings, define bf ctor.  Use struct instead of class
      	with public: at the start.
      
      From-SVN: r278192
      Jakub Jelinek committed
    • alias-decl-pr92206-3.C: Require effective target c++14 rather than c++11. · 49084d39
      	* g++.dg/cpp0x/alias-decl-pr92206-3.C: Require effective target c++14
      	rather than c++11.
      
      From-SVN: r278191
      Jakub Jelinek committed
    • ISO_Fortran_binding_17.c: Include ../../../libgfortran/ISO_Fortran_binding.h rather than... · dec231be
      	* gfortran.dg/ISO_Fortran_binding_17.c: Include
      	../../../libgfortran/ISO_Fortran_binding.h rather than
      	ISO_Fortran_binding.h.
      
      From-SVN: r278190
      Jakub Jelinek committed
    • Daily bump. · d82f3812
      From-SVN: r278189
      GCC Administrator committed
  2. 13 Nov, 2019 24 commits
    • ipa-cp.c (propagate_vr_across_jump_function): Propagate also across binary operations. · 2b89b748
      	* ipa-cp.c (propagate_vr_across_jump_function): Propagate also across
      	binary operations.
      
      From-SVN: r278185
      Jan Hubicka committed
    • ipa-profile.c (check_argument_count): Check properly that e_info is non-NULL; do… · d772e360
      ipa-profile.c (check_argument_count): Check properly that e_info is non-NULL; do not check descriptors.
      
      	* ipa-profile.c (check_argument_count): Check properly that e_info
      	is non-NULL; do not check descriptors.
      
      From-SVN: r278184
      Jan Hubicka committed
    • ipa-inline-analysis.c (do_estimate_edge_time): Relax check for ipa profiles. · 367c959f
      	* ipa-inline-analysis.c (do_estimate_edge_time): Relax
      	check for ipa profiles.
      
      From-SVN: r278179
      Jan Hubicka committed
    • re PR ipa/92421 (ICE in inline_small_functions, at ipa-inline.c:2001 since r277759) · b914768c
      
      	PR c++/92421
      	* ipa-prop.c (update_indirect_edges_after_inlining):
      	Mark parameter as used.
      	* ipa-inline.c (recursive_inlining): Reset node cache
      	after inlining.
      	(inline_small_functions): Remove checking ifdef.
      	* ipa-inline-analysis.c (do_estimate_edge_time): Verify
      	cache consistency.
      	* g++.dg/torture/pr92421.C: New testcase.
      
      From-SVN: r278159
      Jan Hubicka committed
    • re PR ipa/92498 (gcc.dg/tree-prof/crossmodule-indircall-1.c fails starting with r278100) · 7b34a284
      	PR ipa/92498
      	* ipa-profile.c (check_argument_count): Do not ICE when descriptors
      	is NULL.
      	(ipa_profile): Fix reversed test.
      
      From-SVN: r278157
      Jan Hubicka committed
    • ipa-cp.c (ignore_edge_p): Do not check caller flags. · 223f4b10
      	* ipa-cp.c (ignore_edge_p): Do not check caller flags.
      	(propagate_constants_topo): Fix typo.
      
      From-SVN: r278156
      Jan Hubicka committed
    • Move plain value_range things to value-range.[hc]*. · cca78449
      From-SVN: r278153
      Aldy Hernandez committed
    • Sanitize the constant argument for rotr<mode>3 · 425ea30f
      This was dormant for quite some time, but it started happening for me
      on gcc.c-torture/compile/pr65153.c sometime after r276645 for -mabi=32 linux runs.
      
      The pattern accepts any SMALL_OPERAND constant value while it asserts during the final
      that the value is in the mode size range. I this case it happens that combine_and_move_insns
      during ira makes a pattern with negative "shift count" which fails at final stage.
      
      This simple fix just truncates the constant operand to mode size the same as shift patterns.
      
      gcc/ChangeLog:
      
      2019-11-13  Dragan Mladjenovic  <dmladjenovic@wavecomp.com>
      
      	* config/mips/mips.md (rotr<mode>3): Sanitize the constant argument
      	instead of asserting its value.
      
      From-SVN: r278152
      Dragan Mladjenovic committed
    • download_prerequisites: Use http instead of ftp for downloading. · d51dd316
      2019-11-13  Janne Blomqvist  <jb@gcc.gnu.org>
      
              * download_prerequisites: Use http instead of ftp for downloading.
      
      From-SVN: r278151
      Janne Blomqvist committed
    • pr92090.c: Limit -mbig to powerpc64le-*-*. · 5ea9ae01
              * gcc.target/powerpc/pr92090.c: Limit -mbig to powerpc64le-*-*.
              * gcc.target/powerpc/pr92090-2.c: Likewise.
      
      From-SVN: r278150
      David Edelsohn committed
    • libsupc++: Implement comparison algorithms for C++20 · 0ff15d21
      This is incomplete because std::strong_order doesn't support
      floating-point types.
      
      The partial_order and weak_order tests use VERIFY instead of
      static_assert because of PR 92431.
      
      	* libsupc++/compare (strong_order, weak_order, partial_order)
      	(compare_strong_order_fallback, compare_weak_order_fallback)
      	(compare_partial_order_fallback): Define customization point objects
      	for C++20.
      	* testsuite/18_support/comparisons/algorithms/partial_order.cc: New
      	test.
      	* testsuite/18_support/comparisons/algorithms/strong_order.cc: New
      	test.
      	* testsuite/18_support/comparisons/algorithms/weak_order.cc: New test.
      
      From-SVN: r278149
      Jonathan Wakely committed
    • Rewrite value_range constructors to the value_range_kind is at the end, and defaults to VR_RANGE. · 5d462877
      Rewrite value_range constructors to the value_range_kind is at the
      end, and defaults to VR_RANGE.  Similarly for set() methods.
      
      From-SVN: r278148
      Aldy Hernandez committed
    • PR c++/89070 - bogus [[nodiscard]] warning in SFINAE. · 7b521fbd
      This is a complaint that we issue a [[nodiscard]] warning even in SFINAE
      contexts.  Here 'complain' is tf_decltype, but not tf_warning so I guess
      we can fix it as below.
      
      	* cvt.c (convert_to_void): Guard maybe_warn_nodiscard calls with
      	tf_warning.
      
      	* g++.dg/cpp1z/nodiscard7.C: New test.
      
      From-SVN: r278147
      Marek Polacek committed
    • tree-dump.c (dequeue_and_dump): Print first tree operand for VIEW_CONVERT_EXPR. · 2aaf32ab
      2019-11-13  Ulrich Drepper  <drepper@redhat.com>
      
      	* tree-dump.c (dequeue_and_dump): Print first tree operand
      	for VIEW_CONVERT_EXPR.
      
      From-SVN: r278146
      Ulrich Drepper committed
    • Add C2x *_NORM_MAX constants to <float.h>. · 00be2a5f
      C2x adds <float.h> constants FLT_NORM_MAX, DBL_NORM_MAX and
      LDBL_NORM_MAX.  These are for the maximum "normalized" finite
      floating-point number, where the given definition of normalized is
      that all possible values with MANT_DIG significand digits (leading one
      not zero) can be represented with that exponent.  The effect of that
      definition is that these macros are the same as the corresponding MAX
      macros for all formats except IBM long double, where the NORM_MAX
      value has exponent 1 smaller than the MAX one so that all 106 digits
      can be 1.
      
      This patch adds those macros to GCC.  They are only defined for float,
      double and long double; C2x does not include such macros for DFP
      types, and while the integration of TS 18661-3 into C2x has not yet
      occurred, the draft proposed text does not add them for the _FloatN /
      _FloatNx types (where they would always be the same as the MAX
      macros).
      
      Bootstrapped with no regressions on x86_64-pc-linux-gnu.  Also tested
      compilation of the new test for powerpc-linux-gnu to confirm the check
      of LDBL_NORM_MAX in the IBM long double case does get properly
      optimized out.
      
      gcc:
      	* ginclude/float.c [__STDC_VERSION__ > 201710L] (FLT_NORM_MAX,
      	DBL_NORM_MAX, LDBL_NORM_MAX): Define.
      	* real.c (get_max_float): Add norm_max argument.
      	* real.h (get_max_float): Update prototype.
      	* builtins.c (fold_builtin_interclass_mathfn): Update calls to
      	get_max_float.
      
      gcc/c-family:
      	* c-cppbuiltin.c (builtin_define_float_constants): Also define
      	NORM_MAX constants.  Update call to get_max_float.
      	(LAZY_HEX_FP_VALUES_CNT): Update value to include NORM_MAX
      	constants.
      
      gcc/d:
      	* d-target.cc (define_float_constants): Update call to
      	get_max_float.
      
      gcc/testsuite:
      	* gcc.dg/c11-float-3.c, gcc.dg/c2x-float-1.c: New tests.
      
      From-SVN: r278145
      Joseph Myers committed
    • Come up with selftests for dbgcnt. · 5024c8bb
      2019-11-13  Martin Liska  <mliska@suse.cz>
      
      	* dbgcnt.c (test_sorted_dbg_counters): New.
      	(dbgcnt_c_tests): Likewise.
      	* selftest-run-tests.c (selftest::run_tests): Likewise.
      	* selftest.h (dbgcnt_c_tests): Likewise.
      
      From-SVN: r278144
      Martin Liska committed
    • Add a few missing checks that IPA_NODE_REF is not NULL (PR 92454) · 3c4fa8a8
      2019-11-13  Jan Hubicka  <hubicka@ucw.cz>
      	    Martin Jambor  <mjambor@suse.cz>
      
      	PR ipa/92454
      	* ipa-cp.c (spread_undeadness): Check that IPA_NODE_REF exists.
      	(identify_dead_nodes): Likewise.
      
      	testsuite/
      	* g++.dg/ipa/pr92454.C: New test.
      
      From-SVN: r278142
      Martin Jambor committed
    • Do not overuse push/pop_cfun in IPA ICF. · a5e2beb9
      2019-11-13  Martin Liska  <mliska@suse.cz>
      
      	* ipa-icf.c (sem_function::equals_private): Do not overuse
      	push/pop_cfun functions.
      
      From-SVN: r278141
      Martin Liska committed
    • Enhance syntax of -fdbg-cnt. · 83a49336
      2019-11-13  Martin Liska  <mliska@suse.cz>
      
      	* common.opt: Document change of -fdbg-cnt option.
      	* dbgcnt.c (DEBUG_COUNTER): Remove.
      	(dbg_cnt_is_enabled): Remove.
      	(dbg_cnt): Work with new intervals.
      	(dbg_cnt_set_limit_by_index): Set to new
      	list of intervals.
      	(dbg_cnt_set_limit_by_name): Likewise.
      	(dbg_cnt_process_single_pair): Process new format.
      	(dbg_cnt_process_opt): Likewise.
      	(dbg_cnt_list_all_counters): Likewise.
      	* doc/invoke.texi: Document change of -fdbg-cnt option.
      	(cmp_tuples): New.
      2019-11-13  Martin Liska  <mliska@suse.cz>
      
      	* gcc.dg/ipa/ipa-icf-39.c: Update -fdbg-cnt to the new format.
      	* gcc.dg/pr68766.c: Likewise.
      
      From-SVN: r278140
      Martin Liska committed
    • ipa-inline.c (ipa_inline): Check that function is defined before flattening. · 2895b172
      
      	* ipa-inline.c (ipa_inline): Check that function is defined before
      	flattening.
      	* gcc.c-torture/compile/flatten.c: New testcase.
      
      From-SVN: r278139
      Jan Hubicka committed
    • GCN Libgomp Plugin · 237957cc
      2019-11-13  Andrew Stubbs  <ams@codesourcery.com>
      	    Kwok Cheung Yeung  <kcy@codesourcery.com>
      	    Julian Brown  <julian@codesourcery.com>
      	    Tom de Vries  <tom@codesourcery.com>
      
      	libgomp/
      	* plugin/Makefrag.am: Add amdgcn plugin support.
      	* plugin/configfrag.ac: Likewise.
      	* plugin/plugin-gcn.c: New file.
      	* configure: Regenerate.
      	* Makefile.in: Regenerate.
      	* testsuite/Makefile.in: Regenerate.
      
      Co-Authored-By: Julian Brown <julian@codesourcery.com>
      Co-Authored-By: Kwok Cheung Yeung <kcy@codesourcery.com>
      Co-Authored-By: Tom de Vries <tom@codesourcery.com>
      
      From-SVN: r278138
      Andrew Stubbs committed
    • Use a single worker for OpenACC on AMD GCN · fe22e0d4
      2019-11-13  Andrew Stubbs  <ams@codesourcery.com>
      	    Julian Brown  <julian@codesourcery.com>
      
      	gcc/
      	* config/gcn/gcn.c (gcn_goacc_validate_dims): Ensure
      	flag_worker_partitioning is not set.
      	(TARGET_GOACC_WORKER_PARTITIONING): Remove target hook definition.
      	* config/gcn/gcn.opt (macc-experimental-workers): Default to off.
      
      Co-Authored-By: Julian Brown <julian@codesourcery.com>
      
      From-SVN: r278137
      Andrew Stubbs committed
    • Optimize GCN OpenMP malloc performance · cee16451
      2019-11-13  Andrew Stubbs  <ams@codesourcery.com>
      
      	libgomp/
      	* config/gcn/team.c (gomp_gcn_enter_kernel): Set up the team arena
      	and use team_malloc variants.
      	(gomp_gcn_exit_kernel): Use team_free.
      	* libgomp.h (TEAM_ARENA_SIZE): Define.
      	(TEAM_ARENA_START): Define.
      	(TEAM_ARENA_FREE): Define.
      	(TEAM_ARENA_END): Define.
      	(team_malloc): New function.
      	(team_malloc_cleared): New function.
      	(team_free): New function.
      	* team.c (gomp_new_team): Initialize and use team_malloc.
      	(free_team): Use team_free.
      	(gomp_free_thread): Use team_free.
      	(gomp_pause_host): Use team_free.
      	* work.c (gomp_init_work_share): Use team_malloc.
      	(gomp_fini_work_share): Use team_free.
      
      From-SVN: r278136
      Andrew Stubbs committed
    • GCN libgomp port · fa499995
      2019-11-13  Andrew Stubbs  <ams@codesourcery.com>
      	    Kwok Cheung Yeung  <kcy@codesourcery.com>
      	    Julian Brown  <julian@codesourcery.com>
      	    Tom de Vries  <tom@codesourcery.com>
      
      	include/
      	* gomp-constants.h (GOMP_DEVICE_GCN): Define.
      	(GOMP_VERSION_GCN): Define.
      
      	libgomp/
      	* Makefile.am (libgomp_la_SOURCES): Add oacc-target.c.
      	* Makefile.in: Regenerate.
      	* config.h.in (PLUGIN_GCN): Add new undef.
      	* config/accel/openacc.f90 (acc_device_gcn): New parameter.
      	* config/gcn/affinity-fmt.c: New file.
      	* config/gcn/bar.c: New file.
      	* config/gcn/bar.h: New file.
      	* config/gcn/doacross.h: New file.
      	* config/gcn/icv-device.c: New file.
      	* config/gcn/oacc-target.c: New file.
      	* config/gcn/simple-bar.h: New file.
      	* config/gcn/target.c: New file.
      	* config/gcn/task.c: New file.
      	* config/gcn/team.c: New file.
      	* config/gcn/time.c: New file.
      	* configure.ac: Add amdgcn*-*-*.
      	* configure: Regenerate.
      	* configure.tgt: Add amdgcn*-*-*.
      	* libgomp-plugin.h (offload_target_type): Add OFFLOAD_TARGET_TYPE_GCN.
      	* libgomp.h (gcn_thrs): Add amdgcn variant.
      	(set_gcn_thrs): Likewise.
      	(gomp_thread): Likewise.
      	* oacc-int.h (goacc_thread): Likewise.
      	* oacc-target.c: New file.
      	* openacc.f90 (acc_device_gcn): New parameter.
      	* openacc.h (acc_device_t): Add acc_device_gcn.
      	* team.c (gomp_free_pool_helper): Add amdgcn support.
      
      Co-Authored-By: Julian Brown <julian@codesourcery.com>
      Co-Authored-By: Kwok Cheung Yeung <kcy@codesourcery.com>
      Co-Authored-By: Tom de Vries <tom@codesourcery.com>
      
      From-SVN: r278135
      Andrew Stubbs committed