1. 22 Apr, 2020 23 commits
    • S/390: Fix several test cases · 803596fe
      gcc/ChangeLog:
      
      2020-04-21  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>
      
      	* config/s390/s390.md ("*<risbg_n>_ior_and_sr_ze<mode>"): Lift from SI
      	mode to DSI. ("*trunc_sidi_and_subreg_ze<clobbercc_or_nocc>"): New
      	insn pattern.
      
      gcc/testsuite/ChangeLog:
      
      2020-04-21  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>
      
      	* gcc.target/s390/addsub-signed-overflow-1.c: Fix options.
      	* gcc.target/s390/addsub-signed-overflow-2.c: Fix options.
      	* gcc.target/s390/bswap-1.c: Fix scan assembler regex.
      	* gcc.target/s390/global-array-element-pic2.c: Fix scan assembler regex.
      	* gcc.target/s390/load-relative-check.c: Fix options.
      	* gcc.target/s390/morestack.c: Fix options.
      	* gcc.target/s390/nobp-return-mem-z900.c: Temporarily silence this case.
      	* gcc.target/s390/risbg-ll-1.c: Fix scan assembler regex.
      	* gcc.target/s390/risbg-ll-2.c: Fix scan assembler regex.
      	* gcc.target/s390/risbg-ll-3.c: Fix scan assembler regex.
      	* gcc.target/s390/target-attribute/pr82012.c: Fix error message.
      Stefan Schulze Frielinghaus committed
    • ia64: Fix C++14 vs. C++17 ABI issue on ia64 [PR94706] · 1be62528
      ia64 seems to be affected too, but the backend doesn't have any
      -Wpsabi warnings and I'm not sure if we really need them for an (almost?)
      dead target.
      
      2020-04-22  Jakub Jelinek  <jakub@redhat.com>
      
      	PR target/94706
      	* config/ia64/ia64.c (hfa_element_mode): Ignore
      	cxx17_empty_base_field_p fields.
      Jakub Jelinek committed
    • calls: Introduce cxx17_empty_base_field_p [PR94383] · c3a34659
      As multiple targets are affected apparently, I believe at least
      aarch64, arm, powerpc64le, s390{,x} and ia64,
      I think we should have a middle-end predicate for this, so that if we need
      to tweak it, we can do it in one spot.
      
      2020-04-22  Jakub Jelinek  <jakub@redhat.com>
      
      	PR target/94383
      	* calls.h (cxx17_empty_base_field_p): Declare.
      	* calls.c (cxx17_empty_base_field_p): Define.
      Jakub Jelinek committed
    • testsuite: [arm] Include arm_acle.h in related effective targets · 4e16452e
      Since arm_acle.h includes stdint.h, its use requires the presence of
      the right gnu/stub-*.h, so make sure to include arm_acle.h when
      checking the effective targets that generally imply that the testcase
      will include it: arm_dsp, arm_crc, arm_coproc[1-4]
      
      This makes several tests unsupported rather than fail.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* lib/target-supports.exp (check_effective_target_arm_dsp)
      	(check_effective_target_arm_crc_ok_nocache)
      	(check_effective_target_arm_coproc1_ok_nocache)
      	(check_effective_target_arm_coproc2_ok_nocache)
      	(check_effective_target_arm_coproc3_ok_nocache)
      	(check_effective_target_arm_coproc4_ok_nocache): Include
      	arm_acle.h.
      Christophe Lyon committed
    • testsuite: [arm/cde] Include arm_cde.h and arm_mve.h in arm_v8*m_main_cde* · e6474e22
      Since arm_cde.h includes stdint.h, its use requires the presence of
      the right gnu/stub-*.h, so make sure to include it when checking the
      arm_v8*m_main_cde* effective targets, otherwise we can decide CDE is
      supported while it's not really (all tests that use arm_v8m_main_cde*
      also include arm_cde.h aynway).
      
      Similarly for the effective targets that also require MVE.
      
      This makes several tests unsupported rather than fail.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* lib/target-supports.exp (arm_v8m_main_cde, arm_v8m_main_cde_fp)
      	(arm_v8_1m_main_cde_mve, arm_v8_1m_main_cde_mve_fp): Include
      	arm_cde.h and arm_mve.h as ineeded.
      Christophe Lyon committed
    • testsuite: [arm/mve] Include arm_mve.h in arm_v8_1m_mve_ok · 55ba33cc
      Since arm_mve.h includes stdint.h, its use requires the presence of
      the right gnu/stub-*.h, so make sure to include it when checking the
      arm_v8_1m_mve_ok_nocache effective target, otherwise we can decide MVE
      is supported while it's not really. This makes several tests
      unsupported rather than fail.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* lib/target-supports.exp
      	(check_effective_target_arm_v8_1m_mve_ok_nocache): Include
      	arm_mve.h.
      Christophe Lyon committed
    • testsuite: [arm/mve] Use dg-add-options arm_v8_1m_mve in MVE tests · 90d6f07c
      Several ARM/MVE tests can be compiled even if the toolchain does not
      support -mfloat-abi=hard (softfp is OK).
      
      Use dg-add-options arm_v8_1m_mve or arm_v8_1m_mve_fp instead of using
      dg-additional-options.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* gcc.target/arm/mve/intrinsics/mve_vector_float.c: Use
      	arm_v8_1m_mve_fp.
      	* gcc.target/arm/mve/intrinsics/mve_vector_float1.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_float2.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_int.c: Use
      	arm_v8_1m_mve.
      	* gcc.target/arm/mve/intrinsics/mve_vector_int1.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_int2.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_uint.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_uint1.c: Likewise.
      	* gcc.target/arm/mve/intrinsics/mve_vector_uint2.c: Likewise.
      Christophe Lyon committed
    • testsuite: [arm/mve] Fix mve_move_gpr_to_gpr.c · bdeca63c
      This test can pass with a hard-float toolchain, provided we don't
      force -mfloat-abi=softfp.
      
      This patch removes this useless option, as well as -save-temps which
      is implied by arm_v8_1m_mve_fp.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* gcc.target/arm/mve/intrinsics/mve_move_gpr_to_gpr.c: Remove
      	useless options.
      Christophe Lyon committed
    • testsuite: [arm/mve] Use arm_softfp and arm_hard as needed in MVE tests · ddce7c0c
      Some MVE tests explicitly test a -mfloat-abi=hard option, but we need
      to check that the toolchain actually supports it (which may not be the
      case for arm-linux-gnueabi* targets). We can thus remove the related
      dg-skip directives.
      
      We also make use of dg-add-options arm_v8_1m_mve_fp and arm_v8_1m_mve
      instead of duplicating the corresponding options in
      dg-additional-options where we keep only -mfloat-abi to override the
      option selected by arm_v8_1m_mve_fp.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* gcc.target/arm/mve/intrinsics/mve_fp_fpu1.c: Use arm_hard_ok
      	effective target and arm_v8_1m_mve_fp options.
      	* gcc.target/arm/mve/intrinsics/mve_fp_fpu2.c: Use arm_softfp_ok
      	effective target and arm_v8_1m_mve_fp options.
      	* gcc.target/arm/mve/intrinsics/mve_fpu1.c: Use arm_hard_ok
      	effective target and arm_v8_1m_mve options.
      	* gcc.target/arm/mve/intrinsics/mve_fpu2.c: Use arm_softfp_ok
      	effective target and arm_v8_1m_mve options.
      Christophe Lyon committed
    • testsuite: [arm] Add arm_softfp_ok and arm_hard_ok effective targets. · d414c915
      For arm-linux-gnueabi* targets, a toolchain cannot support the
      float-abi opposite to the one it has been configured for: since glibc
      does not support such multilibs, we end up lacking gnu/stubs-*.h when
      including stdint.h for instance.
      
      This patch introduces two new effective targets to detect whether we
      can compile tests with -mfloat-abi=softfp or -mfloat-abi=hard.
      
      This enables to make such tests unsupported rather than fail.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* lib/target-supports.exp (arm_softfp_ok): New effective target.
      	(arm_hard_ok): Likewise.
      
      	gcc/
      	* doc/sourcebuild.texi (arm_softfp_ok, arm_hard_ok): Document.
      Christophe Lyon committed
    • [arm] Add initial support for Arm Cortex-M55 · a87e0cba
      This patch adds initial -mcpu support for the Arm Cortex-M55 CPU.
      This CPU is an Armv8.1-M Mainline CPU supporting MVE.
      An option to disable floating-point (and MVE) is provided with the +nofp.
      For GCC 11 I'd like to add further fine-grained options to enable integer-only MVE
      but that needs a bit more elaborate surgery in arm-cpus.in that I don't want to do
      in GCC 10 at this stage.
      
      As this CPU is not supported in gas and I don't want to couple GCC 10 to the very
      latest binutils anyway, this CPU emits the cpu string in the assembly file as a build attribute
      rather than a .cpu directive, thus sparing us the need to support .cpu cortex-m55 in gas.
      The .cpu directive in gas isn't used for anything besides setting the Tag_CPU_name
      build attribute anyway (which itself is not used by any tools I'm aware of).
      All the architecture information used for target detection is already emitted using .arch_extension
      directives and similar.
      
      Bootstrapped and tested on arm-none-linux-gnueabihf. Also tested on arm-none-eabi.
      
      2020-04-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
                  Andre Vieira  <andre.simoesdiasvieira@arm.com>
                  Mihail Ionescu  <mihail.ionescu@arm.com>
      
      	* config/arm/arm.c (arm_file_start): Handle isa_bit_quirk_no_asmcpu.
      	* config/arm/arm-cpus.in (quirk_no_asmcpu): Define.
      	(ALL_QUIRKS): Add quirk_no_asmcpu.
      	(cortex-m55): Define new cpu.
      	* config/arm/arm-tables.opt: Regenerate.
      	* config/arm/arm-tune.md: Likewise.
      	* doc/invoke.texi (Arm Options): Document -mcpu=cortex-m55.
      Kyrylo Tkachov committed
    • [Fortran] Truncate warn with OpenMP/OpenACC/!GCC$ (PR94709) · 4ea769a9
      While '!$' with -fopenmp unsets too often load_line's seen_comment flag,
      this only affects <tab> warnings; for trunction warnings, gfc_next_char_literal
      re-handles the directives correctly.  In terms of missed warnings, a directive
      that is completely in the truncated part is not diagnosted (as it starts
      with a '!').
      
              PR fortran/94709
              * scanner.c (load_line): In fixed form, also treat 'C' as comment and
              'D'/'d' only with -fd-lines-as-comments. Treat '!$' with -fopenmp,
              '!$acc' with -fopenacc and '!GCC$' as non-comment to permit <tab>
              and truncation warnings.
      
              PR fortran/94709
              * gfortran.dg/gomp/warn_truncated.f: New.
              * gfortran.dg/gomp/warn_truncated.f90: New.
      Tobias Burnus committed
    • Add a missed Changelog entry. · 4a047a32
      Iain Sandoe committed
    • forwprop: Fix ICE when building an identity constructor [PR94700] · 413232a5
      This is really PR94683 part 2, handling the case in which the vector is
      an identity and so doesn't need a VEC_PERM_EXPR.  I should have realised
      at the time that the other arm of the "if" would need the same fix.
      
      2020-04-22  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	PR tree-optimization/94700
      	* tree-ssa-forwprop.c (simplify_vector_constructor): When processing
      	an identity constructor, use a VIEW_CONVERT_EXPR to handle mixtures
      	of similarly-structured but distinct vector types.
      
      gcc/testsuite/
      	PR tree-optimization/94700
      	* gcc.target/aarch64/sve/acle/general/pr94700.c: New test.
      Richard Sandiford committed
    • coroutines, testsuite: Tidy some test names (NFC). · 56b15072
      Try to make sure that we have consistent naming for the tests
      before first release.
      
      gcc/testsuite/ChangeLog:
      
      2020-04-22 Iain Sandoe <iain@sandoe.co.uk>
      
      	* g++.dg/coroutines/torture/local-var-0.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-00-const.C: ...this.
      	* g++.dg/coroutines/torture/local-var-1.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-01-single.C: ...this.
      	* g++.dg/coroutines/torture/local-var-2.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-02-conditional.C: ...this.
      	* g++.dg/coroutines/torture/local-var-3.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-03-with-awaits.C: ...this.
      	* g++.dg/coroutines/torture/local-var-4.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-04-hiding-nested-scopes.C: this.
      	* g++.dg/coroutines/torture/local-var-5-awaitable.C: Rename to...
      	* g++.dg/coroutines/torture/local-var-05-awaitable.C: ...this.
      Iain Sandoe committed
    • coroutines: Pass class reference to promise param preview [PR94682] · 38644f81
      As reported in the PR, per [dcl.fct.def.coroutine]/4 we should
      be passing a reference to the object to the promise parameter
      preview, and we are currently passing a pointer (this).  Amend to
      pass the reference.
      
      gcc/cp/ChangeLog:
      
      2020-04-22  Iain Sandoe  <iain@sandoe.co.uk>
      
      	PR c++/94682
      	* coroutines.cc (struct param_info): Add a field to note that
      	the param is 'this'.
      	(morph_fn_to_coro): Convert this to a reference before using it
      	in the promise parameter preview.
      
      gcc/testsuite/ChangeLog:
      
      2020-04-22  Iain Sandoe  <iain@sandoe.co.uk>
      
      	PR c++/94682
      	* g++.dg/coroutines/pr94682-preview-this.C: New test.
      Iain Sandoe committed
    • MAINTAINERS: add myself for write after approval · 9ad3c1d8
      ChangeLog:
      
      2020-04-22  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>
      
      	* MAINTAINERS (Write After Approval): add myself
      Stefan Schulze Frielinghaus committed
    • testsuite: Handle --save-temps in schedule-cleanups · ce9b5c09
      Some tests use --save-temps, but schedule-cleanups strictly matches
      -save-temps, so we leave many temporary files after validation.
      Instead of fixing every offending testcase, it's simpler and
      future-proof to make schedule-cleanups handle both --save-temps and
      -save-temps.
      
      2020-04-22  Christophe Lyon  <christophe.lyon@linaro.org>
      
      	gcc/testsuite/
      	* lib/gcc-dg.exp (schedule-cleanups): Accept --save-temps.
      Christophe Lyon committed
    • c++: generic lambda forwarding function [PR94546] · aedd04ca
      While instantiating test(Plot) we partially instantiate the generic lambda.
      We look at forward<T>(rest)... and see that it's just replacing parameter
      packs with new parameter packs and tries to do a direct substitution.  But
      because register_parameter_specializations had built up a
      NONTYPE_ARGUMENT_PACK around the new parameter pack, the substitution
      failed.  So let's not wrap it that way.
      
      gcc/cp/ChangeLog
      2020-04-22  Jason Merrill  <jason@redhat.com>
      
      	PR c++/94546
      	* pt.c (register_parameter_specializations): If the instantiation is
      	still a parameter pack, don't wrap it in a NONTYPE_ARGUMENT_PACK.
      	(tsubst_pack_expansion, tsubst_expr): Adjust.
      Jason Merrill committed
    • c++: reject scalar array initialization with nullptr [PR94510] · 58797021
      The change committed to GCC 9 to allow string literals as template arguments
      caused the compiler to prune away, and thus miss diagnosing, conversion from
      nullptr to int in an array initializer.  After looking at various approaches
      to improving the pruning, we realized that the only place the pruning is
      necessary is in the mangler.
      
      gcc/cp/ChangeLog
      2020-04-22  Martin Sebor  <msebor@redhat.com>
      	    Jason Merrill  <jason@redhat.com>
      
      	PR c++/94510
      	* decl.c (reshape_init_array_1): Avoid stripping redundant trailing
      	zero initializers...
      	* mangle.c (write_expression): ...and handle them here even for
      	pointers to members by calling zero_init_expr_p.
      	* cp-tree.h (zero_init_expr_p): Declare.
      	* tree.c (zero_init_expr_p): Define.
      	(type_initializer_zero_p): Remove.
      	* pt.c (tparm_obj_values): New hash_map.
      	(get_template_parm_object): Store to it.
      	(tparm_object_argument): New.
      
      gcc/testsuite/ChangeLog
      2020-04-22  Martin Sebor  <msebor@redhat.com>
      
      	PR c++/94510
      	* g++.dg/init/array58.C: New test.
      	* g++.dg/init/array59.C: New test.
      	* g++.dg/cpp2a/nontype-class34.C: New test.
      	* g++.dg/cpp2a/nontype-class35.C: New test.
      Martin Sebor committed
    • libstdc++: Improve tests for __cpp_lib_erase_if macro · 0fe9eaaa
      	* testsuite/21_strings/basic_string/erasure.cc: Check for updated
      	value of __cpp_lib_erase_if.
      	* testsuite/23_containers/deque/erasure.cc: Likewise.
      	* testsuite/23_containers/forward_list/erasure.cc: Likewise.
      	* testsuite/23_containers/list/erasure.cc: Likewise.
      	* testsuite/23_containers/map/erasure.cc: Likewise.
      	* testsuite/23_containers/set/erasure.cc: Likewise.
      	* testsuite/23_containers/unordered_map/erasure.cc: Likewise.
      	* testsuite/23_containers/unordered_set/erasure.cc: Likewise.
      	* testsuite/23_containers/vector/erasure.cc: Likewise.
      Jonathan Wakely committed
    • c++: Diagnose invalid use of member function in requires · 05f14938
      This updates diagnose_valid_expression to mirror the convert_to_void check added
      to tsubst_valid_expression_requirement by r10-7554.
      
      gcc/cp/ChangeLog:
      
      	PR c++/67825
      	* constraint.cc (diagnose_valid_expression): Check convert_to_void here
      	as well as in tsubst_valid_expression_requirement.
      
      gcc/testsuite/ChangeLog:
      
      	PR c++/67825
      	* g++.dg/concepts/diagnostic10.C: New test.
      	* g++.dg/cpp2a/concepts-pr67178.C: Adjust dg-message.
      Patrick Palka committed
    • Daily bump. · c270abe8
      GCC Administrator committed
  2. 21 Apr, 2020 17 commits
    • libstdc++: Fix __normal_iterator comparisons for C++20 · 87841658
      This fixes a regression introduced when I replaced __normal_iterator's
      relational operators with operator<=>. If the wrapped iterator type
      doesn't define operator<=> then __normal_iterator doesdn't either, which
      breaks any use of fancy pointers that don't define <=>. The regression
      was found when trying to build cmcstl2.
      
      The solution is to use synth-three-way to define __normal_iterator's
      spaceship operator, so that it is still defined even if the wrapped type
      only supports operator<.
      
      	* include/bits/stl_iterator.h (__normal_iterator): Use synth-three-way
      	to define operator<=>.
      	* testsuite/24_iterators/normal_iterator/cmp_c++20.cc: New test.
      Jonathan Wakely committed
    • c++: Constrained inherited constructor template [PR94549] · 0e665f25
      A comment in satisfy_declaration_constraints says
      
        /* For inherited constructors, consider the original declaration;
           it has the correct template information attached. */
        d = strip_inheriting_ctors (d);
      
      but it looks like this comment is wrong when the inherited constructor is for an
      instantiation of a constructor template.  In that case, DECL_TEMPLATE_INFO is
      correct and DECL_INHERITED_CTOR points to the constructor template of the base
      class rather than to the particular instantiation of the constructor template
      (and so the DECL_TI_ARGS of the DECL_INHERITED_CTOR are in their dependent
      form).
      
      So doing strip_inheriting_ctors in this case then eventually leads to
      satisfy_associated_constraints returning true regardless of the constraints
      themselves, due to the passed in 'args' being dependent.
      
      An inherited constructor seems to have a non-empty DECL_TEMPLATE_INFO only when
      it's for an instantiation of a constructor template, so this patch fixes this
      issue by checking for empty DECL_TEMPLATE_INFO before calling
      strip_inheriting_ctors.
      
      There is another unguarded call to strip_inheriting_ctors in
      get_normalized_constraints_from_decl, but this one seems to be safe to do
      unconditionally because the rest of that function doesn't need/look at the
      DECL_TI_ARGS of the decl.
      
      gcc/cp/ChangeLog:
      
      	PR c++/94549
      	* constraint.cc (satisfy_declaration_constraints): Don't strip the
      	inherited constructor if it already has template information.
      
      gcc/testsuite/ChangeLog:
      
      	PR c++/94549
      	* g++.dg/concepts/inherit-ctor3.C: Adjust expected diagnostics.
      	* g++.dg/cpp2a/concepts-inherit-ctor4.C: New test.
      	* g++.dg/cpp2a/concepts-inherit-ctor8.C: New test.
      Patrick Palka committed
    • testsuite: Fix position of changelog entry · e76100ce
      One of the changelog entries in commit d76925e4 got put in
      the wrong place after a rebase. This places it correctly.
      Jonathan Wakely committed
    • libstdc++: Improve C++14 and C++17 status docs · 57ede05c
      This adds a full table of contents for the C++14 and C++17 standards,
      with status for each part.
      
      For C++14 the list of proposals is removed, as it adds little value now
      that everything is supported. For C++17 the table of proposals is
      retained, because it documents he feature test macros for the features.
      
      	* doc/Makefile.am (xml_sources_manual): Add missing XML files.
      	* doc/Makefile.in: Regenerate.
      	* doc/xml/manual/status_cxx1998.xml: Refer to "this section" instead
      	of "this page".
      	* doc/xml/manual/status_cxx2011.xml: Formatting and other corrections
      	to the C++11 status table.
      	* doc/xml/manual/status_cxx2014.xml: Replace list of C++14 feature
      	proposals with table matching contents of the C++14 standard.
      	* doc/xml/manual/status_cxx2017.xml: Add table matching contents of
      	the C++17 standard.
      	* doc/html/*: Regenerate.
      Jonathan Wakely committed
    • libstdc++: Support arrays in std::is_nothrow_constructible (PR 94149) · d76925e4
      The front end now supports parenthesized initialization for arrays in
      C++20, so extend std::is_nothrow_constructible to support them too.
      
      gcc/testsuite:
      
      	PR c++/94149
      	* g++.dg/cpp2a/paren-init24.C: Fix FIXMEs.
      
      libstdc++-v3:
      
      	PR c++/94149
      	* include/std/type_traits (__is_nt_constructible_impl): Add partial
      	specializations for bounded arrays with non-empty initializers.
      	* testsuite/20_util/is_nothrow_constructible/value_c++20.cc: New test.
      Jonathan Wakely committed
    • libphobos: Remove GDCFLAGSX variable from configure scripts. · 81e07d42
      Always run testsuite with same GDCFLAGS as used in build.
      
      libphobos/ChangeLog:
      
      	* Makefile.in: Regenerate.
      	* configure: Regenerate.
      	* configure.ac: Remove GDCFLAGSX.
      	* libdruntime/Makefile.in: Regenerate.
      	* src/Makefile.in: Regenerate.
      	* testsuite/Makefile.in: Regenerate.
      	* testsuite/testsuite_flags.in: Use GDCFLAGS in --gdcflags.
      	* testsuite/libphobos.thread/fiber_guard_page.d: Test using -O0.
      Iain Buclaw committed
    • PR middle-end/94647 - bogus -Warray-bounds on strncpy into a larger member array… · 3942060c
      PR middle-end/94647 - bogus -Warray-bounds on strncpy into a larger member array from a smaller array
      
      gcc/ChangeLog:
      
      	PR middle-end/94647
      	* gimple-ssa-warn-restrict.c (builtin_access::builtin_access): Correct
      	the computation of the lower bound of the source access size.
      	(builtin_access::generic_overlap): Remove a hack for setting ranges
      	of overlap offsets.
      
      gcc/testsuite/ChangeLog:
      
      	PR middle-end/94647
      	* c-c++-common/Warray-bounds-2.c: Adjust a test case and add a new one.
      	* c-c++-common/Warray-bounds-3.c: Add tests for missing warnings.
      	* c-c++-common/Wrestrict.c: Invert bounds in printed ranges.
      	* gcc.dg/Warray-bounds-59.c: New test.
      	* gcc.dg/Wrestrict-10.c: Add a missing warning.
      	* gcc.dg/Wrestrict-5.c: Adjust text of expected warning.
      	* gcc.dg/Wrestrict-6.c: Expect to see a range of overlap offsets.
      Martin Sebor committed
    • aarch64, libgcc: Fix unwinding from pac-ret to normal frames [PR94514] · fb22faf4
      With -mbranch-protection=pac-ret the debug info toggles the
      signedness state of the return address so the unwinder knows when
      the return address needs pointer authentication.
      
      The unwind context flags were not updated according to the dwarf
      frame info.
      
      This causes unwinding across frames that were built without pac-ret
      to incorrectly authenticate the return address wich corrupts the
      return address on a system where PAuth is enabled.
      
      Note: This even affects systems where all code use pac-ret because
      unwinding across a signal frame the return address is not signed.
      
      gcc/testsuite/ChangeLog:
      
      	PR target/94514
      	* g++.target/aarch64/pr94514.C: New test.
      	* gcc.target/aarch64/pr94514.c: New test.
      
      libgcc/ChangeLog:
      
      	PR target/94514
      	* config/aarch64/aarch64-unwind.h (aarch64_frob_update_context):
      	Update context->flags accroding to the frame state.
      Szabolcs Nagy committed
    • Fix weakening of external declarations. · 1d4a3bfa
      	2020-04-21  John David Anglin  <danglin@gcc.gnu.org>
      
      	* config/pa/som.h (ASM_WEAKEN_LABEL): Delete.
      	(ASM_WEAKEN_DECL): New define.
      	(HAVE_GAS_WEAKREF): Undefine.
      John David Anglin committed
    • forwprop: Fix ICE when building a VEC_PERM_EXPR [PR94683] · 85353e24
      The type compatibility handling in simplify_vector_constructor is
      based on the number of elements and on element type compatibility,
      but that's no longer enough to ensure that two vector types are
      compatible.  This patch uses a VIEW_CONVERT_EXPR if the permutation
      type and result type are distinct.
      
      2020-04-21  Richard Sandiford  <richard.sandiford@arm.com>
      
      gcc/
      	PR tree-optimization/94683
      	* tree-ssa-forwprop.c (simplify_vector_constructor): Use a
      	VIEW_CONVERT_EXPR to handle mixtures of similarly-structured
      	but distinct vector types.
      
      gcc/testsuite/
      	PR tree-optimization/94683
      	* gcc.target/aarch64/sve/acle/general/pr94683.c: New test.
      Richard Sandiford committed
    • testsuite: Extend C++ struct-layout-1.exp testing to test C++14 vs. C++17… · 61960234
      testsuite: Extend C++ struct-layout-1.exp testing to test C++14 vs. C++17 interoperability of structs with empty bases [PR94383]
      
      Jonathan reported an ABI incompatibility between C++14 and C++17 in
      passing some aggregates with empty bases on aarch64 (and apparently on arm
      too).
      
      The following patch adds 3000 (by default) tests for such interoperability,
      using the struct-layout-1* framework.  The current 3000 tests are generated
      as is (so unchanged from previous ones), and afterwards there is another set
      of 3000 ones, where always one of the tNNN_x.C and tNNN_y.C tests get added
      -std=c++14 -DCXX14_VS_CXX17 and another one -std=c++17 -DCXX14_VS_CXX17
      options (which one which is chosen pseudo-randomly), which causes the
      structs to have an empty base.
      
      I haven't added (yet) checks if the alternate compiler does support these
      options (I think that can be done incrementally), so for now this testing is
      done only if the alternate compiler is not used.
      
      I had to fix a bug in the flexible array handling, because while we were
      lucky in the 3000 generated tests not to have toplevel fields after field
      with flexible array members, in the next 3000 we aren't lucky anymore.
      But even with that change, diff -upr between old and new
      testsuite/g++/g++.dg/g++.dg-struct-layout-1/ doesn't show any differences
      except for the ^Only in... messages for the new tests in there.
      
      Bootstrapped/regtested on x86_64-linux and i686-linux and additionally
      tested on aarch64-linux, where
      FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_tst.o execute
      FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_tst.o-cp_compat_y_tst.o execute
      FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_tst.o-cp_compat_y_tst.o execute
      FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_tst.o execute
      FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_tst.o execute
      because of the backend bug, and with that bug fixed it succeeds.
      Matthew has kindly tested it also on aarch64-linux and arm*-*.
      
      The primary goal of the patch is catch if some targets other than aarch64 or
      arm aren't affected too.
      
      2020-04-21  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c++/94383
      	* g++.dg/compat/struct-layout-1.exp: If !$use_alt, add -c to generator
      	args.
      	* g++.dg/compat/struct-layout-1_generate.c (dg_options): Add another
      	%s to the start of dg-options arg.
      	(cxx14_vs_cxx17, do_cxx14_vs_cxx17): New variables.
      	(switchfiles): If cxx14_vs_cxx17, prepend -std=c++14 -DCXX14_VS_CXX17
      	or -std=c++17 -DCXX17_VS_CXX14 - randomly - to dg-options.
      	(output): Don't append further fields once one with flexible array
      	member is added.
      	(generate_random_tests): Don't use toplevel unions if cxx14_vs_cxx17.
      	(main): If -c, emit second set of tests for -std=c++14 vs. -std=c++17
      	testing.
      	* g++.dg/compat/struct-layout-1_x1.h (empty_base): New type.
      	(EMPTY_BASE): Define.
      	(TX): Use EMPTY_BASE.
      	* g++.dg/compat/struct-layout-1_y1.h (empty_base): New type.
      	(EMPTY_BASE): Define.
      	(TX): Use EMPTY_BASE.
      Jakub Jelinek committed
    • ubsan: Avoid -Wpadded warnings [PR94641] · 73f8e9dc
      -Wpadded warnings aren't really useful for the artificial types that GCC
      lays out for ubsan.
      
      2020-04-21  Jakub Jelinek  <jakub@redhat.com>
      
      	PR c/94641
      	* stor-layout.c (place_field, finalize_record_size): Don't emit
      	-Wpadded warning on TYPE_ARTIFICIAL rli->t.
      	* ubsan.c (ubsan_get_type_descriptor_type,
      	ubsan_get_source_location_type, ubsan_create_data): Set
      	TYPE_ARTIFICIAL.
      	* asan.c (asan_global_struct): Likewise.
      
      	* c-c++-common/ubsan/pr94641.c: New test.
      Jakub Jelinek committed
    • c++: Dependent conversion operator in concept [PR94597] · 08d6ec14
      When building the parameter mapping for an atomic constraint,
      find_template_parameters does not spot the template parameter within the
      conversion-type-id of a dependent conversion operator, which later leads to an
      ICE during substitution when looking up the missing template argument for this
      unnoticed template parameter.
      
      gcc/cp/ChangeLog:
      
      	PR c++/94597
      	* pt.c (any_template_parm_r) <case IDENTIFIER_NODE>: New case.  If this
      	is a conversion operator, visit its TREE_TYPE.
      
      gcc/testsuite/ChangeLog:
      
      	PR c++/94597
      	* g++.dg/cpp2a/concepts-conv2.C: New test.
      Patrick Palka committed
    • aarch64: Add an error message in large code model for ilp32 [PR94577] · 6c0ab626
      The option -mabi=ilp32 should not be used in large code model. An error
      message is added for the option conflict.
      
      2020-04-21  Duan bo  <duanbo3@huawei.com>
      
      gcc/
      	PR target/94577
      	* config/aarch64/aarch64.c: Add an error message for option conflict.
      	* doc/invoke.texi (-mcmodel=large): Mention that -mcmodel=large is
      	incompatible with -fpic, -fPIC and -mabi=ilp32.
      
      gcc/testsuite/
      	PR target/94577
      	* gcc.target/aarch64/pr94577.c: New test.
      XieZhiheng committed
    • c++: ICE with ptr_plus_expr · f2c8be18
      An ICE on darwin, when a SFINAE-context substitution produced
      error_mark_node foo an operand of a POINTER_PLUS_EXPR.
      fold_build_pointer_plus is unprepared to deal with that, so we need to
      check earlier.  We had no luck reducing the testcase to something
      manageable.
      
      	* pt.c (tsubst_copy_and_build) [POINTER_PLUS_EXPR]: Check for
      	error_mark_node.
      Nathan Sidwell committed
    • Remove fishy self-assignment in omp-low.c [PR94629] · 15256c8a
      The PR noticed that omp-low.c contains a self-assignment in the
      function new_omp_context:
      
      if (outer_ctx) {
          ...
          ctx->outer_reduction_clauses = ctx->outer_reduction_clauses;
      
      This is obviously useless.  The original intention might have been
      to copy the field from the outer_ctx to ctx.  Since this is done
      (properly) in the only function where this field is actually used
      (in function scan_omp_for) and the field is being initialized to zero
      during the struct allocation, there is no need to attempt to do
      anything to this field in new_omp_context. Thus this commit
      removes any assignment to the field from new_omp_context.
      
      2020-04-21  Frederik Harwath  <frederik@codesourcery.com>
      
      	PR other/94629
      	* gcc/omp-low.c (new_omp_context): Remove assignments to
      	ctx->outer_reduction_clauses and ctx->local_reduction_clauses.
      
      Reviewed-by: Thomas Schwinge  <thomas@codesourcery.com>
      Frederik Harwath committed
    • libphobos: Fix compilation dependencies on s390x-linux-musl · ac1a0a38
      libphobos/ChangeLog:
      
      	* configure: Regenerate.
      	* configure.ac: Call DRUNTIME_LIBRARIES_UCONTEXT.
      	* m4/druntime/libraries.m4 (DRUNTIME_LIBRARIES_UCONTEXT): Define to
      	search libraries for swapcontext.
      	* libdruntime/gcc/sections/elf_shared.d (getTLSRange): Always use
      	__tls_get_addr on Musl.
      
      Co-Authored-By: Mathias Lang <pro.mathias.lang@gmail.com>
      Iain Buclaw committed