1. 19 Apr, 2011 5 commits
    • Tweak a few entries · 7d4f8d02
      From-SVN: r172694
      Eric Botcazou committed
    • Use backend interface for variables. · e09ce6c5
      	* go-gcc.cc: Include "go-c.h".
      	(class Bvariable): Define.
      	(Gcc_backend::init_statement): New function.
      	(Gcc_backend::global_variable): New function.
      	(Gcc_backend::global_variable_set_init): New function.
      	(Gcc_backend::local_variable): New function.
      	(Gcc_backend::parameter_variable): New function.
      	(tree_to_type, var_to_tree): New functions.
      	* Make-lang.in (go/go-gcc.o): Depend on $(GO_C_H).
      	* (go/gogo-tree.o): Depend on go/gofrontend/backend.h.
      
      From-SVN: r172693
      Ian Lance Taylor committed
    • re PR testsuite/48675 (20_util/hash/chi2_quality.cc timeout) · 61bd5ad8
      	PR testsuite/48675
      	* testsuite/20_util/hash/chi2_quality.cc (test_document_words): Stub
      	this part if SAMPLES < 100000.
      
      From-SVN: r172692
      Hans-Peter Nilsson committed
    • Daily bump. · e8580e83
      From-SVN: r172689
      GCC Administrator committed
    • type_traits (is_nothrow_default_constructible, [...]): Add. · 65cee9bd
      2011-04-18  Paolo Carlini  <paolo.carlini@oracle.com>
      
      	* include/std/type_traits (is_nothrow_default_constructible,
      	is_nothrow_copy_constructible, is_nothrow_move_constructible,
      	is_copy_constructible, is_move_constructible): Add.
      	(has_nothrow_default_constructor, has_nothrow_copy_constructor):
      	Remove.
      	(is_nothrow_constructible): Adjust.
      
      	* testsuite/util/testsuite_tr1.h (ThrowDefaultClass,
      	ThrowCopyConsClass, ThrowMoveConsClass, NoexceptDefaultClass,
      	ExceptDefaultClass, NoexceptCopyConsClass, ExceptCopyConsClass,
      	NoexceptMoveConsClass, ExceptMoveConsClass): Add in C++0x mode.
      
      	* testsuite/20_util/has_nothrow_default_constructor: Remove.
      	* testsuite/20_util/has_nothrow_copy_constructor: Likewise.
      
      	* testsuite/20_util/is_nothrow_move_constructible/value.cc: Likewise.
      	* testsuite/20_util/is_nothrow_move_constructible/requirements/
      	typedefs.cc: Likewise.
      	* testsuite/20_util/is_nothrow_move_constructible/requirements/
      	explicit_instantiation.cc: Likewise.
      	* testsuite/20_util/is_nothrow_copy_constructible/value.cc: Likewise.
      	* testsuite/20_util/is_nothrow_copy_constructible/requirements/
      	typedefs.cc: Likewise.
      	* testsuite/20_util/is_nothrow_copy_constructible/requirements/
      	explicit_instantiation.cc: Likewise.
      	* testsuite/20_util/is_nothrow_default_constructible/value.cc:
      	Likewise.
      	* testsuite/20_util/is_nothrow_default_constructible/requirements/
      	typedefs.cc: Likewise.
      	* testsuite/20_util/is_nothrow_default_constructible/requirements/
      	explicit_instantiation.cc: Likewise.
      	* testsuite/20_util/is_move_constructible/value.cc: Likewise.
      	* testsuite/20_util/is_move_constructible/requirements/typedefs.cc:
      	Likewise.
      	* testsuite/20_util/is_move_constructible/requirements/
      	explicit_instantiation.cc: Likewise.
      	* testsuite/20_util/is_copy_constructible/value.cc: Likewise.
      	* testsuite/20_util/is_copy_constructible/requirements/typedefs.cc:
      	Likewise.
      	* testsuite/20_util/is_copy_constructible/requirements/
      	explicit_instantiation.cc: Likewise.
      
      	* testsuite/20_util/is_default_constructible/value.cc: Add tests.
      	* testsuite/20_util/is_nothrow_constructible/value.cc: Likewise.
      
      	* testsuite/20_util/make_signed/requirements/typedefs_neg.cc:
      	Adjust dg-error line numbers.
      	* testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc:
      	Likewise.
      	* testsuite/20_util/declval/requirements/1_neg.cc: Likewise.
      
      From-SVN: r172684
      Paolo Carlini committed
  2. 18 Apr, 2011 35 commits
    • use ASM_COMMENT_START instead of # · 1c13f168
      From-SVN: r172682
      Xinliang David Li committed
    • re PR c++/48569 (internal compiler error: in build_zero_init_1, at cp/init.c:278) · e5dda971
      	PR c++/48569
      	* typeck2.c (build_functional_cast): Handle VOID_TYPE.
      
      From-SVN: r172680
      Jason Merrill committed
    • re PR c++/48537 (C++0x: ICE using union with non-trivial member) · 09262fff
      	PR c++/48537
      	* init.c (build_value_init): Handle UNION_TYPE the same.
      
      From-SVN: r172678
      Jason Merrill committed
    • re PR middle-end/48661 (wrong-code regression with devirtualization) · 84825707
      	PR middle-end/48661
      	* gimple-fold.c (gimple_get_virt_method_for_binfo): Return NULL
      	if TREE_TYPE (v) is non-NULL.
      
      	* gimple-fold.c (gimple_get_virt_method_for_binfo): Renamed from
      	gimple_get_virt_mehtod_for_binfo.
      	* gimple.h (gimple_get_virt_method_for_binfo): Likewise.
      	* ipa-cp.c (ipcp_process_devirtualization_opportunities): Adjust
      	callers.
      	* ipa-prop.c (try_make_edge_direct_virtual_call): Likewise.
      
      	* g++.dg/torture/pr48661.C: New test.
      
      From-SVN: r172677
      Jakub Jelinek committed
    • re PR c++/48632 (Internal compiler error when using OpenMP with template) · 37a8ccfc
      	PR c++/48632
      	* parser.c (cp_parser_omp_for_loop): Don't use cp_parser_omp_for_incr
      	for type dependent pointers.
      
      	* g++.dg/gomp/pr48632.C: New test.
      
      From-SVN: r172674
      Jakub Jelinek committed
    • expr.c (expand_expr_real_2): Use GET_MODE instead of TYPE_MODE. · 7254cb57
      2011-05-18  Michael Matz  <matz@suse.de>
      	    Steve Ellcey  <sje@cup.hp.com>
      
      	* expr.c (expand_expr_real_2): Use GET_MODE instead of TYPE_MODE.
      
      Co-Authored-By: Steve Ellcey <sje@cup.hp.com>
      
      From-SVN: r172673
      Michael Matz committed
    • * doc/passes.texi: Fill crossref nodes. · 474e8e70
      From-SVN: r172672
      Dennis, CHENG Renquan committed
    • re PR lto/48086 (bootstrap-lto creates c-common.s with too many sections on x86_64-apple-darwin10) · 2cd815e7
      2011-04-18  Jack Howarth  <howarth@bromo.med.uc.edu>
      
      	    PR lto/48086
      	    * configure.ac: Re-enable LTO on *-apple-darwin9*.
      	    * configure: Regenerate.
      
      From-SVN: r172671
      Jack Howarth committed
    • i386.h (SSE_VEC_FLOAT_MODE_P): Remove. · f60c2554
      	* config/i386/i386.h (SSE_VEC_FLOAT_MODE_P): Remove.
      	(AVX_FLOAT_MODE_P): Ditto.
      	(AVX128_VEC_FLOAT_MODE_P): Ditto.
      	(AVX256_VEC_FLOAT_MODE_P): Ditto.
      	(AVX_VEC_FLOAT_MODE_P): Ditto.
      	* config/i386/i386.md (UNSPEC_MASKLOAD): Remove.
      	(UNSPEC_MASKSTORE): Ditto.
      	* config/i386/sse.md (<sse>_movmsk<ssemodesuffix><avxmodesuffix>):
      	Merge from <sse>_movmsk<ssemodesuffix> and
      	avx_movmsk<ssemodesuffix>256.  Use VF mode iterator.
      	(*sse2_maskmovdqu): Merge with *sse2_maskmovdqu_rex64.  Use P mode
      	iterator.
      	(avx_maskload<ssemodesuffix><avxmodesuffix>): New expander.
      	(avx_maskstore<ssemodesuffix><avxmodesuffix>): Ditto.
      	(*avx_maskmov<ssemodesuffix><avxmodesuffix>): New insn.
      
      testsuite/ChangeLog:
      
      	* gcc.target/i386/sse2-maskmovdqu.c: New test.
      	* gcc.target/i386/avx-vmaskmovdqu.c: Ditto.
      
      From-SVN: r172669
      Uros Bizjak committed
    • semantics.c (finish_goto_stmt): Do set UNINLINABLE flag on computed gotos. · d77c2e5b
      	* semantics.c (finish_goto_stmt): Do set UNINLINABLE flag on computed
      	gotos.
      
      From-SVN: r172668
      Jan Hubicka committed
    • remove now-unused definition of gfc_free · 513db953
      * misc.c (gfc_free): Remove function.
      * gfortran.h (gfc_free): Remove its prototype.
      
      From-SVN: r172667
      Jim Meyering committed
    • convert each use of gfc_free (p) to free (p) · cede9502
      Do that by running this command:
        perl -pi -e    's/\bgfc_free ?\(/free (/' \
          $(git grep -El '\bgfc_free ?\(')
      which also corrects the few uses that lacked a space between
      the function name and the open parenthesis.
      Manually undo the change to the function definition itself
      and its prototype.  They'll be removed next.
      * array.c (gfc_free_array_spec, gfc_set_array_spec): s/gfc_free/free/
      * constructor.c (node_free): Likewise.
      * cpp.c (dump_queued_macros): Likewise.
      * data.c (gfc_assign_data_value): Likewise.
      * decl.c (free_variable, free_value, gfc_free_data): Likewise.
      (gfc_free_data_all, match_old_style_init): Likewise.
      (gfc_set_constant_character_len, gfc_free_enum_history, NUM_DECL):
      Likewise.
      (gfc_match_modproc): Likewise.
      * dependency.c (check_section_vs_section): Likewise.
      * error.c (gfc_pop_error, gfc_free_error): Likewise.
      * expr.c (free_expr0, gfc_free_expr, gfc_free_actual_arglist): Likewise.
      (gfc_free_ref_list, gfc_replace_expr, gfc_copy_ref): Likewise.
      (find_substring_ref, gfc_simplify_expr, gfc_check_assign_symbol):
      Likewise.
      * frontend-passes.c (gfc_run_passes, cfe_expr_0): Likewise.
      (strip_function_call, optimize_comparison): Likewise.
      * interface.c (gfc_free_interface, arginfo, check_interface0): Likewise.
      (CHECK_OS_COMPARISON, gfc_extend_assign, gfc_free_formal_arglist):
      Likewise.
      * intrinsic.c (gfc_intrinsic_done_1, gfc_convert_type_warn): Likewise.
      (gfc_convert_chartype): Likewise.
      * io.c (gfc_free_open, compare_to_allowed_values, gfc_free_close):
      Likewise.
      (gfc_free_filepos, gfc_free_dt, gfc_free_inquire): Likewise.
      * match.c (gfc_free_iterator, gfc_match_associate): Likewise.
      (gfc_free_alloc_list, gfc_free_namelist, gfc_free_equiv_until):
      Likewise.
      (free_case, gfc_free_forall_iterator): Likewise.
      * misc.c: Likewise.
      * module.c (free_pi_tree, resolve_fixups, free_rename): Likewise.
      (free_true_name, peek_atom, mio_allocated_wide_string): Likewise.
      (mio_pool_string, mio_internal_string, mio_gmp_integer): Likewise.
      (mio_gmp_real, mio_expr, mio_typebound_proc): Likewise.
      (mio_full_typebound_tree, skip_list, load_equiv): Likewise.
      (free_written_common, gfc_use_module, gfc_free_use_stmts): Likewise.
      * openmp.c (gfc_free_omp_clauses): Likewise.
      * options.c (gfc_post_options): Likewise.
      * parse.c (select_type_pop, parse_omp_structured_block): Likewise.
      * primary.c (gfc_free_structure_ctor_component): Likewise.
      * resolve.c (resolve_structure_cons, check_host_association): Likewise.
      (gfc_resolve_forall, resolve_equivalence): Likewise.
      * scanner.c (gfc_scanner_done_1, gfc_release_include_path): Likewise.
      (gfc_define_undef_line, preprocessor_line, include_line): Likewise.
      (load_file, gfc_read_orig_filename): Likewise.
      * simplify.c (simplify_transformation_to_array): Likewise.
      (gfc_simplify_ibits, simplify_shift, gfc_simplify_ishftc, STRING):
      Likewise.
      (gfc_simplify_compiler_options): Likewise.
      * st.c (gfc_free_statement, gfc_free_statements): Likewise.
      (gfc_free_association_list): Likewise.
      * symbol.c (free_components, gfc_free_st_label, free_st_labels):
      Likewise.
      (gfc_delete_symtree, gfc_free_symbol, gfc_undo_symbols): Likewise.
      (free_old_symbol, gfc_commit_symbols, free_tb_tree): Likewise.
      (free_common_tree, free_uop_tree, free_sym_tree): Likewise.
      (gfc_free_dt_list, gfc_free_equiv_infos, gfc_free_equiv_lists):
      Likewise.
      (gfc_free_finalizer, gfc_free_charlen, free_entry_list): Likewise.
      (gfc_free_namespace): Likewise.
      * trans-array.c (gfc_free_ss, gfc_trans_array_bound_check): Likewise.
      (gfc_conv_array_ref, gfc_conv_ss_startstride): Likewise.
      (gfc_trans_dummy_array_bias, gfc_conv_array_parameter): Likewise.
      * trans-common.c (get_init_field, create_common): Likewise.
      * trans-const.c (gfc_build_wide_string_const): Likewise.
      (gfc_conv_string_init): Likewise.
      * trans-decl.c (gfc_generate_function_code): Likewise.
      * trans-expr.c (gfc_conv_substring, gfc_free_interface_mapping):
      Likewise.
      (SCALAR_POINTER, gfc_conv_statement_function): Likewise.
      (gfc_trans_subarray_assign): Likewise.
      * trans-intrinsic.c (conv_generic_with_optional_char_arg): Likewise.
      * trans-io.c (gfc_trans_io_runtime_check, set_string): Likewise.
      (transfer_namelist_element, transfer_array_component): Likewise.
      * trans-openmp.c (gfc_trans_omp_array_reduction): Likewise.
      * trans-stmt.c (cleanup_forall_symtrees, gfc_trans_forall_1): Likewise.
      * trans.c (trans_runtime_error_vararg, gfc_restore_backend_locus):
      Likewise.
      
      From-SVN: r172666
      Jim Meyering committed
    • gfortran: remove cpp definition of free, ... · 5cc124fe
      in preparation for the s/gfc_free/free/ transformation.
      * gfortran.h (free): Remove macro definition that would otherwise
      prevent direct use of the function.
      
      From-SVN: r172665
      Jim Meyering committed
    • ipa-inline.c: Fix comment typos; do not inline gt-ipa-inline.h · 09a2806f
      	* ipa-inline.c: Fix comment typos; do not inline gt-ipa-inline.h
      	(want_inline_function_called_once_p): Break out the logic from
      	ipa_inline.
      	(edge_badness): Ensure that profile is not misupdated.
      	(lookup_recursive_calls): Prioritize by call frequencies.
      	(inline_small_functions): Move program size estimates here;
      	actually process whole queue even when unit growth has been
      	met. (to properly compute inline_failed reasons and for the
      	case unit size decrease.) Revisit comments on recursive
      	inlining.
      	(ipa_inline): Remove unit summary code; first inline hot calls
      	of functions called once, cold calls next.
      	(order, nnodes): Remove unused variables.
      	* Makefile.in (ipa-inline.o): No longer depent on ggc files.
      	(GTFILES): Remove ipa-inline.c
      	* sel-sched.c (fill_insns): Silence uninitialized var warning.
      
      From-SVN: r172663
      Jan Hubicka committed
    • libgo: Fix append declaration. · e1c2f290
      From Rainer Orth.
      
      From-SVN: r172659
      Ian Lance Taylor committed
    • re PR fortran/18918 (Eventually support Fortran 2008's coarrays [co-arrays]) · e84b920c
      2011-04-18  Tobias Burnus  <burnus@net-b.de>
      
              PR fortran/18918
              * array.c (gfc_match_array_ref): Check for too many
              * codimensions.
              * check.c (gfc_check_image_index): Check number of elements
              in SUB argument.
              * simplify.c (gfc_simplify_image_index): Remove unreachable
              * checks.
      
      2011-04-18  Tobias Burnus  <burnus@net-b.de>
      
              PR fortran/18918
              * gfortran.dg/coarray_17.f90: New.
              * gfortran.dg/coarray_10.f90: Update dg-error.
      
      From-SVN: r172658
      Tobias Burnus committed
    • re PR testsuite/48251 (guality_check hangs indefinitely on Tru64 UNIX) · 9c41356c
      	PR testsuite/48251
      	* gcc.dg/guality/guality.exp: Disable on alpha*-dec-osf*.
      	* gfortran.dg/guality/guality.exp: Likewise.
      
      From-SVN: r172657
      Rainer Orth committed
    • * gfortran.dg/fmt_g0_5.f08: Use dg-add-options ieee. · 28533fb9
      From-SVN: r172655
      Rainer Orth committed
    • * gcc.dg/vect/pr48377.c: Remove dg-do run. · f0f3a1d9
      From-SVN: r172654
      Rainer Orth committed
    • * gcc.dg/ipa/pr48195.c: Add dg-require-effective-target lto. · dd7d256b
      From-SVN: r172651
      Rainer Orth committed
    • re PR c++/46364 (basic_string.h:541:32: internal compiler error: Segmentation fault) · ab62fc03
      2011-04-18  Richard Guenther  <rguenther@suse.de>
      
      	PR middle-end/46364
      	* g++.dg/torture/pr46364.C: New testcase.
      
      From-SVN: r172649
      Richard Guenther committed
    • * obj-c++.dg/dwarf-2.mm: Skip on alpha*-dec-osf*. · fa71a2b4
      From-SVN: r172648
      Rainer Orth committed
    • Jie Zhang <jie@codesourcery.com> · 229a1c59
      	Richard Earnshaw  <rearnsha@arm.com>
      
      	* arm.c (neon_builtin_type_bits): Remove.
      	(typedef enum neon_builtin_mode): New.
      	(T_MAX): Don't define.
      	(typedef enum neon_builtin_datum): Remove bits, codes[],
      	num_vars and base_fcode.  Add mode, code and fcode.
      	(VAR1, VAR2, VAR3, VAR4, VAR5, VAR6, VAR7, VAR8, VAR9
      	VAR10): Change accordingly.
      	(neon_builtin_data[]): Change accordingly
      	(arm_init_neon_builtins): Change accordingly.
      	(neon_builtin_compare): Remove.
      	(locate_neon_builtin_icode): Remove.
      	(arm_expand_neon_builtin): Change accordingly.
      
      	* arm.h (enum arm_builtins): Move to ...
      	* arm.c (enum arm_builtins): ... here; and rearrange builtin code.
      
      	* arm.c (arm_builtin_decl): Declare.
      	(TARGET_BUILTIN_DECL): Define.
      	(enum arm_builtins): Correct ARM_BUILTIN_MAX.
      	(arm_builtin_decls[]): New.
      	(arm_init_neon_builtins): Store builtin declarations in
      	arm_builtin_decls[].
      	(arm_init_tls_builtins): Likewise.
      	(arm_init_iwmmxt_builtins): Likewise.  Refactor initialization code.
      	(arm_builtin_decl): New.
      
      Co-Authored-By: Richard Earnshaw <rearnsha@arm.com>
      
      From-SVN: r172646
      Jie Zhang committed
    • tree.c (upper_bound_in_type): Build properly canonicalized INTEGER_CSTs. · 75e802cc
      2011-04-18  Richard Guenther  <rguenther@suse.de>
      
      	* tree.c (upper_bound_in_type): Build properly canonicalized
      	INTEGER_CSTs.
      	(lower_bound_in_type): Likewise.
      
      From-SVN: r172645
      Richard Guenther committed
    • gimple.h (gimple_call_addr_fndecl): New function. · 3b45a007
      2011-04-18  Richard Guenther  <rguenther@suse.de>
      
      	* gimple.h (gimple_call_addr_fndecl): New function.
      	(gimple_call_fndecl): Use it.
      	* gimple-fold.c (gimple_fold_call): Fold away OBJ_TYPE_REFs
      	for direct calls.
      	* tree-ssa-ccp.c (ccp_fold_stmt): Remove OBJ_TYPE_REF folding.
      	* tree-ssa-pre.c (eliminate): Also simplify indirect OBJ_TYPE_REFs.
      
      From-SVN: r172644
      Richard Guenther committed
    • pr48235.c: Add dg-require-effective-target freorder. · 870ef0ce
      	* gcc.dg/pr48235.c: Add dg-require-effective-target freorder.
      
      From-SVN: r172643
      Alexander Monakov committed
    • re PR c/48650 (valgrind: Invalid write of size 8 in build_string (tree.c:1524)) · d25a79ea
      2011-04-18  Richard Guenther  <rguenther@suse.de>
      
      	PR middle-end/48650
      	* tree.c (build_string): STRING_CST is now derived from tree_typed.
      
      From-SVN: r172642
      Richard Guenther committed
    • re PR lto/48492 (LTO bootstrap failure in copy_constant) · 7d5fc814
      	PR lto/48492
      	* cfgexpand.c (expand_debug_expr) <VAR_DECL>: Return NULL for a
      	DECL_IN_CONSTANT_POOL without RTL.
      
      From-SVN: r172641
      Eric Botcazou committed
    • re PR target/48252 (ARM neon: problem with consecutive vzip, vuzp and vtrn) · 7e7cfcf6
      
      	PR target/48252
      	* config/arm/arm.c (neon_emit_pair_result_insn): Swap arguments
      	to match neon_vzip/vuzp/vtrn_internal.
      	* config/arm/neon.md (neon_vtrn<mode>_internal): Make both
      	outputs explicitly dependent on both inputs.
      	(neon_vzip<mode>_internal, neon_vuzp<mode>_internal): Likewise.
      
      
      Co-Authored-By: Ira Rosen <ira.rosen@linaro.org>
      
      From-SVN: r172639
      Ulrich Weigand committed
    • re PR tree-optimization/48616 (-ftree-vectorize -mxop miscompiles right shift) · 49eab32e
      	PR tree-optimization/48616
      	* tree-vect-stmts.c (vectorizable_shift): If SLP, determine
      	whether the shift is by scalar or vector based on whether all SLP
      	scalar stmts have the same rhs.
      
      	* gcc.dg/pr48616.c: New test.
      
      From-SVN: r172638
      Jakub Jelinek committed
    • re PR fortran/18918 (Eventually support Fortran 2008's coarrays [co-arrays]) · 5af07930
      2011-04-18  Tobias Burnus  <burnus@net-b.de>
      
              PR fortran/18918
              * iresolve.c (gfc_resolve_image_index): Set ts.type.
              * simplify.c (gfc_simplify_image_index): Don't abort if the
              * bounds
              are not known at compile time and handle -fcoarray=lib.
              * trans-intrinsics.c (gfc_conv_intrinsic_function): Handle
              IMAGE_INDEX.
              (conv_intrinsic_cobound): Fix comment typo.
              (trans_this_image): New function.
              * trans-array.c (gfc_unlikely): Move to trans.c.
              * trans.c (gfc_unlikely): Function moved from trans-array.c.
              (gfc_trans_runtime_check): Use it.
              * trans-io.c (gfc_trans_io_runtime_check): Ditto.
              * trans.h (gfc_unlikely): Add prototype.
      
      2011-04-18  Tobias Burnus  <burnus@net-b.de>
      
              PR fortran/18918
              * gfortran.dg/coarray_16.f90: New.
      
      From-SVN: r172637
      Tobias Burnus committed
    • re PR fortran/48462 (realloc on assignment: matmul Segmentation Fault with Allocatable Array) · 12df8d01
      2011-04-18  Paul Thomas  <pault@gcc.gnu.org>
      
      	PR fortran/48462
      	* trans-expr.c (fcncall_realloc_result): Renamed version of
      	realloc_lhs_bounds_for_intrinsic_call that does not touch the
      	descriptor bounds anymore but makes a temporary descriptor to
      	hold the result.
      	(gfc_trans_arrayfunc_assign): Modify the reference to above
      	renamed function.
      
      2011-04-18  Paul Thomas  <pault@gcc.gnu.org>
      
      	PR fortran/48462
      	* gfortran.dg/realloc_on_assign_7.f03: New test.
      
      From-SVN: r172636
      Paul Thomas committed