- 18 Oct, 2010 11 commits
-
-
2010-10-18 Eric Botcazou <ebotcazou@adacore.com> * exp_ch6.adb (Expand_N_Subprogram_Declaration): Use Freeze_Before. (Expand_Protected_Object_Reference): Likewise. * sem_attr.adb (Resolve_Attribute): Likewise. * sem_ch3.adb (Analyze_Subtype_Declaration): Likewise. * sem_ch6.adb (Analyze_Subprogram_Body_Helper): Likewise. From-SVN: r165616
Eric Botcazou committed -
2010-10-18 Arnaud Charlet <charlet@adacore.com> * g-comlin.adb (Get_Switches): Prevent dereferencing null Config. 2010-10-18 Robert Dewar <dewar@adacore.com> * aspects.ads, aspects.adb: Add entries for aspects Read/Write/Input/Output. * sem_ch13.adb (Analyze_Aspect_Specifications): Add processing for handling aspects Read/Write/Input/Output. 2010-10-18 Robert Dewar <dewar@adacore.com> * sem_util.adb (Note_Possible_Modification): Do not give warning for use of pragma Unmodified unless we are sure this is a modification. 2010-10-18 Tristan Gingold <gingold@adacore.com> * sysdep.c: Add __gnat_get_stack_bounds. * s-taprop-mingw.adb Call __gnat_get_stack_bounds to set Pri_Stack_Info. 2010-10-18 Robert Dewar <dewar@adacore.com> * a-assert.ads: Fix bad name in header. * sem_ch4.adb, sem_ch6.adb, sem_ch7.adb, sem_ch10.adb: Minor reformatting. * exp_aggr.adb: Fix typo in comment. From-SVN: r165615
Arnaud Charlet committed -
2010-10-18 Javier Miranda <miranda@adacore.com> * exp_util.adb (Side_Effect_Free): Code clean up. 2010-10-18 Ed Schonberg <schonberg@adacore.com> * sem_ch8.adb (Is_Primitive_Operator_In_Use): Renamed from Is_Primitive_Operator. When ending the scope of a use package scope, a primitive operator remains in use if the base type has a current use (type) clause. 2010-10-18 Javier Miranda <miranda@adacore.com> * einfo.ads (Is_Dynamic_Support): Add missing support for limited private types whose full-view is a task type. * sem_util.adb (Enclosing_Subprogram): Add missing support for limited private types whose full-view is a task type. * exp_ch7.adb (Find_Final_List): Minor code cleanup replacing code by function Nearest_Dynamic_Scope which provides the needed functionality. 2010-10-18 Arnaud Charlet <charlet@adacore.com> * sem_prag.adb (Set_Exported): Do not generate error when exporting a variable with an address clause in codepeer mode. From-SVN: r165614
Arnaud Charlet committed -
gcc/ 2010-10-18 Andi Kleen <ak@linux.intel.com> PR other/43448 * gccbug.in: Remove. * Makefile.in (GCCBUG_INSTALL_NAME, gccbug): Remove (doc, distclean, install-common): Remove reference to gccbug. * configure: Regenerate. * configure.ac (all_outputs): Remove gccbug. * doc/configfiles.texi: Remove references to gccbug. * doc/sourcebuild.texi: Dito. contrib/ 2010-10-18 Andi Kleen <ak@linux.intel.com> * gccbug.el: Remove. From-SVN: r165613
Andi Kleen committed -
2010-10-18 Robert Dewar <dewar@adacore.com> * g-trasym-vms-ia64.adb: Minor reformatting. 2010-10-18 Thomas Quinot <quinot@adacore.com> * sem_type.adb (Covers): If either argument is Standard_Void_Type and the other isn't, return False early. 2010-10-18 Ed Falis <falis@adacore.com> * s-vxwext-rtp.ads, s-vxext-rtp.adb: Adapt for missing APIs for RTPs in VxWorks Cert. 2010-10-18 Robert Dewar <dewar@adacore.com> * sem_disp.ads: Minor comment update. 2010-10-18 Robert Dewar <dewar@adacore.com> * einfo.ads, einfo.adb (Spec_PPC_List): Is now present in Entries * sem_ch3.adb (Analyze_Declarations): Add processing for delaying visibility analysis of precondition and postcondition pragmas (and Pre/Post aspects). * sem_ch6.adb (Process_PPCs): Add handling of inherited Pre'Class aspects. * sem_ch7.adb (Analyze_Package_Specification): Remove special handling of pre/post conditions (no longer needed). * sem_disp.adb (Inherit_Subprograms): Deal with interface case. * sem_prag.adb (Analyze_PPC_In_Decl_Part): Remove analysis of message argument, since this is now done in the main processing for pre/postcondition pragmas when they are first seen. (Chain_PPC): Pre'Class and Post'Class now handled properly (Chain_PPC): Handle Pre/Post aspects for entries (Check_Precondition_Postcondition): Handle entry declaration case (Check_Precondition_Postcondition): Handle delay of visibility analysis (Check_Precondition_Postcondition): Preanalyze message argument if present. From-SVN: r165612
Arnaud Charlet committed -
2010-10-18 Robert Dewar <dewar@adacore.com> * g-trasym-vms-ia64.adb, prj-nmsc.adb, prj.ads: Minor reformatting. From-SVN: r165611
Robert Dewar committed -
PR middle-end/46019 * fold-const.c (fold_binary_loc): If integer_pow2p has TREE_INT_CST_LOW zero, look at TREE_INT_CST_HIGH. * gcc.c-torture/execute/pr46019.c: New test. From-SVN: r165610
Jakub Jelinek committed -
2010-10-18 Basile Starynkevitch <basile@starynkevitch.net> Jeremie Salvucci <jeremie.salvucci@free.fr> * gengtype.c (verbosity_level): Added variable. (set_gc_used): Count variables for verbosity. (close_output_files): Backing up files, counting written ones verbosily. (write_types): Count emitted functions for verbosity. Added debug messages. (write_enum_defn): Count structures for verbosity. Added debug messages. (gengtype_long_options): Added "verbose" & "backupdir". (print_usage): Ditto. (main): Verbose display of parsed files. * gengtype.h (verbosity_level): Added declaration. Co-Authored-By: Jeremie Salvucci <jeremie.salvucci@free.fr> From-SVN: r165609
Basile Starynkevitch committed -
gengtype.c (parse_program_options): Added allocation of plugin_files, and corrected test on nb_plugin_files. 2010-10-18 Basile Starynkevitch <basile@starynkevitch.net> * gengtype.c (parse_program_options): Added allocation of plugin_files, and corrected test on nb_plugin_files. From-SVN: r165608
Basile Starynkevitch committed -
2010-10-18 Laurynas Biveinis <laurynas.biveinis@gmail.com> * MAINTAINERS (Reviewers): Add myself for gengtype/GTY. (Write After Approval): Remove myself. From-SVN: r165607Laurynas Biveinis committed -
From-SVN: r165606
GCC Administrator committed
-
- 17 Oct, 2010 14 commits
-
-
In gcc/cp/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from apple/trunk branch on FSF servers. 2006-04-19 Fariborz Jahanian <fjahanian@apple.com> Radar 4516785 * parser.c (cp_parser_simple_type_specifier): Don't lookup for objc object types if type is scope qualified. In gcc/testsuite/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from 'apple/trunk' branch on FSF servers. 2006-04-19 Fariborz Jahanian <fjahanian@apple.com> Radar 4516785 * obj-c++.dg/method-namespace-2.mm: New. From-SVN: r165602Nicola Pero committed -
In gcc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from 'apple/trunk' branch on FSF servers. 2006-03-27 Fariborz Jahanian <fjahanian@apple.com> Radar 4133425 * c-decl.c (undeclared_variable): Issue diagnostic on private 'ivar' access. In gcc/c-family/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from 'apple/trunk' branch on FSF servers. 2006-03-27 Fariborz Jahanian <fjahanian@apple.com> Radar 4133425 * c-common.h (objc_diagnose_private_ivar): New decl. * stub-objc.c (objc_diagnose_private_ivar): New stub. In gcc/cp/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from apple/trunk branch on FSF servers. 2006-03-27 Fariborz Jahanian <fjahanian@apple.com> Radar 4133425 * lex.c (unqualified_name_lookup_error): Issue diagnostic for private 'ivar' access. In gcc/objc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from 'apple/trunk' branch on FSF servers. 2006-03-27 Fariborz Jahanian <fjahanian@apple.com> Radar 4133425 * objc-act.c (objc_diagnose_private_ivar): New. In gcc/testsuite/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> Merge from 'apple/trunk' branch on FSF servers. 2006-03-27 Fariborz Jahanian <fjahanian@apple.com> Radar 4133425 * objc.dg/private-1.m: Test modified. * obj-c++.dg/private-1.mm: Test modified. From-SVN: r165601Nicola Pero committed -
PR testsuite/45987 * gcc.target/i386/push-1.c: Remove. From-SVN: r165600
Uros Bizjak committed -
PR target/46051 * config/i386/sse.md (vec_interleave_highv4df): Fix third RTX of generated sequence to match *avx_vperm2f128<mode>_nozero. (vec_interleave_lowv4df): Ditto. (vec_interleave_highv8sf): Ditto. (vec_interleave_lowv8sf): Ditto. testsuite/ChangeLog: PR target/46051 * gcc.target/i386/pr46051.c: New test. Co-Authored-By: H.J. Lu <hongjiu.lu@intel.com> From-SVN: r165599
Uros Bizjak committed -
2010-10-17 Kai Tietz <kai.tietz@onevision.com> * libgcov.c (create_file_directory): Enable it for win32 case. (gcov_exit): De-couple GCOV_PREFIX and GCOV_PREFIX_STRIP. * doc/gcov.texi (GCOV_PREFIX): Adjusted. (GCOV_PREFIX_SKIP): Likewise. From-SVN: r165596Kai Tietz committed -
In gcc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> * doc/objc.texi (GNU Objective-C runtime API): New section. (Modern GNU Objective-C runtime API): New section. (Traditional GNU Objective-C runtime API): New section. (Executing code before main): Mention that this section is specific to the GNU Objective-C runtime. (Garbage Collection): Same. In gcc/testsuite/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> * obj-c++.dg/gnu-api-2-class.mm: New. * obj-c++.dg/gnu-api-2-ivar.mm: New. * obj-c++.dg/gnu-api-2-method.mm: New. * obj-c++.dg/gnu-api-2-objc.mm: New. * obj-c++.dg/gnu-api-2-object.mm: New. * obj-c++.dg/gnu-api-2-property.mm: New. * obj-c++.dg/gnu-api-2-protocol.mm: New. * obj-c++.dg/gnu-api-2-sel.mm: New. In libobjc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> * objc/message.h: Moved initial includes outside of extern "C". * objc/runtime.h: Add extern "C" for Objective-C++. From-SVN: r165595Nicola Pero committed -
* c-parser.c (c_parser_for_statement): Move initialization of cond and incr before if. From-SVN: r165592
Uros Bizjak committed -
2010-10-17 Paolo Carlini <paolo.carlini@oracle.com> * include/bits/forward_list.h (forward_list<>::erase_after): Return an iterator. (_M_erase_after): Return _Fwd_list_node_base*. * include/bits/forward_list.tcc: Likewise. * include/debug/forward_list: Likewise. * testsuite/23_containers/forward_list/modifiers/3.cc: Update and extend. * testsuite/util/exception/safety.h (erase_base<forward_list<>>): Adjust. * testsuite/23_containers/forward_list/requirements/dr438/ assign_neg.cc: Adjust dg-error line number. * testsuite/23_containers/forward_list/requirements/dr438/ insert_neg.cc: Likewise. * testsuite/23_containers/forward_list/requirements/dr438/ constructor_1_neg.cc: Likewise. * testsuite/23_containers/forward_list/requirements/dr438/ constructor_2_neg.cc: Likewise. From-SVN: r165590
Paolo Carlini committed -
* target.def (preferred_output_reload_class): New hook. * doc/tm.texi.in (TARGET_PREFERRED_OUTPUT_RELOAD_CLASS): Document. * doc/tm.texi: Regenerate. * targhooks.c (default_preferred_output_reload_class): New function. * targhooks.h (default_preferred_output_reload_class): Declare. * reload.c (find_dummy_reload): Change rclass argument type from enum reg_class to reg_class_t. Change this_alternative array type from enum reg_class to reg_class_t. Use TARGET_PREFERRED_OUTPUT_RELOAD_CLASS target hook. (push_reload): Change preferred_class variable type to reg_class_t. Use TARGET_PREFERRED_OUTPUT_RELOAD_CLASS target hook. * recog.c (reg_fits_class_p): Change result type to bool. Change cl argument type from enum reg_class to reg_class_t. Use HARD_REGISTER_NUM_P predicate. * recog.h (reg_fits_class_p): Update prototype. * config/i386/i386.h (PREFERRED_OUTPUT_RELOAD_CLASS): Remove. * config/i386/i386-protos.h (ix86_preferred_output_reload_class): Remove. * config/i386/i386.c (ix86_preferred_output_reload_class): Make static. Change regclass argument and result types from enum reg_class to reg_class_t. (TARGET_PREFERRED_OUTPUT_RELOAD_CLASS): Define. From-SVN: r165588
Anatoly Sokolov committed -
2010-10-17 Paolo Carlini <paolo.carlini@oracle.com> PR libstdc++/43554 * include/profile/forward_list: New file. * include/std/forward_list: Include <profile/forward_list>. * include/Makefile.am: Add. * testsuite/23_containers/forward_list/capacity/1.cc: Adjust. * include/Makefile.in: Regenerate. From-SVN: r165587
Paolo Carlini committed -
gcc/c-family: * c-common.c (c_common_reswords): Add package, RID_AT_PACKAGE. * c-common.h (enum rid): Add RID_AT_PACKAGE. (objc_ivar_visibility_kind): New enum. (objc_set_visibility): Adjust prototype to use visibility enum. * stub-objc.c (objc_set_visibility): Adjust stub to use visibility enum. gcc/objc: * objc-act.c: Rename 'objc_public_flag' to objc_ivar_visibility and make its type 'objc_ivar_visibility_kind'. (objc_start_class_interface): Update to use visibility enum. (objc_start_class_implementation): Likewise. (objc_set_visibility): Update to use visibility enum, warn that @package is handle as per @public. (add_instance_variable): Handle OBJC_IVAR_VIS_PACKAGE. * objc-act.h: Rename 'objc_public_flag' to objc_ivar_visibility and make its type 'objc_ivar_visibility_kind'. gcc/cp: * parser.c (cp_parser_objc_visibility_spec): Update to use visibility enum, and handle @package. gcc: * c-parser.c (c_parser_objc_class_instance_variables): Update to use visibility enum, and handle @package. gcc/testsuite: * objc.dg/fsf-package-0.m: New. * obj-c++.dg/fsf-package-0.m: New. From-SVN: r165585
Iain Sandoe committed -
In libobjc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> * init.c (objc_send_load): Do not wait for NXConstantString to be registered before executing +load. There is no point if -fconstant-string-class=xxx is used when compiling all modules, as is the case for almost all users. * linking.m (__objc_linking): Do not try to forcefully link in NXConstantString. In gcc/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> * doc/objc.texi (What you can and what you cannot do in +load): Document that sending messages to constant string objects in +load is not guaranteed to work. From-SVN: r165583Nicola Pero committed -
In gcc/testsuite/: 2010-10-17 Nicola Pero <nicola.pero@meta-innovation.com> PR objc/18255 * objc.dg/pr18255.m: New. From-SVN: r165579Nicola Pero committed -
From-SVN: r165573
GCC Administrator committed
-
- 16 Oct, 2010 15 commits
-
-
PR middle-end/44206 * g++.dg/torture/pr44206.C: New. * ipa.c (cgraph_remove_unreachable_nodes): Cleanup; check existence of refrences before removing the function. From-SVN: r165569
Jan Hubicka committed -
In testsuite/: 2010-10-16 Nicola Pero <nicola.pero@meta-innovation.com> * objc.dg/gnu-api-2-class.m: New. * objc.dg/gnu-api-2-objc.m: New. From-SVN: r165564Nicola Pero committed -
In libobjc/: 2010-10-16 Nicola Pero <nicola.pero@meta-innovation.com> * objc/runtime.h: Updated comments. (class_addMethod): New. (class_addIvar): New. (class_replaceMethod): New. (objc_allocateClassPair): New. (objc_registerClassPair): New. (objc_disposeClassPair): New. * class.c (objc_allocateClassPair): New. (objc_registerClassPair): New. (objc_disposeClassPair): New. (class_getSuperclass): Return Nil if a class is in construction. * init.c (__objc_exec_class): Call __objc_init_class. (__objc_init_class): New. * ivars.c (class_copyIvarList): Return NULL if class is in construction. Do not lock the runtime mutex. (class_getInstanceVariable): Return NULL if class is in construction. Do not lock the runtime mutex. (class_addIvar): New. * sendmsg.c (class_addMethod): New. (class_replaceMethod): New. * objc-private/module-abi-8.h (__CLS_SETNOTINFO): New. (_CLS_IN_CONSTRUCTION): New. (CLS_IS_IN_CONSTRUCTION): New. (CLS_SET_IN_CONSTRUCTION): New. (CLS_SET_NOT_IN_CONSTRUCTION): New. * objc-private/runtime.h (__objc_init_class): New. From-SVN: r165563Nicola Pero committed -
trans-io.c (gfc_build_io_library_fndecls): Array descriptor arguments to transfer_array can be dereferenced recursively. 2010-10-16 Thomas Koenig <tkoenig@gcc.gnu.org> * trans-io.c (gfc_build_io_library_fndecls): Array descriptor arguments to transfer_array can be dereferenced recursively. From-SVN: r165561
Thomas Koenig committed -
cgraph.c (dump_cgraph_node): Dump same_comdat_group, only_called_at_startup and only_called_at_exit. * cgraph.c (dump_cgraph_node): Dump same_comdat_group, only_called_at_startup and only_called_at_exit. (cgraph_propagate_frequency): Compute only_called_at_startup and only_called_at_exit. * cgraph.h (struct cgraph_node): New fileds only_called_at_startup and only_called_at_exit. * lto-cgraph.c (lto_output_node, input_overwrite_node): Stream the new flags. * predict.c (compute_function_frequency): Initialize the new flags. From-SVN: r165560
Jan Hubicka committed -
2010-10-16 Thomas Koenig <tkoenig@gcc.gnu.org> PR fortran/20165 PR fortran/31593 PR fortran/43665 * gfortran.map: Add _gfortran_transfer_array_write, _gfortran_transfer_array_write, _gfortran_transfer_character_write, _gfortran_transfer_character_wide_write, _gfortran_transfer_complex_write, _gfortran_transfer_integer_write, _gfortran_transfer_logical_write and _gfortran_transfer_real_write. * io/transfer.c (transfer_integer_write): Add prototype and function body as call to the original function, without the _write. (transfer_real_write): Likewise. (transfer_logical_write): Likewise. (transfer_character_write): Likewise. (transfer_character_wide_write): Likewise. (transfer_complex_write): Likewise. (transfer_array_write): Likewise. 2010-10-16 Thomas Koenig <tkoenig@gcc.gnu.org> PR fortran/20165 PR fortran/31593 PR fortran/43665 * trans-io.c (enum iocall): Add IOCALL_X_INTEGER_WRITE, IOCALL_X_LOGICAL_WRITE, IOCALL_X_CHARACTER_WRITE, IOCALL_X_CHARACTER_WIDE_WRIE, IOCALL_X_REAL_WRITE, IOCALL_X_COMPLEX_WRITE and IOCALL_X_ARRAY_WRITE. (gfc_build_io_library_fndecls): Add corresponding function decls. (transfer_expr): If the current transfer is a READ, use the iocall with the original version, otherwise the version with _WRITE. (transfer_array_desc): Likewise. From-SVN: r165559
Thomas Koenig committed -
* gimplify.c (gimplify_type_sizes) <ARRAY_TYPE>: If the type is to be ignored for debug info purposes, do not clear the DECL_IGNORED_P flag on the bounds of its domain. * tree.h (DECL_IGNORED_P): Document effect on TYPE_DECL specifically. From-SVN: r165544
Eric Botcazou committed -
In gcc/testsuite/: 2010-10-16 Nicola Pero <nicola.pero@meta-innovation.com> * objc.dg/gnu-api-2-ivar.m: New. From-SVN: r165543Nicola Pero committed -
2010-10-16 Nicola Pero <nicola.pero@meta-innovation.com> * class.c (class_getSuperclass): Call __objc_resolve_class_links if the class is not resolved yet. * ivars.c (class_getInstanceVariable): Use class_getSuperclass. From-SVN: r165542Nicola Pero committed -
* config/avr/avr.h (PREFERRED_RELOAD_CLASS): Remove. * config/avr/avr-protos.h (preferred_reload_class): Remove. * config/avr/avr.c (preferred_reload_class): Remove. * config/pa/pa.h (PREFERRED_RELOAD_CLASS): Remove. * config/pa/pa.c (emit_move_sequence): Update comment * config/arc/arc.h (PREFERRED_RELOAD_CLASS): Remove. * config/crx/crx.h (PREFERRED_RELOAD_CLASS): Remove. * config/fr30/fr30.h (PREFERRED_RELOAD_CLASS): Remove. * config/frv/frv.h (PREFERRED_RELOAD_CLASS): Remove. * config/h8300/h8300.h (PREFERRED_RELOAD_CLASS): Remove. * config/lm32/lm32.h (PREFERRED_RELOAD_CLASS): Remove. * config/m32r/m32r.h (PREFERRED_RELOAD_CLASS): Remove. * config/moxie/moxie.h (PREFERRED_RELOAD_CLASS): Remove. * config/picochip/picochip.h (PREFERRED_RELOAD_CLASS): Remove. * config/rx/rx.h (PREFERRED_RELOAD_CLASS): Remove. * config/spu/spu.h (PREFERRED_RELOAD_CLASS): Remove. * config/v850/v850.h (PREFERRED_RELOAD_CLASS): Remove. * config/vax/vax.h (PREFERRED_RELOAD_CLASS): Remove. From-SVN: r165541
Anatoly Sokolov committed -
* opts.c (set_fast_math_flags, set_unsafe_math_optimizations_flags): Make static. * toplev.h (set_fast_math_flags, set_unsafe_math_optimizations_flags): Remove prototypes. From-SVN: r165540
Joseph Myers committed -
* config/arm/arm.c (arm_option_optimization): Set flag_section_anchors to 1 not 2. * config/i386/i386.c (ix86_option_override_internal): Check global_options_set.x_flag_zee and global_options_set.x_flag_omit_frame_pointer. (ix86_option_optimization): Don't set flag_omit_frame_pointer and flag_zee to 2. * config/i386/sol2-10.h (SUBTARGET_OVERRIDE_OPTIONS): Check global_options_set.x_flag_omit_frame_pointer. * config/rs6000/rs6000.c (rs6000_option_init_struct): Set opts->x_flag_section_anchors to 1 not 2. * config/sh/sh.c (sh_option_optimization): Don't set flag_schedule_insns to 2. (sh_option_override): Check global_options_set.x_flag_schedule_insns. * opts.c (finish_options): Check opts_set->x_flag_section_anchors. From-SVN: r165539
Joseph Myers committed -
2010-10-16 Kai Tietz <kai.tietz@onevision.com> * configure.ac: Make sure inhibit_libc remains false for mingw targets as cross. * configure: Regenerated. From-SVN: r165538Kai Tietz committed -
From-SVN: r165537
GCC Administrator committed -
In libobjc/: 2010-10-16 Nicola Pero <nicola.pero@meta-innovation.com> * objc/runtime.h (class_getIvarLayout): New. (class_getWeakIvarLayout): New. (class_setIvarLayout): New. (class_setWeakIvarLayout): New. * ivars.c (class_getIvarLayout): New. (class_getWeakIvarLayout): New. (class_setIvarLayout): New. (class_setWeakIvarLayout): New. From-SVN: r165533Nicola Pero committed
-