- 14 Oct, 2019 7 commits
-
-
PR fortran/92072 * error.c (error_print, gfc_format_decoder): Fix %C column- offset handling. From-SVN: r276953
Tobias Burnus committed -
This turned out to be useful for the SVE PCS support, and is a natural tree-level analogue of insn_callee_abi. 2019-10-14 Richard Sandiford <richard.sandiford@arm.com> gcc/ * function-abi.h (expr_callee_abi): Declare. * function-abi.cc (expr_callee_abi): New function. From-SVN: r276952
Richard Sandiford committed -
The current aka diagnostics can sometimes leak internal details that seem more likely to be distracting than useful. E.g. on aarch64: void f (va_list *va) { *va = 1; } gives: incompatible types when assigning to type ‘va_list’ {aka ‘__va_list’} from type ‘int’ where __va_list isn't something the user is expected to know about. A similar thing happens for C++ on the arm_neon.h-based: float x; int8x8_t y = x; which gives: cannot convert ‘float’ to ‘int8x8_t’ {aka ‘__Int8x8_t’} in initialization This is accurate -- and __Int8x8_t is defined by the AArch64 PCS -- but it's not going to be meaningful to most users. This patch stops the aka code looking through typedefs if all of the following are true: (1) the typedef is built into the compiler or comes from a system header (2) the target of the typedef is anonymous or has a name in the implementation namespace (3) the target type is a tag type or vector type, which have in common that: (a) we print their type names if they have one (b) what we print for anonymous types isn't all that useful ("struct <anonymous>" etc. for tag types, pseudo-C "__vector(N) T" for vector types) The patch does this by recursively looking for the aka type, like the C++ frontend already does. This in turn makes "aka" work for distinct type copies like __Int8x8_t on aarch64, fixing the ??? in aarch64/diag_aka_1.c. 2019-10-14 Richard Sandiford <richard.sandiford@arm.com> gcc/c-family/ * c-common.h (user_facing_original_type_p): Declare. * c-common.c: Include c-spellcheck.h. (user_facing_original_type_p): New function. gcc/c/ * c-objc-common.c (useful_aka_type_p): Replace with... (get_aka_type): ...this new function. Given the original type, decide which aka type to print (if any). Only look through typedefs if user_facing_original_type_p. (print_type): Update accordingly. gcc/testsuite/ * gcc.dg/diag-aka-5.h: New test. * gcc.dg/diag-aka-5a.c: Likewise. * gcc.dg/diag-aka-5b.c: Likewise. * gcc.target/aarch64/diag_aka_1.c (f): Expect an aka to be printed for myvec. From-SVN: r276951
Richard Sandiford committed -
c/ * c-parser.c (c_parser_omp_all_clauses): Change bool NESTED_P argument into int NESTED, if it is 2, diagnose missing commas in between clauses. (c_parser_omp_context_selector): Pass 2 as last argument to c_parser_omp_all_clauses. cp/ * parser.c (cp_parser_omp_all_clauses): Change bool NESTED_P argument into int NESTED, if it is 2, diagnose missing commas in between clauses. (cp_parser_omp_context_selector): Pass 2 as last argument to cp_parser_omp_all_clauses. testsuite/ * c-c++-common/gomp/declare-variant-7.c: Add tests for clauses not separated by commas in simd selector trait properties. From-SVN: r276950
Jakub Jelinek committed -
From-SVN: r276949
Aldy Hernandez committed -
'}' is missed at the end. gcc/ChangeLog: 2019-10-14 Xiong Hu Luo <luoxhu@linux.ibm.com> * tree-sra.c (dump_access): Add missing braces. From-SVN: r276948
Xiong Hu Luo committed -
From-SVN: r276947
GCC Administrator committed
-
- 13 Oct, 2019 11 commits
-
-
We applied a conservative, but fairly large, hammer to fix PR71767. However, ideally, we want minimise the number of symbols visible to ld64 and to match the cases emitted by clang (since that's what ld64 is expecting). Now we've improved the handling of indirections, we can make the indirection symbols local when they are in the regular non-lazy symbol pointers section. We will continue to make any indirections in the data section visible (since right now we have no way to track if a given symbol follows a weak global). This change makes no difference to handling of labels for constants (to be revised in a future patch). There's a mechanical change to a number of tests (allowing 'l' or 'L' as the indirection symbol prefix). gcc/ChangeLog: 2019-10-13 Iain Sandoe <iain@sandoe.co.uk> * config/darwin.c (machopic_indirection_name): Rework the function to emit linker-visible symbols only for indirections in the data section. Clean up the code and update comments. gcc/testsuite/ChangeLog: 2019-10-13 Iain Sandoe <iain@sandoe.co.uk> * gcc.target/i386/indirect-thunk-1.c: Allow 'l' or 'L' in indirection label prefix, for Darwin. * gcc.target/i386/indirect-thunk-2.c: Likewise. * gcc.target/i386/indirect-thunk-3.c: Likewise. * gcc.target/i386/indirect-thunk-4.c: Likewise. * gcc.target/i386/indirect-thunk-attr-1.c: Likewise. * gcc.target/i386/indirect-thunk-attr-2.c: Likewise. * gcc.target/i386/indirect-thunk-attr-3.c: Likewise. * gcc.target/i386/indirect-thunk-attr-4.c: Likewise. * gcc.target/i386/indirect-thunk-attr-5.c: Likewise. * gcc.target/i386/indirect-thunk-attr-6.c: Likewise. * gcc.target/i386/indirect-thunk-extern-1.c: Likewise. * gcc.target/i386/indirect-thunk-extern-2.c: Likewise. * gcc.target/i386/indirect-thunk-extern-3.c: Likewise. * gcc.target/i386/indirect-thunk-extern-4.c: Likewise. * gcc.target/i386/indirect-thunk-inline-1.c: Likewise. * gcc.target/i386/indirect-thunk-inline-2.c: Likewise. * gcc.target/i386/indirect-thunk-inline-3.c: Likewise. * gcc.target/i386/indirect-thunk-inline-4.c: Likewise. * gcc.target/i386/pr32219-2.c: Likewise. * gcc.target/i386/pr32219-3.c: Likewise. * gcc.target/i386/pr32219-4.c: Likewise. * gcc.target/i386/pr32219-7.c: Likewise. * gcc.target/i386/pr32219-8.c: Likewise. * gcc.target/i386/ret-thunk-14.c: Likewise. * gcc.target/i386/ret-thunk-15.c: Likewise. * gcc.target/i386/ret-thunk-9.c: Likewise. From-SVN: r276943
Iain Sandoe committed -
This code fragment was imported from the Apple branch (it was never applied to mainline). It is stated to fix up a problem sometimes created by reload (before that had been extended to have greater flexibility in assigning the pic registers). In any event, reload is no longer in use for the port. gcc/ChangeLog: 2019-10-13 Iain Sandoe <iain@sandoe.co.uk> * config/darwin.c (machopic_indirect_data_reference): Remove redundant code. From-SVN: r276942
Iain Sandoe committed -
re PR fortran/91513 (Non-standard terminology in error message for pointer component assignment in pure procedure) 2019-10-13 Damian Rouson <damain@sourceryinstitue.org> PR fortran/91513 * resolve.c (resolve_ordinary_assign): Improved error message. 2019-10-13 Damian Rouson <damain@sourceryinstitue.org> PR fortran/91513 * gfortran.dg/impure_assignment_2.f90: Update dg-error regex. From-SVN: r276941
Damian Rouson committed -
2019-10-13 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/90297 * resolve.c (resolve_typebound_function): Remove code with no functional effect. From-SVN: r276940
Steven G. Kargl committed -
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg00942.html In constifying some more of line-map I discovered gengtype didn't know mutable. Added thusly. * gengtype-lex.l (CXX_KEYWORD): Add 'mutable'. From-SVN: r276939
Nathan Sidwell committed -
2019-10-13 Thomas Koenig <tkoenig@gcc.gnu.org> PR fortran/92017 * expr.c (simplify_parameter_variable): Set the character length of the result expression from the original expression if necessary. 2019-10-13 Thomas Koenig <tkoenig@gcc.gnu.org> PR fortran/92017 * gfortran.dg/minmaxloc_14.f90: New test. From-SVN: r276938
Thomas Koenig committed -
gcc: * doc/sourcebuild.texi (Test Directives, Add Options): Remove c99_runtime. gcc/testsuite: * lib/target-supports.exp (add_options_for_c99_runtime): Remove. (check_effective_target_c99_runtime): Remove call to add_options_for_c99_runtime. * gcc.dg/builtins-18.c: Remove dg-add-options c99_runtime. * gcc.dg/builtins-20.c: Likewise. * gcc.dg/builtins-53.c: Likewise. * gcc.dg/builtins-55.c: Likewise. * gcc.dg/builtins-67.c: Likewise. * gcc.dg/c99-tgmath-1.c: Likewise. * gcc.dg/c99-tgmath-2.c: Likewise. * gcc.dg/c99-tgmath-3.c: Likewise. * gcc.dg/c99-tgmath-4.c: Likewise. * gcc.dg/ipa/inline-8.c: Likewise. * gcc.dg/ipa/ipa-icf-5.c: Likewise. * gcc.dg/ipa/ipa-icf-7.c: Likewise. * gcc.dg/nextafter-2.c: Likewise. * gcc.dg/pr42427.c: Likewise. * gcc.dg/pr78965.c: Likewise. * gcc.dg/single-precision-constant.c: Likewise. * gcc.dg/torture/builtin-convert-1.c: Likewise. * gcc.dg/torture/builtin-convert-2.c: Likewise. * gcc.dg/torture/builtin-convert-3.c: Likewise. * gcc.dg/torture/builtin-convert-4.c: Likewise. * gcc.dg/torture/builtin-fp-int-inexact.c: Likewise. * gcc.dg/torture/builtin-fp-int-inexact-c2x.c: Likewise. * gcc.dg/torture/builtin-integral-1.c: Likewise. * gcc.dg/torture/builtin-power-1.c: Likewise. * gcc.dg/tree-ssa/copy-sign-1.c: Likewise. * gcc.dg/tree-ssa/minmax-2.c: Likewise. * gcc.dg/tree-ssa/mult-abs-2.c: Likewise. * gcc.target/i386/387-builtin-fp-int-inexact.c: Likewise. * gcc.target/i386/387-rint-inline-1.c: Likewise. * gcc.target/i386/387-rint-inline-2.c: Likewise. * gcc.target/i386/conversion.c: Likewise. * gcc.target/i386/pr47312.c: Likewise. * gcc.target/i386/sse2-builtin-fp-int-inexact.c: Likewise. * gcc.target/i386/sse2-rint-inline-1.c: Likewise. * gcc.target/i386/sse2-rint-inline-2.c: Likewise. * gcc.target/i386/sse4_1-builtin-fp-int-inexact.c: Likewise. * gcc.target/i386/sse4_1-rint-inline.c: Likewise. From-SVN: r276937
Rainer Orth committed -
* lto-common.c (read_cgraph_and_symbols): Grow ggc memory use after summary streaming. From-SVN: r276936
Jan Hubicka committed -
From-SVN: r276935
Jan Hubicka committed -
lto-streamer-out.c (collect_block_tree_leafs): Renumber statements so non-virutal are before virutals. * lto-streamer-out.c (collect_block_tree_leafs): Renumber statements so non-virutal are before virutals. (output_function): Avoid body modifications. From-SVN: r276934
Jan Hubicka committed -
From-SVN: r276933
GCC Administrator committed
-
- 12 Oct, 2019 13 commits
-
-
* config/pa/pa.c (pa_output_call): Load descriptor address to register %r22. Load function address before global pointer. (pa_attr_length_indirect_call): Adjust length of inline versions of $$dyncall. (pa_output_indirect_call): Remove fast inline version of $$dyncall before normal cases. Update inline $$dyncall sequences to preserve function descriptor address in register %r22. (TRAMPOLINE_CODE_SIZE): Adjust. (pa_asm_trampoline_template): Revise 32-bit trampoline. Don't assume register %r22 contains trampoline address. (pa_trampoline_init): Adjust offsets. (pa_trampoline_adjust_address): Likewise. * config/pa/pa.h (TRAMPOLINE_SIZE): Adjust 32-bit size. From-SVN: r276928
John David Anglin committed -
When we're using the LLVM-based assembler (the default on modern Darwin) the ordering of stubs and non-lazy symbol pointers is important. Interleaving the output (current GCC behaviour) leads to crashes which prevents us from building code with symbol stubs. To resolve this, we order the output of stubs and symbol indirections: 1. Any indirections in the data section 2. Symbol stubs. 3. Non-lazy symbol pointers. At present, we still emit LTO sections after these. gcc/ChangeLog: 2019-10-12 Iain Sandoe <iain@sandoe.co.uk> PR target/67183 * config/darwin.c (machopic_indirection): New field to flag non-lazy-symbol-pointers in the data section. (machopic_indirection_name): Compute if an indirection should appear in the data section. (machopic_output_data_section_indirection): New callback split from machopic_output_indirection. (machopic_output_stub_indirection): Likewise. (machopic_output_indirection): Retain the code for non-lazy symbol pointers in their regular section. (machopic_finish): Use the new callbacks to order the indirection output. From-SVN: r276926
Iain Sandoe committed -
* config/pa/lib2funcs.S (__gcc_plt_call): Load branch target to %r21. Load PIC register after branch target. Fix white space. * config/pa/milli64.S ($$dyncall): Separate LINUX and non LINUX implementations. Load PIC register after branch target. Don't clobber function pointer when it points to function descriptor. Use nullification instead of branch in LINUX implementation. From-SVN: r276925
John David Anglin committed -
It's only called from darwin.c. gcc/ChangeLog: 2019-10-12 Iain Sandoe <iain@sandoe.co.uk> * config/darwin-protos.h (machopic_finish): Delete. * config/darwin.c (machopic_finish): Make static. From-SVN: r276924
Iain Sandoe committed -
Older versions of GCC emit empty .constructor/.destructor sections whenever building for C++. In fact, these sections are only used for kernel mode code - so don't emit them unless that's what we're building. gcc/ChangeLog: 2019-10-12 Iain Sandoe <iain@sandoe.co.uk> * config/darwin.c (darwin_file_end): Only emit empty CTOR/DTOR sections when building kernel extension code. From-SVN: r276923
Iain Sandoe committed -
Fixes: 66ce32bb2a8 ("Fix the ChangeLog for my previous commit") From-SVN: r276922
Palmer Dabbelt committed -
The documentation used to indicate that the inline keyword was only supported by c99 and c11, whereas in fact it is supported by c99 and all newer standards. gcc/ChangeLog 2019-10-12 Palmer Dabbelt <palmer@sifive.com> * doc/extend.texi (Alternate Keywords): Change "-std=c11" to "a later standard." From-SVN: r276921
Palmer Dabbelt committed -
* gcc/config/pa/pa.c (pa_option_override): Remove trailing comma from warning. From-SVN: r276920
John David Anglin committed -
PR ada/91995 * sem_ch8.adb (Chain_Use_Clause): Remove second argument in calls to Defining_Entity. * sem_elab.adb (Find_Unit_Entity): Likewise. Deal with N_Subunit here in lieu of in Defining_Entity. * sem_util.ads (Defining_Entity): Remove 2nd and 3th parameters. * sem_util.adb (Defining_Entity): Remove 2nd and 3th parameters, and adjust accordingly. Deal with N_Compilation_Unit. From-SVN: r276916
Eric Botcazou committed -
re PR middle-end/92063 (ICE in operation_could_trap_p, at tree-eh.c:2528 when compiling Python's Python/_warnings.c) PR middle-end/92063 * tree-eh.c (operation_could_trap_helper_p) <case COND_EXPR> <case VEC_COND_EXPR>: Return false with *handled = false. (tree_could_trap_p): For {,VEC_}COND_EXPR return false instead of recursing on the first operand. * fold-const.c (simple_operand_p_2): Use generic_expr_could_trap_p instead of tree_could_trap_p. * tree-ssa-sccvn.c (vn_nary_may_trap): Formatting fixes. * gcc.c-torture/compile/pr92063.c: New test. From-SVN: r276915
Jakub Jelinek committed -
c-family/ * c-common.h (c_omp_mark_declare_variant, c_omp_context_selector_matches): Declare. * c-omp.c: Include attribs.h, gimplify.h, cgraph.h, symbol-summary.h and hsa-common.h. (c_omp_get_context_selector): Support second argument NULL. (c_omp_mark_declare_variant, c_omp_context_selector_matches): New functions. * c-attribs.c (c_common_attribute_table): Remove "omp declare variant" attribute, add "omp declare variant base" and "omp declare variant variant" attributes. c/ * c-parser.c (c_parser_omp_context_selector): Improve error recovery. For simd properties, put them directly into TREE_VALUE. (c_finish_omp_declare_variant): Call c_omp_mark_declare_variant. If c_omp_context_selector_matches is 0, don't add attribute, otherwise add "omp declare variant base" attribute rather than "omp declare variant". cp/ * parser.c (cp_parser_omp_context_selector): Improve error recovery. For simd properties, put them directly into TREE_VALUE. (cp_finish_omp_declare_variant): Add "omp declare variant base" attribute rather than "omp declare variant". testsuite/ * c-c++-common/gomp/declare-variant-2.c: Adjust for error recovery improvements. Add new tests. * c-c++-common/gomp/declare-variant-4.c: New test. * c-c++-common/gomp/declare-variant-5.c: New test. * c-c++-common/gomp/declare-variant-6.c: New test. * c-c++-common/gomp/declare-variant-7.c: New test. From-SVN: r276914
Jakub Jelinek committed -
We need to mangle dots to avoid problems with -fgo-pkgpath=a.0. That will confuse the name mangling, which assumes that names entering the mangling cannot contain arbitrary dot characters. We don't need to mangle other characters; go_encode_id will handle them. Fixes golang/go#33871 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/200838 From-SVN: r276913
Ian Lance Taylor committed -
From-SVN: r276912
GCC Administrator committed
-
- 11 Oct, 2019 9 commits
-
-
ISO C2x adds decimal floating point as an optional standard feature. This patch accordingly makes GCC accept DFP constants (DF, DD, DL, df, dd, dl suffixes) in strict C2X mode, with a pedwarn-if-pedantic for older standards and a warning with -Wc11-c2x-compat even in C2x mode (which in turn requires -Wc11-c2x-compat to be newly passed through to libcpp). Bootstrapped with no regressions on x86_64-pc-linux-gnu. gcc/c-family: * c.opt (Wc11-c2x-compat): Add CPP(cpp_warn_c11_c2x_compat) CppReason(CPP_W_C11_C2X_COMPAT). gcc/testsuite: * gcc.dg/dfp/c11-constants-1.c, gcc.dg/dfp/c11-constants-2.c, gcc.dg/dfp/c2x-constants-1.c, gcc.dg/dfp/c2x-constants-2.c: New tests. * gcc.dg/dfp/constants-pedantic.c: Use -std=gnu17 explicitly. Update expected diagnostics. libcpp: * include/cpplib.h (struct cpp_options): Add dfp_constants and cpp_warn_c11_c2x_compat. (enum cpp_warning_reason): Add CPP_W_C11_C2X_COMPAT. * init.c (struct lang_flags): Add dfp_constants. (lang_defaults): Set dfp_constants to 1 for GNUC2X and STDC2X and 0 for other languages. (cpp_set_lang): Set dfp_constants from language. (cpp_create_reader): Set cpp_warn_c11_c2x_compat to -1. * expr.c (interpret_float_suffix): Mention DFP constants as C2X in comment. (cpp_classify_number): Do not diagnose DFP constants for languages setting dfp_constants, unless cpp_warn_c11_c2x_compat. From-SVN: r276908
Joseph Myers committed -
* g++.dg/expr/cond17.C: New test. From-SVN: r276907
Marek Polacek committed -
The concepts merge brought this bit @@ -26326,9 +26559,9 @@ build_non_dependent_expr (tree expr) unexpected recursive instantiations. */ && !parsing_nsdmi () /* Don't do this during concept expansion either and for - the same reason. */ - && !expanding_concept ()) - fold_non_dependent_expr (expr, tf_none); + the same reason. */ + && !parsing_constraint_expression_p ()) + fold_non_dependent_expr (expr); STRIP_ANY_LOCATION_WRAPPER (expr); (which I'm not finding in the ChangeLog). Dropping tf_none means that fold_non_dependent_expr will use tf_warning_or_error by default, and in this test that causes an error: template<bool> struct cond; template<int> struct S { void f(int i) { cond<__builtin_constant_p(i)>(); } }; S<1> s; where it complains that cond<false> is incomplete. Which it is, but we're not actually instantiating the function f, so issuing an error seems overzealous (though not wrong), and it breaks a bunch of tests. This patch brings that tf_none back. We will still complain if we do instantiate f. * pt.c (build_non_dependent_expr): Call fold_non_dependent_expr with tf_none. * g++.dg/template/builtin2.C: New test. From-SVN: r276906
Marek Polacek committed -
2019-10-10 Paolo Carlini <paolo.carlini@oracle.com> * typeck.c (cp_build_binary_op): Do not handle RROTATE_EXPR and LROTATE_EXPR. * constexpr.c (cxx_eval_constant_expression): Likewise. (potential_constant_expression_1): Likewise. * cp-gimplify.c (cp_fold): Likewise. * pt.c (tsubst_copy): Likewise. From-SVN: r276903
Paolo Carlini committed -
* decl2.c (mark_used): Don't clobber DECL_SOURCE_LOCATION on explicitly defaulted functions. * method.c (synthesize_method): Likewise. From-SVN: r276902
Jason Merrill committed -
This addresses PR 91860 which has four testcases triggering internal errors. The problem here is that in combine when handling debug insns, we are trying to substitute (sign_extend:DI (const_int 8160 [0x1fe0])) as the value for (reg:DI 78 [ _9 ]) in the debug insn (debug_insn 29 28 30 2 (var_location:QI d (subreg:QI (reg:DI 78 [ _9 ]) 0)) "tmp4.c":11:5 -1 (nil)) This eventually triggers an abort because 8160 is not a sign-extended QImode value. In subst there is already code check for a CONST_INT inside a ZERO_EXTEND and simplify it. This needs to be extended to also handle a SIGN_EXTEND the same way. gcc/ PR rtl-optimization/91860 * combine.c (subst): If new_rtx is a constant, also check for SIGN_EXTEND when deciding whether to call simplify_unary_operation. gcc/testsuite/ PR rtl-optimization/91860 * gcc.dg/pr91860-1.c: New testcase. * gcc.dg/pr91860-2.c: New testcase. * gcc.dg/pr91860-3.c: New testcase. * gcc.dg/pr91860-4.c: New testcase. From-SVN: r276901
Jim Wilson committed -
2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/91649 check.c (gfc_check_findloc): Additional checking for valid arguments 2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/91649 * gfortran.dg/pr91649.f90: New test. From-SVN: r276900
Steven G. Kargl committed -
2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/91715 * decl.c (gfc_match_prefix): If matching a type-spec returns an error, it's an error so re-act correctly. 2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/91715 * gfortran.dg/function_kinds_5.f90: Prune run-on error. * gfortran.dg/pr85543.f90: Ditto. * gfortran.dg/pr91715.f90: New test. From-SVN: r276899
Steven G. Kargl committed -
2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/92018 * check.c (reset_boz): New function. (illegal_boz_arg, boz_args_check, gfc_check_complex, gfc_check_float, gfc_check_transfer): Use it. (gfc_check_dshift): Use reset_boz, and re-arrange the checking to help suppress possible run-on errors. (gfc_check_and): Restore checks for valid argument types. Use reset_boz, and re-arrange the checking to help suppress possible un-on errors. * resolve.c (resolve_function): Actual arguments cannot be BOZ in a function reference. 2019-10-11 Steven G. Kargl <kargl@gcc.gnu.org> PR fortran/92018 * gfortran.dg/gnu_logical_2.f90: Update dg-error regex. * gfortran.dg/pr81509_2.f90: Ditto. * gfortran.dg/pr92018.f90: New test. From-SVN: r276898
Steven G. Kargl committed
-