Commit fe23b12a by Jason Merrill Committed by Jason Merrill

PR c++/84160 - ICE with nested variadic capture.

	* lambda.c (is_capture_proxy_with_ref): New.
	(insert_capture_proxy): Don't set DECL_CAPTURED_VARIABLE from a
	COMPONENT_REF.
	* expr.c (mark_use): Use is_capture_proxy_with_ref.
	* constexpr.c (potential_constant_expression_1): Likewise.
	* semantics.c (process_outer_var_ref): Likewise.

From-SVN: r257325
parent 60a57222
2018-02-01 Jason Merrill <jason@redhat.com>
PR c++/84160 - ICE with nested variadic capture.
* lambda.c (is_capture_proxy_with_ref): New.
(insert_capture_proxy): Don't set DECL_CAPTURED_VARIABLE from a
COMPONENT_REF.
* expr.c (mark_use): Use is_capture_proxy_with_ref.
* constexpr.c (potential_constant_expression_1): Likewise.
* semantics.c (process_outer_var_ref): Likewise.
2018-02-01 Marek Polacek <polacek@redhat.com> 2018-02-01 Marek Polacek <polacek@redhat.com>
PR c++/84125 PR c++/84125
......
...@@ -5369,7 +5369,7 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now, ...@@ -5369,7 +5369,7 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now,
case VAR_DECL: case VAR_DECL:
if (DECL_HAS_VALUE_EXPR_P (t)) if (DECL_HAS_VALUE_EXPR_P (t))
{ {
if (now && is_normal_capture_proxy (t)) if (now && is_capture_proxy_with_ref (t))
{ {
/* -- in a lambda-expression, a reference to this or to a /* -- in a lambda-expression, a reference to this or to a
variable with automatic storage duration defined outside that variable with automatic storage duration defined outside that
......
...@@ -6901,6 +6901,7 @@ extern void insert_capture_proxy (tree); ...@@ -6901,6 +6901,7 @@ extern void insert_capture_proxy (tree);
extern void insert_pending_capture_proxies (void); extern void insert_pending_capture_proxies (void);
extern bool is_capture_proxy (tree); extern bool is_capture_proxy (tree);
extern bool is_normal_capture_proxy (tree); extern bool is_normal_capture_proxy (tree);
extern bool is_capture_proxy_with_ref (tree);
extern void register_capture_members (tree); extern void register_capture_members (tree);
extern tree lambda_expr_this_capture (tree, bool); extern tree lambda_expr_this_capture (tree, bool);
extern void maybe_generic_this_capture (tree, tree); extern void maybe_generic_this_capture (tree, tree);
......
...@@ -111,7 +111,7 @@ mark_use (tree expr, bool rvalue_p, bool read_p, ...@@ -111,7 +111,7 @@ mark_use (tree expr, bool rvalue_p, bool read_p,
{ {
case VAR_DECL: case VAR_DECL:
case PARM_DECL: case PARM_DECL:
if (rvalue_p && is_normal_capture_proxy (expr)) if (rvalue_p && is_capture_proxy_with_ref (expr))
{ {
/* Look through capture by copy. */ /* Look through capture by copy. */
tree cap = DECL_CAPTURED_VARIABLE (expr); tree cap = DECL_CAPTURED_VARIABLE (expr);
...@@ -154,7 +154,7 @@ mark_use (tree expr, bool rvalue_p, bool read_p, ...@@ -154,7 +154,7 @@ mark_use (tree expr, bool rvalue_p, bool read_p,
{ {
/* Try to look through the reference. */ /* Try to look through the reference. */
tree ref = TREE_OPERAND (expr, 0); tree ref = TREE_OPERAND (expr, 0);
if (rvalue_p && is_normal_capture_proxy (ref)) if (rvalue_p && is_capture_proxy_with_ref (ref))
{ {
/* Look through capture by reference. */ /* Look through capture by reference. */
tree cap = DECL_CAPTURED_VARIABLE (ref); tree cap = DECL_CAPTURED_VARIABLE (ref);
......
...@@ -290,13 +290,24 @@ is_normal_capture_proxy (tree decl) ...@@ -290,13 +290,24 @@ is_normal_capture_proxy (tree decl)
return DECL_NORMAL_CAPTURE_P (val); return DECL_NORMAL_CAPTURE_P (val);
} }
/* Returns true iff DECL is a capture proxy for which we can use
DECL_CAPTURED_VARIABLE. In effect, this is a normal proxy other than a
nested capture of a function parameter pack. */
bool
is_capture_proxy_with_ref (tree var)
{
return (is_normal_capture_proxy (var) && DECL_LANG_SPECIFIC (var)
&& DECL_CAPTURED_VARIABLE (var));
}
/* VAR is a capture proxy created by build_capture_proxy; add it to the /* VAR is a capture proxy created by build_capture_proxy; add it to the
current function, which is the operator() for the appropriate lambda. */ current function, which is the operator() for the appropriate lambda. */
void void
insert_capture_proxy (tree var) insert_capture_proxy (tree var)
{ {
if (is_normal_capture_proxy (var)) if (is_capture_proxy_with_ref (var))
{ {
tree cap = DECL_CAPTURED_VARIABLE (var); tree cap = DECL_CAPTURED_VARIABLE (var);
if (CHECKING_P) if (CHECKING_P)
...@@ -443,11 +454,20 @@ build_capture_proxy (tree member, tree init) ...@@ -443,11 +454,20 @@ build_capture_proxy (tree member, tree init)
init = TREE_OPERAND (init, 0); init = TREE_OPERAND (init, 0);
STRIP_NOPS (init); STRIP_NOPS (init);
} }
gcc_assert (VAR_P (init) || TREE_CODE (init) == PARM_DECL);
while (is_normal_capture_proxy (init)) if (TREE_CODE (init) == COMPONENT_REF)
init = DECL_CAPTURED_VARIABLE (init); /* We're capturing a capture of a function parameter pack, and have
retrofit_lang_decl (var); lost track of the original variable. It's not important to have
DECL_CAPTURED_VARIABLE (var) = init; DECL_CAPTURED_VARIABLE in this case, since a function parameter pack
isn't a constant variable, so don't bother trying to set it. */;
else
{
gcc_assert (VAR_P (init) || TREE_CODE (init) == PARM_DECL);
while (is_normal_capture_proxy (init))
init = DECL_CAPTURED_VARIABLE (init);
retrofit_lang_decl (var);
DECL_CAPTURED_VARIABLE (var) = init;
}
} }
if (name == this_identifier) if (name == this_identifier)
......
...@@ -3321,7 +3321,7 @@ process_outer_var_ref (tree decl, tsubst_flags_t complain, bool odr_use) ...@@ -3321,7 +3321,7 @@ process_outer_var_ref (tree decl, tsubst_flags_t complain, bool odr_use)
{ {
/* Check whether we've already built a proxy. */ /* Check whether we've already built a proxy. */
tree var = decl; tree var = decl;
while (is_normal_capture_proxy (var)) while (is_capture_proxy_with_ref (var))
var = DECL_CAPTURED_VARIABLE (var); var = DECL_CAPTURED_VARIABLE (var);
tree d = retrieve_local_specialization (var); tree d = retrieve_local_specialization (var);
......
// PR c++/84160
// { dg-do compile { target c++11 } }
template < typename ... T > void f (T ... a)
{
[a ...] { [a ...] {}; };
}
void g ()
{
f < int > (0);
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment