re PR c++/33462 (Broken diagnostic: 'va_arg_expr' not supported by dump_expr)

/cp
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33462
	* cxx-pretty-print.c (pp_cxx_va_arg_expression): Add.
	(pp_cxx_primary_expression): Use it.
	* cxx-pretty-print.h (pp_cxx_va_arg_expression): Declare.
	* error.c (dump_expr): Use it.

/testsuite
2007-09-18  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33462
	* g++.dg/ext/va-arg1.C: New.

From-SVN: r128584

gcc/cp/ChangeLog

 2007-09-18  Paolo Carlini  <pcarlini@suse.de>
 
+	PR c++/33462
+	* cxx-pretty-print.c (pp_cxx_va_arg_expression): Add.
+	(pp_cxx_primary_expression): Use it.
+	* cxx-pretty-print.h (pp_cxx_va_arg_expression): Declare.
+	* error.c (dump_expr): Use it.
+
+2007-09-18  Paolo Carlini  <pcarlini@suse.de>
+
 	PR c++/33463
 	* cxx-pretty-print.c (pp_cxx_postfix_expression): Split
 	out case TYPEID_EXPR to...

gcc/cp/cxx-pretty-print.c

@@ -351,6 +351,8 @@ pp_cxx_id_expression (cxx_pretty_printer *pp, tree t)
      id-expression   
 
    GNU Extensions:
+     __builtin_va_arg ( assignment-expression , type-id )
+
      __has_nothrow_assign ( type-id )   
      __has_nothrow_constructor ( type-id )
      __has_nothrow_copy ( type-id )
@@ -410,6 +412,10 @@ pp_cxx_primary_expression (cxx_pretty_printer *pp, tree t)
       pp_cxx_trait_expression (pp, t);
       break;
 
+    case VA_ARG_EXPR:
+      pp_cxx_va_arg_expression (pp, t);
+      break;
+
     default:
       pp_c_primary_expression (pp_c_base (pp), t);
       break;
@@ -2153,6 +2159,17 @@ pp_cxx_typeid_expression (cxx_pretty_printer *pp, tree t)
 }
 
 void
+pp_cxx_va_arg_expression (cxx_pretty_printer *pp, tree t)
+{
+  pp_cxx_identifier (pp, "__builtin_va_arg");
+  pp_cxx_left_paren (pp);
+  pp_cxx_assignment_expression (pp, TREE_OPERAND (t, 0));
+  pp_cxx_separate_with (pp, ',');
+  pp_cxx_type_id (pp, TREE_TYPE (t));
+  pp_cxx_right_paren (pp);
+}
+
+void
 pp_cxx_trait_expression (cxx_pretty_printer *pp, tree t)
 {
   cp_trait_kind kind = TRAIT_EXPR_KIND (t);

gcc/cp/cxx-pretty-print.h

@@ -71,5 +71,6 @@ void pp_cxx_declaration (cxx_pretty_printer *, tree);
 void pp_cxx_canonical_template_parameter (cxx_pretty_printer *, tree);
 void pp_cxx_trait_expression (cxx_pretty_printer *, tree);
 void pp_cxx_typeid_expression (cxx_pretty_printer *, tree);
+void pp_cxx_va_arg_expression (cxx_pretty_printer *, tree);
 
 #endif /* GCC_CXX_PRETTY_PRINT_H */

gcc/cp/error.c

@@ -2062,6 +2062,10 @@ dump_expr (tree t, int flags)
       pp_cxx_typeid_expression (cxx_pp, t);
       break;
 
+    case VA_ARG_EXPR:
+      pp_cxx_va_arg_expression (cxx_pp, t);
+      break;
+
       /*  This list is incomplete, but should suffice for now.
 	  It is very important that `sorry' does not call
 	  `report_error_function'.  That could cause an infinite loop.  */

gcc/testsuite/ChangeLog

+2007-09-18  Paolo Carlini  <pcarlini@suse.de>
+
+	PR c++/33462
+	* g++.dg/ext/va-arg1.C: New.
+
 2007-09-18  Tobias Burnus  <burnus@net-b.de>
 
 	* gfortran.dg/elemental_optional_args_1.f90: Fix test.

gcc/testsuite/g++.dg/ext/va-arg1.C

+// PR c++/33462
+
+struct A {};
+
+void foo()
+{
+  ++__builtin_va_arg(0, A); // { dg-error "'\\+\\+__builtin_va_arg\\(0, A\\)'" }
+}