Commit ebc9a431 by Alan Modra Committed by Alan Modra

re PR target/55033 (PowerPC section type conflict error)

	PR target/55033
	* varasm.c (default_elf_select_section): Move !DECL_P check..
	(get_named_section): ..to here before calling get_section_name.
	Adjust assertion.
	(default_section_type_flags): Add DECL_P check.
	* config/i386/winnt.c (i386_pe_section_type_flags): Likewise.
	* config/rs6000/rs6000.c (rs6000_xcoff_section_type_flags): Likewise.

From-SVN: r198762
parent 65267ae9
2013-05-10 Alan Modra <amodra@gmail.com>
PR target/55033
* varasm.c (default_elf_select_section): Move !DECL_P check..
(get_named_section): ..to here before calling get_section_name.
Adjust assertion.
(default_section_type_flags): Add DECL_P check.
* config/i386/winnt.c (i386_pe_section_type_flags): Likewise.
* config/rs6000/rs6000.c (rs6000_xcoff_section_type_flags): Likewise.
2013-05-09 Joern Rennecke <joern.rennecke@embecosm.com> 2013-05-09 Joern Rennecke <joern.rennecke@embecosm.com>
* config/epiphany/epiphany.c (epiphany_expand_prologue): * config/epiphany/epiphany.c (epiphany_expand_prologue):
......
...@@ -476,7 +476,7 @@ i386_pe_section_type_flags (tree decl, const char *name, int reloc) ...@@ -476,7 +476,7 @@ i386_pe_section_type_flags (tree decl, const char *name, int reloc)
flags |= SECTION_PE_SHARED; flags |= SECTION_PE_SHARED;
} }
if (decl && DECL_ONE_ONLY (decl)) if (decl && DECL_P (decl) && DECL_ONE_ONLY (decl))
flags |= SECTION_LINKONCE; flags |= SECTION_LINKONCE;
/* See if we already have an entry for this section. */ /* See if we already have an entry for this section. */
......
...@@ -26029,7 +26029,7 @@ rs6000_xcoff_section_type_flags (tree decl, const char *name, int reloc) ...@@ -26029,7 +26029,7 @@ rs6000_xcoff_section_type_flags (tree decl, const char *name, int reloc)
unsigned int flags = default_section_type_flags (decl, name, reloc); unsigned int flags = default_section_type_flags (decl, name, reloc);
/* Align to at least UNIT size. */ /* Align to at least UNIT size. */
if (flags & SECTION_CODE || !decl) if ((flags & SECTION_CODE) != 0 || !decl || !DECL_P (decl))
align = MIN_UNITS_PER_WORD; align = MIN_UNITS_PER_WORD;
else else
/* Increase alignment of large objects if not already stricter. */ /* Increase alignment of large objects if not already stricter. */
......
...@@ -402,12 +402,16 @@ get_named_section (tree decl, const char *name, int reloc) ...@@ -402,12 +402,16 @@ get_named_section (tree decl, const char *name, int reloc)
{ {
unsigned int flags; unsigned int flags;
gcc_assert (!decl || DECL_P (decl));
if (name == NULL) if (name == NULL)
name = TREE_STRING_POINTER (DECL_SECTION_NAME (decl)); {
gcc_assert (decl && DECL_P (decl) && DECL_SECTION_NAME (decl));
name = TREE_STRING_POINTER (DECL_SECTION_NAME (decl));
}
flags = targetm.section_type_flags (decl, name, reloc); flags = targetm.section_type_flags (decl, name, reloc);
if (decl && !DECL_P (decl))
decl = NULL_TREE;
return get_section (name, flags, decl); return get_section (name, flags, decl);
} }
...@@ -5990,7 +5994,7 @@ default_section_type_flags (tree decl, const char *name, int reloc) ...@@ -5990,7 +5994,7 @@ default_section_type_flags (tree decl, const char *name, int reloc)
flags |= SECTION_RELRO; flags |= SECTION_RELRO;
} }
if (decl && DECL_ONE_ONLY (decl)) if (decl && DECL_P (decl) && DECL_ONE_ONLY (decl))
flags |= SECTION_LINKONCE; flags |= SECTION_LINKONCE;
if (decl && TREE_CODE (decl) == VAR_DECL && DECL_THREAD_LOCAL_P (decl)) if (decl && TREE_CODE (decl) == VAR_DECL && DECL_THREAD_LOCAL_P (decl))
...@@ -6349,8 +6353,6 @@ default_elf_select_section (tree decl, int reloc, ...@@ -6349,8 +6353,6 @@ default_elf_select_section (tree decl, int reloc,
gcc_unreachable (); gcc_unreachable ();
} }
if (!DECL_P (decl))
decl = NULL_TREE;
return get_named_section (decl, sname, reloc); return get_named_section (decl, sname, reloc);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment