Commit e1d070a4 by Alexandre Oliva Committed by Alexandre Oliva

[bootstrap-O3,fortran] silence warning in simplify_transformation_to_array

simplify_transformation_to_array had the nested loop unrolled 7 times,
which is reasonable given that it iterates over arrays of size
GFC_MAX_DIMENSIONS == 7.

The problem is that the last iteration increments the index, tests
that it's less than result->rank, and then accesses the arrays with
the incremented index.

We did not optimize out that part in the 7th iteration, so VRP flagged
the unreachable code as accessing arrays past the end.

It couldn't possibly know that we'd never reach that part, since the
test was on result->rank, and it's not obvious (for the compiler) that
result->rank <= GFC_MAX_DIMENSIONS.

Even an assert to that effect before the enclosing loop didn't avoid
the warning turned to error, though; I suppose there might be some
aliasing at play, because moving the assert into the loop does.  An
assert on the index itself would also work, even more efficiently, but
we're just silencing the warning instead.

for  gcc/fortran/ChangeLog

	* simplify.c (simplify_transformation_to_array): Silence
	array bounds warning.  Fix whitespace.

From-SVN: r244122
parent 435f3f7a
2017-01-06 Alexandre Oliva <aoliva@redhat.com>
* simplify.c (simplify_transformation_to_array): Silence
array bounds warning. Fix whitespace.
2017-01-04 Alexandre Oliva <aoliva@redhat.com>
* module.c (load_omp_udrs): Initialize name.
......
......@@ -610,9 +610,18 @@ simplify_transformation_to_array (gfc_expr *result, gfc_expr *array, gfc_expr *d
n++;
if (n < result->rank)
{
count [n]++;
#pragma GCC diagnostic push
/* If the nested loop is unrolled GFC_MAX_DIMENSIONS
times, we'd warn for the last iteration, because the
array index will have already been incremented to the
array sizes, and we can't tell that this must make
the test against result->rank false, because ranks
must not exceed GFC_MAX_DIMENSIONS. */
#pragma GCC diagnostic ignored "-Warray-bounds"
count[n]++;
base += sstride[n];
dest += dstride[n];
#pragma GCC diagnostic pop
}
else
done = true;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment