Commit cc4029ee by Andi Kleen Committed by Andi Kleen

Fix handling of very long asm statements in inliner

An auto generated program with a 6.4mio line asm statement gave
with 4.7 and 4.8:

xxx.c:6400017:1: internal compiler error: in account_size_time, at
ipa-inline-analysis.c:601

The problem is that the inliner counts the number of lines in the asm
statement and multiplies that with a weight. With the weight this
overflows 32bit signed int, and triggers an assert for negative time.

Fix this by limiting the number of lines to 1000 for asm cost
estimation. The RTL backend also does similar multiplications for
jump shortening. I haven't tried to address this, but presumably
it's less likely to result in a failure.

gcc/:
2013-09-08  Andi Kleen  <ak@linux.intel.com>

	* tree-inline.c (estimate_num_insns): Limit asm cost to 1000.

From-SVN: r202374
parent 41e96dc8
2013-09-08 Andi Kleen <ak@linux.intel.com>
* tree-inline.c (estimate_num_insns): Limit asm cost to 1000.
2013-09-08 Jan Hubicka <jh@suse.cz>
* ipa.c (walk_polymorphic_call_targets): Fix inliner summary update.
......
......@@ -3744,7 +3744,14 @@ estimate_num_insns (gimple stmt, eni_weights *weights)
return 0;
case GIMPLE_ASM:
return asm_str_count (gimple_asm_string (stmt));
{
int count = asm_str_count (gimple_asm_string (stmt));
/* 1000 means infinity. This avoids overflows later
with very long asm statements. */
if (count > 1000)
count = 1000;
return count;
}
case GIMPLE_RESX:
/* This is either going to be an external function call with one
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment