Commit c95d1dd7 by Jonathan Wakely

c++: Fix misuse of "override" in -Weffc++ warnings (PR 94698)

These warnings have nothing to do with virtual functions, so "override"
is inappropriate. The warnings are just talking about defining special
members, so let's say that.

	PR translation/94698
	* class.c (check_field_decls): Change "override" to "define" in
	-Weffc++ diagnostics.
parent 808a6ead
2020-04-22 Jonathan Wakely <jwakely@redhat.com>
PR translation/94698
* class.c (check_field_decls): Change "override" to "define" in
-Weffc++ diagnostics.
2020-04-22 Iain Sandoe <iain@sandoe.co.uk> 2020-04-22 Iain Sandoe <iain@sandoe.co.uk>
PR c++/94682 PR c++/94682
......
...@@ -3838,13 +3838,13 @@ check_field_decls (tree t, tree *access_decls, ...@@ -3838,13 +3838,13 @@ check_field_decls (tree t, tree *access_decls,
if (! TYPE_HAS_COPY_CTOR (t)) if (! TYPE_HAS_COPY_CTOR (t))
{ {
warning (OPT_Weffc__, warning (OPT_Weffc__,
" but does not override %<%T(const %T&)%>", t, t); " but does not define %<%T(const %T&)%>", t, t);
if (!TYPE_HAS_COPY_ASSIGN (t)) if (!TYPE_HAS_COPY_ASSIGN (t))
warning (OPT_Weffc__, " or %<operator=(const %T&)%>", t); warning (OPT_Weffc__, " or %<operator=(const %T&)%>", t);
} }
else if (! TYPE_HAS_COPY_ASSIGN (t)) else if (! TYPE_HAS_COPY_ASSIGN (t))
warning (OPT_Weffc__, warning (OPT_Weffc__,
" but does not override %<operator=(const %T&)%>", t); " but does not define %<operator=(const %T&)%>", t);
inform (DECL_SOURCE_LOCATION (pointer_member), inform (DECL_SOURCE_LOCATION (pointer_member),
"pointer member %q+D declared here", pointer_member); "pointer member %q+D declared here", pointer_member);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment