re PR target/93141 (Missed optimization : Use of adc when checking overflow)

	PR target/93141
	* config/i386/i386.md (SWIDWI): New mode iterator.
	(DWI, dwi): Add TImode variants.
	(addv<mode>4): Use SWIDWI iterator instead of SWI.  Use
	<general_hilo_operand> instead of <general_operand>.  Use
	CONST_SCALAR_INT_P instead of CONST_INT_P.
	(*addv<mode>4_1): Rename to ...
	(addv<mode>4_1): ... this.
	(QWI): New mode attribute.
	(*addv<dwi>4_doubleword, *addv<dwi>4_doubleword_1): New
	define_insn_and_split patterns.
	(*addv<mode>4_overflow_1, *addv<mode>4_overflow_2): New define_insn
	patterns.
	(uaddv<mode>4): Use SWIDWI iterator instead of SWI.  Use
	<general_hilo_operand> instead of <general_operand>.
	(*addcarry<mode>_1): New define_insn.
	(*add<dwi>3_doubleword_cc_overflow_1): New define_insn_and_split.

	* gcc.target/i386/pr93141-1.c: New test.
	* gcc.dg/pr67089-6.c: Expect 16 ADD_OVERFLOW calls even on ia32.

From-SVN: r279887

gcc/ChangeLog

+2020-01-05  Jakub Jelinek  <jakub@redhat.com>
+
+	PR target/93141
+	* config/i386/i386.md (SWIDWI): New mode iterator.
+	(DWI, dwi): Add TImode variants.
+	(addv<mode>4): Use SWIDWI iterator instead of SWI.  Use
+	<general_hilo_operand> instead of <general_operand>.  Use
+	CONST_SCALAR_INT_P instead of CONST_INT_P.
+	(*addv<mode>4_1): Rename to ...
+	(addv<mode>4_1): ... this.
+	(QWI): New mode attribute.
+	(*addv<dwi>4_doubleword, *addv<dwi>4_doubleword_1): New
+	define_insn_and_split patterns.
+	(*addv<mode>4_overflow_1, *addv<mode>4_overflow_2): New define_insn
+	patterns.
+	(uaddv<mode>4): Use SWIDWI iterator instead of SWI.  Use
+	<general_hilo_operand> instead of <general_operand>.
+	(*addcarry<mode>_1): New define_insn.
+	(*add<dwi>3_doubleword_cc_overflow_1): New define_insn_and_split.
+
 2020-01-03  Konstantin Kharlamov  <Hi-Angel@yandex.ru>
 
 	* gdbinit.in (pr, prl, pt, pct, pgg, pgq, pgs, pge, pmz, pdd, pbs, pbm):

gcc/testsuite/ChangeLog

 2020-01-05  Jakub Jelinek  <jakub@redhat.com>
 
+	PR target/93141
+	* gcc.target/i386/pr93141-1.c: New test.
+	* gcc.dg/pr67089-6.c: Expect 16 ADD_OVERFLOW calls even on ia32.
+
 	PR c++/93138
 	* g++.dg/warn/Wredundant-tags-2.C: New test.
 

gcc/testsuite/gcc.dg/pr67089-6.c

@@ -56,7 +56,6 @@ T (24, unsigned long long, x + y, if (d || y > r) foo (0))
 T (25, unsigned short, 2U - x, if (r > 2U) foo (0))
 T (26, unsigned char, 2U - x, if (r <= 2U) foo (0))
 
-/* { dg-final { scan-tree-dump-times "ADD_OVERFLOW" 16 "widening_mul" { target { { i?86-*-* x86_64-*-* } && { ! ia32 } } } } } */
+/* { dg-final { scan-tree-dump-times "ADD_OVERFLOW" 16 "widening_mul" { target { i?86-*-* x86_64-*-* } } } } */
 /* { dg-final { scan-tree-dump-times "SUB_OVERFLOW" 11 "widening_mul" { target { { i?86-*-* x86_64-*-* } && { ! ia32 } } } } } */
-/* { dg-final { scan-tree-dump-times "ADD_OVERFLOW" 12 "widening_mul" { target { { i?86-*-* x86_64-*-* } && ia32 } } } } */
 /* { dg-final { scan-tree-dump-times "SUB_OVERFLOW" 9 "widening_mul" { target { { i?86-*-* x86_64-*-* } && ia32 } } } } */

gcc/testsuite/gcc.target/i386/pr93141-1.c

+/* PR target/93141 */
+/* { dg-do compile } */
+/* { dg-options "-O2 -masm=att" } */
+/* { dg-final { scan-assembler-not "cmp\[lq]\t" } } */
+/* { dg-final { scan-assembler-times "setc\t%" 3 } } */
+/* { dg-final { scan-assembler-times "seto\t%" 5 } } */
+/* { dg-final { scan-assembler-times "adc\[lq]\t" 5 } } */
+
+#ifdef __x86_64__
+typedef unsigned __int128 U;
+typedef signed __int128 S;
+#else
+typedef unsigned long long U;
+typedef signed long long S;
+#endif
+int o;
+
+U
+foo (U x, U y)
+{
+  U z;
+  o = __builtin_add_overflow (x, y, &z);
+  return z;
+}
+
+U
+bar (U x)
+{
+  U z;
+  o = __builtin_add_overflow (x, ((U) 0xdeadbee) << (sizeof (U) * __CHAR_BIT__ / 2), &z);
+  return z;
+}
+
+U
+baz (U x)
+{
+  U z;
+  o = __builtin_add_overflow (x, (((U) 0xdeadbee) << (sizeof (U) * __CHAR_BIT__ / 2))
+				 | (U) 0xbeedead, &z);
+  return z;
+}
+
+S
+qux (S x, S y)
+{
+  S z;
+  o = __builtin_add_overflow (x, y, &z);
+  return z;
+}
+
+S
+quux (S x)
+{
+  S z;
+  o = __builtin_add_overflow (x, ((S) 0xdeadbee) << (sizeof (S) * __CHAR_BIT__ / 2), &z);
+  return z;
+}
+
+S
+corge (S x)
+{
+  S z;
+  o = __builtin_add_overflow (x, (((S) 0xdeadbee) << (sizeof (S) * __CHAR_BIT__ / 2))
+				 | (S) 0xbeedead, &z);
+  return z;
+}
+
+S
+grault (S x)
+{
+  S z;
+  o = __builtin_add_overflow (x, -((S) 0xdeadbee) << (sizeof (S) * __CHAR_BIT__ / 2), &z);
+  return z;
+}
+
+S
+garply (S x)
+{
+  S z;
+  o = __builtin_add_overflow (x, (-(((S) 0xdeadbee) << (sizeof (S) * __CHAR_BIT__ / 2)))
+				 | (S) 0xbeedead, &z);
+  return z;
+}