Skip to content

R
riscv-gcc-1
Commit c5404f1c by Paolo Bonzini Committed by Paolo Bonzini
Options

c-common.c (maybe_warn_shift_overflow): Warn on all overflows if shifting 1 out of the sign bit. 

gcc:
2015-12-04  Paolo Bonzini  <bonzini@gnu.org>

	* c-family/c-common.c (maybe_warn_shift_overflow): Warn on all
	overflows if shifting 1 out of the sign bit.

gcc/testsuite:
2015-12-04  Paolo Bonzini  <bonzini@gnu.org>

	* c-c++-common/Wshift-overflow-1.c: Test shifting 1 out of the sign bit.
	* c-c++-common/Wshift-overflow-2.c: Test shifting 1 out of the sign bit.
	* c-c++-common/Wshift-overflow-3.c: Test shifting 1 out of the sign bit.
	* c-c++-common/Wshift-overflow-4.c: Test shifting 1 out of the sign bit.
	* c-c++-common/Wshift-overflow-6.c: Test shifting 1 out of the sign bit.
	* c-c++-common/Wshift-overflow-7.c: Test shifting 1 out of the sign bit.

From-SVN: r231290
parent 755be51d
Showing with 41 additions and 2 deletions
gcc/ChangeLog
2015-12-04 Paolo Bonzini <bonzini@gnu.org>
* c-family/c-common.c (maybe_warn_shift_overflow): Warn on all
overflows if shifting 1 out of the sign bit.
2015-12-04 Segher Boessenkool <segher@kernel.crashing.org> 2015-12-04 Segher Boessenkool <segher@kernel.crashing.org>
* (cstore<mode>4_unsigned): Use gpc_reg_operand instead of * (cstore<mode>4_unsigned): Use gpc_reg_operand instead of
gcc/c-family/c-common.c
...@@ -12107,8 +12107,11 @@ maybe_warn_shift_overflow (location_t loc, tree op0, tree op1) ...@@ -12107,8 +12107,11 @@ maybe_warn_shift_overflow (location_t loc, tree op0, tree op1)
unsigned int min_prec = (wi::min_precision (op0, SIGNED) unsigned int min_prec = (wi::min_precision (op0, SIGNED)
+ TREE_INT_CST_LOW (op1)); + TREE_INT_CST_LOW (op1));
/* Handle the left-shifting 1 into the sign bit case. */ /* Handle the case of left-shifting 1 into the sign bit.
if (min_prec == prec0 + 1) * However, shifting 1 _out_ of the sign bit, as in
* INT_MIN << 1, is considered an overflow.
*/
if (!tree_int_cst_sign_bit(op0) && min_prec == prec0 + 1)
{ {
/* Never warn for C++14 onwards. */ /* Never warn for C++14 onwards. */
if (cxx_dialect >= cxx14) if (cxx_dialect >= cxx14)
......
gcc/testsuite/ChangeLog
2015-12-04 Paolo Bonzini <bonzini@gnu.org>
* c-c++-common/Wshift-overflow-1.c: Test shifting 1 out of the sign bit.
* c-c++-common/Wshift-overflow-2.c: Test shifting 1 out of the sign bit.
* c-c++-common/Wshift-overflow-3.c: Test shifting 1 out of the sign bit.
* c-c++-common/Wshift-overflow-4.c: Test shifting 1 out of the sign bit.
* c-c++-common/Wshift-overflow-6.c: Test shifting 1 out of the sign bit.
* c-c++-common/Wshift-overflow-7.c: Test shifting 1 out of the sign bit.
2015-11-25 Nick Clifton <nickc@redhat.com> 2015-11-25 Nick Clifton <nickc@redhat.com>
* gcc.target/msp430/msp_abi_div_funcs.c: New test. * gcc.target/msp430/msp_abi_div_funcs.c: New test.
......
gcc/testsuite/c-c++-common/Wshift-overflow-1.c
...@@ -8,6 +8,9 @@ ...@@ -8,6 +8,9 @@
#define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1) #define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1)
#define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2) #define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2)
#define INT_MIN (-__INT_MAX__-1)
#define LONG_LONG_MIN (-__LONG_LONG_MAX__-1)
int i1 = 1 << INTM1; int i1 = 1 << INTM1;
int i2 = 9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */ int i2 = 9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */
int i3 = 10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */ int i3 = 10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */
...@@ -18,6 +21,7 @@ int i7 = -9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */ ...@@ -18,6 +21,7 @@ int i7 = -9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */
int i8 = -10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */ int i8 = -10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */
int i9 = -__INT_MAX__ << 2; /* { dg-warning "requires 34 bits to represent" } */ int i9 = -__INT_MAX__ << 2; /* { dg-warning "requires 34 bits to represent" } */
int i10 = -__INT_MAX__ << INTM1; /* { dg-warning "requires 63 bits to represent" } */ int i10 = -__INT_MAX__ << INTM1; /* { dg-warning "requires 63 bits to represent" } */
int i11 = INT_MIN << 1; /* { dg-warning "requires 33 bits to represent" } */
int r1 = 1 >> INTM1; int r1 = 1 >> INTM1;
int r2 = 9 >> INTM1; int r2 = 9 >> INTM1;
...@@ -46,6 +50,7 @@ long long int l7 = -9LL << LLONGM1; /* { dg-warning "requires 68 bits to represe ...@@ -46,6 +50,7 @@ long long int l7 = -9LL << LLONGM1; /* { dg-warning "requires 68 bits to represe
long long int l8 = -10LL << LLONGM2; /* { dg-warning "requires 67 bits to represent" } */ long long int l8 = -10LL << LLONGM2; /* { dg-warning "requires 67 bits to represent" } */
long long int l9 = -__LONG_LONG_MAX__ << 2; /* { dg-warning "requires 66 bits to represent" } */ long long int l9 = -__LONG_LONG_MAX__ << 2; /* { dg-warning "requires 66 bits to represent" } */
long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; /* { dg-warning "requires 127 bits to represent" } */ long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; /* { dg-warning "requires 127 bits to represent" } */
long long int l11 = LONG_LONG_MIN << 1; /* { dg-warning "requires 65 bits to represent" } */
void void
fn (void) fn (void)
......
gcc/testsuite/c-c++-common/Wshift-overflow-2.c
...@@ -8,6 +8,9 @@ ...@@ -8,6 +8,9 @@
#define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1) #define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1)
#define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2) #define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2)
#define INT_MIN (-__INT_MAX__-1)
#define LONG_LONG_MIN (-__LONG_LONG_MAX__-1)
int i1 = 1 << INTM1; int i1 = 1 << INTM1;
int i2 = 9 << INTM1; int i2 = 9 << INTM1;
int i3 = 10 << INTM2; int i3 = 10 << INTM2;
...@@ -18,6 +21,7 @@ int i7 = -9 << INTM1; ...@@ -18,6 +21,7 @@ int i7 = -9 << INTM1;
int i8 = -10 << INTM2; int i8 = -10 << INTM2;
int i9 = -__INT_MAX__ << 2; int i9 = -__INT_MAX__ << 2;
int i10 = -__INT_MAX__ << INTM1; int i10 = -__INT_MAX__ << INTM1;
int i11 = INT_MIN << 1;
int r1 = 1 >> INTM1; int r1 = 1 >> INTM1;
int r2 = 9 >> INTM1; int r2 = 9 >> INTM1;
...@@ -46,6 +50,7 @@ long long int l7 = -9LL << LLONGM1; ...@@ -46,6 +50,7 @@ long long int l7 = -9LL << LLONGM1;
long long int l8 = -10LL << LLONGM2; long long int l8 = -10LL << LLONGM2;
long long int l9 = -__LONG_LONG_MAX__ << 2; long long int l9 = -__LONG_LONG_MAX__ << 2;
long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; long long int l10 = -__LONG_LONG_MAX__ << LLONGM1;
long long int l11 = LONG_LONG_MIN << 1;
void void
fn (void) fn (void)
......
gcc/testsuite/c-c++-common/Wshift-overflow-3.c
...@@ -9,6 +9,9 @@ ...@@ -9,6 +9,9 @@
#define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1) #define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1)
#define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2) #define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2)
#define INT_MIN (-__INT_MAX__-1)
#define LONG_LONG_MIN (-__LONG_LONG_MAX__-1)
int i1 = 1 << INTM1; int i1 = 1 << INTM1;
int i2 = 9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */ int i2 = 9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */
int i3 = 10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */ int i3 = 10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */
...@@ -19,6 +22,7 @@ int i7 = -9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */ ...@@ -19,6 +22,7 @@ int i7 = -9 << INTM1; /* { dg-warning "requires 36 bits to represent" } */
int i8 = -10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */ int i8 = -10 << INTM2; /* { dg-warning "requires 35 bits to represent" } */
int i9 = -__INT_MAX__ << 2; /* { dg-warning "requires 34 bits to represent" } */ int i9 = -__INT_MAX__ << 2; /* { dg-warning "requires 34 bits to represent" } */
int i10 = -__INT_MAX__ << INTM1; /* { dg-warning "requires 63 bits to represent" } */ int i10 = -__INT_MAX__ << INTM1; /* { dg-warning "requires 63 bits to represent" } */
int i11 = INT_MIN << 1; /* { dg-warning "requires 33 bits to represent" } */
int r1 = 1 >> INTM1; int r1 = 1 >> INTM1;
int r2 = 9 >> INTM1; int r2 = 9 >> INTM1;
...@@ -47,6 +51,7 @@ long long int l7 = -9LL << LLONGM1; /* { dg-warning "requires 68 bits to represe ...@@ -47,6 +51,7 @@ long long int l7 = -9LL << LLONGM1; /* { dg-warning "requires 68 bits to represe
long long int l8 = -10LL << LLONGM2; /* { dg-warning "requires 67 bits to represent" } */ long long int l8 = -10LL << LLONGM2; /* { dg-warning "requires 67 bits to represent" } */
long long int l9 = -__LONG_LONG_MAX__ << 2; /* { dg-warning "requires 66 bits to represent" } */ long long int l9 = -__LONG_LONG_MAX__ << 2; /* { dg-warning "requires 66 bits to represent" } */
long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; /* { dg-warning "requires 127 bits to represent" } */ long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; /* { dg-warning "requires 127 bits to represent" } */
long long int l11 = LONG_LONG_MIN << 1; /* { dg-warning "requires 65 bits to represent" } */
void void
fn (void) fn (void)
......
gcc/testsuite/c-c++-common/Wshift-overflow-4.c
...@@ -9,6 +9,9 @@ ...@@ -9,6 +9,9 @@
#define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1) #define LLONGM1 (sizeof (long long) * __CHAR_BIT__ - 1)
#define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2) #define LLONGM2 (sizeof (long long) * __CHAR_BIT__ - 2)
#define INT_MIN (-__INT_MAX__-1)
#define LONG_LONG_MIN (-__LONG_LONG_MAX__-1)
int i1 = 1 << INTM1; int i1 = 1 << INTM1;
int i2 = 9 << INTM1; int i2 = 9 << INTM1;
int i3 = 10 << INTM2; int i3 = 10 << INTM2;
...@@ -19,6 +22,7 @@ int i7 = -9 << INTM1; ...@@ -19,6 +22,7 @@ int i7 = -9 << INTM1;
int i8 = -10 << INTM2; int i8 = -10 << INTM2;
int i9 = -__INT_MAX__ << 2; int i9 = -__INT_MAX__ << 2;
int i10 = -__INT_MAX__ << INTM1; int i10 = -__INT_MAX__ << INTM1;
int i11 = INT_MIN << 1;
int r1 = 1 >> INTM1; int r1 = 1 >> INTM1;
int r2 = 9 >> INTM1; int r2 = 9 >> INTM1;
...@@ -47,6 +51,7 @@ long long int l7 = -9LL << LLONGM1; ...@@ -47,6 +51,7 @@ long long int l7 = -9LL << LLONGM1;
long long int l8 = -10LL << LLONGM2; long long int l8 = -10LL << LLONGM2;
long long int l9 = -__LONG_LONG_MAX__ << 2; long long int l9 = -__LONG_LONG_MAX__ << 2;
long long int l10 = -__LONG_LONG_MAX__ << LLONGM1; long long int l10 = -__LONG_LONG_MAX__ << LLONGM1;
long long int l11 = LONG_LONG_MIN << 1;
void void
fn (void) fn (void)
......
gcc/testsuite/c-c++-common/Wshift-overflow-6.c
...@@ -34,3 +34,4 @@ int i27 = 0b1000000000000000000000000000 << 4; ...@@ -34,3 +34,4 @@ int i27 = 0b1000000000000000000000000000 << 4;
int i28 = 0b10000000000000000000000000000 << 3; int i28 = 0b10000000000000000000000000000 << 3;
int i29 = 0b100000000000000000000000000000 << 2; int i29 = 0b100000000000000000000000000000 << 2;
int i30 = 0b1000000000000000000000000000000 << 1; int i30 = 0b1000000000000000000000000000000 << 1;
int i31 = (int) 0b10000000000000000000000000000000u << 1; /* { dg-warning "requires 33 bits to represent" } */
gcc/testsuite/c-c++-common/Wshift-overflow-7.c
...@@ -34,3 +34,4 @@ int i27 = 0b1000000000000000000000000000 << 4; /* { dg-warning "requires 33 bits ...@@ -34,3 +34,4 @@ int i27 = 0b1000000000000000000000000000 << 4; /* { dg-warning "requires 33 bits
int i28 = 0b10000000000000000000000000000 << 3; /* { dg-warning "requires 33 bits to represent" } */ int i28 = 0b10000000000000000000000000000 << 3; /* { dg-warning "requires 33 bits to represent" } */
int i29 = 0b100000000000000000000000000000 << 2; /* { dg-warning "requires 33 bits to represent" } */ int i29 = 0b100000000000000000000000000000 << 2; /* { dg-warning "requires 33 bits to represent" } */
int i30 = 0b1000000000000000000000000000000 << 1; /* { dg-warning "requires 33 bits to represent" } */ int i30 = 0b1000000000000000000000000000000 << 1; /* { dg-warning "requires 33 bits to represent" } */
int i31 = (int) 0b10000000000000000000000000000000u << 1; /* { dg-warning "requires 33 bits to represent" } */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment