Commit c36d5c04 by Michael Koch Committed by Michael Koch

2003-12-23 Michael Koch <konqueror@gmx.de>

	* javax/print/attribute/AttributeSetUtilities.java
	(verifyCategoryForValue): Renamed from verifyCategoryForAttribute.
	* javax/print/attribute/HashAttributeSet.java
	(HashAttributeSet): Call internal add methods, added missing
	exceptions.
	(add): Call addInternal, added exceptions to documentation.
	(addInternal): New method.
	(addAll): Call addAllInternal, added exception to documentation.
	(addAllInternal): New method.
	(clear): Added exception to documentation.
	(remove): Likewise.
	* javax/print/attribute/URISyntax.java
	(serialVersionUID): Fixed value.

From-SVN: r74969
parent 5d027e7b
2003-12-23 Michael Koch <konqueror@gmx.de>
* javax/print/attribute/AttributeSetUtilities.java
(verifyCategoryForValue): Renamed from verifyCategoryForAttribute.
* javax/print/attribute/HashAttributeSet.java
(HashAttributeSet): Call internal add methods, added missing
exceptions.
(add): Call addInternal, added exceptions to documentation.
(addInternal): New method.
(addAll): Call addAllInternal, added exception to documentation.
(addAllInternal): New method.
(clear): Added exception to documentation.
(remove): Likewise.
* javax/print/attribute/URISyntax.java
(serialVersionUID): Fixed value.
2003-12-22 Thomas Fitzsimmons <fitzsim@redhat.com> 2003-12-22 Thomas Fitzsimmons <fitzsim@redhat.com>
* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
......
...@@ -432,8 +432,8 @@ public final class AttributeSetUtilities ...@@ -432,8 +432,8 @@ public final class AttributeSetUtilities
* @exception IllegalArgumentException if the categories are not equal * @exception IllegalArgumentException if the categories are not equal
* @exception NullPointerException if category is null * @exception NullPointerException if category is null
*/ */
public static void verifyCategoryForAttribute(Class category, public static void verifyCategoryForValue(Class category,
Attribute attribute) Attribute attribute)
{ {
if (category == null) if (category == null)
throw new NullPointerException("object may not be null"); throw new NullPointerException("object may not be null");
......
...@@ -124,7 +124,7 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -124,7 +124,7 @@ public class HashAttributeSet implements AttributeSet, Serializable
if (attribute == null) if (attribute == null)
throw new NullPointerException(); throw new NullPointerException();
add(attribute); addInternal(attribute, interfaceName);
} }
/** /**
...@@ -142,7 +142,7 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -142,7 +142,7 @@ public class HashAttributeSet implements AttributeSet, Serializable
throw new NullPointerException(); throw new NullPointerException();
for (int index = 0; index < attributes.length; index++) for (int index = 0; index < attributes.length; index++)
add(attributes[index]); addInternal(attributes[index], interfaceName);
} }
/** /**
...@@ -150,14 +150,13 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -150,14 +150,13 @@ public class HashAttributeSet implements AttributeSet, Serializable
* *
* @exception ClassCastException if any element of attributes is not an * @exception ClassCastException if any element of attributes is not an
* interface of interfaceName * interface of interfaceName
* @exception NullPointerException if attributes or interfaceName is null
*/ */
public HashAttributeSet(AttributeSet attributes, Class interfaceName) public HashAttributeSet(AttributeSet attributes, Class interfaceName)
{ {
this(interfaceName); this(interfaceName);
if (attributes != null) if (attributes != null)
addAll(attributes); addAllInternal(attributes, interfaceName);
} }
/** /**
...@@ -166,12 +165,24 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -166,12 +165,24 @@ public class HashAttributeSet implements AttributeSet, Serializable
* @param attribute the attribute to add * @param attribute the attribute to add
* *
* @return true if the attribute set has changed, false otherwise * @return true if the attribute set has changed, false otherwise
*
* @exception NullPointerException if attribute is null
* @exception UnmodifiableSetException if this attribute set does not
* support this action.
*/ */
public boolean add(Attribute attribute) public boolean add(Attribute attribute)
{ {
return addInternal(attribute, interfaceName);
}
private boolean addInternal(Attribute attribute, Class interfaceName)
{
if (attribute == null) if (attribute == null)
throw new NullPointerException("attribute may not be null"); throw new NullPointerException("attribute may not be null");
AttributeSetUtilities.verifyAttributeCategory(interfaceName,
this.interfaceName);
Object old = attributeMap.put Object old = attributeMap.put
(attribute.getCategory(), AttributeSetUtilities.verifyAttributeValue (attribute.getCategory(), AttributeSetUtilities.verifyAttributeValue
(attribute, interfaceName)); (attribute, interfaceName));
...@@ -184,14 +195,22 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -184,14 +195,22 @@ public class HashAttributeSet implements AttributeSet, Serializable
* @param attributes the attributes to add * @param attributes the attributes to add
* *
* @return true if the attribute set has changed, false otherwise * @return true if the attribute set has changed, false otherwise
*
* @exception UnmodifiableSetException if this attribute set does not
* support this action.
*/ */
public boolean addAll(AttributeSet attributes) public boolean addAll(AttributeSet attributes)
{ {
return addAllInternal(attributes, interfaceName);
}
private boolean addAllInternal(AttributeSet attributes, Class interfaceName)
{
boolean modified = false; boolean modified = false;
Attribute[] array = attributes.toArray(); Attribute[] array = attributes.toArray();
for (int index = 0; index < array.length; index++) for (int index = 0; index < array.length; index++)
if (! add(array[index])) if (addInternal(array[index], interfaceName))
modified = true; modified = true;
return modified; return modified;
...@@ -199,6 +218,9 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -199,6 +218,9 @@ public class HashAttributeSet implements AttributeSet, Serializable
/** /**
* Removes all attributes from this attribute set. * Removes all attributes from this attribute set.
*
* @exception UnmodifiableSetException if this attribute set does not
* support this action.
*/ */
public void clear() public void clear()
{ {
...@@ -285,6 +307,9 @@ public class HashAttributeSet implements AttributeSet, Serializable ...@@ -285,6 +307,9 @@ public class HashAttributeSet implements AttributeSet, Serializable
* @param attribute the attribute value of the entry to be removed * @param attribute the attribute value of the entry to be removed
* *
* @return true if the attribute set has changed, false otherwise. * @return true if the attribute set has changed, false otherwise.
*
* @exception UnmodifiableSetException if this attribute set does not
* support this action.
*/ */
public boolean remove(Attribute attribute) public boolean remove(Attribute attribute)
{ {
......
...@@ -46,7 +46,7 @@ import java.net.URI; ...@@ -46,7 +46,7 @@ import java.net.URI;
public abstract class URISyntax public abstract class URISyntax
implements Cloneable, Serializable implements Cloneable, Serializable
{ {
private static final long serialVersionUID = 3666874174847632203L; private static final long serialVersionUID = -7842661210486401678L;
private URI uri; private URI uri;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment